From 464a9dc5564cf07e1f64b9335381ce8f01fc0830 Mon Sep 17 00:00:00 2001 From: Mark Nelson Date: Tue, 16 Oct 2018 16:49:42 +0800 Subject: [PATCH] MDL-27520 assignfeedback_comments: is_feedback_modified considers files --- mod/assign/feedback/comments/locallib.php | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/mod/assign/feedback/comments/locallib.php b/mod/assign/feedback/comments/locallib.php index d931386e329..49400633960 100644 --- a/mod/assign/feedback/comments/locallib.php +++ b/mod/assign/feedback/comments/locallib.php @@ -122,7 +122,15 @@ class assign_feedback_comments extends assign_feedback_plugin { } } - if ($commenttext == $data->assignfeedbackcomments_editor['text']) { + $formtext = $data->assignfeedbackcomments_editor['text']; + + // Need to convert the form text to use @@PLUGINFILE@@ and format it so we can compare it with what is stored in the DB. + if (isset($data->assignfeedbackcomments_editor['itemid'])) { + $formtext = file_rewrite_urls_to_pluginfile($formtext, $data->assignfeedbackcomments_editor['itemid']); + $formtext = format_text($formtext, FORMAT_HTML); + } + + if ($commenttext == $formtext) { return false; } else { return true; -- 2.36.1