From 56aee7c2f6f93f3bce0b68b9f459039ba65bca5d Mon Sep 17 00:00:00 2001 From: =?utf8?q?David=20Mudr=C3=A1k?= Date: Fri, 15 Mar 2013 01:00:29 +0100 Subject: [PATCH] MDL-38497 Fix invalid $ADMIN->add() calls As the admin_category::add() method now checks for the third parameter, couple of typos were detected in the code. Additional parameters passed to the add() method were probably a mistake, a relict or a typo. Note that the typo in admin/tool/unsuproles/settings.php had actually significant impact on the functionality as the array with required capabilities was not actually passed to the admin_externalpage constructor as intended. --- admin/settings/plugins.php | 21 ++++++++------------- admin/tool/unsuproles/settings.php | 2 +- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/admin/settings/plugins.php b/admin/settings/plugins.php index f2d6f587f80..61d24776cad 100644 --- a/admin/settings/plugins.php +++ b/admin/settings/plugins.php @@ -196,9 +196,9 @@ if ($hassiteconfig) { 50, PARAM_INT, 3)); $ADMIN->add('portfoliosettings', $temp); - $ADMIN->add('portfoliosettings', new admin_externalpage('portfolionew', new lang_string('addnewportfolio', 'portfolio'), $url, 'moodle/site:config', true), '', $url); - $ADMIN->add('portfoliosettings', new admin_externalpage('portfoliodelete', new lang_string('deleteportfolio', 'portfolio'), $url, 'moodle/site:config', true), '', $url); - $ADMIN->add('portfoliosettings', new admin_externalpage('portfoliocontroller', new lang_string('manageportfolios', 'portfolio'), $url, 'moodle/site:config', true), '', $url); + $ADMIN->add('portfoliosettings', new admin_externalpage('portfolionew', new lang_string('addnewportfolio', 'portfolio'), $url, 'moodle/site:config', true)); + $ADMIN->add('portfoliosettings', new admin_externalpage('portfoliodelete', new lang_string('deleteportfolio', 'portfolio'), $url, 'moodle/site:config', true)); + $ADMIN->add('portfoliosettings', new admin_externalpage('portfoliocontroller', new lang_string('manageportfolios', 'portfolio'), $url, 'moodle/site:config', true)); foreach (portfolio_instances(false, false) as $portfolio) { require_once($CFG->dirroot . '/portfolio/' . $portfolio->get('plugin') . '/lib.php'); @@ -234,20 +234,15 @@ if ($hassiteconfig) { $temp->add(new admin_setting_configcheckbox('legacyfilesinnewcourses', new lang_string('legacyfilesinnewcourses', 'admin'), new lang_string('legacyfilesinnewcourses_help', 'admin'), 0)); $ADMIN->add('repositorysettings', $temp); $ADMIN->add('repositorysettings', new admin_externalpage('repositorynew', - new lang_string('addplugin', 'repository'), $url, 'moodle/site:config', true), - '', $url); + new lang_string('addplugin', 'repository'), $url, 'moodle/site:config', true)); $ADMIN->add('repositorysettings', new admin_externalpage('repositorydelete', - new lang_string('deleterepository', 'repository'), $url, 'moodle/site:config', true), - '', $url); + new lang_string('deleterepository', 'repository'), $url, 'moodle/site:config', true)); $ADMIN->add('repositorysettings', new admin_externalpage('repositorycontroller', - new lang_string('manage', 'repository'), $url, 'moodle/site:config', true), - '', $url); + new lang_string('manage', 'repository'), $url, 'moodle/site:config', true)); $ADMIN->add('repositorysettings', new admin_externalpage('repositoryinstancenew', - new lang_string('createrepository', 'repository'), $url, 'moodle/site:config', true), - '', $url); + new lang_string('createrepository', 'repository'), $url, 'moodle/site:config', true)); $ADMIN->add('repositorysettings', new admin_externalpage('repositoryinstanceedit', - new lang_string('editrepositoryinstance', 'repository'), $url, 'moodle/site:config', true), - '', $url); + new lang_string('editrepositoryinstance', 'repository'), $url, 'moodle/site:config', true)); foreach ($allplugins['repository'] as $repositorytype) { $repositorytype->load_settings($ADMIN, 'repositorysettings', $hassiteconfig); } diff --git a/admin/tool/unsuproles/settings.php b/admin/tool/unsuproles/settings.php index 5d30c44ef03..e803291cbd5 100644 --- a/admin/tool/unsuproles/settings.php +++ b/admin/tool/unsuproles/settings.php @@ -26,5 +26,5 @@ defined('MOODLE_INTERNAL') || die; if ($hassiteconfig) { - $ADMIN->add('roles', new admin_externalpage('toolunsuproles', get_string('pluginname', 'tool_unsuproles'), "$CFG->wwwroot/$CFG->admin/tool/unsuproles/index.php"), array('moodle/site:config', 'moodle/role:assign')); + $ADMIN->add('roles', new admin_externalpage('toolunsuproles', get_string('pluginname', 'tool_unsuproles'), "$CFG->wwwroot/$CFG->admin/tool/unsuproles/index.php", array('moodle/site:config', 'moodle/role:assign'))); } -- 2.43.0