From 596c71156d16e8184f9f9573794864acb12b46d8 Mon Sep 17 00:00:00 2001 From: Petr Skoda Date: Sat, 20 Nov 2010 03:55:53 +0000 Subject: [PATCH] MDL-25314 some more header diagnostics when preparing to send file --- lib/filelib.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/filelib.php b/lib/filelib.php index 77045109c79..5070a79ae20 100644 --- a/lib/filelib.php +++ b/lib/filelib.php @@ -1482,6 +1482,11 @@ function send_file_not_found() { function prepare_file_sending() { $olddebug = error_reporting(0); + // We need to be able to send headers + if (headers_sent()) { + throw new file_serving_exception('Headers already sent, can not serve file, this is definitely a server configuration issue!'); + } + // this is weird, but browser that do not support gzip or deflate have session problems here, // let's try to work around it $bugalert = false; @@ -1513,7 +1518,9 @@ function prepare_file_sending() { // create XSS problems through student files // or the content of the file would be borked. if (headers_sent()) { - throw new file_serving_exception('Headers already sent, can not serve file!'); + //NOTE: if too many sites have problems with the ob_end_flush() above + // then we may need to comment this out. + throw new file_serving_exception('Headers already sent, can not serve file! This could be caused also by PHP bug or server misconfiguration.'); } } -- 2.17.1