From 7e804d0cb403aa6f2aeac769669afed2f28e20c7 Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Wed, 5 Feb 2014 12:14:01 +0800 Subject: [PATCH] MDL-43992 Javascript: Remove key listener for confirmation The listener was previously confirming, even when the cancel or 'No' buttons were selected. However, having the default action as 'Confirm' seems dangerous in this situation, so removing this option entirely. --- .../moodle-core-notification-confirm-debug.js | Bin 4610 -> 4541 bytes .../moodle-core-notification-confirm-min.js | Bin 2193 -> 2144 bytes .../moodle-core-notification-confirm.js | Bin 4610 -> 4541 bytes lib/yui/src/notification/js/confirm.js | 1 - 4 files changed, 1 deletion(-) diff --git a/lib/yui/build/moodle-core-notification-confirm/moodle-core-notification-confirm-debug.js b/lib/yui/build/moodle-core-notification-confirm/moodle-core-notification-confirm-debug.js index c34e8673b34c72f27b5bad8b1fd6d4fbdfcbeea6..3c6c5471c1f4e7516c76a07462a97102b3f21e1e 100644 GIT binary patch delta 12 TcmZot*{i%^8|UWVoa`I`BAEod delta 20 bcmdn1+@!K$8z-}&vHIi>oYI^7IrTUIO%VpH diff --git a/lib/yui/build/moodle-core-notification-confirm/moodle-core-notification-confirm-min.js b/lib/yui/build/moodle-core-notification-confirm/moodle-core-notification-confirm-min.js index 0a7c6364ed46c76c8a5498ef64958f518a29dbf5..b3ee827d1559a2c4090aaa8c94b2647969d3755a 100644 GIT binary patch delta 12 UcmbOz_&{L89M;WeS&uLQ03#6vF8}}l delta 26 hcmaDLFi~*B99CXKVoYI^7IrTUIO%VpH diff --git a/lib/yui/src/notification/js/confirm.js b/lib/yui/src/notification/js/confirm.js index 6c4bfaaaba0..ec6cf7648c7 100644 --- a/lib/yui/src/notification/js/confirm.js +++ b/lib/yui/src/notification/js/confirm.js @@ -38,7 +38,6 @@ Y.extend(CONFIRM, M.core.dialogue, { '

' + this.get(TITLE) + '

', Y.WidgetStdMod.REPLACE); this.closeEvents.push( - Y.on('key', this.submit, window, 'down:13', this, true), Y.on('key', this.submit, window, 'down:27', this, false), yes.on('click', this.submit, this, true), no.on('click', this.submit, this, false) -- 2.17.1