From 7eea889b76e436b25b8516bf8decc5ccd39cc07e Mon Sep 17 00:00:00 2001 From: Frederic Massart Date: Wed, 23 May 2012 15:06:17 +0800 Subject: [PATCH] MDL-30905 Accessibility: recent activity list is XHTML compliant --- course/recent.php | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/course/recent.php b/course/recent.php index f33ef54c617..8b31e29835f 100644 --- a/course/recent.php +++ b/course/recent.php @@ -221,7 +221,9 @@ if (!empty($activities)) { echo $OUTPUT->spacer(array('height'=>30, 'br'=>true)); // should be done with CSS instead } echo $OUTPUT->box_start(); - echo "

$activity->name

"; + if (!empty($activity->name)) { + echo html_writer::tag('h2', $activity->name); + } $inbox = true; } else if ($activity->type == 'activity') { @@ -230,16 +232,17 @@ if (!empty($activities)) { $cm = $modinfo->cms[$activity->cmid]; if ($cm->visible) { - $linkformat = ''; + $class = ''; } else { - $linkformat = 'class="dimmed"'; + $class = 'dimmed'; } $name = format_string($cm->name); $modfullname = $modnames[$cm->modname]; - $image = "pix_url('icon', $cm->modname) . "\" class=\"icon\" alt=\"$modfullname\" />"; - echo "

$image $modfullname". - " wwwroot/mod/$cm->modname/view.php?id=$cm->id\" $linkformat>$name

"; + $image = $OUTPUT->pix_icon('icon', $modfullname, $cm->modname, array('class' => 'icon smallicon')); + $link = html_writer::link(new moodle_url("/mod/$cm->modname/view.php", + array("id" => $cm->id)), $name, array('class' => $class)); + echo html_writer::tag('h3', "$image $modfullname $link"); } } else { @@ -269,7 +272,7 @@ if (!empty($activities)) { } else { - echo '

' . get_string('norecentactivity') . '

'; + echo html_writer::tag('h3', get_string('norecentactivity'), array('class' => 'mdl-align')); } -- 2.43.0