From 89556019c0ce1c7ab045d779733e54481c510eaf Mon Sep 17 00:00:00 2001
From: Dan Poltawski <dan@moodle.com>
Date: Mon, 19 Dec 2016 10:53:59 +0000
Subject: [PATCH 1/1] MDL-57450 enviroment: remove tls library check

Unfortunately it has come to light that the version sniffing is just not
reliable at all, operating system vendors backport security patches to
older versions - so in many cases we reporting a problem which is not a
problem. False positives and the solution to self-compile or something
like php will be causing more harm than good.
---
 admin/environment.xml | 5 -----
 lib/upgradelib.php    | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/admin/environment.xml b/admin/environment.xml
index 8c35fb6799b..55502ee3c71 100644
--- a/admin/environment.xml
+++ b/admin/environment.xml
@@ -1868,11 +1868,6 @@
           <ON_CHECK message="unoconvwarning" />
         </FEEDBACK>
       </CUSTOM_CHECK>
-      <CUSTOM_CHECK file="lib/upgradelib.php" function="check_tls_libraries" level="optional">
-        <FEEDBACK>
-          <ON_CHECK message="tlswarning" />
-        </FEEDBACK>
-      </CUSTOM_CHECK>
       <CUSTOM_CHECK file="lib/upgradelib.php" function="check_libcurl_version" level="optional">
         <FEEDBACK>
           <ON_CHECK message="libcurlwarning" />
diff --git a/lib/upgradelib.php b/lib/upgradelib.php
index de6e6b4ac0d..0a61cfa3c71 100644
--- a/lib/upgradelib.php
+++ b/lib/upgradelib.php
@@ -2325,7 +2325,7 @@ function check_unoconv_version(environment_results $result) {
 }
 
 /**
- * Checks for up-to-date TLS libraries.
+ * Checks for up-to-date TLS libraries. NOTE: this is not currently used, see MDL-57262.
  *
  * @param environment_results $result object to update, if relevant.
  * @return environment_results|null updated results or null if unoconv path is not executable.
-- 
2.17.1