From 8eb35d9826a0cbb048710ad0dee2e06dbb6a0fed Mon Sep 17 00:00:00 2001 From: Marina Glancy Date: Mon, 23 Mar 2015 16:52:20 +0800 Subject: [PATCH] MDL-13831 workshop: process gradepass only if set --- mod/workshop/lib.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mod/workshop/lib.php b/mod/workshop/lib.php index 8ad5a585fd7..9e8e1f6974f 100644 --- a/mod/workshop/lib.php +++ b/mod/workshop/lib.php @@ -1140,7 +1140,8 @@ function workshop_grade_item_category_update($workshop) { if (!empty($gradeitems)) { foreach ($gradeitems as $gradeitem) { if ($gradeitem->itemnumber == 0) { - if ($gradeitem->gradepass != $workshop->submissiongradepass) { + if (isset($workshop->submissiongradepass) && + $gradeitem->gradepass != $workshop->submissiongradepass) { $gradeitem->gradepass = $workshop->submissiongradepass; $gradeitem->update(); } @@ -1148,7 +1149,8 @@ function workshop_grade_item_category_update($workshop) { $gradeitem->set_parent($workshop->gradecategory); } } else if ($gradeitem->itemnumber == 1) { - if ($gradeitem->gradepass != $workshop->gradinggradepass) { + if (isset($workshop->gradinggradepass) && + $gradeitem->gradepass != $workshop->gradinggradepass) { $gradeitem->gradepass = $workshop->gradinggradepass; $gradeitem->update(); } -- 2.43.0