From 926814896641b1fc0294f4b7b4a047e84329f884 Mon Sep 17 00:00:00 2001 From: Dan Poltawski Date: Sun, 9 Jan 2011 18:01:55 +0000 Subject: [PATCH 1/1] blog MDL-23393 - Tidy up preferences form Make form display set value and use mforms type checking --- blog/preferences.php | 1 + blog/preferences_form.php | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/blog/preferences.php b/blog/preferences.php index 366beda6c7a..472ee3075a2 100755 --- a/blog/preferences.php +++ b/blog/preferences.php @@ -73,6 +73,7 @@ require_capability('moodle/blog:view', $context); /// If data submitted, then process and store. $mform = new blog_preferences_form('preferences.php'); +$mform->set_data(array('pagesize' => get_user_preferences('blogpagesize'))); if (!$mform->is_cancelled() && $data = $mform->get_data()) { $pagesize = $data->pagesize; diff --git a/blog/preferences_form.php b/blog/preferences_form.php index a1fff640c71..d5c5005befc 100644 --- a/blog/preferences_form.php +++ b/blog/preferences_form.php @@ -39,7 +39,9 @@ class blog_preferences_form extends moodleform { $strpagesize = get_string('pagesize', 'blog'); $mform->addElement('text', 'pagesize', $strpagesize); - $mform->setDefault('pagesize', get_user_preferences('pagesize')); + $mform->setType('pagesize', PARAM_INT); + $mform->addRule('pagesize', null, 'numeric', null, 'client'); + $mform->setDefault('pagesize', 10); $this->add_action_buttons(); } -- 2.17.1