From 9523f0e04067b3de803bb6c82dc8f74980c1a58f Mon Sep 17 00:00:00 2001 From: Michael Hawkins Date: Wed, 9 Oct 2019 10:44:39 +0800 Subject: [PATCH] MDL-66076 forumreport_summary: Added missing SQL group by fields Also removed a redundant variable declaration. --- mod/forum/report/summary/classes/summary_table.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mod/forum/report/summary/classes/summary_table.php b/mod/forum/report/summary/classes/summary_table.php index 1db6814d328..2aff4369826 100644 --- a/mod/forum/report/summary/classes/summary_table.php +++ b/mod/forum/report/summary/classes/summary_table.php @@ -430,7 +430,7 @@ class summary_table extends table_sql { $this->sql->basewhere = 'e.courseid = :courseid'; - $this->sql->basegroupby = 'ue.userid, e.courseid, f.id, u.id'; + $this->sql->basegroupby = 'ue.userid, e.courseid, f.id, u.id, ' . $userfieldssql; if ($this->logreader) { $this->fill_log_summary_temp_table($this->context->id); @@ -526,7 +526,6 @@ class summary_table extends table_sql { * @return string The complete SQL statement. */ protected function get_full_sql(bool $fullselect = true): string { - $selectfields = ''; $groupby = ''; $orderby = ''; -- 2.43.0