From 9d49a142b67417d2800b3fb90243abdd485913c6 Mon Sep 17 00:00:00 2001 From: Dan Marsden Date: Sat, 17 Jul 2010 06:45:57 +0000 Subject: [PATCH 1/1] SCORM MDL-21568 fix regression --- mod/scorm/db/upgrade.php | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/mod/scorm/db/upgrade.php b/mod/scorm/db/upgrade.php index 9c1f712edfa..413dff2f634 100644 --- a/mod/scorm/db/upgrade.php +++ b/mod/scorm/db/upgrade.php @@ -40,9 +40,11 @@ function xmldb_scorm_upgrade($oldversion) { if (empty($whatgradefixed)) { /// fix bad usage of whatgrade/grading method. $scorms = $DB->get_records('scorm'); - foreach ($scorms as $scorm) { - $scorm->whatgrade = $scorm->grademethod/10; - $DB->update_record('scorm', $scorm); + if (!empty($scorm)) { + foreach ($scorms as $scorm) { + $scorm->whatgrade = $scorm->grademethod/10; + $DB->update_record('scorm', $scorm); + } } } } else { @@ -473,9 +475,11 @@ function xmldb_scorm_upgrade($oldversion) { if (empty($grademethodfixed)) { /// fix bad usage of whatgrade/grading method. $scorms = $DB->get_records('scorm'); - foreach ($scorms as $scorm) { - $scorm->grademethod = $scorm->grademethod%10; - $DB->update_record('scorm', $scorm); + if (!empty($scorm)) { + foreach ($scorms as $scorm) { + $scorm->grademethod = $scorm->grademethod%10; + $DB->update_record('scorm', $scorm); + } } } else { //dump this config var as it isn't needed anymore. -- 2.17.1