From a81b4cab2258d6bf86fb2ee61de983501a074772 Mon Sep 17 00:00:00 2001 From: =?utf8?q?David=20Mudr=C3=A1k?= Date: Thu, 16 Jul 2015 19:37:01 +0200 Subject: [PATCH] MDL-50673 workshop: Fix some coding style violations --- mod/workshop/locallib.php | 5 +++-- mod/workshop/view.php | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/mod/workshop/locallib.php b/mod/workshop/locallib.php index aa08dd19090..4f98583aa54 100644 --- a/mod/workshop/locallib.php +++ b/mod/workshop/locallib.php @@ -1782,7 +1782,8 @@ class workshop { return array(); } - if (!in_array($sortby, array('lastname','firstname','submissiontitle', 'submissionmodified','submissiongrade','gradinggrade'))) { + if (!in_array($sortby, array('lastname', 'firstname', 'submissiontitle', 'submissionmodified', + 'submissiongrade', 'gradinggrade'))) { $sortby = 'lastname'; } @@ -1814,7 +1815,7 @@ class workshop { $sqlsort = implode(',', $sqlsort); $picturefields = user_picture::fields('u', array(), 'userid'); $sql = "SELECT $picturefields, s.title AS submissiontitle, s.timemodified AS submissionmodified, - s.grade AS submissiongrade, ag.gradinggrade + s.grade AS submissiongrade, ag.gradinggrade FROM {user} u LEFT JOIN {workshop_submissions} s ON (s.authorid = u.id AND s.workshopid = :workshopid1 AND s.example = 0) LEFT JOIN {workshop_aggregations} ag ON (ag.userid = u.id AND ag.workshopid = :workshopid2) diff --git a/mod/workshop/view.php b/mod/workshop/view.php index b5e4211a6a4..66adc1743d9 100644 --- a/mod/workshop/view.php +++ b/mod/workshop/view.php @@ -239,11 +239,11 @@ case workshop::PHASE_SUBMISSION: echo $output->container(groups_print_activity_menu($workshop->cm, $PAGE->url, true), 'groupwidget'); - // prepare paging bar + // Prepare the paging bar. $baseurl = new moodle_url($PAGE->url, array('sortby' => $sortby, 'sorthow' => $sorthow)); $pagingbar = new paging_bar($data->totalcount, $page, $perpage, $baseurl, 'page'); - // submissions report display options + // Populate the display options for the submissions report. $reportopts = new stdclass(); $reportopts->showauthornames = has_capability('mod/workshop:viewauthornames', $workshop->context); $reportopts->showreviewernames = has_capability('mod/workshop:viewreviewernames', $workshop->context); -- 2.43.0