From a850fa5de80051efbbf3c36333713f670268f24e Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Thu, 24 Sep 2020 23:14:06 +0100 Subject: [PATCH] MDL-69156 backup: correct behaviour of course copy idnumber field. When a given user doesn't have the capability to change the idnumber field during course copy, freeze the field value. --- backup/util/ui/classes/output/copy_form.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/backup/util/ui/classes/output/copy_form.php b/backup/util/ui/classes/output/copy_form.php index dec99e459f7..51f8bb8815f 100644 --- a/backup/util/ui/classes/output/copy_form.php +++ b/backup/util/ui/classes/output/copy_form.php @@ -152,14 +152,14 @@ class copy_form extends \moodleform { $mform->addHelpButton('relativedatesmodegroup', 'relativedatesmode'); } - // Course id number. + // Course ID number (default to the current course ID number; blank for users who can't change ID numbers). $mform->addElement('text', 'idnumber', get_string('idnumbercourse'), 'maxlength="100" size="10"'); + $mform->setDefault('idnumber', $course->idnumber); $mform->addHelpButton('idnumber', 'idnumbercourse'); $mform->setType('idnumber', PARAM_RAW); - if (!empty($course->id) and !has_capability('moodle/course:changeidnumber', $coursecontext)) { + if (!has_capability('moodle/course:changeidnumber', $coursecontext)) { $mform->hardFreeze('idnumber'); - $mform->setDefault('idnumber', ''); - $mform->setConstants('idnumber', $course->idnumber); + $mform->setConstant('idnumber', ''); } // Keep source course user data. @@ -173,7 +173,7 @@ class copy_form extends \moodleform { ); if (!has_all_capabilities($requiredcapabilities, $coursecontext)) { $mform->hardFreeze('userdata'); - $mform->setConstants('userdata', 0); + $mform->setConstant('userdata', 0); } // Keep manual enrolments. -- 2.43.0