From aafa4f324a4880c26001ab745ee06b32ee57cb31 Mon Sep 17 00:00:00 2001 From: "Andrew Davis (andyjdavis)" Date: Mon, 21 Feb 2011 10:48:38 +0800 Subject: [PATCH] rating MDL-26461 fixed an off by 1 bug that made the safeguard against too high ratings not work --- rating/index.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rating/index.php b/rating/index.php index 41d085ecb69..8f4cf708b71 100644 --- a/rating/index.php +++ b/rating/index.php @@ -92,7 +92,8 @@ if (!$ratings) { echo "$strtime"; echo ""; - $maxrating = count($scalemenu); + //if the scale was changed after ratings were submitted some ratings may have a value above the current maximum + $maxrating = count($scalemenu) - 1; foreach ($ratings as $rating) { //Undo the aliasing of the user id column from user_picture::fields() //we could clone the rating object or preserve the rating id if we needed it again -- 2.43.0