From b58f4df6ea00ce9608fdf8bf9ffc0d9ecb517de4 Mon Sep 17 00:00:00 2001 From: Aaron Barnes Date: Fri, 19 Aug 2011 14:56:29 +1200 Subject: [PATCH] MDL-28248 completion: Incorrect SQL for finding enrol start date --- lib/completion/completion_criteria_duration.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/completion/completion_criteria_duration.php b/lib/completion/completion_criteria_duration.php index 6ce85e9b2cd..bc2c8a07883 100644 --- a/lib/completion/completion_criteria_duration.php +++ b/lib/completion/completion_criteria_duration.php @@ -90,7 +90,12 @@ class completion_criteria_duration extends completion_criteria { private function get_timeenrolled($completion) { global $DB; - return $DB->get_field('user_enrolments', 'timestart', array('courseid' => $this->course, 'userid' => $completion->userid)); + return $DB->get_field_sql(' + SELECT eu.timestart + FROM {user_enrolments} eu + JOIN {enrol} e ON eu.enrolid = e.id + WHERE e.courseid = ? + AND eu.userid = ?', array($this->course, $completion->userid)); } /** -- 2.17.1