From b7030c3def2381020f803d836f82e39540278620 Mon Sep 17 00:00:00 2001 From: Andreas Grabs Date: Thu, 23 Jun 2011 21:22:38 +0200 Subject: [PATCH] MDL-28014 - unpropitious use of bcmod() --- mod/feedback/item/multichoice/lib.php | 6 +----- mod/feedback/item/multichoicerated/lib.php | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/mod/feedback/item/multichoice/lib.php b/mod/feedback/item/multichoice/lib.php index af2dfcb0a7f..30402b26ecc 100644 --- a/mod/feedback/item/multichoice/lib.php +++ b/mod/feedback/item/multichoice/lib.php @@ -213,11 +213,7 @@ class feedback_item_multichoice extends feedback_item_base { $analysedVals = $analysedItem[2]; $pixnr = 0; foreach($analysedVals as $val) { - if( function_exists("bcmod")) { - $intvalue = bcmod($pixnr, 10); - }else { - $intvalue = 0; - } + $intvalue = $pixnr % 10; $pix = "pics/$intvalue.gif"; $pixnr++; $pixwidth = intval($val->quotient * FEEDBACK_MAX_PIX_LENGTH); diff --git a/mod/feedback/item/multichoicerated/lib.php b/mod/feedback/item/multichoicerated/lib.php index 77a2b040b5c..41764e9a463 100644 --- a/mod/feedback/item/multichoicerated/lib.php +++ b/mod/feedback/item/multichoicerated/lib.php @@ -184,11 +184,7 @@ class feedback_item_multichoicerated extends feedback_item_base { $pixnr = 0; $avg = 0.0; foreach($analysedVals as $val) { - if( function_exists("bcmod")) { - $intvalue = bcmod($pixnr, 10); - }else { - $intvalue = 0; - } + $intvalue = $pixnr % 10; $pix = "pics/$intvalue.gif"; $pixnr++; $pixwidth = intval($val->quotient * FEEDBACK_MAX_PIX_LENGTH); -- 2.17.1