From cfc73aa7905b66c9bf01d11629d887a31bbb8693 Mon Sep 17 00:00:00 2001 From: Dan Marsden Date: Fri, 4 May 2012 19:26:16 +1200 Subject: [PATCH] MDL-31731 Advanced Grading: Marking Guide - prevent negative scores when marking users --- grade/grading/form/guide/lib.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/grade/grading/form/guide/lib.php b/grade/grading/form/guide/lib.php index 7bd24e2ba76..707fb37bb2a 100644 --- a/grade/grading/form/guide/lib.php +++ b/grade/grading/form/guide/lib.php @@ -704,7 +704,8 @@ class gradingform_guide_instance extends gradingform_instance { foreach ($criteria as $id => $criterion) { if (!isset($elementvalue['criteria'][$id]['score']) || $criterion['maxscore'] < $elementvalue['criteria'][$id]['score'] - || !is_numeric($elementvalue['criteria'][$id]['score'])) { + || !is_numeric($elementvalue['criteria'][$id]['score']) + || $elementvalue['criteria'][$id]['score'] < 0) { $this->validationerrors[$id]['score'] = $elementvalue['criteria'][$id]['score']; } } -- 2.39.2