From d13c358a797a0c559c3c522a11657a57fbf783b8 Mon Sep 17 00:00:00 2001 From: Andrew Davis Date: Fri, 15 Oct 2010 02:56:28 +0000 Subject: [PATCH] gradebook MDL-24682 corrected a capability check that was incorrectly allowing some users to make a course scale a standard scale --- grade/edit/scale/edit_form.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/grade/edit/scale/edit_form.php b/grade/edit/scale/edit_form.php index e727bffa91a..186fb0a416c 100644 --- a/grade/edit/scale/edit_form.php +++ b/grade/edit/scale/edit_form.php @@ -81,7 +81,8 @@ class edit_scale_form extends moodleform { if (empty($courseid)) { $mform->hardFreeze('standard'); - } else if (empty($scale->courseid) and !has_capability('moodle/course:managescales', get_context_instance(CONTEXT_SYSTEM))) { + } else if (!has_capability('moodle/course:managescales', get_context_instance(CONTEXT_SYSTEM))) { + //if they dont have managescales at system level the shouldnt be allowed to make scales standard (or not standard) $mform->hardFreeze('standard'); } else if ($used and !empty($scale->courseid)) { -- 2.17.1