From d6b8e1923aaa2933a32476b5da64ee05fee709ed Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Tue, 19 Mar 2013 12:10:40 +0000 Subject: [PATCH] MDL-38528 qtype_calc* dataset forms: disable short-forms for now. At the moment using short-forms no these forms really does not work. In future is may be possible to do a complete overhaul, but for now, just disabling short-forms is a simple fix. --- question/type/calculated/datasetdefinitions_form.php | 3 +++ question/type/calculated/datasetitems_form.php | 2 ++ 2 files changed, 5 insertions(+) diff --git a/question/type/calculated/datasetdefinitions_form.php b/question/type/calculated/datasetdefinitions_form.php index 45efea3bcdd..6e1158ce508 100644 --- a/question/type/calculated/datasetdefinitions_form.php +++ b/question/type/calculated/datasetdefinitions_form.php @@ -71,7 +71,10 @@ class question_dataset_dependent_definitions_form extends question_wizard_form { protected function definition() { global $SESSION; + $mform = $this->_form; + $mform->setDisableShortforms(); + $possibledatasets = $this->qtypeobj->find_dataset_names($this->question->questiontext); $mandatorydatasets = array(); if (isset($this->question->options->answers)) { diff --git a/question/type/calculated/datasetitems_form.php b/question/type/calculated/datasetitems_form.php index a4bb3ef808b..f1f4a7b17bf 100644 --- a/question/type/calculated/datasetitems_form.php +++ b/question/type/calculated/datasetitems_form.php @@ -111,6 +111,8 @@ class question_dataset_dependent_items_form extends question_wizard_form { $labelsharedwildcard = get_string("sharedwildcard", "qtype_calculated"); $mform =& $this->_form; + $mform->setDisableShortforms(); + $strquestionlabel = $this->qtypeobj->comment_header($this->question); if ($this->maxnumber != -1 ) { $this->noofitems = $this->maxnumber; -- 2.17.1