From dde3d58eb136f41d07249fc656f8a1e699666ec2 Mon Sep 17 00:00:00 2001
From: Marina Glancy <marina@moodle.com>
Date: Mon, 23 Apr 2018 13:14:30 +0800
Subject: [PATCH] MDL-62138 core: remove core_register and core_publish

These components have no classes and no strings and have no purspose. Component core_hub is responsible
for storing data, defining classes and strings for site registration and course publishing

This also reverts MDL-61945
---
 .../registration/classes/privacy/provider.php | 41 -------------------
 lang/en/register.php                          | 23 -----------
 lib/classes/component.php                     |  2 -
 lib/tests/component_test.php                  |  2 +-
 4 files changed, 1 insertion(+), 67 deletions(-)
 delete mode 100644 admin/registration/classes/privacy/provider.php
 delete mode 100644 lang/en/register.php

diff --git a/admin/registration/classes/privacy/provider.php b/admin/registration/classes/privacy/provider.php
deleted file mode 100644
index c1c4ea48ad2..00000000000
--- a/admin/registration/classes/privacy/provider.php
+++ /dev/null
@@ -1,41 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-/**
- * Privacy Subsystem implementation for core_register.
- *
- * @package    core_register
- * @copyright  2018 Carlos Escobedo <carlos@moodle.com>
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-namespace core_register\privacy;
-defined('MOODLE_INTERNAL') || die();
-/**
- * Privacy Subsystem for core_register implementing null_provider.
- *
- * @copyright  2018 Carlos Escobedo <carlos@moodle.com>
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-class provider implements \core_privacy\local\metadata\null_provider {
-    /**
-     * Get the language string identifier with the component's language
-     * file to explain why this plugin stores no data.
-     *
-     * @return  string
-     */
-    public static function get_reason() : string {
-        return 'privacy:metadata';
-    }
-}
\ No newline at end of file
diff --git a/lang/en/register.php b/lang/en/register.php
deleted file mode 100644
index 36d02655cc5..00000000000
--- a/lang/en/register.php
+++ /dev/null
@@ -1,23 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-/**
- *  Strings for core_register.
- *
- * @package    core_register
- * @copyright  2018 Carlos Escobedo <carlos@moodle.com>
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-$string['privacy:metadata'] = 'The Register plugin does not store any personal data.';
diff --git a/lib/classes/component.php b/lib/classes/component.php
index c21fce847cc..28ec855c6c9 100644
--- a/lib/classes/component.php
+++ b/lib/classes/component.php
@@ -471,10 +471,8 @@ $cache = '.var_export($cache, true).';
             'plugin'      => null,
             'portfolio'   => $CFG->dirroot.'/portfolio',
             'privacy'     => $CFG->dirroot . '/privacy',
-            'publish'     => $CFG->dirroot.'/course/publish',
             'question'    => $CFG->dirroot.'/question',
             'rating'      => $CFG->dirroot.'/rating',
-            'register'    => $CFG->dirroot.'/'.$CFG->admin.'/registration', // Broken badly if $CFG->admin changed.
             'repository'  => $CFG->dirroot.'/repository',
             'rss'         => $CFG->dirroot.'/rss',
             'role'        => $CFG->dirroot.'/'.$CFG->admin.'/roles',
diff --git a/lib/tests/component_test.php b/lib/tests/component_test.php
index 7cde09c3be1..ee71d374df3 100644
--- a/lib/tests/component_test.php
+++ b/lib/tests/component_test.php
@@ -36,7 +36,7 @@ class core_component_testcase extends advanced_testcase {
      * this is defined here to annoy devs that try to add more without any thinking,
      * always verify that it does not collide with any existing add-on modules and subplugins!!!
      */
-    const SUBSYSTEMCOUNT = 68;
+    const SUBSYSTEMCOUNT = 66;
 
     public function setUp() {
         $psr0namespaces = new ReflectionProperty('core_component', 'psr0namespaces');
-- 
2.17.1