From e4b17111a4b44946557e776722d026518f2be32f Mon Sep 17 00:00:00 2001 From: James Pratt Date: Tue, 19 Nov 2013 21:11:50 +0700 Subject: [PATCH] MDL-42957 quiz statistics : Hardcoded sql LIMIT clause --- question/classes/statistics/questions/calculator.php | 3 +-- question/classes/statistics/responses/analyser.php | 7 +++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/question/classes/statistics/questions/calculator.php b/question/classes/statistics/questions/calculator.php index 55bb8031e3b..78ab82e87c2 100644 --- a/question/classes/statistics/questions/calculator.php +++ b/question/classes/statistics/questions/calculator.php @@ -250,8 +250,7 @@ class calculator { global $DB; $timemodified = time() - self::TIME_TO_CACHE; - return $DB->get_field_select('question_statistics', 'timemodified', 'hashcode = ? AND timemodified > ? '. - 'ORDER BY timemodified DESC LIMIT 1', + return $DB->get_field_select('question_statistics', 'timemodified', 'hashcode = ? AND timemodified > ?', array($qubaids->get_hash_code(), $timemodified)); } diff --git a/question/classes/statistics/responses/analyser.php b/question/classes/statistics/responses/analyser.php index 14ce6eb726d..a42d2f01c7b 100644 --- a/question/classes/statistics/responses/analyser.php +++ b/question/classes/statistics/responses/analyser.php @@ -137,7 +137,7 @@ class analyser { global $DB; $timemodified = time() - self::TIME_TO_CACHE; - $rows = $DB->get_records_select('question_response_analysis', 'hashcode = ? AND questionid = ? AND timemodified > ? ', + $rows = $DB->get_records_select('question_response_analysis', 'hashcode = ? AND questionid = ? AND timemodified > ?', array($qubaids->get_hash_code(), $this->questiondata->id, $timemodified)); if (!$rows) { return false; @@ -161,8 +161,7 @@ class analyser { global $DB; $timemodified = time() - self::TIME_TO_CACHE; - return $DB->get_field_select('question_response_analysis', 'timemodified', 'hashcode = ? AND timemodified > ? '. - 'ORDER BY timemodified DESC LIMIT 1', - array($qubaids->get_hash_code(), $timemodified)); + return $DB->get_field_select('question_response_analysis', 'hashcode = ? AND questionid = ? AND timemodified > ?', + array($qubaids->get_hash_code(), $this->questiondata->id, $timemodified), IGNORE_MULTIPLE); } } -- 2.17.1