From f451ef06cd4b17b5f82f7418258fc92b4d17c744 Mon Sep 17 00:00:00 2001 From: Peter Dias Date: Mon, 21 Sep 2020 14:28:28 +0800 Subject: [PATCH] MDL-65959 badge: Reset external_identifiers if backpack details modified --- badges/backpacks.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/badges/backpacks.php b/badges/backpacks.php index 74beaddd85c..635a1645cf8 100644 --- a/badges/backpacks.php +++ b/badges/backpacks.php @@ -69,7 +69,11 @@ if ($action == 'edit') { } else if ($data = $form->get_data()) { require_sesskey(); if (!empty($data->id)) { - badges_update_site_backpack($data->id, $data); + $id = $data->id; + badges_update_site_backpack($id, $data); + // Apart from the password, any change here would result in an error in other parts of the badge systems. + // In order to negate this, we restart any further mapping from scratch. + badges_external_delete_mappings($id); } else { badges_create_site_backpack($data); } -- 2.17.1