From f712aa2877255026af442163fe6b8bfa7eb2e13d Mon Sep 17 00:00:00 2001 From: Jinu Abraham Date: Mon, 31 Aug 2015 14:48:31 +0930 Subject: [PATCH] MDL-50483 gradereport_user: fix the fatal error of no enrolled users --- grade/report/user/index.php | 6 +++++- .../user/tests/behat/view_usereport.feature | 20 +++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 grade/report/user/tests/behat/view_usereport.feature diff --git a/grade/report/user/index.php b/grade/report/user/index.php index 3136c562a39..b1023e9fdee 100644 --- a/grade/report/user/index.php +++ b/grade/report/user/index.php @@ -167,6 +167,10 @@ if (has_capability('moodle/grade:viewall', $context)) { //Teachers will see all } // Trigger report viewed event. -$report->viewed(); +if (isset($report)) { + $report->viewed(); +} else { + echo $OUTPUT->notification(get_string('nostudentsyet')); +} echo $OUTPUT->footer(); diff --git a/grade/report/user/tests/behat/view_usereport.feature b/grade/report/user/tests/behat/view_usereport.feature new file mode 100644 index 00000000000..b9c7d11cae2 --- /dev/null +++ b/grade/report/user/tests/behat/view_usereport.feature @@ -0,0 +1,20 @@ +@core @core_grades @gradereport_user +Feature: We can use the user report + As a user + I browse to the User report + + Background: + Given the following "courses" exist: + | fullname | shortname | category | + | Course 1 | C1 | 0 | + + Scenario: Verify we can view a user grade report with no users enrolled. + Given I log in as "admin" + And I am on site homepage + And I follow "Course 1" + And I navigate to "Grades" node in "Course administration" + And I select "User report" from the "Grade report" singleselect + And I press "Go" + And I select "All users (0)" from the "Select all or one user" singleselect + And I click on "Go" "button" in the "#choosegradeuser" "css_element" + Then I should see "No students enrolled in this course yet" -- 2.17.1