From fabd4fcf5339193a4102c780ccef072ce2c2ee7f Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Mon, 7 Nov 2011 01:10:30 +0100 Subject: [PATCH] MDL-20534 lti: A4, add some todos towards unified Oauth --- mod/lti/locallib.php | 3 ++- mod/lti/service.php | 2 ++ mod/lti/servicelib.php | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/mod/lti/locallib.php b/mod/lti/locallib.php index 3beaa173293..aaf73c6df6e 100644 --- a/mod/lti/locallib.php +++ b/mod/lti/locallib.php @@ -48,6 +48,7 @@ defined('MOODLE_INTERNAL') || die; +// TODO: Switch to core oauthlib once implemented - MDL-30149 use moodle\mod\lti as lti; require_once($CFG->dirroot.'/mod/lti/OAuth.php'); @@ -1052,9 +1053,9 @@ function lti_sign_parameters($oldparms, $endpoint, $method, $oauthconsumerkey, $ $testtoken = ''; + // TODO: Switch to core oauthlib once implemented - MDL-30149 $hmacmethod = new lti\OAuthSignatureMethod_HMAC_SHA1(); $testconsumer = new lti\OAuthConsumer($oauthconsumerkey, $oauthconsumersecret, null); - $accreq = lti\OAuthRequest::from_consumer_and_token($testconsumer, $testtoken, $method, $endpoint, $parms); $accreq->sign_request($hmacmethod, $testconsumer, $testtoken); diff --git a/mod/lti/service.php b/mod/lti/service.php index bc2265eb76f..9099e105111 100644 --- a/mod/lti/service.php +++ b/mod/lti/service.php @@ -27,12 +27,14 @@ require_once(dirname(__FILE__) . "/../../config.php"); require_once($CFG->dirroot.'/mod/lti/locallib.php'); require_once($CFG->dirroot.'/mod/lti/servicelib.php'); +// TODO: Switch to core oauthlib once implemented - MDL-30149 use moodle\mod\lti as lti; $rawbody = file_get_contents("php://input"); foreach (getallheaders() as $name => $value) { if ($name === 'Authorization') { + // TODO: Switch to core oauthlib once implemented - MDL-30149 $oauthparams = lti\OAuthUtil::split_header($value); $consumerkey = $oauthparams['oauth_consumer_key']; diff --git a/mod/lti/servicelib.php b/mod/lti/servicelib.php index f7211a38aa2..049e677fd3c 100644 --- a/mod/lti/servicelib.php +++ b/mod/lti/servicelib.php @@ -25,6 +25,7 @@ require_once($CFG->dirroot.'/mod/lti/OAuthBody.php'); +// TODO: Switch to core oauthlib once implemented - MDL-30149 use moodle\mod\lti as lti; define('LTI_ITEM_TYPE', 'mod'); @@ -187,6 +188,7 @@ function lti_verify_message($key, $sharedsecrets, $body, $headers = null) { $signaturefailed = false; try { + // TODO: Switch to core oauthlib once implemented - MDL-30149 lti\handleOAuthBodyPOST($key, $secret, $body, $headers); } catch (Exception $e) { $signaturefailed = true; -- 2.43.0