Sara Arjona [Wed, 3 Mar 2021 16:51:16 +0000 (17:51 +0100)]
Merge branch 'MDL-68721-master' of git://github.com/ferranrecio/moodle
Ferran Recio [Thu, 14 Jan 2021 15:03:33 +0000 (16:03 +0100)]
MDL-68721 mod_h5pactivity: report acceptance tests
Paul Holden [Wed, 3 Mar 2021 13:36:11 +0000 (13:36 +0000)]
MDL-65552 block_activity_results: correct Behat tests for idnumbers.
Teachers can see user idnumber fields only when they are configured
identity fields. Students cannot.
Marina Glancy [Mon, 1 Mar 2021 18:14:35 +0000 (19:14 +0100)]
MDL-65552 user: escape idnumber and email in table_sql
Paul Holden [Mon, 1 Mar 2021 14:20:02 +0000 (14:20 +0000)]
MDL-65552 user: escape idnumber field on output.
This commit also corrects parameter definition of the field to
match core_user.
Sara Arjona [Wed, 3 Mar 2021 14:47:16 +0000 (15:47 +0100)]
Merge branch 'MDL-70125_master-3' of git://github.com/mdjnelson/moodle
Sara Arjona [Wed, 3 Mar 2021 14:24:44 +0000 (15:24 +0100)]
Merge branch 'MDL-70921-master' of git://github.com/marinaglancy/moodle
Sara Arjona [Wed, 3 Mar 2021 10:45:28 +0000 (11:45 +0100)]
Merge branch 'MDL-67494-master' of git://github.com/lameze/moodle
Sara Arjona [Wed, 3 Mar 2021 10:11:29 +0000 (11:11 +0100)]
Merge branch 'MDL-67119-master' of git://github.com/aanabit/moodle
Jun Pataleta [Wed, 3 Mar 2021 08:42:18 +0000 (16:42 +0800)]
Merge branch 'MDL-70987-master' of git://github.com/andrewnicols/moodle
Sara Arjona [Wed, 3 Mar 2021 08:30:41 +0000 (09:30 +0100)]
Merge branch 'MDL-70966-master' of git://github.com/marinaglancy/moodle
Jun Pataleta [Wed, 3 Mar 2021 08:22:50 +0000 (16:22 +0800)]
Merge branch 'MDL-71009' of https://github.com/timhunt/moodle
Sara Arjona [Wed, 3 Mar 2021 08:06:45 +0000 (09:06 +0100)]
Merge branch 'MDL-69097-master' of https://github.com/inigozendegi/moodle
Simey Lameze [Mon, 7 Sep 2020 09:31:16 +0000 (17:31 +0800)]
MDL-67494 calendar: user_delete_user should delete all user events
Simey Lameze [Mon, 7 Sep 2020 04:03:44 +0000 (12:03 +0800)]
MDL-67494 calendar: privacy provider should not delete shared events
Simey Lameze [Mon, 7 Sep 2020 08:56:23 +0000 (16:56 +0800)]
MDL-67494 calendar: shared subscriptions should not set userid to 0
Simey Lameze [Fri, 5 Feb 2021 08:09:52 +0000 (16:09 +0800)]
MDL-67494 calendar: only user overrides should retain userid
Simey Lameze [Mon, 24 Aug 2020 03:09:42 +0000 (11:09 +0800)]
MDL-67494 calendar: set userid to zero for shared events
Simey Lameze [Mon, 7 Sep 2020 08:04:57 +0000 (16:04 +0800)]
MDL-67494 calendar: step to set userid 0 to all shared events
Simey Lameze [Mon, 24 Aug 2020 03:08:00 +0000 (11:08 +0800)]
MDL-67494 calendar: add logic for category events in get_context
Jun Pataleta [Wed, 3 Mar 2021 07:05:36 +0000 (15:05 +0800)]
Merge branch 'MDL-70995' of https://github.com/paulholden/moodle
Jun Pataleta [Wed, 3 Mar 2021 06:35:06 +0000 (14:35 +0800)]
Merge branch 'MDL-69883' of https://github.com/paulholden/moodle
Andrew Nicols [Wed, 3 Mar 2021 04:23:04 +0000 (12:23 +0800)]
Merge branch 'MDL-70268-master-2' of git://github.com/peterRd/moodle
Peter Dias [Thu, 28 Jan 2021 03:46:19 +0000 (11:46 +0800)]
MDL-70268 core: Update the oauthlib to exclude scope if none provided
Paul Holden [Mon, 8 Feb 2021 08:23:12 +0000 (08:23 +0000)]
MDL-70822 enrol: respect capability to view other users profile.
When retrieving courses of another user via web services, we should
respect the capability to view that users profile in a given course.
Sander Wind [Tue, 19 Jan 2021 08:05:41 +0000 (16:05 +0800)]
MDL-70668 auth: Fix secret validation during user confirmation
Co-authored-by: Michael Hawkins <michaelh@moodle.com>
Eloy Lafuente (stronk7) [Tue, 2 Mar 2021 22:32:30 +0000 (23:32 +0100)]
Merge branch 'MDL-70340-master' of git://github.com/jleyva/moodle
Víctor Déniz [Tue, 2 Mar 2021 17:53:59 +0000 (17:53 +0000)]
Merge branch 'MDL-70676-master' of git://github.com/ilyatregubov/moodle
Fixed mod/workshop/db/upgrade.php: \xmldb_field::getNotNull()
does not verify if the column is nullable in the database.
Peter Dias [Thu, 25 Feb 2021 02:06:10 +0000 (10:06 +0800)]
MDL-59293 block_onlineusers: Update behat tests
Peter Dias [Fri, 28 Aug 2020 04:53:26 +0000 (12:53 +0800)]
MDL-59293 block_onlineusers: Check whether current user can view online users
- Removed block from site admin.
- Blocked guest from viewuserlist cap
Ilya Tregubov [Tue, 26 Jan 2021 12:21:33 +0000 (14:21 +0200)]
MDL-70676 workshop: Allow empty grades.
Sara Arjona [Tue, 2 Mar 2021 10:21:17 +0000 (11:21 +0100)]
Merge branch 'MDL-67515-master' of git://github.com/vmdef/moodle
Jun Pataleta [Tue, 2 Mar 2021 09:39:36 +0000 (17:39 +0800)]
Merge branch 'MDL-70457' of https://github.com/stronk7/moodle
Víctor Déniz [Tue, 2 Mar 2021 09:16:41 +0000 (09:16 +0000)]
Merge branch 'MDL-70172-master' of git://github.com/rezaies/moodle
Víctor Déniz [Wed, 10 Feb 2021 13:55:16 +0000 (13:55 +0000)]
MDL-67515 tool_customlang: Ignore invalid component strings
After uninstalling a plugin, the translated strings remain in
tool_customlang table, throwing an exception when trying to localise
any strings. Currently there is no mechanism to
clean up customlang tables and files during the uninstall process,
so with this patch the invalid components will be ignored.
Sara Arjona [Tue, 2 Mar 2021 08:29:17 +0000 (09:29 +0100)]
Merge branch 'MDL-70877' of https://github.com/stronk7/moodle
Jun Pataleta [Tue, 2 Mar 2021 08:02:52 +0000 (16:02 +0800)]
Merge branch 'MDL-70876' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 21:50:33 +0000 (22:50 +0100)]
Merge branch 'MDL-70898-master' of git://github.com/marinaglancy/moodle
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 21:33:17 +0000 (22:33 +0100)]
Merge branch 'MDL-67974-master' of git://github.com/sarjona/moodle
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 20:58:45 +0000 (21:58 +0100)]
Merge branch 'MDL-70916' of https://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 19:20:46 +0000 (20:20 +0100)]
Merge branch 'MDL-70899-master' of git://github.com/marinaglancy/moodle
Shamim Rezaie [Thu, 10 Dec 2020 12:23:49 +0000 (23:23 +1100)]
MDL-70172 output: pages with main logo should have a first-level header
Shamim Rezaie [Wed, 9 Dec 2020 17:02:09 +0000 (04:02 +1100)]
MDL-70172 output: Fix empty links
The approach taken is inline with font-awesome documentation:
https://fontawesome.com/how-to-use/on-the-web/other-topics/accessibility
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 15:47:28 +0000 (16:47 +0100)]
Merge branch 'MDL-70912-master' of git://github.com/sarjona/moodle
Sara Arjona [Mon, 1 Mar 2021 15:17:19 +0000 (16:17 +0100)]
Merge branch 'MDL-68735' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 13:21:59 +0000 (14:21 +0100)]
Merge branch 'MDL-70913-master' of git://github.com/sarjona/moodle
Sara Arjona [Tue, 16 Feb 2021 11:39:35 +0000 (12:39 +0100)]
MDL-70913 core_badges: Use and update properly sortorder
Sortorder field in badge_external_backpack was updated with a wrong
value. This patch fixes this behaviour and adds sortorder as
sorting criteria for displaying the list of site backpacks.
In the phpunit method reviewed for covering this, a couple of
assertEquals() calls have been changed too to put the expected value
first.
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 09:00:27 +0000 (10:00 +0100)]
Merge branch 'MDL-70931-master-xmldbeol' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 08:54:00 +0000 (09:54 +0100)]
Merge branch 'MDL-70941-master' of git://github.com/dravek/moodle
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 08:46:27 +0000 (09:46 +0100)]
Merge branch 'MDL-70910-master' of git://github.com/dravek/moodle
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 08:33:49 +0000 (09:33 +0100)]
Merge branch 'MDL-70964-master-enfix' of git://github.com/mudrd8mz/moodle
Marina Glancy [Mon, 22 Feb 2021 15:36:17 +0000 (16:36 +0100)]
MDL-70966 various: Under PHP8 empty string is no longer equals to 0
David Matamoros [Thu, 18 Feb 2021 16:16:36 +0000 (17:16 +0100)]
MDL-70910 contentbank: fix for using contentid not validated
Tim Hunt [Fri, 26 Feb 2021 12:46:32 +0000 (12:46 +0000)]
MDL-71009 question bank: escape idnumbers when displayed
Eloy Lafuente (stronk7) [Thu, 11 Feb 2021 22:50:41 +0000 (23:50 +0100)]
MDL-70876 php80: 5th param removed from custom error handlers
It was deprecated in php72 and now it's gone.
Have used this regexp to find all the uses in core:
ag set_error_handler | uniq
And then checked all them manually, that parameter was not
being used in the 3 methods where we are removing it.
Eloy Lafuente (stronk7) [Sat, 13 Feb 2021 11:50:10 +0000 (12:50 +0100)]
MDL-68735 env: Moodle 3.8.x, 3.9.x and 3.10.x do not support PHP 8.0
Marina Glancy [Wed, 17 Feb 2021 13:31:43 +0000 (14:31 +0100)]
MDL-70877 php: remove final functions __clone and __wakeup
Implementing these functions as final does not prevent the object to be
cloned or serialized, so the comment to them was wrong.
However having these functions not public breaks in PHP 8.0.
It still does not make sense to clone or serialise file_system or external_settings classes
but there are a lot of classes in moodle that should not be cloned, no reason to have
a specific solution here.
Eloy Lafuente (stronk7) [Sat, 13 Feb 2021 18:45:16 +0000 (19:45 +0100)]
MDL-70457 forms: php74 fix for the (not used in core) date element
Curly brackets to access by index to strings or arrays is
deprecated since php74.
Amaia Anabitarte [Fri, 26 Feb 2021 10:31:32 +0000 (11:31 +0100)]
MDL-67119 core_analytics: Analyse users once per course
User's activity in a course should be analysed only once
no matter the number of enrolments the user has in that course.
David Matamoros [Thu, 18 Feb 2021 14:53:02 +0000 (15:53 +0100)]
MDL-70941 contentbank: fix empty equality check when renaming content
Jun Pataleta [Fri, 26 Feb 2021 05:42:40 +0000 (13:42 +0800)]
weekly release 4.0dev
Jun Pataleta [Fri, 26 Feb 2021 05:42:36 +0000 (13:42 +0800)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Marina Glancy [Sun, 21 Feb 2021 22:30:11 +0000 (23:30 +0100)]
MDL-70921 repository: filter function can not accept argument by ref
PHP8.0 shows error that filter function accepts value by reference
The nested filtering was never working but also this function was never called on a tree with sub-levels,
so this logic is now removed
David Mudrák [Thu, 25 Feb 2021 08:38:38 +0000 (09:38 +0100)]
MDL-70964 lang: Use the fixed strings in tests
Helen Foster [Thu, 25 Feb 2021 08:22:48 +0000 (09:22 +0100)]
MDL-70964 lang: Import fixed English strings (en_fix)
Jun Pataleta [Thu, 25 Feb 2021 04:30:22 +0000 (12:30 +0800)]
Merge branch 'MDL-70169-master' of git://github.com/lameze/moodle
Jun Pataleta [Thu, 25 Feb 2021 03:32:36 +0000 (11:32 +0800)]
Merge branch 'MDL-70768-langpack-admin' of https://github.com/brendanheywood/moodle
AMOS bot [Thu, 25 Feb 2021 00:07:45 +0000 (00:07 +0000)]
Automatically generated installer lang files
Paul Holden [Mon, 8 Feb 2021 23:42:22 +0000 (23:42 +0000)]
MDL-69883 message: fix lazy loading of conversations.
Set max-height on each container section rather than the container
itself, so that each can respond to the scrollBottom event within
the lazy loading module (which handles the overflow itself).
Paul Holden [Wed, 24 Feb 2021 19:16:46 +0000 (19:16 +0000)]
MDL-70995 user: format group names in course participants filter.
Iñigo Zendegi [Fri, 4 Dec 2020 10:30:39 +0000 (11:30 +0100)]
MDL-69097 mod_forum: Apply filters to whole forum grading
Víctor Déniz [Wed, 24 Feb 2021 14:07:33 +0000 (14:07 +0000)]
Merge branch 'MDL-51111-muc-reset' of https://github.com/brendanheywood/moodle
Eloy Lafuente (stronk7) [Wed, 24 Feb 2021 10:14:25 +0000 (11:14 +0100)]
Merge branch 'MDL-70828-master' of git://github.com/abgreeve/moodle
Adrian Greeve [Tue, 9 Feb 2021 01:32:32 +0000 (09:32 +0800)]
MDL-70828 performance: Allow session locking issue to be turned off.
If a developer has debugging on then they will recieve all debugging
messages for locking whether wanted or not. We already have a setting
to display these messages.
Andrew Nicols [Wed, 24 Feb 2021 01:05:36 +0000 (09:05 +0800)]
MDL-70987 core_form: Use correct id for elementid during validation
The id of the formid was being passed instead of the elementid.
Eloy Lafuente (stronk7) [Tue, 23 Feb 2021 18:07:56 +0000 (19:07 +0100)]
Merge branch 'MDL-52817' of git://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Tue, 23 Feb 2021 17:39:24 +0000 (18:39 +0100)]
MDL-70314 lib: Remove a few more hidden files and add instructions
Eloy Lafuente (stronk7) [Tue, 23 Feb 2021 17:33:29 +0000 (18:33 +0100)]
Merge branch 'MDL-70314' of https://github.com/Chocolate-lightning/moodle
Eloy Lafuente (stronk7) [Tue, 23 Feb 2021 16:43:32 +0000 (17:43 +0100)]
Merge branch 'MDL-70920-master' of git://github.com/marinaglancy/moodle
Sara Arjona [Tue, 23 Feb 2021 14:26:20 +0000 (15:26 +0100)]
MDL-67974 core_badges: Recovered expired stamp
Expired stamp icon displayed over the badge images has been added
again to CSS (it was lost at any point).
Sara Arjona [Tue, 23 Feb 2021 14:23:53 +0000 (15:23 +0100)]
MDL-67974 core_badges: Badge expiry date when hover
Text displayed for expired badges when the user hovers over the
warning (!) icon has been fixed in the "Issued badge information"
page.
Víctor Déniz [Tue, 23 Feb 2021 11:14:14 +0000 (11:14 +0000)]
Merge branch 'MDL-70038-master' of https://github.com/jpahullo/moodle
Jordi Pujol Ahulló [Mon, 26 Oct 2020 15:57:25 +0000 (16:57 +0100)]
MDL-70038 assign: add suport for pdftoppm tool
pdftoppm (from poppler-utils package) is several orders of
magnitude quicker than ghostscript extracting PNG images
from PDF documents.
We add support for this tool and use it whenever set up,
or using gs as before if missing.
Revisited code with peer review comments. In particular:
1. Make default path for pdftoppm empty string.
2. Fix a typo on the method description for get_gs_command_for_image.
3. Added more information why is useful pdftoppm into string pathtopdftoppm_help.
4. Check that path for pdftoppm is executable to prevent errors. Otherwise, use gs.
Eloy Lafuente (stronk7) [Mon, 22 Feb 2021 22:09:53 +0000 (23:09 +0100)]
Merge branch 'MDL-43697-master' of https://github.com/praxisdigital/moodle
Mark Nelson [Sat, 9 Jan 2021 06:13:08 +0000 (14:13 +0800)]
MDL-70125 core_grade: do not change overridden status during regrading
Mathew May [Mon, 22 Feb 2021 03:43:05 +0000 (11:43 +0800)]
MDL-70314 lib: Change XLSX wrapper to no change the default styles
This is required due to changes in the base library see #1712
Summary is that if a column already has styling it can't be overpowered.
Mathew May [Fri, 8 Jan 2021 06:52:48 +0000 (14:52 +0800)]
MDL-70314 lib: Apply Moodle specific phpspreadsheet changes
Mathew May [Mon, 18 Jan 2021 03:40:23 +0000 (11:40 +0800)]
MDL-70314 lib: Upgrade PhpSpreadsheet to 1.16.0
Andrew Nicols [Mon, 22 Feb 2021 04:19:18 +0000 (12:19 +0800)]
MDL-69259 h5pactivity: Whitespace fix
Andrew Nicols [Mon, 22 Feb 2021 04:06:13 +0000 (12:06 +0800)]
Merge branch 'MDL-69259-master' of git://github.com/ilyatregubov/moodle
AMOS bot [Mon, 22 Feb 2021 00:07:44 +0000 (00:07 +0000)]
Automatically generated installer lang files
Andrew Nicols [Sun, 21 Feb 2021 23:49:54 +0000 (07:49 +0800)]
Merge branch 'MDL-70879' of https://github.com/stronk7/moodle
Marina Glancy [Thu, 18 Feb 2021 10:49:43 +0000 (11:49 +0100)]
MDL-70920 core: prevent calls to call_user_fun_array() with assoc array
Marina Glancy [Tue, 16 Feb 2021 21:52:52 +0000 (22:52 +0100)]
MDL-70920 backup: call_user_func_array can accept named arguments
Because arguments names do not match in associative array, we change it to regular array or arguments
Paul Holden [Wed, 11 Nov 2020 22:38:34 +0000 (22:38 +0000)]
MDL-52817 dml: implement driver methods for SQL group concatenation.
Daniel Kristian Steffensen [Tue, 15 Dec 2020 14:51:31 +0000 (15:51 +0100)]
MDL-43697 backup: Archived badges are restored during course restore
Ilya Tregubov [Tue, 24 Nov 2020 08:14:35 +0000 (10:14 +0200)]
MDL-69259 h5pactivity: Add get_user_attempts webservice
Eloy Lafuente (stronk7) [Sun, 14 Feb 2021 15:58:09 +0000 (16:58 +0100)]
MDL-70879 behat: Bump to Behat 3.8.x (required for php80)
Víctor Déniz [Fri, 19 Feb 2021 12:38:56 +0000 (12:38 +0000)]
weekly release 4.0dev
Víctor Déniz [Fri, 19 Feb 2021 12:38:56 +0000 (12:38 +0000)]
NOBUG: Fixed file access permissions