Andrew Nicols [Thu, 27 May 2021 03:25:59 +0000 (11:25 +0800)]
Merge branch 'MDL-71466-master' of https://github.com/sammarshallou/moodle
Andrew Nicols [Thu, 27 May 2021 03:18:14 +0000 (11:18 +0800)]
Merge branch 'MDL-71047-master' of https://github.com/NashTechOpenUniversity/moodle
Andrew Nicols [Thu, 27 May 2021 02:58:50 +0000 (10:58 +0800)]
Merge branch 'MDL-70853-master' of git://github.com/lucaboesch/moodle
Andrew Nicols [Thu, 27 May 2021 01:54:02 +0000 (09:54 +0800)]
MDL-71462 core: Remove duplicate gitignore line
Andrew Nicols [Thu, 27 May 2021 01:52:59 +0000 (09:52 +0800)]
Merge branch 'MDL-71462-master' of https://github.com/SysBind/moodle
Andrew Nicols [Thu, 27 May 2021 01:44:26 +0000 (09:44 +0800)]
Merge branch 'MDL-67771-master' of git://github.com/peterRd/moodle
Andrew Nicols [Thu, 27 May 2021 01:35:09 +0000 (09:35 +0800)]
Merge branch 'MDL-71145-master' of git://github.com/HuongNV13/moodle
Eloy Lafuente (stronk7) [Wed, 26 May 2021 16:35:55 +0000 (18:35 +0200)]
Merge branch 'MDL-71159-master' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Wed, 26 May 2021 15:25:44 +0000 (17:25 +0200)]
Merge branch 'MDL-68394-master' of git://github.com/ilyatregubov/moodle
Sara Arjona [Wed, 26 May 2021 10:39:25 +0000 (12:39 +0200)]
Merge branch 'MDL-53544-master-2' of git://github.com/peterRd/moodle
Peter Dias [Fri, 21 May 2021 02:24:30 +0000 (10:24 +0800)]
MDL-53544 lib: Update unit tests and thirdpartylibs
Peter Dias [Fri, 21 May 2021 02:34:41 +0000 (10:34 +0800)]
MDL-53544 core: Remove typo3 usages in core
Peter Dias [Fri, 21 May 2021 02:23:37 +0000 (10:23 +0800)]
MDL-53544 lib: Remove typo3 from text.php
Ilya Tregubov [Wed, 20 Jan 2021 12:18:09 +0000 (14:18 +0200)]
MDL-68394 h5pactivity: Implement methods to display recent
activity info.
Jake Dallimore [Wed, 26 May 2021 04:49:34 +0000 (12:49 +0800)]
Merge branch 'MDL-70990-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 25 Feb 2021 01:33:18 +0000 (09:33 +0800)]
MDL-70990 core: Deprecate core/events::getLegacyEvents()
Andrew Nicols [Thu, 25 Feb 2021 02:41:25 +0000 (10:41 +0800)]
MDL-70990 core_block: Replace legacy BLOCK_CONTENT_UPDATED event
The legacy M.core.event.BLOCK_CONTENT_UPDATED event has been replaced with a
new core_block/events::blockContentUpdated native DOM event.
The new event can be triggered using the `notifyBlockContentUpdated`
event, and by providing the HTMLElement that was updated, for example:
```
import {notifyBlockContentUpdated} from 'core_block/events';
const someHandler = e => {
// ...
const updatedBlock = e.target.closest('.block');
notifyBlockContentUpdated(updatedBlock);
};
```
The new event can be listened to at any point in the DOM using the
following syntax:
```
import {eventTypes} from 'core_block/events';
const handler = e => {
// The block that was updated.
e.target;
// The id of the updated block.
e.detail.instanceId;
};
document.addEventListener(eventTypes.blockContentUpdated, handler);
```
A backward-compatabibility layer is included to ensure that any legacy
YUI event listener is still called with the same arguments.
This legacy bridges will be removed after Moodle 4.3.
Andrew Nicols [Thu, 25 Feb 2021 02:24:03 +0000 (10:24 +0800)]
MDL-70990 core_form: Replace FORM_ERROR event
The legacy M.core.event.FORM_ERROR event has been replaced with a new
core_form/events::formError native DOM event.
The new event can be listened to at any point in the DOM using the
following syntax:
```
import {eventTypes} from 'core_form/events';
document.addEventListener(eventTypes.formError, handler);
```
A backward-compatabibility layer is included to ensure that any legacy
YUI event listener is still called with the same arguments.
This legacy bridges will be removed after Moodle 4.3.
Andrew Nicols [Mon, 17 May 2021 07:09:19 +0000 (15:09 +0800)]
MDL-70990 core_filter: Add new native filterContentUpdated event
The legacy M.core.event.FILTER_CONTENT_UPDATED event has been replaced with a
new core_filter/events::filterContentUpdated native DOM event.
The new event can be triggered using the `notifyFilterContentUpdated`
function, and by providing with an Array containing the HTMLElements
that were updated, for example:
```
import {notifyFilterContentUpdated} from 'core_filter/events';
const someHandler = e => {
// ...
const nodeList = Array.from(document.querySelectorAll('div'));
notifyFilterContentUpdated(nodeList);
};
```
The new event can be listened to at any point in the DOM using the
following syntax:
```
import {eventTypes} from 'core_filter/events';
const handler = e => {
// The list of HTMLElements in an Array.
e.detail.nodes;
};
document.addEventListener(eventTypes.filterContentUpdated, handler);
```
A backward-compatabibility layer is included to ensure that any legacy
YUI event listener, or jQuery event listener are still called with the
same arguments.
This legacy bridges will be removed after Moodle 4.3.
Andrew Nicols [Wed, 24 Feb 2021 09:41:35 +0000 (17:41 +0800)]
MDL-70990 core_editor: Replace EDITOR_CONTENT_RESTORED event
The legacy M.core.event.EDITOR_CONTENT_RESTORED event has been replaced
with a new core_editor/events::editorContentRestored native DOM event.
The new event can be listened to at any point in the DOM using the
following syntax:
```
import {eventTypes} from 'core_editor/events';
document.addEventListener(eventTypes.editorContentRestored, handler);
```
A backward-compatabibility layer is included to ensure that any legacy
jQuery event is still called with the same arguments.
This legacy bridge will be removed after Moodle 4.3.
Andrew Nicols [Tue, 25 May 2021 05:18:25 +0000 (13:18 +0800)]
MDL-70990 core_form: Standardise event name usage
The `types` object introduced in Moodle 3.11 has been replaced with the
`eventTypes` object which is used consistently across all CustomEvent
definitinos.
Likewise the trigger functions have been renamed from
`triggerUploadStarted` to `notifyUploadStarted` and from
`triggerUploadCompleted` to `notifyUploadCompleted`.
Backwards compatability is maintained.
Andrew Nicols [Tue, 25 May 2021 05:46:03 +0000 (13:46 +0800)]
MDL-70990 core_form: Replace FORM_FIELD_VALIDATION event
The legacy core/event::FORM_FIELD_VALIDATION event has been replaced with a
new core_form/events::formFieldValidationFailed native DOM event.
The new event can be listened to at any point in the DOM using the
following syntax:
```
import {eventTypes} from 'core_form/events';
document.addEventListener(eventTypes.formFieldValidationFailed, handler);
```
A backward-compatabibility layer is included to ensure that any legacy
jQuery event is still called with the same arguments.
This legacy bridge will be removed after Moodle 4.3.
Andrew Nicols [Mon, 17 May 2021 07:05:12 +0000 (15:05 +0800)]
MDL-70990 core_form: Replace FORM_SUBMIT_AJAX event
The legacy M.core.event.FORM_SUBMIT_AJAX ecent has been replaced with a
new core_form/events::formSubmittedByJavascript native DOM event.
The new event can be listened to at any point in the DOM using the
following syntax:
```
import {eventTypes} from 'core_form/events';
document.addEventListener(eventTypes.formSubmittedByJavascript, handler);
```
A backward-compatabibility layer is included to ensure that any
legacy YUI event triggered on a form is still respected and the new
native event is also fired.
A similar handler is also included to ensure that any legacy YUI event
listener is still called with the same arguments.
These legacy bridges will be removed after Moodle 4.3.
Andrew Nicols [Wed, 24 Feb 2021 01:35:38 +0000 (09:35 +0800)]
MDL-70990 core: Rewrite core/event as ES6
Andrew Nicols [Wed, 26 May 2021 02:38:48 +0000 (10:38 +0800)]
Merge branch 'MDL-71628-master' of https://github.com/nguyenphuctien/moodle
Sara Arjona [Tue, 25 May 2021 13:34:23 +0000 (15:34 +0200)]
Merge branch 'MDL-68925_master' of git://github.com/mdjnelson/moodle
Tien Nguyen [Fri, 14 May 2021 07:51:40 +0000 (14:51 +0700)]
MDL-71628 quiz: Quiz review: names not shown on Manual grading screens
Eloy Lafuente (stronk7) [Mon, 24 May 2021 21:22:59 +0000 (23:22 +0200)]
Merge branch 'MDL-71659-master-missinggradeitem' of git://github.com/mudrd8mz/moodle
avi [Tue, 27 Apr 2021 13:14:56 +0000 (16:14 +0300)]
MDL-71462 core: Add phpstorm metadata file to gitignore
Andrew Nicols [Mon, 1 Mar 2021 12:25:39 +0000 (20:25 +0800)]
MDL-70990 core: Ignore amd directory in plugin-like lists
The `get_list_of_plugins()` function is used to fetch plugin-like files
or directories from a specified directory. A number of standard
exclusions are included but this list is not the same as the list in
`core_component`.
The list has been updated to include the `amd` directory, which is
regularly used in both components, and plugins.
Peter Dias [Tue, 27 Apr 2021 05:15:29 +0000 (13:15 +0800)]
MDL-53544 lib: Remove old Typo3 files
Huong Nguyen [Mon, 12 Apr 2021 08:59:00 +0000 (15:59 +0700)]
MDL-71145 qtype_ddmarker: Incorrect marker positions in responsive mode
Jun Pataleta [Fri, 21 May 2021 00:56:08 +0000 (08:56 +0800)]
Merge branch 'MDL-60431' of https://github.com/jonof/moodle
Jonathon Fowler [Wed, 5 May 2021 06:35:52 +0000 (16:35 +1000)]
MDL-60431 qtype_calculated: handle NAN and INF calculation outcomes
With significant-digits presentation mode, NAN would be formatted as
'NAN' followed by zeroes, which looks silly, and +INF would cause an
execution timeout as Moodle tries to divide +∞ by 10 until it becomes
less than 1, which can happen in a divide-by-zero situation.
Note that the user can't answer NAN or INF to any question, but at this
at least now looks consistent and also doesn't break Moodle in the case
of +INF.
Luca Bösch [Tue, 18 May 2021 19:54:34 +0000 (21:54 +0200)]
MDL-70853 theme: align submit buttons in settings forms.
Sara Arjona [Thu, 20 May 2021 09:09:00 +0000 (11:09 +0200)]
weekly release 4.0dev
Sara Arjona [Thu, 20 May 2021 09:08:57 +0000 (11:08 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Peter Dias [Thu, 20 May 2021 07:13:51 +0000 (15:13 +0800)]
MDL-67771 theme: Add side-post to incourse views
Mark Nelson [Mon, 12 Oct 2020 05:12:08 +0000 (15:12 +1000)]
MDL-68925 assignfeedback_editpdf: avoid hiding comments with a menu open
Co-authored by: Jonathon Fowler <fowlerj@usq.edu.au>
Jun Pataleta [Thu, 20 May 2021 04:30:15 +0000 (12:30 +0800)]
Merge branch 'MDL-71157-master' of git://github.com/sarjona/moodle
abgreeve [Thu, 20 May 2021 03:10:07 +0000 (11:10 +0800)]
Merge branch 'MDL-65203-master' of https://github.com/dcai/moodle
Andrew Nicols [Thu, 20 May 2021 02:49:13 +0000 (10:49 +0800)]
Merge branch 'MDL-71647' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 20 May 2021 01:32:06 +0000 (09:32 +0800)]
Merge branch 'MDL-71626' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Wed, 19 May 2021 21:02:41 +0000 (23:02 +0200)]
Merge branch 'MDL-71126-master' of git://github.com/HuongNV13/moodle
Eloy Lafuente (stronk7) [Wed, 19 May 2021 20:50:02 +0000 (22:50 +0200)]
Merge branch 'MDL-67935-master' of git://github.com/sarjona/moodle
Eloy Lafuente (stronk7) [Wed, 19 May 2021 17:36:04 +0000 (19:36 +0200)]
Merge branch 'MDL-71373-master' of git://github.com/lucaboesch/moodle
Luca Bösch [Wed, 19 May 2021 07:28:11 +0000 (09:28 +0200)]
MDL-71373 tool_usertours: localize "previous"/"next" in user tours.
AMOS BEGIN
CPY [previous,core],[previousstep,tool_usertours]
CPY [next,core],[nextstep,tool_usertours]
AMOS END
Sara Arjona [Fri, 14 May 2021 13:57:54 +0000 (15:57 +0200)]
MDL-71157 block_myoverview: remove wait from behat
The step "And I wait until ".block_myoverview
[data-control='next']" "css_element" exists" is not correct
because this [data-control='next'] element exists before and
after the step so, in some cases, it might cause the following
step will start earlier than expected.
As pending JS has been added, this wait steps are not required
any more.
Andrew Nicols [Tue, 18 May 2021 00:56:23 +0000 (08:56 +0800)]
MDL-71157 core: Pending JS in paged content bars
Eloy Lafuente (stronk7) [Tue, 18 May 2021 20:59:13 +0000 (22:59 +0200)]
Merge branch 'MDL-71619' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Tue, 18 May 2021 20:41:42 +0000 (22:41 +0200)]
Merge branch 'MDL-71373-master' of git://github.com/lucaboesch/moodle
David Mudrák [Tue, 18 May 2021 16:58:53 +0000 (18:58 +0200)]
MDL-71659 completion: Consider modules without grade_item incomplete
Activity modules may not have the associated grade_item created yet. It
used to throw fatal error in that case - even when trying to view the
course or edit the activity. So there was no easy way to recover from
this situation.
The patch is based on reasoning that an activity without grade item is
same as activity without any grades. And as such it is considered
incomplete.
A new unit test is added to cover this specific scenario. The existing
unit test is modified and it does not expect the exception any more.
There does not seem to be any good reason why this situation should be
exceptional.
Dongsheng Cai [Tue, 18 May 2021 10:36:49 +0000 (20:36 +1000)]
MDL-65203 template: tab should be quoted to produce valid json
AMOS bot [Tue, 18 May 2021 00:07:58 +0000 (00:07 +0000)]
Automatically generated installer lang files
Paul Holden [Mon, 17 May 2021 15:01:07 +0000 (16:01 +0100)]
MDL-71647 user: allow searching user selector by identity fields.
Fixes regression from
d916cd77, which passed empty extra fields when
not including custom fields.
Nhan Vo [Wed, 10 Mar 2021 11:20:06 +0000 (18:20 +0700)]
MDL-71047 HTML Editor (Atto): Cursor position is not correct when paste
Luca Bösch [Tue, 20 Apr 2021 05:56:59 +0000 (07:56 +0200)]
MDL-71373 core_enrol: localize "close" in role manager.
Luca Bösch [Tue, 20 Apr 2021 05:53:18 +0000 (07:53 +0200)]
MDL-71373 tool_usertours: localize "previous"/"next" in user tours.
Luca Bösch [Mon, 19 Apr 2021 11:24:07 +0000 (13:24 +0200)]
MDL-71373 core_table: localize "previous"/"next" in pagination.
Huong Nguyen [Tue, 11 May 2021 08:12:58 +0000 (15:12 +0700)]
MDL-71126 Quiz: Manual grading page size preference can get stuck at 0
Including in this change:
- New positiveint regex rule to check if the value is a positive integer
Sara Arjona [Fri, 14 May 2021 09:06:18 +0000 (11:06 +0200)]
weekly release 4.0dev
Sara Arjona [Fri, 14 May 2021 09:06:16 +0000 (11:06 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Sara Arjona [Fri, 14 May 2021 08:11:12 +0000 (10:11 +0200)]
MDL-67935 tool_lp: fix random errors with login/logout
AMOS bot [Fri, 14 May 2021 00:07:53 +0000 (00:07 +0000)]
Automatically generated installer lang files
Víctor Déniz [Thu, 13 May 2021 21:34:11 +0000 (22:34 +0100)]
Merge branch 'MDL-71569-master_Summarydata' of https://github.com/brickfield/moodle
Paul Holden [Mon, 10 May 2021 07:07:13 +0000 (08:07 +0100)]
MDL-71626 admin: filter site fullname in CLI maintenance script.
Paul Holden [Thu, 13 May 2021 09:54:04 +0000 (10:54 +0100)]
MDL-71619 privacy: extend correct class in provider testcases.
Extending the privacy provider testcase means that it's tearDown
method will reset the request writer.
Sara Arjona [Thu, 13 May 2021 09:45:36 +0000 (11:45 +0200)]
Merge branch 'MDL-71611-master_blockaccessreviewupgrade' of https://github.com/brickfield/moodle
Jun Pataleta [Thu, 13 May 2021 06:30:24 +0000 (14:30 +0800)]
Merge branch 'MDL-71612-master' of https://github.com/snake/moodle
Jun Pataleta [Thu, 13 May 2021 05:57:22 +0000 (13:57 +0800)]
Merge branch 'MDL-71584-master_Languagestrings' of https://github.com/brickfield/moodle
Jake Dallimore [Thu, 13 May 2021 04:47:58 +0000 (12:47 +0800)]
MDL-71612 tool_oauth2: remove erroneous hideIf rules for form fields
Some fields were being hidden based on whether the service was set up
for internal service use or was a service shown on the login page.
These fields refer to OAuth 2 logins and must be configurable for both
kinds of services.
Eloy Lafuente (stronk7) [Wed, 12 May 2021 20:58:12 +0000 (22:58 +0200)]
Merge branch 'MDL-71580-master-enfix' of git://github.com/mudrd8mz/moodle
Mike Churchward [Wed, 12 May 2021 20:29:09 +0000 (16:29 -0400)]
MDL-71611 block_accessreview: Return formats if feature disabled.
David Mudrák [Wed, 12 May 2021 06:48:00 +0000 (08:48 +0200)]
MDL-71580 lang: Fix reworded strings in tests
Helen Foster [Wed, 12 May 2021 06:34:29 +0000 (08:34 +0200)]
MDL-71580 lang: Import fixed English strings (en_fix)
Mike Churchward [Tue, 11 May 2021 00:08:40 +0000 (20:08 -0400)]
MDL-71584 tool_brickfield: Fixed up language string issues.
Jun Pataleta [Wed, 12 May 2021 05:25:53 +0000 (13:25 +0800)]
Merge branch 'MDL-71590-master' of git://github.com/HuongNV13/moodle
Huong Nguyen [Tue, 11 May 2021 08:35:00 +0000 (15:35 +0700)]
MDL-71590 usertours: Create language string for activity information
Jake Dallimore [Wed, 12 May 2021 02:35:34 +0000 (10:35 +0800)]
Merge branch 'MDL-71583' of https://github.com/stronk7/moodle
Karen Holland [Fri, 7 May 2021 18:51:45 +0000 (19:51 +0100)]
MDL-71569 Accessibility toolkit: Fix Summary data task failure
Eloy Lafuente (stronk7) [Tue, 11 May 2021 18:11:07 +0000 (20:11 +0200)]
MDL-71583 versions: Add all the missing full-stops to version/requires
It seems that the new phpcs3 checker is now controlling those
line comments that previously were ignored.
This commit just looks for all the cases and bulk-add
them when needed. The bash script (mac) used to add all them is:
while read -r line; do
arr=(${line//:/ })
if [[ -n ${arr[0]} ]] && [[ -n ${arr[1]} ]]; then
echo " file ${arr[0]}, line ${arr[1]}"
sed -i "${arr[1]}s/\$/\./" ${arr[0]}
fi
done < <(find . -name version.php | xargs ag --nomultiline '>(version|requires) *=.*//.*[^;\.]$')
sam marshall [Tue, 27 Apr 2021 14:46:51 +0000 (15:46 +0100)]
MDL-71466 admin: Add custom user field support to role screens
Implements custom user field support within the 'check capabilities'
and 'assign roles' screens.
Sara Arjona [Tue, 11 May 2021 10:42:28 +0000 (12:42 +0200)]
weekly release 4.0dev
Sara Arjona [Tue, 11 May 2021 10:42:25 +0000 (12:42 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
AMOS bot [Tue, 11 May 2021 00:07:55 +0000 (00:07 +0000)]
Automatically generated installer lang files
Víctor Déniz [Mon, 10 May 2021 22:40:53 +0000 (23:40 +0100)]
Merge branch 'MDL-71060-master' of https://github.com/NashTechOpenUniversity/moodle
Víctor Déniz [Mon, 10 May 2021 21:47:13 +0000 (22:47 +0100)]
Merge branch 'MDL-70900' of https://github.com/stronk7/moodle
Víctor Déniz [Mon, 10 May 2021 21:06:59 +0000 (22:06 +0100)]
Merge branch 'MDL-71543-master_toggleicon' of https://github.com/brickfield/moodle
Sara Arjona [Mon, 10 May 2021 13:38:24 +0000 (15:38 +0200)]
Merge branch 'MDL-71570-master' of git://github.com/mihailges/moodle
Sara Arjona [Mon, 10 May 2021 09:37:58 +0000 (11:37 +0200)]
Merge branch 'MDL-71533' of git://github.com/danmarsden/moodle
Jun Pataleta [Mon, 10 May 2021 09:23:05 +0000 (17:23 +0800)]
Merge branch 'MDL-71552-master_heatmaptoggle' of https://github.com/brickfield/moodle
Mihail Geshoski [Mon, 10 May 2021 04:21:31 +0000 (12:21 +0800)]
MDL-71570 mod_forum: Avoid using deprecated string in forum templates
Mihail Geshoski [Mon, 10 May 2021 04:17:15 +0000 (12:17 +0800)]
MDL-71570 core_grades: Avoid using deprecated string in grade templates
Thong Bui [Sun, 9 May 2021 17:22:22 +0000 (00:22 +0700)]
MDL-71060 Questions: Duplicates 'Current category' text.
Víctor Déniz [Sat, 8 May 2021 19:30:31 +0000 (20:30 +0100)]
Merge branch 'MDL-71544-master_Errorspage' of https://github.com/brickfield/moodle
Eloy Lafuente (stronk7) [Fri, 12 Feb 2021 11:04:31 +0000 (12:04 +0100)]
MDL-70900 ci: Move highest PHP to 8.0 (from current 7.4)
Also adds xmlrpc-beta from PECL (PHP8 moved the extension there)
and setups max_input_vars=5000 as initial value (see MDL-71390).
Note that this also includes a tiny modification when configuring
redis sessions, because there was some outdated code from old issue,
now fixed (MDL-60978), so that info has been removed.
Eloy Lafuente (stronk7) [Fri, 7 May 2021 14:54:26 +0000 (16:54 +0200)]
weekly release 4.0dev
Eloy Lafuente (stronk7) [Fri, 7 May 2021 14:54:26 +0000 (16:54 +0200)]
NOBUG: Fixed file access permissions
Eloy Lafuente (stronk7) [Fri, 7 May 2021 14:54:23 +0000 (16:54 +0200)]
NOBUG: Fixed SVG browser compatibility
Jun Pataleta [Fri, 7 May 2021 04:21:33 +0000 (12:21 +0800)]
Merge branch 'MDL-71234-master' of git://github.com/HuongNV13/moodle