Bas Brands [Tue, 27 Oct 2020 12:44:02 +0000 (13:44 +0100)]
MDL-69453 core_form: improve form UI icons and alignment
Eloy Lafuente (stronk7) [Fri, 6 Nov 2020 21:55:37 +0000 (22:55 +0100)]
weekly release 4.0dev
Eloy Lafuente (stronk7) [Fri, 6 Nov 2020 21:55:34 +0000 (22:55 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install into master
Víctor Déniz [Fri, 6 Nov 2020 19:14:58 +0000 (19:14 +0000)]
Merge branch 'MDL-70137-master-2' of git://github.com/andrewnicols/moodle
Andrew Nicols [Fri, 6 Nov 2020 07:07:57 +0000 (15:07 +0800)]
MDL-70137 cache: Write config to temp file and move into place
Andrew Nicols [Fri, 6 Nov 2020 07:27:46 +0000 (15:27 +0800)]
MDL-70137 cache: Use sensible default when reading MUC config
When we read the MUC configuration, a file which exists but is empty
will not error, but will cause all configuration to be empty.
We already perform an {{is_array()}} check on the {{$configuration}}
variable, but the default value for {{$configuration}} is an empty
array. In the case where the file exists, but is empty, no errors occur
when the file is loaded, and the initial {{$configuration}} value is
not overwritten, leading to the file being replaced with an empty copy.
Eloy Lafuente (stronk7) [Fri, 6 Nov 2020 18:52:03 +0000 (19:52 +0100)]
Merge branch 'MDL-70143-master' of git://github.com/marinaglancy/moodle into master
Marina Glancy [Fri, 6 Nov 2020 17:07:24 +0000 (18:07 +0100)]
MDL-70143 tool_uploaduser: fix wrong cache reference
Eloy Lafuente (stronk7) [Fri, 6 Nov 2020 18:27:10 +0000 (19:27 +0100)]
Merge branch 'MDL-70139-master' of git://github.com/sarjona/moodle into master
Sara Arjona [Fri, 6 Nov 2020 14:15:45 +0000 (15:15 +0100)]
MDL-70139 core_badges: fix invalid request when sending to backpack
Having mixed $data in badge exporters is causing some issues.
As all these exporters are using $data as an object, $data can be
converted to object in the constructor, to avoid errors and get
the expected behaviour always.
Jun Pataleta [Fri, 6 Nov 2020 03:28:02 +0000 (11:28 +0800)]
Merge branch 'MDL-70130-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Fri, 6 Nov 2020 02:46:02 +0000 (10:46 +0800)]
MDL-70130 core: Compare realpaths for file attachment checks
Rather than using the provided path, the `realpath` must be used to
ensure that the use of symlinks in paths is normalised.
Andrew Nicols [Fri, 6 Nov 2020 02:50:56 +0000 (10:50 +0800)]
MDL-70130 core: Simplify attachment handling in email_to_suer
Marina Glancy [Thu, 5 Nov 2020 16:01:54 +0000 (17:01 +0100)]
MDL-70130 core: allow to attach files from localrequestdir to emails
Co-authored-by: Paul Holden <paulh@moodle.com>
Marina Glancy [Thu, 5 Nov 2020 17:10:13 +0000 (18:10 +0100)]
MDL-70131 cli: only allow to negate existing keys
Andrew Nicols [Fri, 6 Nov 2020 01:04:06 +0000 (09:04 +0800)]
Merge branch 'MDL-70120-assign-stamp-expires' of https://github.com/brendanheywood/moodle
AMOS bot [Fri, 6 Nov 2020 00:09:51 +0000 (00:09 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Thu, 5 Nov 2020 11:15:57 +0000 (12:15 +0100)]
weekly release 4.0dev
Jun Pataleta [Thu, 5 Nov 2020 04:51:31 +0000 (12:51 +0800)]
Merge branch 'MDL-70075-master-2' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 5 Nov 2020 02:00:33 +0000 (10:00 +0800)]
Merge branch 'MDL-70066-master' of git://github.com/lameze/moodle
Andrew Nicols [Wed, 4 Nov 2020 03:24:04 +0000 (11:24 +0800)]
MDL-70075 core: Autocomplete selection should always have an active item
Ensure that there is always one active element in the list of selected
autocomplete elements.
Without this we have issues beacuse clicking on the link makes the first
one active if one is not already active, and this turns a click event
into a drag event, which means that it is not deleted.
Eloy Lafuente (stronk7) [Wed, 4 Nov 2020 21:39:24 +0000 (22:39 +0100)]
Merge branch 'MDL-70100-master' of git://github.com/bmbrands/moodle into master
Víctor Déniz [Wed, 4 Nov 2020 19:17:04 +0000 (19:17 +0000)]
Merge branch 'MDL-70112' of https://github.com/timhunt/moodle
Sara Arjona [Wed, 4 Nov 2020 19:14:50 +0000 (20:14 +0100)]
Merge branch 'MDL-70114-master' of git://github.com/bmbrands/moodle
Víctor Déniz [Wed, 4 Nov 2020 15:17:03 +0000 (15:17 +0000)]
Merge branch 'MDL-68749-master-2' of git://github.com/mickhawkins/moodle
Sara Arjona [Wed, 4 Nov 2020 14:19:28 +0000 (15:19 +0100)]
Merge branch 'MDL-70119-master' of git://github.com/ferranrecio/moodle
Bas Brands [Wed, 4 Nov 2020 13:21:57 +0000 (13:21 +0000)]
MDL-70114 mod_data: add border for to textarea
Ferran Recio [Wed, 4 Nov 2020 11:48:09 +0000 (12:48 +0100)]
MDL-70119 core_badges: fix tab names
Brendan Heywood [Wed, 4 Nov 2020 11:42:21 +0000 (22:42 +1100)]
MDL-70120 assignfeedback_editpdf: Stamp files should be cached
Simey Lameze [Thu, 29 Oct 2020 23:17:43 +0000 (07:17 +0800)]
MDL-70066 badges: change usages of array_key_exists to isset
Andrew Nicols [Mon, 2 Nov 2020 07:42:38 +0000 (15:42 +0800)]
MDL-70075 core: Do not return a value in an event handler
Returning a value of `false` in an event handler has the effect of
calling event.preventDefault() and event.stopPropagation().
This is neither obvious, nor desirable in this situation.
Andrew Nicols [Mon, 2 Nov 2020 07:42:13 +0000 (15:42 +0800)]
MDL-70075 core: jQuery.attr() does not accept a bool value
The documented values that jQuery.attr() accepts are String, Number, or
null. For some reason, when we pass a Boolean value, the subsequent
click handler does not work in some situations.
Changing this to take a Number, and unsetting it when empty, resolves
this issue.
Andrew Nicols [Mon, 2 Nov 2020 01:33:05 +0000 (09:33 +0800)]
MDL-70075 core: Listen for `change` in accessibleChange event
The accessibleChange custom interaction event was only listening for
blur and focus, however some OS/browser combinations do not emit these
events until the element is explicitly blurred. This is notably
different on Firefox on some Operating Systems.
Recent changes in MDL-68167 explicitly moved the user participants page
filter module to use the accessibleChange event, which means that the
selections are now only triggered on an explicit blur when using
Firefox. This highlight a bug whereby, when the mouse is used to make a
selection, the event is not triggered until the element is blurred.
This change modifies the accessibleChange event to ignore the `change`
event where it was triggered by the keyboard and where that keybaord
event was not a [return] or [escape] keypress, but to otherwise respect
the native change event.
Andrew Nicols [Mon, 2 Nov 2020 00:12:22 +0000 (08:12 +0800)]
MDL-70075 core: Listen for the `focus` and `blur` events again
The `blur` event does not bubble, but the `focusout` events are not
available in all supported versions of Firefox.
Rather than switching event, this patch using event capture to
effectively achieve the same result and bubble the event up through the
DOM to the delegated listener.
There should be no functional change with this patch, except to support
Firefox fully.
Jake Dallimore [Wed, 4 Nov 2020 01:00:05 +0000 (09:00 +0800)]
Merge branch 'MDL-70093-master' of https://github.com/golenkovm/moodle
Tim Hunt [Tue, 3 Nov 2020 21:25:51 +0000 (21:25 +0000)]
MDL-70112 drag-drop qtypes: fix form preview
Mihail Geshoski [Tue, 22 Sep 2020 08:09:59 +0000 (16:09 +0800)]
MDL-67837 backup: Add unit tests
Mihail Geshoski [Tue, 22 Sep 2020 08:09:35 +0000 (16:09 +0800)]
MDL-67837 backup: Verify caps before unenrolling users on course restore
andreasschenkel [Mon, 12 Oct 2020 09:06:12 +0000 (11:06 +0200)]
MDL-69844 user: Fix no email in download_participants_table
Only include eMail in download_participants_table
if selected in showuseridentity
($identityfieldsselect)
Juan Leyva [Mon, 28 Sep 2020 16:55:25 +0000 (18:55 +0200)]
MDL-67015 mod_data: Prevent users adding entries to other groups
Amaia Anabitarte [Tue, 15 Sep 2020 13:33:57 +0000 (15:33 +0200)]
MDL-69046 core_contentbank: Escape quotes when showing name
Ferran Recio [Wed, 19 Aug 2020 16:16:46 +0000 (18:16 +0200)]
MDL-69378 tool_uploadcourse: fix enrolment methods uploads
Peter Dias [Wed, 9 Sep 2020 05:50:21 +0000 (13:50 +0800)]
MDL-56310 restore: Confirm user has permission to change capabilities
Eloy Lafuente (stronk7) [Tue, 3 Nov 2020 11:21:06 +0000 (12:21 +0100)]
weekly release 4.0dev
Michael Hawkins [Tue, 3 Nov 2020 06:47:58 +0000 (14:47 +0800)]
MDL-68749 theme: Fix bootstrap toggle switches in RTL layout
Co-authored-by: Bas Brands <bas@moodle.com>
Andrew Nicols [Tue, 3 Nov 2020 04:03:49 +0000 (12:03 +0800)]
Merge branch 'MDL-70059-master' of git://github.com/sarjona/moodle
Jun Pataleta [Tue, 3 Nov 2020 04:02:08 +0000 (12:02 +0800)]
Merge branch 'MDL-70033-master-2' of git://github.com/mickhawkins/moodle
Michael Hawkins [Tue, 27 Oct 2020 10:51:28 +0000 (18:51 +0800)]
MDL-70033 course: Update download content event handling for Classic
Michael Hawkins [Tue, 27 Oct 2020 10:47:01 +0000 (18:47 +0800)]
MDL-70033 core: Update tree.js event handlers to replace stopPropagation
Also added support to allow links to override action keys (enter/space)
Co-authored-by: Andrew Nicols <andrew@nicols.co.uk>
Eloy Lafuente (stronk7) [Tue, 3 Nov 2020 00:24:45 +0000 (01:24 +0100)]
Merge branch 'MDL-70081-master' of git://github.com/jleyva/moodle into master
Jun Pataleta [Mon, 2 Nov 2020 16:00:44 +0000 (00:00 +0800)]
Merge branch 'MDL-69975' of https://github.com/stronk7/moodle
Sara Arjona [Mon, 2 Nov 2020 14:44:41 +0000 (15:44 +0100)]
Merge branch 'MDL-69973' of https://github.com/stronk7/moodle
Bas Brands [Mon, 2 Nov 2020 11:29:23 +0000 (11:29 +0000)]
MDL-70100 theme_boost: quiztimer zindex fix
Sara Arjona [Thu, 29 Oct 2020 17:25:16 +0000 (18:25 +0100)]
MDL-70059 core_badges: avoid duplicate key error
When 2 or more backpack were created without credentials,
a "Duplicate key value violates unique constraint" error
was raised because externalbackpackid was not taking the
correct value.
Other improvements have been done to the code too in order
to make it more readable.
Jake Dallimore [Mon, 2 Nov 2020 05:57:21 +0000 (13:57 +0800)]
Merge branch 'MDL-70073-master' of git://github.com/peterRd/moodle
Mikhail Golenkov [Mon, 2 Nov 2020 03:46:17 +0000 (14:46 +1100)]
MDL-70093 dataformat_pdf: Fix row height calculation with high cells
Peter Dias [Mon, 2 Nov 2020 02:17:30 +0000 (10:17 +0800)]
MDL-70073 badges: Fix the master upgrade savepoint
Jun Pataleta [Mon, 2 Nov 2020 02:04:24 +0000 (10:04 +0800)]
Merge branch 'MDL-70074-add-authendpoint' of https://github.com/cengage/moodle
Brendan Heywood [Wed, 28 Oct 2020 05:08:11 +0000 (16:08 +1100)]
MDL-69975 core: Fix paths longer than 260 chars on windows
Also, ensure that remove_dir() only processes directories,
because sometimes it was being called by shutdown managers
with files, leading to PHP warnings.
Co-authored-by: Eloy Lafuente (stronk7) <stronk7@moodle.org>
Co-authored-by: Jun Pataleta <jun@moodle.com>
Juan Leyva [Sat, 31 Oct 2020 12:07:30 +0000 (13:07 +0100)]
MDL-70081 airnotifier: Add missing device type in token registration
Claude Vervoort [Fri, 30 Oct 2020 19:57:15 +0000 (15:57 -0400)]
MDL-70074 mod_lti: add authorization_endpoint
Eloy Lafuente (stronk7) [Sun, 18 Oct 2020 09:59:59 +0000 (11:59 +0200)]
MDL-69973 xmldb: Ensure all reports use fresh metadata (not cached)
Eloy Lafuente (stronk7) [Sun, 18 Oct 2020 09:53:37 +0000 (11:53 +0200)]
MDL-69973 xmldb: Fix problem with MariaDB >= 10.2.7 metadata defaults
With MariaDB 10.2.7 the driver was incorrectly returning '' (empty
string) as default for all the columns having null (meaning, no
default).
Also, cover the case in unit tests, it seems that we were already
testing other defaults but not the null case.
Eloy Lafuente (stronk7) [Fri, 30 Oct 2020 12:48:48 +0000 (13:48 +0100)]
weekly release 4.0dev
Eloy Lafuente (stronk7) [Fri, 30 Oct 2020 12:48:46 +0000 (13:48 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install into master
Jun Pataleta [Fri, 30 Oct 2020 05:17:02 +0000 (13:17 +0800)]
Merge branch 'MDL-68167-master' of git://github.com/rezaies/moodle
Shamim Rezaie [Thu, 29 Oct 2020 15:54:38 +0000 (02:54 +1100)]
MDL-68167 lib: autocomplete focos should not be removed on blur
See https://www.w3.org/TR/wai-aria-practices-1.1/examples/listbox/listbox-rearrangeable.html
Shamim Rezaie [Thu, 29 Oct 2020 17:59:40 +0000 (04:59 +1100)]
MDL-68167 lib: Do not set aria-expanded if it should not be set
Shamim Rezaie [Thu, 29 Oct 2020 17:51:08 +0000 (04:51 +1100)]
MDL-68167 user: Fix missing label for participants filter input fields
Shamim Rezaie [Thu, 29 Oct 2020 13:39:05 +0000 (00:39 +1100)]
MDL-68167 lib: Clear single-select autocomplete elements with keyboard
Following MDL-57680, it should be possible to clear the selected option
using keyboard as well.
Shamim Rezaie [Tue, 28 Jul 2020 17:51:48 +0000 (03:51 +1000)]
MDL-68167 user: Fix a hardcoded string to be read from lang pack
Shamim Rezaie [Tue, 28 Jul 2020 16:45:30 +0000 (02:45 +1000)]
MDL-68167 lib: Fix label for autocomplete selection/suggestion box
The content of the autocomplete selection div is purged by javascript
so we have to move its label outside of it. aria-labeledby is the way
to go.
Each time the suggestion box is expanded, autocomplete js renders the
autocomplete suggestions template. So the label cannot be outside the
suggestions ul.
Shamim Rezaie [Tue, 28 Jul 2020 14:22:39 +0000 (00:22 +1000)]
MDL-68167 user: filter elements should listen to accessibleChange event
Shamim Rezaie [Tue, 28 Jul 2020 08:26:22 +0000 (18:26 +1000)]
MDL-68167 lib: The accessibleChange custom event now supports bubbling
The change event bubbles so the accessibleChange shoud bubble as well.
Shamim Rezaie [Mon, 27 Jul 2020 06:26:11 +0000 (16:26 +1000)]
MDL-68167 theme_boost: make focus outline accessible for autocompletes
Andrew Nicols [Fri, 30 Oct 2020 03:51:48 +0000 (11:51 +0800)]
Merge branch 'MDL-69156_master' of https://github.com/ffhs/moodle
Shamim Rezaie [Mon, 27 Jul 2020 03:36:25 +0000 (13:36 +1000)]
MDL-68167 lib: Autocomplete selection to use listbox aria role
The aria-selected state cannot be used for the listitem role. The
autocomplete widget highly uses the aria-selected state internally.
Shamim Rezaie [Mon, 27 Jul 2020 00:12:48 +0000 (10:12 +1000)]
MDL-68167 user: Improve keyboard navigation on autocomplete fields
Shamim Rezaie [Fri, 30 Oct 2020 03:37:25 +0000 (14:37 +1100)]
Merge branch 'MDL-69390-master' of git://github.com/bmbrands/moodle into MDL-69390-master-test
AMOS bot [Fri, 30 Oct 2020 00:09:45 +0000 (00:09 +0000)]
Automatically generated installer lang files
Víctor Déniz [Thu, 29 Oct 2020 22:27:17 +0000 (22:27 +0000)]
Merge branch 'MDL-70032-master-2' of git://github.com/junpataleta/moodle
Paul Holden [Thu, 24 Sep 2020 22:14:06 +0000 (23:14 +0100)]
MDL-69156 backup: correct behaviour of course copy idnumber field.
When a given user doesn't have the capability to change the idnumber
field during course copy, freeze the field value.
Adrian Perez [Sat, 27 Jun 2020 08:22:36 +0000 (10:22 +0200)]
MDL-69156 course_copy: set defaults for idnumber when not permitted
Jun Pataleta [Thu, 29 Oct 2020 07:59:29 +0000 (15:59 +0800)]
MDL-70032 qtype_multichoice: Use custom partial named selector
* With the removal of the label element, Behat now has to click on the
answer text. In order to achieve this, the custom partial named selector
"qtype_multichoice > Answer" was now added and have replaced the
instances where the label of the answer's checkbox/radio button is
being clicked.
Jun Pataleta [Thu, 29 Oct 2020 07:36:15 +0000 (15:36 +0800)]
MDL-70032 qtype_multichoice: Fix answer labelling
* Discard the use of the label element in order to be able to render
multiple choice answers as they are and have these act as the radio
button/checkbox' label through the aria-labelledby attribute.
* New JS module qtype_multichoice/answers that listens for click events
on the answer text container and selects the appropriate answer radio
button/checkbox.
Andrew Nicols [Thu, 29 Oct 2020 06:02:59 +0000 (14:02 +0800)]
Merge branch 'MDL-68722-master' of https://github.com/matt-catalyst/moodle
Jake Dallimore [Thu, 29 Oct 2020 04:39:48 +0000 (12:39 +0800)]
Merge branch 'MDL-69716-master' of git://github.com/aanabit/moodle
Jake Dallimore [Thu, 29 Oct 2020 03:48:58 +0000 (11:48 +0800)]
Merge branch 'MDL-70041-master' of git://github.com/mihailges/moodle
Adrian Greeve [Thu, 29 Oct 2020 00:34:27 +0000 (08:34 +0800)]
Merge branch 'm40_MDL-70042_Progress_Bar_Upgrade_Message_Popup' of https://github.com/scara/moodle
Matteo Scaramuccia [Wed, 28 Oct 2020 21:44:07 +0000 (22:44 +0100)]
MDL-70042 message_popup: Trivial savepoint comment cleanup
Matteo Scaramuccia [Wed, 28 Oct 2020 21:41:48 +0000 (22:41 +0100)]
MDL-70042 message_popup: progress bar on upgrade only when necessary
Jun Pataleta [Wed, 28 Oct 2020 14:44:15 +0000 (22:44 +0800)]
Merge branch 'MDL-69390-master' of git://github.com/bmbrands/moodle
Bas Brands [Thu, 1 Oct 2020 11:37:47 +0000 (13:37 +0200)]
MDL-69390 theme_boost: dropdown menu accessibility
- display a dot before the active element
- use the active colour for the hover colour
Jun Pataleta [Wed, 28 Oct 2020 06:19:32 +0000 (14:19 +0800)]
Merge branch 'MDL-69815-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Wed, 28 Oct 2020 05:10:14 +0000 (13:10 +0800)]
Merge branch 'MDL-70004-master' of git://github.com/junpataleta/moodle
Jake Dallimore [Wed, 28 Oct 2020 04:10:29 +0000 (12:10 +0800)]
Merge branch 'MDL-64723' of git://github.com/paulholden/moodle
Jake Dallimore [Wed, 28 Oct 2020 03:59:44 +0000 (11:59 +0800)]
Merge branch 'MDL-65792-master' of git://github.com/bmbrands/moodle
Mihail Geshoski [Wed, 28 Oct 2020 03:48:33 +0000 (11:48 +0800)]
MDL-70041 filepicker: Make sure the user has a recently used license
Jake Dallimore [Wed, 28 Oct 2020 03:07:19 +0000 (11:07 +0800)]
Merge branch 'MDL-70010' of https://github.com/stronk7/moodle
Andrew Nicols [Wed, 28 Oct 2020 01:27:15 +0000 (09:27 +0800)]
MDL-69815 core: Bump Node to v14.15.0 (LTS/Fermium)