sam marshall [Fri, 15 Nov 2019 13:55:43 +0000 (13:55 +0000)]
MDL-67274 Tasks: Log display fails with memory errors
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 17:03:02 +0000 (18:03 +0100)]
weekly back-to-dev release 3.9dev
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 16:54:08 +0000 (17:54 +0100)]
NOBUG: Change travis.yml back to master
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 16:54:07 +0000 (17:54 +0100)]
Moodle release 3.8
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 16:54:08 +0000 (17:54 +0100)]
NOBUG: Change travis.yml to MOODLE_38_STABLE
Jun Pataleta [Sat, 16 Nov 2019 09:44:05 +0000 (17:44 +0800)]
Merge branch 'MDL-67281' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Fri, 15 Nov 2019 18:11:34 +0000 (19:11 +0100)]
MDL-67281 forum: don't show discussion creation time twice
The discussion creation time (or first post) is being shown
both in the "started by" and "last post" columns in forum
discussions list.
Just let's change the former to show the discussion modification
time (or last post) instead.
Eloy Lafuente (stronk7) [Fri, 15 Nov 2019 11:30:52 +0000 (12:30 +0100)]
Moodle release 3.8rc1
Jun Pataleta [Fri, 15 Nov 2019 04:38:54 +0000 (12:38 +0800)]
Merge branch 'MDL-67269-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Fri, 15 Nov 2019 04:08:33 +0000 (12:08 +0800)]
Merge branch 'MDL-67268-master' of git://github.com/mihailges/moodle
Mihail Geshoski [Fri, 15 Nov 2019 04:05:59 +0000 (12:05 +0800)]
MDL-67268 mod_forum: Group and label radio buttons in forum grader
Andrew Nicols [Fri, 15 Nov 2019 03:45:17 +0000 (11:45 +0800)]
MDL-67269 mod_forum: Capture form submission in grading panel
Andrew Nicols [Fri, 15 Nov 2019 02:35:00 +0000 (10:35 +0800)]
Merge branch 'MDL-67265' of git://github.com/Chocolate-lightning/moodle_forum-project
Mathew May [Fri, 15 Nov 2019 01:21:06 +0000 (09:21 +0800)]
MDL-67265 core: Set max-height on toast wrapper
Jake Dallimore [Thu, 14 Nov 2019 08:34:28 +0000 (16:34 +0800)]
Merge branch 'MDL-67241-master' of git://github.com/lameze/moodle
Jake Dallimore [Thu, 14 Nov 2019 07:17:24 +0000 (15:17 +0800)]
Merge branch 'MDL-67144-integration' of git://github.com/Chocolate-lightning/moodle_forum-project
Mathew May [Thu, 14 Nov 2019 03:49:25 +0000 (11:49 +0800)]
MDL-67144 mod_forum: If no users exist do not show the grading interface
Jun Pataleta [Thu, 14 Nov 2019 06:34:17 +0000 (14:34 +0800)]
Merge branch 'MDL-67246-master' of git://github.com/jleyva/moodle
Jake Dallimore [Thu, 14 Nov 2019 06:27:42 +0000 (14:27 +0800)]
Merge branch 'MDL-67207-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Thu, 14 Nov 2019 04:37:22 +0000 (12:37 +0800)]
Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 14 Nov 2019 03:42:56 +0000 (11:42 +0800)]
MDL-67116 course: Restore removed line
This line was inadvertently removed in a previous commit.
Andrew Nicols [Thu, 14 Nov 2019 02:54:14 +0000 (10:54 +0800)]
Merge branch 'MDL-67250-master-httpswwwroot' of git://github.com/mudrd8mz/moodle
Simey Lameze [Thu, 14 Nov 2019 02:10:29 +0000 (10:10 +0800)]
MDL-67241 mod_forum: raise memory limit when exporting
Adrian Greeve [Thu, 14 Nov 2019 01:03:31 +0000 (09:03 +0800)]
Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 14 Nov 2019 00:38:19 +0000 (08:38 +0800)]
MDL-67116 course: Strict empty string check required
In PHP the following are true:
assert('' == '');
assert(0 == '');
assert(null == '');
The options in the course completion settings are now:
'' => none selected
[int] => itemnumber of activity course completion item.
In the case where the itemnumber was 0 this was being incorrectly
evaluated as an empty string due to the implicit cast to int of the
empty string:
(int) '' === 0
As a result, the non-strict comparison means that the following are
identical:
assert(0 == '');
assert(0 == (int) '');
assert(0 == '0');
Changing the comparison to a strict comparison is correct because it
ensures the type consitency between the empty string value, and the int
of itemnumber 0. It is safe because the value always comes from the
form, where an int is always returned, and not the DB, where a string is
returned.
Eloy Lafuente (stronk7) [Thu, 14 Nov 2019 00:12:01 +0000 (01:12 +0100)]
Merge branch 'MDL-67248-master' of git://github.com/cescobedo/moodle
David Mudrák [Wed, 13 Nov 2019 18:58:10 +0000 (19:58 +0100)]
MDL-67250 setup: Revert removal of the httpswwwroot setting
It is still used widely in the plugins that would stop working suddenly
without being warned via a debugging message. We must keep it forever as
an alias for the wwwroot.
cescobedo [Wed, 13 Nov 2019 17:36:09 +0000 (18:36 +0100)]
MDL-67248 filter_displayh5p: Add new description on filter
Juan Leyva [Wed, 13 Nov 2019 14:33:20 +0000 (15:33 +0100)]
MDL-67246 admin: Return course color settings for external clients
Jun Pataleta [Wed, 13 Nov 2019 08:00:16 +0000 (16:00 +0800)]
Merge branch 'MDL-67231-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Wed, 13 Nov 2019 07:31:03 +0000 (15:31 +0800)]
Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Wed, 13 Nov 2019 04:10:16 +0000 (12:10 +0800)]
MDL-67207 forum: Reset focus after closing grade viewer
Andrew Nicols [Wed, 13 Nov 2019 03:51:51 +0000 (11:51 +0800)]
MDL-67207 forum: Return focus when closing expanded discussion
Andrew Nicols [Wed, 13 Nov 2019 03:50:51 +0000 (11:50 +0800)]
MDL-67207 core: Use focus lock manager in modals
Andrew Nicols [Tue, 12 Nov 2019 01:52:08 +0000 (09:52 +0800)]
MDL-67207 forum: Reset focus after closing grader
Andrew Nicols [Tue, 12 Nov 2019 01:37:35 +0000 (09:37 +0800)]
MDL-67207 forum: Lock focus in grader
Andrew Nicols [Tue, 12 Nov 2019 01:36:14 +0000 (09:36 +0800)]
MDL-67207 core: Add new ARIA focus locker
This is based on code and examples provided in the ARIA specification
https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html
Adrian Greeve [Wed, 13 Nov 2019 06:30:06 +0000 (14:30 +0800)]
Merge branch 'MDL-67178' of git://github.com/Chocolate-lightning/moodle_forum-project
Andrew Nicols [Wed, 13 Nov 2019 06:24:28 +0000 (14:24 +0800)]
MDL-67231 h5p: Correct naming of h5p unit test files
Jun Pataleta [Wed, 13 Nov 2019 05:49:22 +0000 (13:49 +0800)]
Merge branch 'MDL-67232-master' of git://github.com/lameze/moodle
Mathew May [Fri, 8 Nov 2019 04:08:01 +0000 (12:08 +0800)]
MDL-67178 mod_forum: Allow users to backup forum grades
Andrew Nicols [Wed, 13 Nov 2019 04:49:57 +0000 (12:49 +0800)]
MDL-67116 course: Fix completion disabled for gradable items
The default value is an empty string (""), which in PHP evaluates to 0 when
cast to a string in our DML layer.
The fix is to forcibly make it null which is not cast to string in DML
for optional strings.
Jun Pataleta [Wed, 13 Nov 2019 03:20:02 +0000 (11:20 +0800)]
Merge branch 'MDL-67199' of https://github.com/stronk7/moodle
Jun Pataleta [Wed, 13 Nov 2019 03:00:22 +0000 (11:00 +0800)]
Merge branch 'MDL-67218-master' of git://github.com/andrewnicols/moodle
Simey Lameze [Wed, 13 Nov 2019 02:33:55 +0000 (10:33 +0800)]
MDL-67232 mod_forum: remove initialuserid data attr from template
Jake Dallimore [Wed, 13 Nov 2019 02:25:42 +0000 (10:25 +0800)]
Merge branch 'MDL-66812-master' of git://github.com/bmbrands/moodle
Adrian Greeve [Wed, 13 Nov 2019 02:18:59 +0000 (10:18 +0800)]
Merge branch 'MDL-67215-master' of git://github.com/peterRd/moodle
Andrew Nicols [Tue, 12 Nov 2019 04:34:37 +0000 (12:34 +0800)]
MDL-67116 form: Require grade in multi-grade-item activities
AMOS BEGIN
CPY [rating,rating],[grade_rating_name,rating]
AMOS END
Ryan Wyllie [Fri, 8 Nov 2019 05:04:51 +0000 (13:04 +0800)]
MDL-67116 course: allow grading completion for non ratings grade item
Andrew Nicols [Tue, 12 Nov 2019 03:29:34 +0000 (11:29 +0800)]
MDL-67218 form: Do not clear grade when rescaling not enabled
Andrew Nicols [Wed, 13 Nov 2019 00:38:34 +0000 (08:38 +0800)]
Merge branch 'MDL-67194-master' of git://github.com/vmdef/moodle
Andrew Nicols [Wed, 13 Nov 2019 00:31:25 +0000 (08:31 +0800)]
Merge branch 'wip_MDL-67205_master' of git://github.com/gjb2048/moodle
Eloy Lafuente (stronk7) [Tue, 12 Nov 2019 16:58:42 +0000 (17:58 +0100)]
MDL-67199 versions: main version bump
Eloy Lafuente (stronk7) [Tue, 12 Nov 2019 16:57:08 +0000 (17:57 +0100)]
MDL-67199 versions: bump all versions and requires near release
version =
2019111800 release version
requires=
2019111200 current beta (week7roll1) version
Eloy Lafuente (stronk7) [Tue, 12 Nov 2019 15:50:55 +0000 (16:50 +0100)]
Moodle release 3.8beta
Jun Pataleta [Tue, 12 Nov 2019 14:01:37 +0000 (22:01 +0800)]
Merge branch 'MDL-66906-master-fix' of git://github.com/andrewnicols/moodle
Andrew Nicols [Tue, 12 Nov 2019 13:04:54 +0000 (21:04 +0800)]
MDL-66906 gradingform_rubric: Add back missing field
Jun Pataleta [Tue, 12 Nov 2019 08:38:58 +0000 (16:38 +0800)]
Merge branch 'MDL-66906-integration-3' of git://github.com/Chocolate-lightning/moodle_forum-project
Mathew May [Wed, 16 Oct 2019 06:20:05 +0000 (14:20 +0800)]
MDL-66906 mod_forum: Show learners their grades in a Modal
Jun Pataleta [Tue, 12 Nov 2019 08:10:38 +0000 (16:10 +0800)]
Merge branch 'MDL-66360-master-fix' of git://github.com/andrewnicols/moodle
Andrew Nicols [Tue, 12 Nov 2019 08:00:50 +0000 (16:00 +0800)]
MDL-66360 grading: Validate notifyuser
Andrew Nicols [Tue, 12 Nov 2019 07:59:53 +0000 (15:59 +0800)]
MDL-66360 grade: Correct argument order in params
Andrew Nicols [Tue, 12 Nov 2019 03:29:34 +0000 (11:29 +0800)]
MDL-67218 form: Do not clear grade when rescaling not enabled
Andrew Nicols [Tue, 12 Nov 2019 02:16:12 +0000 (10:16 +0800)]
Merge branch 'MDL-66360-master-fix' of git://github.com/lameze/moodle
Simey Lameze [Mon, 11 Nov 2019 23:46:31 +0000 (07:46 +0800)]
MDL-66360 forum: rename sendstudentnotifications_forum to forum_grade_notify
Peter [Tue, 12 Nov 2019 01:55:18 +0000 (09:55 +0800)]
MDL-67215 core: Revert update from lib upgrade
Víctor Déniz Falcón [Mon, 11 Nov 2019 21:09:50 +0000 (21:09 +0000)]
MDL-67194 core_h5p: save core API version that content types require
Jun Pataleta [Mon, 11 Nov 2019 14:22:08 +0000 (22:22 +0800)]
Merge branch 'MDL-67187_master' of git://github.com/dmonllao/moodle
Bas Brands [Thu, 17 Oct 2019 12:29:23 +0000 (14:29 +0200)]
MDL-66812 core_message: update custom checkbox for message dialogue
Gareth Barnard [Mon, 11 Nov 2019 12:55:17 +0000 (12:55 +0000)]
MDL-67205 themes: Incorrect information in theme/upgrade.txt.
Eloy Lafuente (stronk7) [Mon, 11 Nov 2019 11:11:41 +0000 (12:11 +0100)]
Merge branch 'MDL-66405-master-fix' of https://github.com/sarjona/moodle
Sara Arjona [Mon, 11 Nov 2019 10:52:20 +0000 (11:52 +0100)]
MDL-66405 core_h5p: Fix behat tests
Eloy Lafuente (stronk7) [Mon, 11 Nov 2019 09:49:31 +0000 (10:49 +0100)]
MDL-66360 grade: whitespace fix
Andrew Nicols [Mon, 11 Nov 2019 09:38:02 +0000 (17:38 +0800)]
MDL-66360 forum: Fix unit tests in integration
Andrew Nicols [Mon, 11 Nov 2019 09:27:35 +0000 (17:27 +0800)]
MDL-66360 forum: Add missing var from merge conflict
Andrew Nicols [Mon, 11 Nov 2019 09:16:48 +0000 (17:16 +0800)]
Merge branch 'MDL-66360-master' of git://github.com/lameze/moodle
Simey Lameze [Mon, 11 Nov 2019 03:05:31 +0000 (11:05 +0800)]
MDL-66360 mod_forum: fix cibot issues
Simey Lameze [Mon, 11 Nov 2019 02:47:36 +0000 (10:47 +0800)]
MDL-66360 mod_forum: change notifyuser parameter order
Simey Lameze [Mon, 11 Nov 2019 02:25:01 +0000 (10:25 +0800)]
MDL-66360 grade: add missing gradenotifications defaults
Simey Lameze [Fri, 8 Nov 2019 07:26:30 +0000 (15:26 +0800)]
MDL-66360 grade: fix unit tests failures and errors
Simey Lameze [Fri, 8 Nov 2019 04:10:22 +0000 (12:10 +0800)]
MDL-66360 lang: fix typo on gradenotificationsubjects string
Simey Lameze [Fri, 8 Nov 2019 01:58:40 +0000 (09:58 +0800)]
MDL-66360 mod_forum: add missing notifyuser to doc block
Simey Lameze [Fri, 8 Nov 2019 01:50:44 +0000 (09:50 +0800)]
MDL-66360 mod_forum: remove debug code from template
Simey Lameze [Fri, 8 Nov 2019 01:49:58 +0000 (09:49 +0800)]
MDL-66360 grade: fix user grade notification sending errors
Shamim Rezaie [Thu, 24 Oct 2019 02:54:13 +0000 (13:54 +1100)]
MDL-66360 mod_forum: Notify the student when the marker choose to notify
Shamim Rezaie [Thu, 24 Oct 2019 19:22:20 +0000 (06:22 +1100)]
MDL-66360 gradingform_rubric: support sending grading notifications
Shamim Rezaie [Thu, 24 Oct 2019 18:49:23 +0000 (05:49 +1100)]
MDL-66360 gradingform_guide: Support sending grading notifications
Shamim Rezaie [Thu, 24 Oct 2019 19:12:15 +0000 (06:12 +1100)]
MDL-66360 core_grade: grade notifications for scale-based marking
Shamim Rezaie [Thu, 24 Oct 2019 19:05:29 +0000 (06:05 +1100)]
MDL-66360 core_grade: grade notifications for simple direct grading
Shamim Rezaie [Fri, 25 Oct 2019 00:27:39 +0000 (11:27 +1100)]
MDL-66360 core_grade: New method to send grade notifications to students
Shamim Rezaie [Thu, 24 Oct 2019 18:11:56 +0000 (05:11 +1100)]
MDL-66360 core_grade: New message handler for grade notifications
Shamim Rezaie [Wed, 23 Oct 2019 21:45:27 +0000 (08:45 +1100)]
MDL-66360 mod_forum: display notification option pre-set to default
Shamim Rezaie [Mon, 21 Oct 2019 20:10:23 +0000 (07:10 +1100)]
MDL-66360 mod_forum: Save the sendstudentnotifications setting
Shamim Rezaie [Mon, 21 Oct 2019 20:12:28 +0000 (07:12 +1100)]
MDL-66360 mod_forum: phpdoc fixes
Shamim Rezaie [Mon, 21 Oct 2019 05:33:04 +0000 (16:33 +1100)]
MDL-66360 mod_forum: added settings for send notifications default val
AMOS BEGIN
CPY [sendstudentnotifications, mod_assign],[sendstudentnotifications, mod_forum]
CPY [sendstudentnotifications_help, mod_assign],[sendstudentnotifications_help, mod_forum]
AMOS END
Jake Dallimore [Mon, 11 Nov 2019 06:56:52 +0000 (14:56 +0800)]
Merge branch 'MDL-67137-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Mon, 11 Nov 2019 03:26:08 +0000 (11:26 +0800)]
Merge branch 'MDL-66958' of git://github.com/Chocolate-lightning/moodle_forum-project
Mathew May [Wed, 6 Nov 2019 01:15:35 +0000 (09:15 +0800)]
MDL-66958 core_grade: Add hasgrade to all external fetch webservices
Mathew May [Wed, 6 Nov 2019 01:13:37 +0000 (09:13 +0800)]
MDL-66958 core_grade: Add grade status abstract
Also implement the new abstract in Forum
Mathew May [Tue, 5 Nov 2019 09:43:36 +0000 (17:43 +0800)]
MDL-66958 core_grade: Only save scale on form change