moodle.git
10 months agoMerge branch 'MDL-66917' of https://github.com/paulholden/moodle
Andrew Nicols [Fri, 15 May 2020 02:54:15 +0000 (10:54 +0800)]
Merge branch 'MDL-66917' of https://github.com/paulholden/moodle

10 months agoMDL-67689 core: Whitespace fix
Andrew Nicols [Fri, 15 May 2020 02:15:49 +0000 (10:15 +0800)]
MDL-67689 core: Whitespace fix

10 months agoMerge branch 'MDL-67689-master' of git://github.com/bmbrands/moodle
Andrew Nicols [Fri, 15 May 2020 02:13:43 +0000 (10:13 +0800)]
Merge branch 'MDL-67689-master' of git://github.com/bmbrands/moodle

10 months agoMerge branch 'MDL-68537-master' of git://github.com/jleyva/moodle
Andrew Nicols [Fri, 15 May 2020 01:04:21 +0000 (09:04 +0800)]
Merge branch 'MDL-68537-master' of git://github.com/jleyva/moodle

10 months agoMDL-67990 antivirus_clamav: Typo fix
Andrew Nicols [Fri, 15 May 2020 00:57:24 +0000 (08:57 +0800)]
MDL-67990 antivirus_clamav: Typo fix

10 months agoMerge branch 'MDL-67990' of https://github.com/OdyX/moodle
Andrew Nicols [Fri, 15 May 2020 00:56:10 +0000 (08:56 +0800)]
Merge branch 'MDL-67990' of https://github.com/OdyX/moodle

10 months agoMerge branch 'MDL-68677-master' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Thu, 14 May 2020 23:58:41 +0000 (01:58 +0200)]
Merge branch 'MDL-68677-master' of git://github.com/andrewnicols/moodle

10 months agoMerge branch 'MDL-68084' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Thu, 14 May 2020 23:30:28 +0000 (01:30 +0200)]
Merge branch 'MDL-68084' of https://github.com/paulholden/moodle

10 months agoMerge branch 'MDL-68645-master-earlyoutputinit' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Thu, 14 May 2020 14:35:35 +0000 (16:35 +0200)]
Merge branch 'MDL-68645-master-earlyoutputinit' of git://github.com/mudrd8mz/moodle

10 months agoMerge branch 'MDL-68200-master-take2' of git://github.com/rezaies/moodle
Sara Arjona [Thu, 14 May 2020 11:10:01 +0000 (13:10 +0200)]
Merge branch 'MDL-68200-master-take2' of git://github.com/rezaies/moodle

10 months agoMerge branch 'MDL-68246-master-IR-squashed' of git://github.com/mickhawkins/moodle
Sara Arjona [Thu, 14 May 2020 10:31:29 +0000 (12:31 +0200)]
Merge branch 'MDL-68246-master-IR-squashed' of git://github.com/mickhawkins/moodle

10 months agoMerge branch 'MDL-68241-master' of git://github.com/ferranrecio/moodle
Sara Arjona [Thu, 14 May 2020 07:55:35 +0000 (09:55 +0200)]
Merge branch 'MDL-68241-master' of git://github.com/ferranrecio/moodle

10 months agoMDL-68246 user: Add participants_search role & keyword unit tests
Andrew Nicols [Tue, 21 Apr 2020 06:23:48 +0000 (14:23 +0800)]
MDL-68246 user: Add participants_search role & keyword unit tests

Created the participants_search unit testing file, including
tests for role, keywords, status and enroment method filtering.

Co-authored-by: Michael Hawkins <michaelh@moodle.com>
10 months agoMDL-68246 user: Adding the participants_search class
Michael Hawkins [Thu, 26 Mar 2020 08:13:40 +0000 (16:13 +0800)]
MDL-68246 user: Adding the participants_search class

This class introduces support for multiple values per filter to the
participants page.

10 months agoMDL-68246 lib: Prepare for participants filter multiple groups support
Michael Hawkins [Thu, 26 Mar 2020 11:03:12 +0000 (19:03 +0800)]
MDL-68246 lib: Prepare for participants filter multiple groups support

These function updates are in preparation for the participants_search
class, which will be used to support multiple values per filter when
filtering the participants page.

10 months agoMDL-68246 lib: Grouplib coding standards and consistency improvements
Michael Hawkins [Mon, 20 Apr 2020 08:23:03 +0000 (16:23 +0800)]
MDL-68246 lib: Grouplib coding standards and consistency improvements

10 months agoMDL-68241 mod_h5pactivity: remove MOODLE_INTERNAL
Ferran Recio [Tue, 12 May 2020 13:08:56 +0000 (15:08 +0200)]
MDL-68241 mod_h5pactivity: remove MOODLE_INTERNAL

10 months agoMDL-68241 mod_h5pactivity: add grading attempts options
Ferran Recio [Thu, 9 Apr 2020 16:55:36 +0000 (18:55 +0200)]
MDL-68241 mod_h5pactivity: add grading attempts options

10 months agoMerge branch 'MDL-68498-master' of git://github.com/mihailges/moodle
Adrian Greeve [Thu, 14 May 2020 06:13:55 +0000 (14:13 +0800)]
Merge branch 'MDL-68498-master' of git://github.com/mihailges/moodle

10 months agoMDL-68677 core: Enable prefetching when cachejs is disabled
Andrew Nicols [Tue, 12 May 2020 01:21:03 +0000 (09:21 +0800)]
MDL-68677 core: Enable prefetching when cachejs is disabled

With the templaterev issue resolved we should enable the prefetch module
when cachejs is enabled to avoid a different experience when cachejs is
enabled vs. disabled.

Previously there was little point in doing this due to a range of other
bugs (string normalisation, and misuse of templaterev).

With these issues resolved we should enabel the caching.

10 months agoMDL-68677 core: Correct usage of templaterev for caching templates
Andrew Nicols [Tue, 12 May 2020 01:18:32 +0000 (09:18 +0800)]
MDL-68677 core: Correct usage of templaterev for caching templates

The M.cfg.templaterev variable should only be used to present persistent
caching, not caching of content within the same page load.

Preventing caching of same-page content makes it difficult to develop
for real user experiences as content is slow to load and does not give a
realistic and consistent loading experience.

This change affects the loading of partials specifically which notably
includes the loading spinner. Without this patch the loading icon is
often not seen at all because it does not load in a timely fashion and
the content being loaded is loaded first.

10 months agoMDL-68645 output: Make other generators fail if they init the output too
David Mudrák [Thu, 14 May 2020 05:55:19 +0000 (07:55 +0200)]
MDL-68645 output: Make other generators fail if they init the output too

Identically to what we've added to the module generators, let's raise a
coding exception if generating a block or a repository triggers the
theme and output initialisation.

10 months agoMerge branch 'MDL-68529' of https://github.com/Chocolate-lightning/moodle
Jun Pataleta [Thu, 14 May 2020 04:51:35 +0000 (12:51 +0800)]
Merge branch 'MDL-68529' of https://github.com/Chocolate-lightning/moodle

10 months agoMerge branch 'MDL-68227-master' of git://github.com/sarjona/moodle
Víctor Déniz Falcón [Wed, 13 May 2020 16:13:11 +0000 (17:13 +0100)]
Merge branch 'MDL-68227-master' of git://github.com/sarjona/moodle

10 months agoMerge branch 'MDL-68697-master' of git://github.com/andrewnicols/moodle
Víctor Déniz Falcón [Wed, 13 May 2020 15:53:16 +0000 (16:53 +0100)]
Merge branch 'MDL-68697-master' of git://github.com/andrewnicols/moodle

11 months agoMerge branch 'MDL-68483-master' of git://github.com/sarjona/moodle
Jun Pataleta [Wed, 13 May 2020 11:33:37 +0000 (19:33 +0800)]
Merge branch 'MDL-68483-master' of git://github.com/sarjona/moodle

11 months agoMDL-68483 contentbank: remove unneeded MOODLE_INTERNAL
Sara Arjona [Wed, 6 May 2020 08:07:10 +0000 (10:07 +0200)]
MDL-68483 contentbank: remove unneeded MOODLE_INTERNAL

These improvements were suggested by Eloy when MDL-67795 and other
content bank issues (such as MDL-67790) were integrated.

11 months agoMDL-68483 contentbank: improve search API
Sara Arjona [Tue, 28 Apr 2020 16:27:16 +0000 (18:27 +0200)]
MDL-68483 contentbank: improve search API

These improvements were suggested by Eloy when MDL-67797 was integrated.

11 months agoMDL-68483 contentbank: order contents by name
Sara Arjona [Wed, 29 Apr 2020 14:11:47 +0000 (16:11 +0200)]
MDL-68483 contentbank: order contents by name

11 months agoMDL-68483 contentbank: filter contents by name
Sara Arjona [Tue, 21 Apr 2020 12:55:51 +0000 (14:55 +0200)]
MDL-68483 contentbank: filter contents by name

Credits to Bas and Rafa for helping us to improve the UX.
Also to Amaia with her help with Behat tests.

11 months agoMerge branch 'MDL-68314-master' of git://github.com/aanabit/moodle
Eloy Lafuente (stronk7) [Wed, 13 May 2020 11:15:17 +0000 (13:15 +0200)]
Merge branch 'MDL-68314-master' of git://github.com/aanabit/moodle

11 months agoMDL-68697 core_h5p: Store missing translations as null
Andrew Nicols [Wed, 13 May 2020 01:18:59 +0000 (09:18 +0800)]
MDL-68697 core_h5p: Store missing translations as null

11 months agoMDL-68645 output: Do not apply filters when creating calendar events
David Mudrák [Tue, 12 May 2020 19:30:30 +0000 (21:30 +0200)]
MDL-68645 output: Do not apply filters when creating calendar events

Applying filters on an activity module description when using it as a
new calendar event's description is bad m'kay? We need to store the raw
text and apply the filters only when we actually display the text. That
way, filters (such as multi-language content) may actually fully work
and we do not initialise the theme and output machinery.

Additionally, we need to explicitly set the format of the description
text to HTML (because we have converted it to it already). Otherwise it
defaults to the current user's preferred editor format.

This is still a pragmatic hot-fix solution. The proper solution would be
to pass the raw text, format and embedded files.

11 months agoMDL-68645 output: Make module generators fail if they init the output
Tim Hunt [Sat, 9 May 2020 08:49:38 +0000 (09:49 +0100)]
MDL-68645 output: Make module generators fail if they init the output

The coding exception hint should say it all. Creating an activity module
should not need any output function call. It turned out it can lead to
hard-to-debug bugs and unexpected behaviour. So better to explicitly
fail and let the developer fix the code.

11 months agoMDL-68314 core_contentbank: Backup and restore tests
Amaia Anabitarte [Mon, 27 Apr 2020 10:41:06 +0000 (12:41 +0200)]
MDL-68314 core_contentbank: Backup and restore tests

11 months agoMDL-68314 core_contentbank: Course content bank backup and restore
Amaia Anabitarte [Mon, 27 Apr 2020 10:40:16 +0000 (12:40 +0200)]
MDL-68314 core_contentbank: Course content bank backup and restore

11 months agoMerge branch 'MDL-68261-cli-config-log' of https://github.com/brendanheywood/moodle
Jun Pataleta [Wed, 13 May 2020 02:36:54 +0000 (10:36 +0800)]
Merge branch 'MDL-68261-cli-config-log' of https://github.com/brendanheywood/moodle

11 months agoMDL-68498 core: Fix content bank links in the navigation drawer
Mihail Geshoski [Wed, 13 May 2020 01:26:18 +0000 (09:26 +0800)]
MDL-68498 core: Fix content bank links in the navigation drawer

11 months agoMerge branch 'MDL-68631' of https://github.com/jonof/moodle
Jake Dallimore [Wed, 13 May 2020 01:24:30 +0000 (09:24 +0800)]
Merge branch 'MDL-68631' of https://github.com/jonof/moodle

11 months agoMDL-68498 core: Display content bank icon in nav drawer in classic theme
Mihail Geshoski [Wed, 6 May 2020 07:24:16 +0000 (15:24 +0800)]
MDL-68498 core: Display content bank icon in nav drawer in classic theme

11 months agoMerge branch 'MDL-68614-master' of git://github.com/aanabit/moodle
Eloy Lafuente (stronk7) [Tue, 12 May 2020 21:51:04 +0000 (23:51 +0200)]
Merge branch 'MDL-68614-master' of git://github.com/aanabit/moodle

11 months agoMerge branch 'MDL-68417-master' of git://github.com/lameze/moodle
Eloy Lafuente (stronk7) [Tue, 12 May 2020 21:20:21 +0000 (23:20 +0200)]
Merge branch 'MDL-68417-master' of git://github.com/lameze/moodle

11 months agoMDL-68084 blocks: check capability before getting content.
Paul Holden [Fri, 1 May 2020 08:00:41 +0000 (09:00 +0100)]
MDL-68084 blocks: check capability before getting content.

Some blocks (e.g. Calendar) load additional JS modules when returning
content. We need to make sure they aren't asked to generate content
unless the user can actually view the block, or the expected content
required by the JS will not exist in the DOM and can cause exceptions.

11 months agoMDL-68483 contentbank: adapt to existing behat generator
Amaia Anabitarte [Tue, 12 May 2020 08:38:15 +0000 (10:38 +0200)]
MDL-68483 contentbank: adapt to existing behat generator

11 months agoMDL-68227 core_h5p: localize H5P editor strings
Sara Arjona [Thu, 26 Mar 2020 12:38:27 +0000 (13:38 +0100)]
MDL-68227 core_h5p: localize H5P editor strings

H5P editor has a folder with all supported languages in JS files.
A mechanish has been added to let users to translate them using AMOS.
That's how the translations are managed (the order how they are processed):

- If there a JS file for a language, it's loaded.
- If a string has been translated in Moodle (they are placed in
h5plib_vXXX), it will override strings loaded from the JS file.

11 months agoMDL-68417 core_table: add some css styling to loading icon
Simey Lameze [Mon, 11 May 2020 07:14:10 +0000 (15:14 +0800)]
MDL-68417 core_table: add some css styling to loading icon

11 months agoMDL-68614 core_contentbank: Add svg and png contentbank icons
Amaia Anabitarte [Mon, 11 May 2020 17:42:14 +0000 (19:42 +0200)]
MDL-68614 core_contentbank: Add svg and png contentbank icons

11 months agoweekly release 3.9dev+
Sara Arjona [Tue, 12 May 2020 12:16:44 +0000 (14:16 +0200)]
weekly release 3.9dev+

11 months agoMDL-68529 course: Refactor chooser to include loading
Mathew May [Wed, 29 Apr 2020 09:14:38 +0000 (17:14 +0800)]
MDL-68529 course: Refactor chooser to include loading

11 months agoMDL-68200 core: Fix phpdoc for the external return functions
Shamim Rezaie [Mon, 13 Apr 2020 23:05:24 +0000 (09:05 +1000)]
MDL-68200 core: Fix phpdoc for the external return functions

11 months agoMDL-68200 core: Fix datetime format
Shamim Rezaie [Mon, 13 Apr 2020 21:00:14 +0000 (07:00 +1000)]
MDL-68200 core: Fix datetime format

date.toISOString() prints out the seconds as well.
Current code supports most valid values for the datetime attribute

11 months agoMDL-68200 mod_forum: fix invalid format of the time tag on modern view
Shamim Rezaie [Thu, 26 Mar 2020 03:12:35 +0000 (14:12 +1100)]
MDL-68200 mod_forum: fix invalid format of the time tag on modern view

11 months agoMDL-68200 mod_forum: Fix the invalid date format in the time tags
Shamim Rezaie [Wed, 25 Mar 2020 04:07:13 +0000 (15:07 +1100)]
MDL-68200 mod_forum: Fix the invalid date format in the time tags

11 months agoMDL-68200 mod_forum: Use core/time_element for the discussion list page
Jun Pataleta [Wed, 25 Mar 2020 11:46:01 +0000 (22:46 +1100)]
MDL-68200 mod_forum: Use core/time_element for the discussion list page

11 months agoMDL-68200 core: Add new time_element template
Jun Pataleta [Wed, 8 Apr 2020 10:46:29 +0000 (20:46 +1000)]
MDL-68200 core: Add new time_element template

11 months agoMDL-68200 core: Support fixday/hour for core/user_date's get() method
Jun Pataleta [Wed, 8 Apr 2020 10:37:18 +0000 (20:37 +1000)]
MDL-68200 core: Support fixday/hour for core/user_date's get() method

11 months agoMDL-68200 core: Support fixday/hour for core_external::get_user_dates()
Jun Pataleta [Wed, 8 Apr 2020 10:20:15 +0000 (20:20 +1000)]
MDL-68200 core: Support fixday/hour for core_external::get_user_dates()

11 months agoMDL-68200 core: Add calendartype param to user_date.loadDatesFromServer
Shamim Rezaie [Wed, 8 Apr 2020 11:25:17 +0000 (21:25 +1000)]
MDL-68200 core: Add calendartype param to user_date.loadDatesFromServer

11 months agoMDL-68200 core: Add type param to core_get_user_dates external function
Shamim Rezaie [Wed, 25 Mar 2020 03:23:19 +0000 (14:23 +1100)]
MDL-68200 core: Add type param to core_get_user_dates external function

11 months agoMDL-68200 mod_forum: remove address tags
Shamim Rezaie [Thu, 26 Mar 2020 06:24:17 +0000 (17:24 +1100)]
MDL-68200 mod_forum: remove address tags

Reasons:
- The element “h4” must not appear as a descendant of the “address” element
- This element should not contain more information than the contact
information, like a publication date (which belongs in a <time> element)
 element)

11 months agoMDL-68200 mod_forum: single discussion to follow nestet_v2 display rules
Shamim Rezaie [Wed, 25 Mar 2020 18:05:49 +0000 (05:05 +1100)]
MDL-68200 mod_forum: single discussion to follow nestet_v2 display rules

11 months agoMDL-68200 theme_boost: workaround for IE for flexbox not filling height
Shamim Rezaie [Wed, 25 Mar 2020 17:57:49 +0000 (04:57 +1100)]
MDL-68200 theme_boost: workaround for IE for flexbox not filling height

read more:
https://philipwalton.com/articles/normalizing-cross-browser-flexbox-bugs/

11 months agoMDL-68417 core_table: add spinner to dynamic table
Simey Lameze [Mon, 11 May 2020 07:13:27 +0000 (15:13 +0800)]
MDL-68417 core_table: add spinner to dynamic table

11 months agoMerge branch 'MDL-68579-master' of git://github.com/cescobedo/moodle
Eloy Lafuente (stronk7) [Mon, 11 May 2020 21:13:45 +0000 (23:13 +0200)]
Merge branch 'MDL-68579-master' of git://github.com/cescobedo/moodle

11 months agoMerge branch 'MDL-68276-replace-logs' of https://github.com/brendanheywood/moodle
Eloy Lafuente (stronk7) [Mon, 11 May 2020 21:10:49 +0000 (23:10 +0200)]
Merge branch 'MDL-68276-replace-logs' of https://github.com/brendanheywood/moodle

11 months agoMerge branch 'MDL-68654-master' of https://github.com/catalyst/moodle
Sara Arjona [Mon, 11 May 2020 17:16:14 +0000 (19:16 +0200)]
Merge branch 'MDL-68654-master' of https://github.com/catalyst/moodle

11 months agoMerge branch 'MDL-66109-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Mon, 11 May 2020 16:03:19 +0000 (00:03 +0800)]
Merge branch 'MDL-66109-master' of git://github.com/andrewnicols/moodle

11 months agoMerge branch 'MDL-68571-master' of git://github.com/cescobedo/moodle
Sara Arjona [Mon, 11 May 2020 14:52:48 +0000 (16:52 +0200)]
Merge branch 'MDL-68571-master' of git://github.com/cescobedo/moodle

11 months agoMDL-68571 core_h5p: Return default handler if no it has been defined
cescobedo [Wed, 6 May 2020 17:11:58 +0000 (19:11 +0200)]
MDL-68571 core_h5p: Return default handler if no it has been defined

11 months agoMerge branch 'MDL-68576-master' of git://github.com/mihailges/moodle
Sara Arjona [Mon, 11 May 2020 14:36:59 +0000 (16:36 +0200)]
Merge branch 'MDL-68576-master' of git://github.com/mihailges/moodle

11 months agoMerge branch 'MDL-63580-master' of git://github.com/cescobedo/moodle
Jun Pataleta [Mon, 11 May 2020 14:32:34 +0000 (22:32 +0800)]
Merge branch 'MDL-63580-master' of git://github.com/cescobedo/moodle

11 months agoMDL-63580 core_task: Deprecation cron_run_single_task and run_from_cli
cescobedo [Thu, 13 Feb 2020 17:08:59 +0000 (18:08 +0100)]
MDL-63580 core_task: Deprecation cron_run_single_task and run_from_cli

Also we have move the functions in \tool_task\run_from_cli to \core\task\manager
and we have deprecated that class.

11 months agoMDL-63580 core_task: Deprecation CLI scripts from admin/tool/task/cli
cescobedo [Thu, 13 Feb 2020 15:29:47 +0000 (16:29 +0100)]
MDL-63580 core_task: Deprecation CLI scripts from admin/tool/task/cli

Copy the CLI scripts from admin/tool/task/cli to admin/cli (schedule_task.php and adhoc_task.php)
and rename to scheduled_task.php and to improve in order to use cron_run_inner_scheduled_task.

11 months agoMerge branch 'MDL-68041-master-rev2' of https://github.com/nhoobin/moodle
Jun Pataleta [Mon, 11 May 2020 08:27:48 +0000 (16:27 +0800)]
Merge branch 'MDL-68041-master-rev2' of https://github.com/nhoobin/moodle

11 months agoMDL-68579 core_h5p: Add a check to avoid execute task using BEHAT
cescobedo [Thu, 7 May 2020 17:25:03 +0000 (19:25 +0200)]
MDL-68579 core_h5p: Add a check to avoid execute task using BEHAT

11 months agoMDL-68041 core_theme: New admin settings in secure page layout
Nicholas Hoobin [Mon, 2 Mar 2020 05:13:33 +0000 (16:13 +1100)]
MDL-68041 core_theme: New admin settings in secure page layout

This adds two new admin settings to the theme appearance options.

Shows the lang menu in secure layout, langmenuinsecurelayout.
Shows the user's name in secure layout, logininfoinsecurelayout.

When the page layout is set to secure, these options will be in effect.

11 months agoMDL-66109 js: Fix Shifter linting issues
Andrew Nicols [Wed, 29 Apr 2020 04:27:43 +0000 (12:27 +0800)]
MDL-66109 js: Fix Shifter linting issues

11 months agoMDL-66109 js: Upgrade to latest version of Shifter
Andrew Nicols [Wed, 22 Apr 2020 02:34:13 +0000 (10:34 +0800)]
MDL-66109 js: Upgrade to latest version of Shifter

This change bumps the version of Shifter that we use to the final
release - version 1.2.0.

I strongly doubt that there will be more releases, and this release was
over two years ago.

This version uses a newer version of Istanbul, and fixes to use that
specific version of Istanbul. As a result I have forked Shifter and
applied the Moodle Circular Dependency fixes there instead.

This version also inludes an upgrade to uglify from 1.3.x to 2.4.x. This
major upgrade includes a some changes to the built YUI module code.

11 months agoMDL-66109 behat: Prevent the use of Examples in Scenarios
Andrew Nicols [Wed, 22 Apr 2020 00:40:12 +0000 (08:40 +0800)]
MDL-66109 behat: Prevent the use of Examples in Scenarios

This change enables the Gherkin-lint rule to prevent the use of
"Examples" in a Scenario.

The Example tag is only allowed in a Scenario Outline at this time and
their use in a Scenario has no meaning.

11 months agoMDL-66109 behat: Require newline at EOF
Andrew Nicols [Mon, 11 May 2020 02:57:28 +0000 (10:57 +0800)]
MDL-66109 behat: Require newline at EOF

This change enables the gherkinlint rule to require a new line at the
end of the file. This change is in keeping with existing Moodle coding
style guidelines.

11 months agoMDL-66109 behat: Fix Example usage in feature files
Andrew Nicols [Wed, 22 Apr 2020 03:00:40 +0000 (11:00 +0800)]
MDL-66109 behat: Fix Example usage in feature files

The gherkin-lint package now understands the use of "Examples" and
requries that their indentation be correct and consistent.

This change sets the indentatation for these to:

    "Examples": 4,
    "example": 6,

This is in-line with the examples given in the offical Cucumber/Gherkin
documentation at
https://cucumber.io/docs/gherkin/reference/#scenario-outline whereby the
Examples and individual rows of the Examples table are children of the
Scenario outline.

This is contrary to the default for Gherkin-lint which places them as
top-level nodes with an indentatio of 0, and 2 respectively.

11 months agoMDL-66109 css: Fix incorrect max-empty-lines in Boost scss
Andrew Nicols [Wed, 22 Apr 2020 03:00:35 +0000 (11:00 +0800)]
MDL-66109 css: Fix incorrect max-empty-lines in Boost scss

This was previously not picked up by stylelint for an unknown reason.

11 months agoMDL-66109 css: Drop use of filter:alpha(opacity)
Andrew Nicols [Wed, 22 Apr 2020 02:58:39 +0000 (10:58 +0800)]
MDL-66109 css: Drop use of filter:alpha(opacity)

This CSS statement was an MS-only rule which was never accepted, and
which was abonded some time before IE 10. It has no effect in supported
browsers and can be safely replace with `opacity: [0.0-1.0]`.

11 months agoMDL-66109 js: Build changes for NodeJS upgrade
Andrew Nicols [Wed, 22 Apr 2020 02:44:14 +0000 (10:44 +0800)]
MDL-66109 js: Build changes for NodeJS upgrade

This change includes a build to fix all minified file changes in Moodle
as a result of upgrades to our build process.

11 months agoMDL-66109 js: Upgrade Node dependencies
Andrew Nicols [Wed, 22 Apr 2020 00:14:45 +0000 (08:14 +0800)]
MDL-66109 js: Upgrade Node dependencies

This change updates most libraries used in our Grunt build stack and
applies necessary changes to Grunt and Gherkin-lint configuration to
ensure that they continue to work.

The grunt-sass plugin has been updated to support alternative
'implementations' of sass compilers, and the chosen sass compiler must
now be specified in the grunt configuration. We continue to use the
`node-sass` package for this.

Our gherkin-lintrc included two rules which were renamed from
'no-unamed-*' to 'no-unnamed-*'. This change occurred in version 2.0.0
of Gherkin-lint and has no other effect.

11 months agoMDL-66109 js: Built file changes from new Node version
Andrew Nicols [Wed, 22 Apr 2020 03:38:11 +0000 (11:38 +0800)]
MDL-66109 js: Built file changes from new Node version

11 months agoMDL-66109 js: Fix circular dependency in Shifter dependency
Andrew Nicols [Wed, 22 Apr 2020 02:12:30 +0000 (10:12 +0800)]
MDL-66109 js: Fix circular dependency in Shifter dependency

Shifter is using an ancient and no-longer supported of Istanbul. That
version contains a circular dependency whereby it fetches the version
from the index that included the file in the first place.  This throws a
warning on newer versions of Node.

The fix here is simple and intended to be the bare minimum to remove
these warnings anad resolve the issue.

We have forked the istanbul project and created a v0.1.37_moodle branch
at the root version of the Istanbul version that Shifter uses (v0.1.37
tag). The circular dependency is then addressed and a new tag created.

I have then forked Shifter, pointing its package.json at the tar.gz
download of that new tag and pushed a new branch and tag for that fix.

Following this our own package.json is updated to point to the tar.gz
version of the new Shifter tag.

11 months agoMDL-66109 js: Upgrade to latest stable version of NodeJS
Andrew Nicols [Tue, 21 Apr 2020 12:58:34 +0000 (20:58 +0800)]
MDL-66109 js: Upgrade to latest stable version of NodeJS

Version 14.0.0 has just been released as stable, and will make its way
to an LTS release which will be supported until 30th April 2023.

At time of writing it is the "Current stable" release and will remain in
this phase until 20th October 2020, at whciih point it will transition
to LTS status.

11 months agoMerge branch 'MDL-68271-master' of git://github.com/sarjona/moodle
Andrew Nicols [Mon, 11 May 2020 01:10:40 +0000 (09:10 +0800)]
Merge branch 'MDL-68271-master' of git://github.com/sarjona/moodle

11 months agoMDL-68654 quizaccess: destroy a restore controller in tests
Dmitrii Metelkin [Sat, 9 May 2020 23:20:08 +0000 (09:20 +1000)]
MDL-68654 quizaccess: destroy a restore controller in tests

11 months agoMerge branch 'MDL-65547-master' of git://github.com/jleyva/moodle
Jun Pataleta [Fri, 8 May 2020 16:30:34 +0000 (00:30 +0800)]
Merge branch 'MDL-65547-master' of git://github.com/jleyva/moodle

11 months agoMDL-68271 core_h5p: implement localization methods for editor
Sara Arjona [Mon, 30 Mar 2020 10:35:40 +0000 (12:35 +0200)]
MDL-68271 core_h5p: implement localization methods for editor

The following methods have been implemented for supporting
content-type translations:
- H5PEditorAjaxInterface.getTranslations. This method is used for
loading the "Text overrides and translations" section.
- H5peditorStorage.getLanguage. This method is used for displaying
the specific fields and messages for each content-type library.
- H5peditorStorage.getAvailableLanguages. This method is used to
get the language list displayed into the "Text overrides and
translations" section.

11 months agoMDL-65547 tool_mobile: Allow to generate site QR codes only
Juan Leyva [Wed, 22 Apr 2020 11:01:57 +0000 (13:01 +0200)]
MDL-65547 tool_mobile: Allow to generate site QR codes only

11 months agoon-demand release 3.9dev+
Eloy Lafuente (stronk7) [Fri, 8 May 2020 11:32:22 +0000 (13:32 +0200)]
on-demand release 3.9dev+

11 months agoNOBUG: Fixed file access permissions
Eloy Lafuente (stronk7) [Fri, 8 May 2020 11:32:22 +0000 (13:32 +0200)]
NOBUG: Fixed file access permissions

11 months agoNOBUG: Fixed SVG browser compatibility
Eloy Lafuente (stronk7) [Fri, 8 May 2020 11:32:20 +0000 (13:32 +0200)]
NOBUG: Fixed SVG browser compatibility

11 months agoMerge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Eloy Lafuente (stronk7) [Fri, 8 May 2020 11:32:18 +0000 (13:32 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install

11 months agoMDL-68576 filepicker: Cover in behat file edition in filemanager
Mihail Geshoski [Fri, 8 May 2020 08:58:43 +0000 (16:58 +0800)]
MDL-68576 filepicker: Cover in behat file edition in filemanager

The added behat tests would also confirm whether the behaviour of
a click action on a file using different views in the filemanager
is consistent.

11 months agoMDL-68576 filepicker: Cover in behat file selection from filepicker
Mihail Geshoski [Fri, 8 May 2020 08:33:57 +0000 (16:33 +0800)]
MDL-68576 filepicker: Cover in behat file selection from filepicker

The added behat tests would cover the issue in MDL-68576. They test
whether the behaviour of a click action on a file using different
views in the filepicker is consistent.

11 months agoMDL-65547 tool_mobile: New WS for generating tokens with qr login keys
Juan Leyva [Tue, 14 Apr 2020 19:17:43 +0000 (21:17 +0200)]
MDL-65547 tool_mobile: New WS for generating tokens with qr login keys