Sara Arjona [Mon, 11 Nov 2019 12:43:17 +0000 (13:43 +0100)]
MDL-67042 customfield: Add behat tests to check hidden fields
Fields with the visibility different to Everyone should
be never displayed in the available filters custom field.
Sara Arjona [Mon, 11 Nov 2019 12:42:12 +0000 (13:42 +0100)]
MDL-67042 customfield: Display only fields visible to everybody
When defining the available filters for the Dashboard, only the
fields visible to everyone should be displayed in the Custom field
filter.
Eloy Lafuente (stronk7) [Thu, 21 Nov 2019 23:17:41 +0000 (00:17 +0100)]
weekly on-sync release 3.9dev
Jake Dallimore [Thu, 21 Nov 2019 03:55:07 +0000 (11:55 +0800)]
Merge branch 'MDL-67035' of https://github.com/stronk7/moodle
Jun Pataleta [Thu, 21 Nov 2019 03:36:33 +0000 (11:36 +0800)]
Merge branch 'MDL-66964' of https://github.com/stronk7/moodle
Tim Hunt [Thu, 25 Apr 2019 19:57:44 +0000 (20:57 +0100)]
MDL-48024 behat: allow plugins to have data generators
This extends the step
Given the following "users" exist:
to also support things like
Given the following "mod_quiz > user overrides" exist:
Instructions are on the behat_data_generators and
behat_generator_base classes.
Jake Dallimore [Thu, 21 Nov 2019 00:18:46 +0000 (08:18 +0800)]
Merge branch 'MDL-67030' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Sat, 19 Oct 2019 08:51:25 +0000 (10:51 +0200)]
MDL-66964 markdown: add details to readme
The commit to apply, from upstream repo, is:
https://github.com/michelf/php-markdown/commit/
a35858f0409e5f01474f5cd562d17289fe8e5435
But it doesn't apply clean to our current 1.8.0 version.
So we have ended a slightly different version in core reproducing the same changes.
Jake Dallimore [Wed, 20 Nov 2019 08:21:47 +0000 (16:21 +0800)]
Merge branch 'MDL-67031' of https://github.com/stronk7/moodle
Jun Pataleta [Wed, 20 Nov 2019 08:08:30 +0000 (16:08 +0800)]
Merge branch 'MDL-67077' of https://github.com/stronk7/moodle
Jake Dallimore [Wed, 20 Nov 2019 05:16:28 +0000 (13:16 +0800)]
Merge branch 'MDL-67034' of https://github.com/stronk7/moodle
Jake Dallimore [Wed, 20 Nov 2019 03:45:10 +0000 (11:45 +0800)]
Merge branch 'MDL-67029' of https://github.com/stronk7/moodle
Adrian Greeve [Wed, 20 Nov 2019 01:57:50 +0000 (09:57 +0800)]
Merge branch 'MDL-67017' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 22:25:54 +0000 (00:25 +0200)]
MDL-67034 lti_provider: php74 fix (curly braces) for LTI Provider lib
Jake Dallimore [Tue, 19 Nov 2019 02:51:05 +0000 (10:51 +0800)]
Merge branch 'MDL-67274-master' of https://github.com/sammarshallou/moodle
Eloy Lafuente (stronk7) [Mon, 18 Nov 2019 17:42:37 +0000 (18:42 +0100)]
Merge branch 'MDL-67148-master' of git://github.com/junpataleta/moodle
sam marshall [Fri, 15 Nov 2019 13:55:43 +0000 (13:55 +0000)]
MDL-67274 Tasks: Log display fails with memory errors
Jun Pataleta [Mon, 18 Nov 2019 08:02:05 +0000 (16:02 +0800)]
Merge branch 'MDL-67073-master' of git://github.com/marinaglancy/moodle
Jake Dallimore [Mon, 18 Nov 2019 03:27:00 +0000 (11:27 +0800)]
Merge branch 'MDL-67284' of https://github.com/stronk7/moodle
Jake Dallimore [Mon, 18 Nov 2019 03:20:28 +0000 (11:20 +0800)]
Merge branch 'MDL-67283' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Sun, 17 Nov 2019 11:27:17 +0000 (12:27 +0100)]
MDL-67284 mod_feedback: Add missing file phpdoc block
Eloy Lafuente (stronk7) [Sun, 17 Nov 2019 10:25:40 +0000 (11:25 +0100)]
MDL-67283 backup: Bump release to 3.9
Eloy Lafuente (stronk7) [Sun, 17 Nov 2019 10:40:19 +0000 (11:40 +0100)]
MDL-67284 upgrade: add 3.8.0 separation line to all upgrade scripts
Eloy Lafuente (stronk7) [Wed, 30 Oct 2019 10:24:34 +0000 (11:24 +0100)]
MDL-67077 h5p: php74 fix (curly braces) for the H5P lib
This has been sent also upstream @ https://github.com/h5p/h5p-php-library/pull/69
Eloy Lafuente (stronk7) [Sun, 27 Oct 2019 23:26:17 +0000 (00:26 +0100)]
MDL-67035 tags: fix nested ternary operators to be php74 compliant
Nesting ternary operators without explicit parentheses is deprecated:
// Code like
$a ? $b : $c ? $d : $e
// should be replaced by (current interpretation)
($a ? $b : $c) ? $d : $e
// or (likely intended interpretation)
$a ? $b : ($c ? $d : $e)
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 22:21:56 +0000 (00:21 +0200)]
MDL-67034 google: php74 fix (curly braces) for the Google-Client lib
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 22:18:05 +0000 (00:18 +0200)]
MDL-67034 adodb: php74 fix (curly braces) for the AdoDB lib
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 22:15:48 +0000 (00:15 +0200)]
MDL-67034 horde: php74 fix (curly braces) for the Horde lib
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 15:05:29 +0000 (17:05 +0200)]
MDL-67031 s3: php74 fixup for class S3 v0.5.1
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 09:37:37 +0000 (11:37 +0200)]
MDL-67030 htmlpurifier: add details to readme
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 09:34:03 +0000 (11:34 +0200)]
MDL-67030 htmlpurifier: php74 fixup for htmlpurifier v4.10.0
This simply applies this pull request:
https://github.com/ezyang/htmlpurifier/pull/224
straight to our library. Once there is some new htmlpurifier
release available (>v4.11.0) we'll be back upstream because
the fix will be included.
Eloy Lafuente (stronk7) [Fri, 25 Oct 2019 20:00:57 +0000 (22:00 +0200)]
MDL-67029 bennu: add details to readme
Eloy Lafuente (stronk7) [Fri, 25 Oct 2019 19:50:13 +0000 (21:50 +0200)]
MDL-67029 bennu: php74 fixup for bennu lib 0.1-custom
Eloy Lafuente (stronk7) [Thu, 24 Oct 2019 16:48:30 +0000 (18:48 +0200)]
MDL-67017 typo3: add details to readme
Eloy Lafuente (stronk7) [Thu, 24 Oct 2019 16:41:52 +0000 (18:41 +0200)]
MDL-67017 typo3: php74 fixup for typo3 lib 4.7.19
We are using a really outdated Typo3 library (2014) already patched
for php73 support. Plus, probably, we'll be soon removing it from core.
So we have decided to, instead of upgrade, apply the needed php74 fixes.
Eloy Lafuente (stronk7) [Sat, 19 Oct 2019 08:48:00 +0000 (10:48 +0200)]
MDL-66964 markdown: php74 fixup for markdown lib 1.8.0
Note this is different from the upstream commit:
https://github.com/michelf/php-markdown/commit/
a35858f0409e5f01474f5cd562d17289fe8e5435
because it was conflicting so only the cases corresponding
to our current 1.8.0 version have been modified.
This commit is trivial, just a pure curly to square replacement.
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 17:03:02 +0000 (18:03 +0100)]
weekly back-to-dev release 3.9dev
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 16:54:08 +0000 (17:54 +0100)]
NOBUG: Change travis.yml back to master
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 16:54:07 +0000 (17:54 +0100)]
Moodle release 3.8
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 16:54:08 +0000 (17:54 +0100)]
NOBUG: Change travis.yml to MOODLE_38_STABLE
Jun Pataleta [Sat, 16 Nov 2019 09:44:05 +0000 (17:44 +0800)]
Merge branch 'MDL-67281' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Fri, 15 Nov 2019 18:11:34 +0000 (19:11 +0100)]
MDL-67281 forum: don't show discussion creation time twice
The discussion creation time (or first post) is being shown
both in the "started by" and "last post" columns in forum
discussions list.
Just let's change the former to show the discussion modification
time (or last post) instead.
Eloy Lafuente (stronk7) [Fri, 15 Nov 2019 11:30:52 +0000 (12:30 +0100)]
Moodle release 3.8rc1
Jun Pataleta [Fri, 15 Nov 2019 04:38:54 +0000 (12:38 +0800)]
Merge branch 'MDL-67269-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Fri, 15 Nov 2019 04:08:33 +0000 (12:08 +0800)]
Merge branch 'MDL-67268-master' of git://github.com/mihailges/moodle
Mihail Geshoski [Fri, 15 Nov 2019 04:05:59 +0000 (12:05 +0800)]
MDL-67268 mod_forum: Group and label radio buttons in forum grader
Andrew Nicols [Fri, 15 Nov 2019 03:45:17 +0000 (11:45 +0800)]
MDL-67269 mod_forum: Capture form submission in grading panel
Andrew Nicols [Fri, 15 Nov 2019 02:35:00 +0000 (10:35 +0800)]
Merge branch 'MDL-67265' of git://github.com/Chocolate-lightning/moodle_forum-project
Mathew May [Fri, 15 Nov 2019 01:21:06 +0000 (09:21 +0800)]
MDL-67265 core: Set max-height on toast wrapper
Jake Dallimore [Thu, 14 Nov 2019 08:34:28 +0000 (16:34 +0800)]
Merge branch 'MDL-67241-master' of git://github.com/lameze/moodle
Jake Dallimore [Thu, 14 Nov 2019 07:17:24 +0000 (15:17 +0800)]
Merge branch 'MDL-67144-integration' of git://github.com/Chocolate-lightning/moodle_forum-project
Mathew May [Thu, 14 Nov 2019 03:49:25 +0000 (11:49 +0800)]
MDL-67144 mod_forum: If no users exist do not show the grading interface
Jun Pataleta [Thu, 14 Nov 2019 06:34:17 +0000 (14:34 +0800)]
Merge branch 'MDL-67246-master' of git://github.com/jleyva/moodle
Jake Dallimore [Thu, 14 Nov 2019 06:27:42 +0000 (14:27 +0800)]
Merge branch 'MDL-67207-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Thu, 14 Nov 2019 04:37:22 +0000 (12:37 +0800)]
Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 14 Nov 2019 03:42:56 +0000 (11:42 +0800)]
MDL-67116 course: Restore removed line
This line was inadvertently removed in a previous commit.
Andrew Nicols [Thu, 14 Nov 2019 02:54:14 +0000 (10:54 +0800)]
Merge branch 'MDL-67250-master-httpswwwroot' of git://github.com/mudrd8mz/moodle
Simey Lameze [Thu, 14 Nov 2019 02:10:29 +0000 (10:10 +0800)]
MDL-67241 mod_forum: raise memory limit when exporting
Adrian Greeve [Thu, 14 Nov 2019 01:03:31 +0000 (09:03 +0800)]
Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 14 Nov 2019 00:38:19 +0000 (08:38 +0800)]
MDL-67116 course: Strict empty string check required
In PHP the following are true:
assert('' == '');
assert(0 == '');
assert(null == '');
The options in the course completion settings are now:
'' => none selected
[int] => itemnumber of activity course completion item.
In the case where the itemnumber was 0 this was being incorrectly
evaluated as an empty string due to the implicit cast to int of the
empty string:
(int) '' === 0
As a result, the non-strict comparison means that the following are
identical:
assert(0 == '');
assert(0 == (int) '');
assert(0 == '0');
Changing the comparison to a strict comparison is correct because it
ensures the type consitency between the empty string value, and the int
of itemnumber 0. It is safe because the value always comes from the
form, where an int is always returned, and not the DB, where a string is
returned.
Eloy Lafuente (stronk7) [Thu, 14 Nov 2019 00:12:01 +0000 (01:12 +0100)]
Merge branch 'MDL-67248-master' of git://github.com/cescobedo/moodle
David Mudrák [Wed, 13 Nov 2019 18:58:10 +0000 (19:58 +0100)]
MDL-67250 setup: Revert removal of the httpswwwroot setting
It is still used widely in the plugins that would stop working suddenly
without being warned via a debugging message. We must keep it forever as
an alias for the wwwroot.
cescobedo [Wed, 13 Nov 2019 17:36:09 +0000 (18:36 +0100)]
MDL-67248 filter_displayh5p: Add new description on filter
Juan Leyva [Wed, 13 Nov 2019 14:33:20 +0000 (15:33 +0100)]
MDL-67246 admin: Return course color settings for external clients
Jun Pataleta [Wed, 13 Nov 2019 08:00:16 +0000 (16:00 +0800)]
Merge branch 'MDL-67231-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Wed, 13 Nov 2019 07:31:03 +0000 (15:31 +0800)]
Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Wed, 13 Nov 2019 04:10:16 +0000 (12:10 +0800)]
MDL-67207 forum: Reset focus after closing grade viewer
Andrew Nicols [Wed, 13 Nov 2019 03:51:51 +0000 (11:51 +0800)]
MDL-67207 forum: Return focus when closing expanded discussion
Andrew Nicols [Wed, 13 Nov 2019 03:50:51 +0000 (11:50 +0800)]
MDL-67207 core: Use focus lock manager in modals
Andrew Nicols [Tue, 12 Nov 2019 01:52:08 +0000 (09:52 +0800)]
MDL-67207 forum: Reset focus after closing grader
Andrew Nicols [Tue, 12 Nov 2019 01:37:35 +0000 (09:37 +0800)]
MDL-67207 forum: Lock focus in grader
Andrew Nicols [Tue, 12 Nov 2019 01:36:14 +0000 (09:36 +0800)]
MDL-67207 core: Add new ARIA focus locker
This is based on code and examples provided in the ARIA specification
https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html
Adrian Greeve [Wed, 13 Nov 2019 06:30:06 +0000 (14:30 +0800)]
Merge branch 'MDL-67178' of git://github.com/Chocolate-lightning/moodle_forum-project
Andrew Nicols [Wed, 13 Nov 2019 06:24:28 +0000 (14:24 +0800)]
MDL-67231 h5p: Correct naming of h5p unit test files
Jun Pataleta [Wed, 13 Nov 2019 05:49:22 +0000 (13:49 +0800)]
Merge branch 'MDL-67232-master' of git://github.com/lameze/moodle
Mathew May [Fri, 8 Nov 2019 04:08:01 +0000 (12:08 +0800)]
MDL-67178 mod_forum: Allow users to backup forum grades
Andrew Nicols [Wed, 13 Nov 2019 04:49:57 +0000 (12:49 +0800)]
MDL-67116 course: Fix completion disabled for gradable items
The default value is an empty string (""), which in PHP evaluates to 0 when
cast to a string in our DML layer.
The fix is to forcibly make it null which is not cast to string in DML
for optional strings.
Jun Pataleta [Wed, 13 Nov 2019 03:20:02 +0000 (11:20 +0800)]
Merge branch 'MDL-67199' of https://github.com/stronk7/moodle
Jun Pataleta [Wed, 13 Nov 2019 03:00:22 +0000 (11:00 +0800)]
Merge branch 'MDL-67218-master' of git://github.com/andrewnicols/moodle
Simey Lameze [Wed, 13 Nov 2019 02:33:55 +0000 (10:33 +0800)]
MDL-67232 mod_forum: remove initialuserid data attr from template
Jake Dallimore [Wed, 13 Nov 2019 02:25:42 +0000 (10:25 +0800)]
Merge branch 'MDL-66812-master' of git://github.com/bmbrands/moodle
Adrian Greeve [Wed, 13 Nov 2019 02:18:59 +0000 (10:18 +0800)]
Merge branch 'MDL-67215-master' of git://github.com/peterRd/moodle
Andrew Nicols [Tue, 12 Nov 2019 04:34:37 +0000 (12:34 +0800)]
MDL-67116 form: Require grade in multi-grade-item activities
AMOS BEGIN
CPY [rating,rating],[grade_rating_name,rating]
AMOS END
Ryan Wyllie [Fri, 8 Nov 2019 05:04:51 +0000 (13:04 +0800)]
MDL-67116 course: allow grading completion for non ratings grade item
Andrew Nicols [Tue, 12 Nov 2019 03:29:34 +0000 (11:29 +0800)]
MDL-67218 form: Do not clear grade when rescaling not enabled
Andrew Nicols [Wed, 13 Nov 2019 00:38:34 +0000 (08:38 +0800)]
Merge branch 'MDL-67194-master' of git://github.com/vmdef/moodle
Andrew Nicols [Wed, 13 Nov 2019 00:31:25 +0000 (08:31 +0800)]
Merge branch 'wip_MDL-67205_master' of git://github.com/gjb2048/moodle
Eloy Lafuente (stronk7) [Tue, 12 Nov 2019 16:58:42 +0000 (17:58 +0100)]
MDL-67199 versions: main version bump
Eloy Lafuente (stronk7) [Tue, 12 Nov 2019 16:57:08 +0000 (17:57 +0100)]
MDL-67199 versions: bump all versions and requires near release
version =
2019111800 release version
requires=
2019111200 current beta (week7roll1) version
Eloy Lafuente (stronk7) [Tue, 12 Nov 2019 15:50:55 +0000 (16:50 +0100)]
Moodle release 3.8beta
Jun Pataleta [Tue, 12 Nov 2019 14:01:37 +0000 (22:01 +0800)]
Merge branch 'MDL-66906-master-fix' of git://github.com/andrewnicols/moodle
Andrew Nicols [Tue, 12 Nov 2019 13:04:54 +0000 (21:04 +0800)]
MDL-66906 gradingform_rubric: Add back missing field
Jun Pataleta [Tue, 12 Nov 2019 08:38:58 +0000 (16:38 +0800)]
Merge branch 'MDL-66906-integration-3' of git://github.com/Chocolate-lightning/moodle_forum-project
Mathew May [Wed, 16 Oct 2019 06:20:05 +0000 (14:20 +0800)]
MDL-66906 mod_forum: Show learners their grades in a Modal
Jun Pataleta [Tue, 12 Nov 2019 08:10:38 +0000 (16:10 +0800)]
Merge branch 'MDL-66360-master-fix' of git://github.com/andrewnicols/moodle
Andrew Nicols [Tue, 12 Nov 2019 08:00:50 +0000 (16:00 +0800)]
MDL-66360 grading: Validate notifyuser
Andrew Nicols [Tue, 12 Nov 2019 07:59:53 +0000 (15:59 +0800)]
MDL-66360 grade: Correct argument order in params
Andrew Nicols [Tue, 12 Nov 2019 03:29:34 +0000 (11:29 +0800)]
MDL-67218 form: Do not clear grade when rescaling not enabled
Andrew Nicols [Tue, 12 Nov 2019 02:16:12 +0000 (10:16 +0800)]
Merge branch 'MDL-66360-master-fix' of git://github.com/lameze/moodle
Simey Lameze [Mon, 11 Nov 2019 23:46:31 +0000 (07:46 +0800)]
MDL-66360 forum: rename sendstudentnotifications_forum to forum_grade_notify