Andrew Nicols [Tue, 25 Sep 2018 00:35:08 +0000 (08:35 +0800)]
Merge branch 'MDL-63346' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Mon, 24 Sep 2018 15:38:10 +0000 (17:38 +0200)]
MDL-63020 tests: ensure that searching for is null values also works ok
Eloy Lafuente (stronk7) [Mon, 24 Sep 2018 14:01:21 +0000 (16:01 +0200)]
Merge branch 'MDL-63020' of git://github.com/timhunt/moodle
Tim Hunt [Mon, 24 Sep 2018 10:41:25 +0000 (11:41 +0100)]
MDL-63020 dml: improve the unit tests
David Monllao [Mon, 24 Sep 2018 09:24:49 +0000 (11:24 +0200)]
Merge branch 'MDL-61573-master' of https://github.com/Kathrin84/moodle
David Monllao [Mon, 24 Sep 2018 07:50:05 +0000 (09:50 +0200)]
MDL-47962 upgrade.txt: Update commit reference
David Monllao [Mon, 24 Sep 2018 07:45:47 +0000 (09:45 +0200)]
Merge branch 'MDL-47962' of git://github.com/timhunt/moodle
David Monllao [Mon, 24 Sep 2018 07:41:18 +0000 (09:41 +0200)]
MDL-54035 upgrade.txt: Limit comments to relevant info for upgrades
Jonathan Champ [Wed, 20 Jun 2018 14:31:25 +0000 (10:31 -0400)]
MDL-54035 course: Test reset roles in reset_course_userdata()
Previously, reset_course_userdata() was deleting the role_capabilities
directly, but has_capability() checks the local capabilities cache
which was still returning the previous value.
Jonathan Champ [Thu, 21 Jun 2018 17:23:03 +0000 (13:23 -0400)]
MDL-54035 accesslib: Add context->get_parent_context_paths()
Returns full context paths for parent contexts. Useful for exact
matches, such as when checking dirtycontexts.
Jonathan Champ [Tue, 5 Jun 2018 20:37:25 +0000 (16:37 -0400)]
MDL-54035 accesslib: add mark_user_dirty helper
Instead of marking an entire context dirty and affecting all users
of those contexts, mark the user as dirty when the change only
affects that user.
Jonathan Champ [Fri, 22 Jun 2018 21:16:14 +0000 (17:16 -0400)]
MDL-54035 accesslib: only modify role_capabilities in accesslib
Whenever the role_capabilities table is changed, we need to remember
to clear the cache for the role(s) being modified. This is far simpler
when all of those changes happen in a single file, i.e. accesslib.php,
allowing other parts of the application to use the public functions
without requiring knowledge of the cache internals.
Jonathan Champ [Tue, 5 Jun 2018 19:13:02 +0000 (15:13 -0400)]
MDL-54035 accesslib: separate role definition cache clear
Thanks to MDL-49398, we can separate the combined user session and role
definition cache clearing function into two separate functions. At the
same time, we want to identify and remove mark_dirty() calls that were
added for role definition changes but were incorrectly left behind.
Change highlights:
- Remove unnecessary mark_dirty() calls performed after
assign_capability(), unassign_capability(), delete_role(),
deleted contexts, brand new contexts
- Move role definition cache clear from the user-centric
accesslib_clear_all_caches() to the newly created,
role-dedicated accesslib_reset_role_cache()
Tim Hunt [Wed, 19 Sep 2018 13:54:52 +0000 (14:54 +0100)]
MDL-47962 filter_glossary: changes made during integration review
Tim Hunt [Thu, 13 Sep 2018 17:42:14 +0000 (18:42 +0100)]
MDL-47962 filter_glossary: only create replacement HTML if needed
Tim Hunt [Thu, 13 Sep 2018 17:03:35 +0000 (18:03 +0100)]
MDL-47962 filter_glossary: only prepare the replacement if used
Tim Hunt [Thu, 13 Sep 2018 16:53:10 +0000 (17:53 +0100)]
MDL-47962 filter_glossary: clean up filterobject class
This is another preliminary commit, rationalising the ->work... fields
and also moving the code that sets them up into a separate function.
This is also to prepare for the next commit.
Tim Hunt [Thu, 13 Sep 2018 16:21:02 +0000 (17:21 +0100)]
MDL-47962 filter_glossary: only prepare_phrases_for_filtering once
Tim Hunt [Thu, 13 Sep 2018 16:08:28 +0000 (17:08 +0100)]
MDL-47962 filter_glossary: use preg features for fullmatch
This eliminates a lot of necessary string manipulation for something
that preg can just do with the \b assertion.
The change also extracts all the work to prepare ->work_phrase (renamed
->regexp) into a separate function. This is to pave the way for future
efficiency gains, but for now I have not done them, so it is easier to
verify by inspection that this commit does not change behaviour.
Also, some tidy-ups to the filterobject structure, to eliminate some
redundant fields.
Tim Hunt [Tue, 11 Sep 2018 16:36:29 +0000 (17:36 +0100)]
MDL-47962 filter_glossary: cache concept list in a MUC static cache
This is a slight improvement on a suggestion by David Monllaó
Tim Hunt [Tue, 11 Sep 2018 15:49:10 +0000 (16:49 +0100)]
MDL-47962 filter_glossary: Fix lang string concatenation
Tim Hunt [Tue, 20 Jan 2015 18:14:29 +0000 (18:14 +0000)]
MDL-47962 filter_glossary: $GLOSSARY_EXCLUDEENTRY shouldn't stop caching
Also, greatly improved unit tests, to test more cases of how the filter
should work.
Tim Hunt [Tue, 20 Jan 2015 18:05:23 +0000 (18:05 +0000)]
MDL-47962 filterlib: Fix lots of coding style
Tim Hunt [Fri, 7 Sep 2018 14:32:33 +0000 (15:32 +0100)]
MDL-63020 ddl: fix nullable unique indexes in OCI and MS SQL
This works-around the default non-standard behaviour of these DB engines.
Tim Hunt [Fri, 7 Sep 2018 14:30:50 +0000 (15:30 +0100)]
MDL-63020 xmldb: Improve PHPdoc comments for better IDE autocomplete
Eloy Lafuente (stronk7) [Thu, 20 Sep 2018 10:11:53 +0000 (12:11 +0200)]
weekly release 3.6dev
Eloy Lafuente (stronk7) [Fri, 14 Sep 2018 10:34:02 +0000 (12:34 +0200)]
MDL-63346 nodejs: Bump to created from scratch shrinkwrap file
Steps:
- remove node_modules & npm-shrinkwrap.json
- npm cache clear --force
- npm install
- npm shrinkwrap
Eloy Lafuente (stronk7) [Wed, 19 Sep 2018 21:07:20 +0000 (23:07 +0200)]
MDL-23545 question: fix remaining sizes leading to failures
Eloy Lafuente (stronk7) [Wed, 19 Sep 2018 16:10:37 +0000 (18:10 +0200)]
Merge branch 'MDL-23545-phpunit-fixes' of https://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Wed, 19 Sep 2018 14:55:20 +0000 (16:55 +0200)]
MDL-59227 course: Use low level early renaming to avoid dupes
Instead of using set_coursemodule_name() to proceed with the name
change we perform the change earlier in the process, both to avoid
duplicate events caused by the renaming function and also to get the new
name used by all proper generated events.
David Monllao [Wed, 19 Sep 2018 11:30:43 +0000 (13:30 +0200)]
Merge branch 'MDL-63140-master' of git://github.com/rezaies/moodle
Tim Hunt [Tue, 18 Sep 2018 12:52:51 +0000 (13:52 +0100)]
MDL-23545 qformat_xml: fix another Behat test
David Monllao [Wed, 19 Sep 2018 11:12:40 +0000 (13:12 +0200)]
Merge branch 'MDL-63135-master' of git://github.com/rezaies/moodle
Eloy Lafuente (stronk7) [Tue, 18 Sep 2018 22:26:25 +0000 (00:26 +0200)]
Merge branch 'MDL-23545-phpunit-fixes' of https://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Tue, 18 Sep 2018 21:26:51 +0000 (23:26 +0200)]
Merge branch 'MDL-63116-master-1' of git://github.com/mihailges/moodle
Eloy Lafuente (stronk7) [Tue, 18 Sep 2018 21:11:34 +0000 (23:11 +0200)]
Merge branch 'MDL-59227' of https://github.com/rlorenzo/moodle
Mihail Geshoski [Thu, 13 Sep 2018 06:44:26 +0000 (14:44 +0800)]
MDL-61908 privacy: Fix heading in data privacy pages
Eloy Lafuente (stronk7) [Tue, 18 Sep 2018 15:50:13 +0000 (17:50 +0200)]
Merge branch 'MDL-63109-master' of git://github.com/mihailges/moodle
David Monllao [Tue, 18 Sep 2018 14:39:58 +0000 (16:39 +0200)]
Merge branch 'MDL-63138-master' of git://github.com/rezaies/moodle
David Monllao [Tue, 18 Sep 2018 14:36:55 +0000 (16:36 +0200)]
Merge branch 'MDL-63139-master' of git://github.com/rezaies/moodle
David Monllao [Tue, 18 Sep 2018 14:32:58 +0000 (16:32 +0200)]
Merge branch 'MDL-63117-master' of git://github.com/rezaies/moodle
Tim Hunt [Tue, 18 Sep 2018 12:52:51 +0000 (13:52 +0100)]
MDL-23545 qformat_xml: don't allow irrelevant DB differences to break tests
Also slightly improve formatting of the exported file.
David Monllao [Tue, 18 Sep 2018 10:17:46 +0000 (12:17 +0200)]
Merge branch 'MDL-63333_master' of git://github.com/markn86/moodle
Mihail Geshoski [Tue, 18 Sep 2018 07:06:23 +0000 (15:06 +0800)]
MDL-63109 privacy: Add behat tests
Kathrin Osswald [Thu, 7 Jun 2018 11:04:16 +0000 (13:04 +0200)]
MDL-61573 user: Changes to pix path for better support of fa mapping
Jun Pataleta [Tue, 18 Sep 2018 06:10:11 +0000 (14:10 +0800)]
Merge branch 'm36_MDL-63319_MySQL_MSSQL_Rename_Field_Reserved_Word' of https://github.com/scara/moodle
Mihail Geshoski [Thu, 30 Aug 2018 05:48:00 +0000 (13:48 +0800)]
MDL-63109 privacy: Fix the initialisation of the policy acceptance modal
Jun Pataleta [Tue, 18 Sep 2018 02:07:56 +0000 (10:07 +0800)]
Merge branch 'MDL-23545-master-fix' of git://github.com/junpataleta/moodle
Jun Pataleta [Tue, 18 Sep 2018 02:04:03 +0000 (10:04 +0800)]
MDL-23545 question_format: Replace tabs with spaces in upgrade.txt
Jun Pataleta [Tue, 18 Sep 2018 01:47:38 +0000 (09:47 +0800)]
Merge branch 'wip-MDL-23545-master' of https://github.com/Beedell/moodle
Rohan Khajuria [Mon, 10 Sep 2018 22:02:00 +0000 (15:02 -0700)]
MDL-59227 course: add (copy) to duplicated modules
Eloy Lafuente (stronk7) [Mon, 17 Sep 2018 21:56:37 +0000 (23:56 +0200)]
Merge branch 'MDL-63279_master' of https://github.com/aanabit/moodle
Eloy Lafuente (stronk7) [Mon, 17 Sep 2018 21:39:35 +0000 (23:39 +0200)]
Merge branch 'MDL-58781_master' of https://github.com/aanabit/moodle
Eloy Lafuente (stronk7) [Mon, 17 Sep 2018 21:30:13 +0000 (23:30 +0200)]
Merge branch 'MDL-63009-master' of git://github.com/mickhawkins/moodle
Eloy Lafuente (stronk7) [Mon, 17 Sep 2018 21:10:39 +0000 (23:10 +0200)]
Merge branch 'MDL-63184-master-2' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Mon, 17 Sep 2018 21:09:20 +0000 (23:09 +0200)]
Merge branch 'MDL-63371' of git://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Mon, 17 Sep 2018 21:05:31 +0000 (23:05 +0200)]
Merge branch 'MDL-63354-master' of https://github.com/HuongNV13/moodle
Jun Pataleta [Mon, 20 Aug 2018 06:36:28 +0000 (14:36 +0800)]
MDL-63184 tool_dataprivacy: Ensure PO roles have correct capability
David Monllao [Mon, 17 Sep 2018 11:44:49 +0000 (13:44 +0200)]
Merge branch 'MDL-62554-master' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Mon, 17 Sep 2018 08:40:41 +0000 (10:40 +0200)]
Merge branch 'MDL-63215-master' of https://github.com/lucaboesch/moodle
Eloy Lafuente (stronk7) [Mon, 17 Sep 2018 07:54:31 +0000 (09:54 +0200)]
Merge branch 'MDL-63379-master' of git://github.com/junpataleta/moodle
Jun Pataleta [Mon, 17 Sep 2018 03:25:37 +0000 (11:25 +0800)]
MDL-63379 user: Fix Behat tests for participants filtering
Mark Nelson [Tue, 11 Sep 2018 04:57:30 +0000 (12:57 +0800)]
MDL-63333 core: removed unused setting 'messaginghidereadnotifications'
Mihail Geshoski [Mon, 10 Sep 2018 07:33:02 +0000 (15:33 +0800)]
MDL-63116 privacy: Add bulk actions to the privacy request table
Mihail Geshoski [Tue, 4 Sep 2018 05:08:12 +0000 (13:08 +0800)]
MDL-63116 privacy: Add behat tests
Mihail Geshoski [Fri, 24 Aug 2018 07:47:55 +0000 (15:47 +0800)]
MDL-63116 privacy: Add unit tests
Michelle Melton [Mon, 27 Aug 2018 19:06:48 +0000 (21:06 +0200)]
MDL-63215 block_rss_client: Escaping tags in RSS entries
Matteo Scaramuccia [Thu, 13 Sep 2018 19:59:03 +0000 (21:59 +0200)]
MDL-63319 ddl: Added getRenameFieldSQL() coverage
Matteo Scaramuccia [Thu, 13 Sep 2018 19:55:17 +0000 (21:55 +0200)]
MDL-63319 ddl: Improved rename_field() coverage
DB API should allow to rename fields, including renaming
those columns named using a reserved word.
Matteo Scaramuccia [Sat, 8 Sep 2018 22:19:08 +0000 (00:19 +0200)]
MDL-63319 ddl: MSSQL should rename reserved words
Matteo Scaramuccia [Sun, 9 Sep 2018 05:38:34 +0000 (07:38 +0200)]
MDL-63319 ddl: MySQL should rename reserved words
John Beedell [Fri, 3 Aug 2018 08:53:54 +0000 (09:53 +0100)]
MDL-23545 question: XML import/export add category description
Tim Hunt [Fri, 14 Sep 2018 15:02:08 +0000 (16:02 +0100)]
MDL-63371 question: USE_RAW_DATA case in check_qt_var_name_restrictions
Amaia Anabitarte [Wed, 5 Sep 2018 17:17:23 +0000 (18:17 +0100)]
MDL-63279 messaging: Add admin setting for toggling site-wide messaging
Amaia Anabitarte [Thu, 9 Aug 2018 15:01:39 +0000 (16:01 +0100)]
MDL-58781 mod_feedback: Inconsistency in analysis exported to excel
Eloy Lafuente (stronk7) [Thu, 13 Sep 2018 22:21:57 +0000 (00:21 +0200)]
MDL-63346 travis: GRUNT job immune to npm-shrinkwrap.json changes
When upgrading nodejs/npm versions, there are modifications to
different packages or to the format of the npm-shrinkwrap.json
file. Usually that leads to failed jobs untill the bundled file
is updated.
To avoid that, we just ignore the npm-shrinkwrap.json file, so
just the REAL modifications in css/js/ignore stuff are considered.
Eloy Lafuente (stronk7) [Fri, 14 Sep 2018 09:06:32 +0000 (11:06 +0200)]
weekly release 3.6dev
Eloy Lafuente (stronk7) [Fri, 14 Sep 2018 09:06:29 +0000 (11:06 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Shamim Rezaie [Fri, 7 Sep 2018 08:28:22 +0000 (18:28 +1000)]
MDL-63140 mod_glossary: Check if the module is visible to the user
Huong Nguyen [Thu, 13 Sep 2018 07:15:52 +0000 (14:15 +0700)]
MDL-63354 Group: Rollover text on long group names is not consistent
Eloy Lafuente (stronk7) [Thu, 13 Sep 2018 17:01:09 +0000 (19:01 +0200)]
MDL-61169 iplookup: Change to another block still remaining to SF
Jun Pataleta [Thu, 13 Sep 2018 08:17:02 +0000 (16:17 +0800)]
Merge branch 'MDL-51177-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 13 Sep 2018 07:32:20 +0000 (15:32 +0800)]
MDL-51177 atto_html: Check isHTML before hiding editor
Jun Pataleta [Tue, 11 Sep 2018 08:57:40 +0000 (16:57 +0800)]
MDL-62554 tool_dataprivacy: Integration review fixes
Eloy Lafuente (stronk7) [Wed, 12 Sep 2018 21:14:54 +0000 (23:14 +0200)]
Merge branch 'MDL-60630-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 2 Aug 2018 02:23:14 +0000 (10:23 +0800)]
MDL-60630 cachestore: Remove memcache plugin
Michael Hawkins [Wed, 12 Sep 2018 09:26:03 +0000 (17:26 +0800)]
MDL-63009 tool_dataprivacy: Added site name/link to request emails
Eloy Lafuente (stronk7) [Wed, 12 Sep 2018 08:19:19 +0000 (10:19 +0200)]
Merge branch 'MDL-63329-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Wed, 12 Sep 2018 07:34:59 +0000 (15:34 +0800)]
Merge branch 'mdl63321-master' of https://github.com/tlock/moodle
Jun Pataleta [Wed, 12 Sep 2018 05:30:39 +0000 (13:30 +0800)]
Merge branch 'MDL-51177-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Wed, 12 Sep 2018 04:36:19 +0000 (12:36 +0800)]
MDL-51177 core: Ignore built files in stylelint
Andrew Nicols [Wed, 5 Sep 2018 02:11:35 +0000 (10:11 +0800)]
MDL-51177 atto_html: Import htmlplus functionality
Jun Pataleta [Wed, 12 Sep 2018 02:00:01 +0000 (10:00 +0800)]
Merge branch 'MDL-63231-set-default-value-for-int-param-MOODLE_Master' of https://github.com/guillalva06/moodle
Jun Pataleta [Wed, 12 Sep 2018 01:44:36 +0000 (09:44 +0800)]
Merge branch 'MDL-50314_master' of git://github.com/do-you-even-curl/moodle
Andrew Nicols [Mon, 10 Sep 2018 01:50:08 +0000 (09:50 +0800)]
MDL-63329 core: Remove memcache session support
Eloy Lafuente (stronk7) [Tue, 11 Sep 2018 21:55:00 +0000 (23:55 +0200)]
Merge branch 'MDL-63130_master' of git://github.com/markn86/moodle
Eloy Lafuente (stronk7) [Tue, 11 Sep 2018 21:52:02 +0000 (23:52 +0200)]
Merge branch 'MDL-63136-master' of git://github.com/rezaies/moodle
Eloy Lafuente (stronk7) [Tue, 11 Sep 2018 21:02:40 +0000 (23:02 +0200)]
Merge branch 'MDL-62528-master' of git://github.com/bmbrands/moodle
Guillermo Alvarez [Fri, 24 Aug 2018 17:40:06 +0000 (12:40 -0500)]
MDL-63231 filepicker: Skype validation for null values
In file_get_all_files_in_draftarea function an integer could get
a null value so it is necessary to execute this function only
when is called with a valid integer value.
Jun Pataleta [Mon, 10 Sep 2018 08:22:48 +0000 (16:22 +0800)]
Merge branch 'wip-MDL-62520_MASTER' of https://github.com/jason-platts/moodle