Andrew Nicols [Mon, 15 Jun 2020 01:44:39 +0000 (09:44 +0800)]
MDL-69107 form_autocomplete: Rewrite item selection
The form_autocomplete is essentially a custom element. Unfortunately the
`setValue()` function in Mink has undesired actions so it is necessary
to write our own handling for it.
The standard Mink `setValue()` function focuses the element, sets a
value, and then blurs the element. In the case of the autocomplete this
can cause the autocomplete suggestions list to be closed in some
situations. Instead of using the setValue we click, and type the value,
but do not immediately blur.
Víctor Déniz [Thu, 10 Dec 2020 21:10:47 +0000 (21:10 +0000)]
weekly release 3.10+
Víctor Déniz [Thu, 10 Dec 2020 21:10:40 +0000 (21:10 +0000)]
Merge branch 'install_310_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_310_STABLE
Shamim Rezaie [Thu, 10 Dec 2020 06:42:14 +0000 (17:42 +1100)]
MDL-69301 theme_boost: Remove the special handling of Escape key
Jake Dallimore [Thu, 10 Dec 2020 00:13:37 +0000 (08:13 +0800)]
Merge branch 'MDL-70320-310' of https://github.com/andrewnicols/moodle into MOODLE_310_STABLE
Andrew Nicols [Wed, 9 Dec 2020 23:53:56 +0000 (07:53 +0800)]
MDL-70320 behat: User full path to page admin node
Víctor Déniz [Wed, 9 Dec 2020 12:47:52 +0000 (12:47 +0000)]
Merge branch 'MDL-63683-310' of https://github.com/dravek/moodle into MOODLE_310_STABLE
Jake Dallimore [Wed, 9 Dec 2020 06:46:14 +0000 (14:46 +0800)]
Merge branch 'MDL-70151-310' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE
Shamim Rezaie [Wed, 9 Dec 2020 05:26:23 +0000 (16:26 +1100)]
MDL-69301 behat: comment a test out
The e.key is not filled correctly by Geckodriver on the verssion of
Firefox that we use.
Andrew Nicols [Wed, 9 Dec 2020 04:06:22 +0000 (12:06 +0800)]
Merge branch 'MDL-70320_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE
Andrew Nicols [Wed, 9 Dec 2020 00:53:27 +0000 (08:53 +0800)]
Merge branch 'MDL-62707-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE
Jake Dallimore [Tue, 8 Dec 2020 08:33:43 +0000 (16:33 +0800)]
Merge branch 'MDL-70285_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE
AMOS bot [Tue, 8 Dec 2020 00:07:22 +0000 (00:07 +0000)]
Automatically generated installer lang files
Adrian Greeve [Mon, 7 Dec 2020 01:29:24 +0000 (09:29 +0800)]
Merge branch 'MDL-69301-310' of git://github.com/rezaies/moodle into MOODLE_310_STABLE
AMOS bot [Sun, 6 Dec 2020 00:07:27 +0000 (00:07 +0000)]
Automatically generated installer lang files
Paul Holden [Tue, 4 Feb 2020 08:19:02 +0000 (08:19 +0000)]
MDL-62707 search: account for no matching courses when listing areas.
When limiting the list of courses during retrieval of the search areas
the user can access, make sure we have some contexts before looking
for blocks.
David Matamoros [Fri, 20 Nov 2020 16:09:37 +0000 (17:09 +0100)]
MDL-63683 enrol: Fix plugin settings when no role has student archetype
Jake Dallimore [Fri, 4 Dec 2020 00:42:48 +0000 (08:42 +0800)]
weekly release 3.10+
Jake Dallimore [Fri, 4 Dec 2020 00:42:45 +0000 (08:42 +0800)]
Merge branch 'install_310_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_310_STABLE
Jake Dallimore [Thu, 3 Dec 2020 03:54:18 +0000 (11:54 +0800)]
Merge branch 'MDL-70326-MOODLE_310_STABLE' of https://github.com/durzo/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 3 Dec 2020 03:51:59 +0000 (11:51 +0800)]
Merge branch 'MDL-70327-310' of git://github.com/cescobedo/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 3 Dec 2020 03:39:54 +0000 (11:39 +0800)]
Merge branch 'MDL-70321_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE
Jake Dallimore [Thu, 3 Dec 2020 03:37:00 +0000 (11:37 +0800)]
Merge branch 'MDL-69411-310' of git://github.com/dravek/moodle into MOODLE_310_STABLE
Jake Dallimore [Thu, 3 Dec 2020 03:16:31 +0000 (11:16 +0800)]
Merge branch 'MDL-67460-310_profile_secure' of https://github.com/beenet-dev/moodle into MOODLE_310_STABLE
Adrian Greeve [Thu, 3 Dec 2020 02:56:37 +0000 (10:56 +0800)]
Merge branch 'wip_MDL-70267_m310' of git://github.com/gjb2048/moodle into MOODLE_310_STABLE
Adrian Greeve [Thu, 3 Dec 2020 01:57:42 +0000 (09:57 +0800)]
Merge branch 'MDL-70167-310' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE
AMOS bot [Thu, 3 Dec 2020 00:07:26 +0000 (00:07 +0000)]
Automatically generated installer lang files
Andrew Nicols [Wed, 2 Dec 2020 23:47:48 +0000 (07:47 +0800)]
Merge branch 'MDL-69868-310' of git://github.com/ilya-catalyst/moodle into MOODLE_310_STABLE
Shamim Rezaie [Wed, 2 Dec 2020 17:18:01 +0000 (04:18 +1100)]
MDL-69301 theme_boost: Use event.key in aria.js
Both event.which and event.keyCode are deprecated. So
We switched to using event.key. We can only do so now
because IE is no longer supported.
Shamim Rezaie [Wed, 16 Sep 2020 16:43:18 +0000 (02:43 +1000)]
MDL-69301 course: Remove custom keyboard navigation code
Shamim Rezaie [Wed, 16 Sep 2020 15:12:54 +0000 (01:12 +1000)]
MDL-69301 core: Enhanced WAI-ARIA support for tab elements
Shamim Rezaie [Wed, 16 Sep 2020 13:25:36 +0000 (23:25 +1000)]
MDL-69301 theme_boost: convert aria.js to es6 module
Jake Dallimore [Wed, 2 Dec 2020 08:23:54 +0000 (16:23 +0800)]
Merge branch 'MDL-67514-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE
AMOS bot [Wed, 2 Dec 2020 00:07:23 +0000 (00:07 +0000)]
Automatically generated installer lang files
AMOS bot [Tue, 1 Dec 2020 00:07:30 +0000 (00:07 +0000)]
Automatically generated installer lang files
Gareth Barnard [Fri, 20 Nov 2020 16:22:01 +0000 (16:22 +0000)]
MDL-70267 ux, theme: Course user profile inconsistent page layout.
AMOS bot [Sun, 29 Nov 2020 00:07:31 +0000 (00:07 +0000)]
Automatically generated installer lang files
Sara Arjona [Fri, 27 Nov 2020 06:50:48 +0000 (07:50 +0100)]
weekly release 3.10+
Sara Arjona [Fri, 27 Nov 2020 06:50:45 +0000 (07:50 +0100)]
Merge branch 'install_310_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_310_STABLE
AMOS bot [Fri, 27 Nov 2020 06:21:03 +0000 (06:21 +0000)]
Automatically generated installer lang files
Sara Arjona [Thu, 26 Nov 2020 14:04:30 +0000 (15:04 +0100)]
Merge branch 'MDL-70276_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 26 Nov 2020 03:26:15 +0000 (11:26 +0800)]
MDL-70153 qtype_essay: Whitespace/behat fixes
Andrew Nicols [Thu, 26 Nov 2020 03:27:14 +0000 (11:27 +0800)]
Merge branch 'MDL-70153-310' of git://github.com/dpalou/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 26 Nov 2020 03:04:29 +0000 (11:04 +0800)]
Merge branch 'MDL-70237-310' of git://github.com/rezaies/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 26 Nov 2020 02:49:19 +0000 (10:49 +0800)]
Merge branch 'MDL-70242-310' of git://github.com/marinaglancy/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 26 Nov 2020 02:04:11 +0000 (10:04 +0800)]
Merge branch 'MDL-65852-310' of git://github.com/ilya-catalyst/moodle into MOODLE_310_STABLE
Sara Arjona [Wed, 25 Nov 2020 15:22:59 +0000 (16:22 +0100)]
Merge branch 'MDL-70248-310' of https://github.com/HuongNV13/moodle into MOODLE_310_STABLE
Sara Arjona [Wed, 25 Nov 2020 14:46:50 +0000 (15:46 +0100)]
Merge branch 'MDL-70265_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE
Ilya Tregubov [Thu, 26 Nov 2020 10:13:55 +0000 (12:13 +0200)]
MDL-69868 h5pactivity: Prevent breaking $USER when seeing
attempt report.
Eloy Lafuente (stronk7) [Sat, 21 Nov 2020 12:05:22 +0000 (13:05 +0100)]
MDL-70276 github actions: First cut, phpunit and grunt checks
First working version, supports phpunit (using build matrix):
- php72 (lowest), running mysql.
- php74 (highest), running postgres.
Also verifies that the branch has been "gruntified" and there
isn't any missing change (build js/css files).
TODO: Verify the remaining checks currently in .travis.yml, namely:
- CITEST
- Add caching
- Better health-check for DB images.
- Support from the tracker (satus badges and enable check).
- Support from CiBoT (status and enable check).
- Consider moving both the common setup (git, composer...)
and the database (mysql, postgres) to own actions for
easier tweaking.
Tim Hunt [Tue, 24 Nov 2020 17:20:12 +0000 (17:20 +0000)]
MDL-70320 permission overrides: role names were double-escaped
cescobedo [Wed, 25 Nov 2020 15:30:04 +0000 (16:30 +0100)]
MDL-70327 core_h5p: Add preventredirect to the player
Jordan Tomkinson [Wed, 25 Nov 2020 10:28:56 +0000 (11:28 +0100)]
MDL-70326 antivirus: fixing regression in MDL-66222
Ilya Tregubov [Fri, 13 Nov 2020 09:02:52 +0000 (11:02 +0200)]
MDL-65852 user: Fix permission check to download course participants.
Tim Hunt [Tue, 24 Nov 2020 15:26:32 +0000 (15:26 +0000)]
MDL-70321 question backup: fix MDL-47178 unit tests
They were failing if you had CodeRunner installed
Simon Mok [Tue, 24 Nov 2020 12:48:52 +0000 (20:48 +0800)]
MDL-67460 profile: User profile link to use HTTPS
Tim Hunt [Mon, 23 Nov 2020 20:45:46 +0000 (20:45 +0000)]
MDL-70285 completion upgrade: fix performance of the MDL-69687 code
David Matamoros [Sun, 22 Nov 2020 15:22:03 +0000 (16:22 +0100)]
MDL-69411 core_message: Fix return structure for empty result set
Passing a timefrom higher than last message timecreated needs to
return a formatted response so it does not break ws.
Eloy Lafuente (stronk7) [Mon, 23 Nov 2020 12:40:52 +0000 (13:40 +0100)]
MDL-70265 travis: Completely remove the UPGRADE check
It was broken since ages ago, see MDL-64874, so no sense
to keep it eating minutes for nothing.
Adrian Greeve [Mon, 23 Nov 2020 07:37:44 +0000 (15:37 +0800)]
Merge branch 'MDL-67668-310-2' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE
Jake Dallimore [Mon, 23 Nov 2020 07:22:49 +0000 (15:22 +0800)]
Merge branch 'MDL-70160-function-cache-310' of https://github.com/Peterburnett/moodle into MOODLE_310_STABLE
Andrew Nicols [Tue, 17 Dec 2019 02:44:32 +0000 (10:44 +0800)]
MDL-70151 assign: Fix bulk change for behat
Behat does not play well with confirmation dialogues and in some
situations it does not wait for the page to reload before starting the
next step.
This change adds a pending_js call which is only resolved if the cancel
button was pressed, otherwise it remains in-progress until the page
reloads resetting the entire state of it.
Andrew Nicols [Mon, 23 Nov 2020 01:00:13 +0000 (09:00 +0800)]
MDL-70167 behat: Rewrite attribute check steps
This commit updates the following steps to use the
`the_attribute_of_should_be_set` step under the hood:
- the [element] [type] should be disabled
- the [element] [type] should be enabled
- the [element] [type] should be readonly
- the [element] [type] should not be readonly
This reduces unnecssary code duplication.
Andrew Nicols [Tue, 23 Jun 2020 03:37:20 +0000 (11:37 +0800)]
MDL-70167 behat: Boolean attributes should either exist or not
Andrew Nicols [Wed, 17 Jun 2020 05:45:37 +0000 (13:45 +0800)]
MDL-67668 behat: Update tests for inplace editable field type
Andrew Nicols [Wed, 17 Jun 2020 05:45:15 +0000 (13:45 +0800)]
MDL-67668 behat: Add inplace editable field type
This commit promotes the Inplace Editable field to a first-class form
element by introducing a new partial selector for inplace editable
fields, and teaching the field manager how to recognise these, then
introducing a new field type which can handle setting values for this
field.
Andrew Nicols [Tue, 10 Nov 2020 07:10:30 +0000 (15:10 +0800)]
MDL-67668 behat: Share behat_behat functionality with forms
Behat form fields are implemented in a way completely isolated from the
rest of the Behat Context system. Whereas regular step definitions have
access to execute steps, to call `find`, check for JS running, and other
related functionality, the Moodle implementation of a field type does
not have any access to this.
By moving the core functionality of behat_base to a new trait, and the
constants to a new interface, the functionality can also be used in
behat form fields in the same way as elsewhere.
Andrew Nicols [Thu, 12 Nov 2020 00:17:34 +0000 (08:17 +0800)]
MDL-67668 behat: Correct js pending check
Pending checks should only run when JS is running, but some uses were
not apply this check.
Andrew Nicols [Thu, 12 Nov 2020 00:15:55 +0000 (08:15 +0800)]
MDL-67668 behat: Support NodeElement when fetching node in container
This is similar to change made in MDL-69136 to allow an already-fetched
NodeElement to be provided to the get_node_in_container() function and
makes it easier to be deterministic when writing steps.
Eloy Lafuente (stronk7) [Fri, 20 Nov 2020 15:20:18 +0000 (16:20 +0100)]
MDL-70265 travis: Only run highest phpunit if configured via env
By default only lowest php version will be executed, and only pgsql.
This default behavior can be changed with a new variable:
MOODLE_PHP = [all]
MOODLE_DATABASE = [pgsql | mysqli | all]
Eloy Lafuente (stronk7) [Fri, 20 Nov 2020 22:17:06 +0000 (23:17 +0100)]
weekly release 3.10+
Huong Nguyen [Wed, 18 Nov 2020 09:09:05 +0000 (16:09 +0700)]
MDL-70248 qtype_ddimageortext: Drop zones have UI issue in Editing form
Adrian Greeve [Thu, 19 Nov 2020 03:57:33 +0000 (11:57 +0800)]
Merge branch 'MOODLE_310_STABLE-MDL-67636' of https://github.com/yao9394/moodle into MOODLE_310_STABLE
John Yao [Thu, 19 Nov 2020 01:36:32 +0000 (12:36 +1100)]
MDL-67636 gradebook: Prevent exposing hidden grade in locked category
Adrian Greeve [Thu, 19 Nov 2020 03:10:48 +0000 (11:10 +0800)]
Merge branch 'MDL-56653-310' of git://github.com/lameze/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 19 Nov 2020 02:47:46 +0000 (10:47 +0800)]
Merge branch 'MDL-69809-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE
Jun Pataleta [Thu, 19 Nov 2020 01:36:53 +0000 (09:36 +0800)]
Merge branch 'MDL-70094-310' of https://github.com/SangNguyen2601/moodle into MOODLE_310_STABLE
Eloy Lafuente (stronk7) [Wed, 18 Nov 2020 22:00:18 +0000 (23:00 +0100)]
Merge branch 'MDL-69201-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE
Shamim Rezaie [Mon, 16 Nov 2020 10:37:45 +0000 (21:37 +1100)]
MDL-70237 payment: Allow html tags in gateway description
sangnguyen2601 [Mon, 9 Nov 2020 08:47:14 +0000 (15:47 +0700)]
MDL-70094 Question: Technical info section expands if click help icon
Dani Palou [Tue, 17 Nov 2020 09:31:32 +0000 (10:31 +0100)]
MDL-70153 qtype_essay: Add behat test for attachments max size
Dani Palou [Mon, 16 Nov 2020 14:20:34 +0000 (15:20 +0100)]
MDL-70153 qtype_essay: Fix max size displayed for attachments
Vitaly [Fri, 18 Sep 2020 18:45:26 +0000 (21:45 +0300)]
MDL-56653 enrol_meta: a single DB query in edit_instance_validation
The 'edit_instance_validation()' method checks for existing meta enrolment instances.
The fix replaces DB queries in a loop for each course with a single query for all courses.
Also, a new testing method 'test_edit_instance_validation_with_existing_courses()'
was added to /enrol/meta/tests/plugin_test.php to test if the new implementation
returns an error in case of trying to save the already linked courses in the 'customint1' field.
Andrew Nicols [Wed, 18 Nov 2020 01:33:06 +0000 (09:33 +0800)]
Merge branch '310_MDL-68896' of git://github.com/danmarsden/moodle into MOODLE_310_STABLE
Eloy Lafuente (stronk7) [Tue, 17 Nov 2020 22:13:17 +0000 (23:13 +0100)]
Merge branch 'MDL-70148-310' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE
Paul Holden [Wed, 17 Jun 2020 19:25:43 +0000 (20:25 +0100)]
MDL-67514 customfield: correct external usescategories return type.
Marina Glancy [Tue, 17 Nov 2020 15:47:12 +0000 (16:47 +0100)]
MDL-70242 auth_oauth2: set page context and url
Andrew Nicols [Mon, 9 Nov 2020 07:35:54 +0000 (15:35 +0800)]
MDL-70148 gradereport_grader: Improve reliability of keyboard usage
In some browsers the ajax grade select does not properly update the
grade after setting values. The previous solution was to press the
[enter] key, but doing this with the new key type step opens the select
box again. This is what happens when a real user presses enter on the
select.
This is the last possible field in the report, so pressing the tab key
to move to the next gradable element does not work.
The solution uses a shift-tab to move the focus away to the previous
gradale element. In this case it must also be moved to an earlier step
because the previously selected value must be checked in the Then
section of the test and if it is selected then its value cannot be
checked.
Andrew Nicols [Tue, 23 Jun 2020 03:09:58 +0000 (11:09 +0800)]
MDL-70148 qtype: Update qtype steps to new key interaction
Note: The ddmarker question type was previously getting the number of
keypresses wrong. This was because it was using both keyDown/keyUp, and
also keyPress. As a result each keypress was essentially happening two
times.
Andrew Nicols [Mon, 22 Jun 2020 02:39:57 +0000 (10:39 +0800)]
MDL-70148 behat: Update steps for keyboard
Andrew Nicols [Wed, 17 Jun 2020 06:50:04 +0000 (14:50 +0800)]
MDL-70148 behat: Add steps to send keys without an element
Andrew Nicols [Tue, 17 Nov 2020 06:55:10 +0000 (14:55 +0800)]
Merge branch 'MDL-69526-310' of git://github.com/lucaboesch/moodle into MOODLE_310_STABLE
Adrian Greeve [Tue, 17 Nov 2020 05:08:48 +0000 (13:08 +0800)]
Merge branch 'MDL-50955-310' of git://github.com/peterRd/moodle into MOODLE_310_STABLE
Andrew Nicols [Tue, 17 Nov 2020 02:22:38 +0000 (10:22 +0800)]
Merge branch 'MDL-69964-310' of git://github.com/paulholden/moodle into MOODLE_310_STABLE
Paul Holden [Wed, 21 Oct 2020 09:22:55 +0000 (10:22 +0100)]
MDL-69964 course: toggle participant checkboxes in root element.
For a given toggleGroup, the relevant action elements are not
necessarily descendants of the same tableRoot element, on the
course participants page.
Andrew Nicols [Mon, 16 Nov 2020 07:19:28 +0000 (15:19 +0800)]
MDL-67513 core: Only move modal to body if currently attached
A previous change as part of this commitset was intended to move the
modal to the document.body, but where the modal had been destroyed it
was instead added back to the body.
Peter Dias [Wed, 7 Oct 2020 02:55:25 +0000 (10:55 +0800)]
MDL-50955 core: Reset lessons completion criteria if grade type is none
Andrew Nicols [Mon, 16 Nov 2020 00:27:35 +0000 (08:27 +0800)]
Merge branch 'MDL-67513-m310' of https://github.com/NeillM/moodle into MOODLE_310_STABLE
Luca Bösch [Fri, 21 Aug 2020 14:03:18 +0000 (16:03 +0200)]
MDL-69526 block_myoverview: custom course fields natural sorting
Eloy Lafuente (stronk7) [Thu, 12 Nov 2020 21:11:40 +0000 (22:11 +0100)]
weekly release 3.10+