moodle.git
4 years agoMoodle release 3.10beta v3.10.0-beta
Eloy Lafuente (stronk7) [Tue, 27 Oct 2020 22:48:46 +0000 (23:48 +0100)]
Moodle release 3.10beta

4 years agoNOBUG: Fixed file access permissions
Eloy Lafuente (stronk7) [Tue, 27 Oct 2020 22:48:45 +0000 (23:48 +0100)]
NOBUG: Fixed file access permissions

4 years agoNOBUG: Fixed SVG browser compatibility
Eloy Lafuente (stronk7) [Tue, 27 Oct 2020 22:48:43 +0000 (23:48 +0100)]
NOBUG: Fixed SVG browser compatibility

4 years agoMDL-69166 enrol_fee: fix behat string from fee to enrolment by payment
Sara Arjona [Tue, 27 Oct 2020 13:37:25 +0000 (14:37 +0100)]
MDL-69166 enrol_fee: fix behat string from fee to enrolment by payment

4 years agoMDL-69166 enrol_fee: define default value to currency setting
Sara Arjona [Tue, 27 Oct 2020 11:58:02 +0000 (12:58 +0100)]
MDL-69166 enrol_fee: define default value to currency setting

4 years agoMerge branch 'MDL-69166-310-4' of git://github.com/rezaies/moodle into MOODLE_310_STABLE
Andrew Nicols [Tue, 27 Oct 2020 08:35:58 +0000 (16:35 +0800)]
Merge branch 'MDL-69166-310-4' of git://github.com/rezaies/moodle into MOODLE_310_STABLE

4 years agoMDL-69166 core: Fix missing lang strings
Shamim Rezaie [Tue, 27 Oct 2020 07:15:09 +0000 (18:15 +1100)]
MDL-69166 core: Fix missing lang strings

4 years agoMerge branch 'MDL-69166-310-4' of git://github.com/rezaies/moodle into MOODLE_310_STABLE
Andrew Nicols [Tue, 27 Oct 2020 04:59:25 +0000 (12:59 +0800)]
Merge branch 'MDL-69166-310-4' of git://github.com/rezaies/moodle into MOODLE_310_STABLE

4 years agoMDL-69166 core_payment: Add privacy implementation
Shamim Rezaie [Wed, 14 Oct 2020 06:38:14 +0000 (17:38 +1100)]
MDL-69166 core_payment: Add privacy implementation

4 years agoMDL-69166 core_payment: Use promises instead of callbacks
Shamim Rezaie [Sun, 18 Oct 2020 15:31:44 +0000 (02:31 +1100)]
MDL-69166 core_payment: Use promises instead of callbacks

4 years agoMDL-69166 core_payment: Addressing various integration points
Shamim Rezaie [Fri, 16 Oct 2020 17:43:25 +0000 (04:43 +1100)]
MDL-69166 core_payment: Addressing various integration points

- Add help for 'payment account' field in the enrol instance form
- Remove MOODLE_INTERNALs when not necessary
- Add $userid to deliver_order
- Check if provider classes implement the provider interface
- Rename get_cost to get_payable
- get_payable returns payable object
- Improve registerEventListeners and added init
- Rename payment\provider to payment\service_provider

4 years agoMDL-69166 core_payment: Rename componentid to itemid
Shamim Rezaie [Fri, 16 Oct 2020 18:05:54 +0000 (05:05 +1100)]
MDL-69166 core_payment: Rename componentid to itemid

4 years agoMDL-69166 core_payment: Renamed plugintype name from pg to paygw
Shamim Rezaie [Fri, 16 Oct 2020 15:45:36 +0000 (02:45 +1100)]
MDL-69166 core_payment: Renamed plugintype name from pg to paygw

4 years agoMDL-69166 core_payment: addressing integration review
Marina Glancy [Fri, 16 Oct 2020 14:46:12 +0000 (01:46 +1100)]
MDL-69166 core_payment: addressing integration review

4 years agoMDL-69166 core_payment: rename some functions
Marina Glancy [Wed, 7 Oct 2020 08:53:01 +0000 (19:53 +1100)]
MDL-69166 core_payment: rename some functions

4 years agoMDL-69166 Replace all upgrade steps with just "create_table" steps
Shamim Rezaie [Wed, 7 Oct 2020 10:56:13 +0000 (21:56 +1100)]
MDL-69166 Replace all upgrade steps with just "create_table" steps

4 years agoMDL-69166 core_payment: Add paymentarea to the payment subsystem
Shamim Rezaie [Fri, 2 Oct 2020 10:23:53 +0000 (20:23 +1000)]
MDL-69166 core_payment: Add paymentarea to the payment subsystem

4 years agoMDL-69166 core_payment: archiving accounts, triggering events, tests
Marina Glancy [Fri, 2 Oct 2020 06:01:56 +0000 (16:01 +1000)]
MDL-69166 core_payment: archiving accounts, triggering events, tests

4 years agoMDL-69166 core_payment: Show cost on the modal when no gateway is chosen
Shamim Rezaie [Thu, 1 Oct 2020 14:53:54 +0000 (00:53 +1000)]
MDL-69166 core_payment: Show cost on the modal when no gateway is chosen

4 years agoMDL-69166 core_payment: improvements to api, small fixes
Marina Glancy [Wed, 30 Sep 2020 17:21:30 +0000 (19:21 +0200)]
MDL-69166 core_payment: improvements to api, small fixes

4 years agoMDL-69166 core_payment: add payment accounts
Marina Glancy [Tue, 29 Sep 2020 17:27:37 +0000 (19:27 +0200)]
MDL-69166 core_payment: add payment accounts

4 years agoMDL-69166 enrol_fee: Show a warning when no currency is supported
Shamim Rezaie [Wed, 30 Sep 2020 03:24:43 +0000 (13:24 +1000)]
MDL-69166 enrol_fee: Show a warning when no currency is supported

4 years agoMDL-69166 enrol_fee: Prevent adding instance if no currency is supported
Shamim Rezaie [Wed, 30 Sep 2020 01:48:58 +0000 (11:48 +1000)]
MDL-69166 enrol_fee: Prevent adding instance if no currency is supported

4 years agoMDL-69166 pg_paypal: only prevent closing during autorisation
Shamim Rezaie [Tue, 29 Sep 2020 11:33:16 +0000 (21:33 +1000)]
MDL-69166 pg_paypal: only prevent closing during autorisation

4 years agoMDL-69166 core-payment: Autoselect gateway when there is only one
Shamim Rezaie [Tue, 29 Sep 2020 11:32:13 +0000 (21:32 +1000)]
MDL-69166 core-payment: Autoselect gateway when there is only one

4 years agoMDL-69166 core_payment: payment gateways can have a surcharge
Shamim Rezaie [Tue, 30 Jun 2020 07:37:50 +0000 (17:37 +1000)]
MDL-69166 core_payment: payment gateways can have a surcharge

4 years agoMDL-69166 core_payment: show cost on the modal
Shamim Rezaie [Tue, 30 Jun 2020 07:14:38 +0000 (17:14 +1000)]
MDL-69166 core_payment: show cost on the modal

4 years agoMDL-69166 pg_paypal: capture payment directly
Shamim Rezaie [Fri, 17 Jan 2020 16:20:41 +0000 (03:20 +1100)]
MDL-69166 pg_paypal: capture payment directly

4 years agoMDL-69166 pg_paypal: New helper to get order details from PayPal
Shamim Rezaie [Fri, 17 Jan 2020 16:08:02 +0000 (03:08 +1100)]
MDL-69166 pg_paypal: New helper to get order details from PayPal

4 years agoMDL-69166 core_form: allow modals to prevent closing on accidental click
Marina Glancy [Fri, 17 Jan 2020 13:25:53 +0000 (00:25 +1100)]
MDL-69166 core_form: allow modals to prevent closing on accidental click

4 years agoMDL-69166 core_payment: ES6-ifying modal_gateways
Shamim Rezaie [Wed, 15 Jan 2020 13:22:05 +0000 (00:22 +1100)]
MDL-69166 core_payment: ES6-ifying modal_gateways

4 years agoMDL-69166 core_payment: Use a custom modal type for gateway selector
Shamim Rezaie [Wed, 15 Jan 2020 11:48:26 +0000 (22:48 +1100)]
MDL-69166 core_payment: Use a custom modal type for gateway selector

4 years agoMDL-69166 pg_paypal: Support multiple currencies on the same page
Shamim Rezaie [Wed, 15 Jan 2020 04:58:32 +0000 (15:58 +1100)]
MDL-69166 pg_paypal: Support multiple currencies on the same page

4 years agoMDL-69166 enrol_fee: use template for payment btn & properly format cost
Shamim Rezaie [Mon, 13 Jan 2020 17:37:01 +0000 (04:37 +1100)]
MDL-69166 enrol_fee: use template for payment btn & properly format cost

4 years agoMDL-69166 core_payment: es6-ify
Shamim Rezaie [Sun, 12 Jan 2020 14:31:44 +0000 (01:31 +1100)]
MDL-69166 core_payment: es6-ify

4 years agoMDL-69166 core_payment: add a callback for when payment is done
Shamim Rezaie [Sat, 11 Jan 2020 19:28:34 +0000 (06:28 +1100)]
MDL-69166 core_payment: add a callback for when payment is done

4 years agoMDL-69166 pg_paypal: Display PayPal buttons in a modal
Shamim Rezaie [Fri, 10 Jan 2020 18:34:47 +0000 (05:34 +1100)]
MDL-69166 pg_paypal: Display PayPal buttons in a modal

4 years agoMDL-69166 pg_paypal: handle paypal checkout callbacks
Shamim Rezaie [Fri, 10 Jan 2020 08:30:07 +0000 (19:30 +1100)]
MDL-69166 pg_paypal: handle paypal checkout callbacks

4 years agoMDL-69166 pg_paypal: Ability to connect to sandbox or live environment
Shamim Rezaie [Fri, 10 Jan 2020 07:59:58 +0000 (18:59 +1100)]
MDL-69166 pg_paypal: Ability to connect to sandbox or live environment

4 years agoMDL-69166 pg_paypal: Process after payment
Shamim Rezaie [Wed, 8 Jan 2020 17:06:44 +0000 (04:06 +1100)]
MDL-69166 pg_paypal: Process after payment

4 years agoMDL-69166 core_payment: Save general payment information
Shamim Rezaie [Wed, 8 Jan 2020 16:45:51 +0000 (03:45 +1100)]
MDL-69166 core_payment: Save general payment information

4 years agoMDL-69166 pg_paypal: paypal helper class to work with API
Shamim Rezaie [Wed, 8 Jan 2020 15:57:11 +0000 (02:57 +1100)]
MDL-69166 pg_paypal: paypal helper class to work with API

4 years agoMDL-69166 enrol_fee: Implement callback functions for payment subsystem
Shamim Rezaie [Wed, 8 Jan 2020 14:43:51 +0000 (01:43 +1100)]
MDL-69166 enrol_fee: Implement callback functions for payment subsystem

4 years agoMDL-69166 core_payment: helper methods to get cost and to deliver order
Shamim Rezaie [Wed, 8 Jan 2020 14:41:12 +0000 (01:41 +1100)]
MDL-69166 core_payment: helper methods to get cost and to deliver order

Also create the infrastructure to let components know when they have to
deliver what they sold. We are going to use namespace functions instead
of traditional callbacks.

4 years agoMDL-69166 enrol_fee: set a description for enrolment
Shamim Rezaie [Mon, 6 Jan 2020 08:48:08 +0000 (19:48 +1100)]
MDL-69166 enrol_fee: set a description for enrolment

4 years agoMDL-69166 core_payment: send a purchase description to payment gateways
Shamim Rezaie [Mon, 6 Jan 2020 08:54:31 +0000 (19:54 +1100)]
MDL-69166 core_payment: send a purchase description to payment gateways

We truncate description to 127 chars as per PayPal requirement

4 years agoMDL-69166 pg_paypal: render PayPal buttons and set up transaction
Shamim Rezaie [Fri, 3 Jan 2020 09:07:51 +0000 (20:07 +1100)]
MDL-69166 pg_paypal: render PayPal buttons and set up transaction

We truncate brand_name to 127 chars as per PayPal requirement.

4 years agoMDL-69166 pg_paypal: WS and AMD to return some settings to be used in js
Shamim Rezaie [Tue, 29 Sep 2020 11:21:33 +0000 (21:21 +1000)]
MDL-69166 pg_paypal: WS and AMD to return some settings to be used in js

4 years agoMDL-69166 core_payment: post to process payment
Shamim Rezaie [Fri, 27 Dec 2019 13:19:21 +0000 (00:19 +1100)]
MDL-69166 core_payment: post to process payment

4 years agoMDL-69166 core_payment: display an image for each gateway
Shamim Rezaie [Mon, 29 Jun 2020 20:34:14 +0000 (06:34 +1000)]
MDL-69166 core_payment: display an image for each gateway

4 years agoMDL-69166 core_payment: some basic styling
Shamim Rezaie [Fri, 27 Dec 2019 01:00:06 +0000 (12:00 +1100)]
MDL-69166 core_payment: some basic styling

4 years agoMDL-69166 core_payment: display the gateways modal
Shamim Rezaie [Wed, 29 Jan 2020 08:11:37 +0000 (19:11 +1100)]
MDL-69166 core_payment: display the gateways modal

4 years agoMDL-69166 core_payment: WS to get list of gateways supporting a currency
Shamim Rezaie [Wed, 29 Jan 2020 08:09:53 +0000 (19:09 +1100)]
MDL-69166 core_payment: WS to get list of gateways supporting a currency

4 years agoMDL-69166 enrol_fee: An enrolment plugin that supports payments
Shamim Rezaie [Mon, 16 Dec 2019 12:14:14 +0000 (23:14 +1100)]
MDL-69166 enrol_fee: An enrolment plugin that supports payments

4 years agoMDL-69166 pg_paypal: A new payment gateway is born
Shamim Rezaie [Mon, 16 Dec 2019 12:14:51 +0000 (23:14 +1100)]
MDL-69166 pg_paypal: A new payment gateway is born

4 years agoMDL-69166 core: list settings page in the admin tree
Shamim Rezaie [Mon, 16 Dec 2019 12:58:11 +0000 (23:58 +1100)]
MDL-69166 core: list settings page in the admin tree

4 years agoMDL-69166 core_payment: basic gateway skeleton
Shamim Rezaie [Mon, 16 Dec 2019 14:21:47 +0000 (01:21 +1100)]
MDL-69166 core_payment: basic gateway skeleton

4 years agoMDL-69166 core: define payment as a subsystem and pg as a plugin type
Shamim Rezaie [Mon, 16 Dec 2019 13:23:26 +0000 (00:23 +1100)]
MDL-69166 core: define payment as a subsystem and pg as a plugin type

4 years agoMDL-69559 course: Fix course download cap checks when creating courses
Michael Hawkins [Tue, 27 Oct 2020 03:40:46 +0000 (11:40 +0800)]
MDL-69559 course: Fix course download cap checks when creating courses

4 years agoMDL-69559 core: Removed stopPropagation from tree click handling
Michael Hawkins [Mon, 26 Oct 2020 09:17:24 +0000 (17:17 +0800)]
MDL-69559 core: Removed stopPropagation from tree click handling

It was preventing JS click event handlers being reached on some
elements, such as course admin items in Classic
(eg download course content for teachers).

4 years agoMDL-69559 course: Fixed behat navigation in download course content
Michael Hawkins [Mon, 26 Oct 2020 08:35:20 +0000 (16:35 +0800)]
MDL-69559 course: Fixed behat navigation in download course content

4 years agoMDL-65959 core_badges: fix unique index in upgrade.php
Sara Arjona [Mon, 26 Oct 2020 22:32:10 +0000 (23:32 +0100)]
MDL-65959 core_badges: fix unique index in upgrade.php

There was an error when creating the unique index. Apart from that,
the code has been reorganised to copy data in the new structure only
if password field hasn't been removed.

4 years agoMerge branch 'MDL-65959-310' of git://github.com/peterRd/moodle into MOODLE_310_STABLE
Sara Arjona [Mon, 26 Oct 2020 21:44:05 +0000 (22:44 +0100)]
Merge branch 'MDL-65959-310' of git://github.com/peterRd/moodle into MOODLE_310_STABLE

4 years agoMDL-65959 badges: Allow cross domain/protocol functionality - obv2
Peter Dias [Thu, 24 Sep 2020 06:13:23 +0000 (14:13 +0800)]
MDL-65959 badges: Allow cross domain/protocol functionality - obv2

4 years agoMDL-65959 badge: Enable OB2.1 *connection* with cross domain ability
Peter Dias [Thu, 24 Sep 2020 03:03:55 +0000 (11:03 +0800)]
MDL-65959 badge: Enable OB2.1 *connection* with cross domain ability

4 years agoMDL-65959 badge: Reset external_identifiers if backpack details modified
Peter Dias [Mon, 21 Sep 2020 06:28:28 +0000 (14:28 +0800)]
MDL-65959 badge: Reset external_identifiers if backpack details modified

4 years agoMDL-65959 badge: Confirm assertion data is updated before awarding
Peter Dias [Thu, 27 Aug 2020 05:21:25 +0000 (13:21 +0800)]
MDL-65959 badge: Confirm assertion data is updated before awarding

4 years agoMDL-65959 badges: Unit and Behat tests
Peter Dias [Thu, 16 Jul 2020 12:23:02 +0000 (20:23 +0800)]
MDL-65959 badges: Unit and Behat tests

4 years agoMDL-65959 badges: Do not use badge user preference after verification
Peter Dias [Thu, 7 May 2020 00:40:05 +0000 (08:40 +0800)]
MDL-65959 badges: Do not use badge user preference after verification

4 years agoMDL-65959 badges: Update the implementation to use admin set backpack
Peter Dias [Fri, 28 Feb 2020 05:00:15 +0000 (13:00 +0800)]
MDL-65959 badges: Update the implementation to use admin set backpack

4 years agoMDL-65959 core_badges: Allow ability to upload badges cross domain.
Peter [Wed, 2 Oct 2019 04:28:45 +0000 (12:28 +0800)]
MDL-65959 core_badges: Allow ability to upload badges cross domain.

4 years agoMDL-65959 core_badges: Unrestricted user's badger account
Peter [Wed, 25 Sep 2019 04:38:53 +0000 (12:38 +0800)]
MDL-65959 core_badges: Unrestricted user's badger account

* Restructure the email to be backpack specific
* Amended table defintion and functions

4 years agoMerge branch 'MDL-69993-310' of git://github.com/paulholden/moodle into MOODLE_310_STABLE
Eloy Lafuente (stronk7) [Mon, 26 Oct 2020 09:42:51 +0000 (10:42 +0100)]
Merge branch 'MDL-69993-310' of git://github.com/paulholden/moodle into MOODLE_310_STABLE

4 years agoMerge branch 'MDL-69995-310' of git://github.com/lucaboesch/moodle into MOODLE_310_STABLE
Andrew Nicols [Mon, 26 Oct 2020 08:00:38 +0000 (16:00 +0800)]
Merge branch 'MDL-69995-310' of git://github.com/lucaboesch/moodle into MOODLE_310_STABLE

4 years agoMDL-69559 core_course: Fix to bad behat test formatting.
Adrian Greeve [Mon, 26 Oct 2020 05:28:10 +0000 (13:28 +0800)]
MDL-69559 core_course: Fix to bad behat test formatting.

4 years agoMerge branch 'MDL-69559-310-7' of git://github.com/mickhawkins/moodle into MOODLE_310...
Adrian Greeve [Mon, 26 Oct 2020 05:05:33 +0000 (13:05 +0800)]
Merge branch 'MDL-69559-310-7' of git://github.com/mickhawkins/moodle into MOODLE_310_STABLE

4 years agoMerge branch 'MDL-67301-dynreg-squashed-310' of https://github.com/cengage/moodle...
Jun Pataleta [Mon, 26 Oct 2020 04:40:23 +0000 (12:40 +0800)]
Merge branch 'MDL-67301-dynreg-squashed-310' of https://github.com/cengage/moodle into MOODLE_310_STABLE

4 years agoMDL-69559 course: Add course setting and cap to control course downloads
Michael Hawkins [Fri, 18 Sep 2020 10:52:13 +0000 (18:52 +0800)]
MDL-69559 course: Add course setting and cap to control course downloads

4 years agoMDL-69559 course: Add course content download UI and execution page
Michael Hawkins [Thu, 3 Sep 2020 05:55:30 +0000 (13:55 +0800)]
MDL-69559 course: Add course content download UI and execution page

4 years agoMDL-69559 course: Add capability and access checks for course download
Michael Hawkins [Thu, 3 Sep 2020 05:53:41 +0000 (13:53 +0800)]
MDL-69559 course: Add capability and access checks for course download

4 years agoMDL-69559 admin: Add course download admin settings and lang strings
Michael Hawkins [Wed, 2 Sep 2020 04:17:42 +0000 (12:17 +0800)]
MDL-69559 admin: Add course download admin settings and lang strings

4 years agoMDL-69995 backup: padding before activity icons.
Luca Bösch [Wed, 21 Oct 2020 21:24:42 +0000 (23:24 +0200)]
MDL-69995 backup: padding before activity icons.

4 years agoMDL-67301 mod_lti: dynamic registration
Claude Vervoort [Thu, 6 Feb 2020 15:48:11 +0000 (10:48 -0500)]
MDL-67301 mod_lti: dynamic registration

4 years agoon-demand release 3.10dev+
Eloy Lafuente (stronk7) [Fri, 23 Oct 2020 12:41:20 +0000 (14:41 +0200)]
on-demand release 3.10dev+

4 years agoMDL-69993 output: correct navigation node type for user reports.
Paul Holden [Fri, 23 Oct 2020 07:04:44 +0000 (08:04 +0100)]
MDL-69993 output: correct navigation node type for user reports.

4 years agoMerge branch 'MDL-67650-forced-checkbox-textarea-MOODLE_310_STABLE' of https://github...
Adrian Greeve [Fri, 23 Oct 2020 01:01:59 +0000 (09:01 +0800)]
Merge branch 'MDL-67650-forced-checkbox-textarea-MOODLE_310_STABLE' of https://github.com/brendanheywood/moodle into MOODLE_310_STABLE

4 years agoMerge branch 'MDL-68664-310' of git://github.com/lameze/moodle into MOODLE_310_STABLE
Víctor Déniz [Thu, 22 Oct 2020 11:25:51 +0000 (12:25 +0100)]
Merge branch 'MDL-68664-310' of git://github.com/lameze/moodle into MOODLE_310_STABLE

4 years agoMerge branch 'MDL-69553-m310' of https://github.com/NeillM/moodle into MOODLE_310_STABLE
Sara Arjona [Thu, 22 Oct 2020 06:56:05 +0000 (08:56 +0200)]
Merge branch 'MDL-69553-m310' of https://github.com/NeillM/moodle into MOODLE_310_STABLE

4 years agoMDL-67650 admin: Consistently show forced config settings
Brendan Heywood [Tue, 18 Feb 2020 12:42:58 +0000 (23:42 +1100)]
MDL-67650 admin: Consistently show forced config settings

4 years agoMerge branch 'MDL-68438_310' of https://github.com/t-schroeder/moodle into MOODLE_310...
Jake Dallimore [Thu, 22 Oct 2020 01:30:48 +0000 (09:30 +0800)]
Merge branch 'MDL-68438_310' of https://github.com/t-schroeder/moodle into MOODLE_310_STABLE

4 years agoMerge branch 'MDL-69788-310' of https://github.com/paulholden/moodle into MOODLE_310_...
Adrian Greeve [Thu, 22 Oct 2020 01:07:54 +0000 (09:07 +0800)]
Merge branch 'MDL-69788-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE

4 years agoMerge branch 'MDL-66392-310' of https://github.com/paulholden/moodle into MOODLE_310_...
Eloy Lafuente (stronk7) [Wed, 21 Oct 2020 17:45:26 +0000 (19:45 +0200)]
Merge branch 'MDL-66392-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE

4 years agoMDL-66392 analytics: make model output directory default to empty.
Paul Holden [Tue, 29 Sep 2020 07:57:56 +0000 (08:57 +0100)]
MDL-66392 analytics: make model output directory default to empty.

Falling back to path within $CFG->dataroot/models.

4 years agoMerge branch 'm310_MDL-68536_Notice_Undefined_Property_CFG_branch' of https://github...
Sara Arjona [Wed, 21 Oct 2020 16:32:47 +0000 (18:32 +0200)]
Merge branch 'm310_MDL-68536_Notice_Undefined_Property_CFG_branch' of https://github.com/scara/moodle into MOODLE_310_STABLE

4 years agoMerge branch 'MDL-67673_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE
Sara Arjona [Wed, 21 Oct 2020 15:38:16 +0000 (17:38 +0200)]
Merge branch 'MDL-67673_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE

4 years agoMerge branch 'MDL-69392-310' of git://github.com/junpataleta/moodle into MOODLE_310_S...
Víctor Déniz [Wed, 21 Oct 2020 15:26:44 +0000 (16:26 +0100)]
Merge branch 'MDL-69392-310' of git://github.com/junpataleta/moodle into MOODLE_310_STABLE

4 years agoMerge branch 'MDL-69513-dkim-settings-MOODLE_310_STABLE' of https://github.com/brenda...
Víctor Déniz [Wed, 21 Oct 2020 10:32:33 +0000 (11:32 +0100)]
Merge branch 'MDL-69513-dkim-settings-MOODLE_310_STABLE' of https://github.com/brendanheywood/moodle into MOODLE_310_STABLE

4 years agoMDL-67673 phpunit: Document all the changes in upgrade.txt
Eloy Lafuente (stronk7) [Wed, 7 Oct 2020 19:33:38 +0000 (21:33 +0200)]
MDL-67673 phpunit: Document all the changes in upgrade.txt

This includes:

- Breaking changes (return void + PHP 7.1 min requirement).
- Deprecations and removals.
- Specifically DbUnit and its replacement.
- Printer showing how to rerun tests removed.

4 years agoMDL-67673 phpunit: Remove the rerun hint on failed test cases
Eloy Lafuente (stronk7) [Wed, 7 Oct 2020 18:41:44 +0000 (20:41 +0200)]
MDL-67673 phpunit: Remove the rerun hint on failed test cases

That custom printer was using some hacks to be able to intercept
configuration switches, reflection and other tricks to be able to
print the:

To re-run:
 vendor/bin/phpunit --verbose "core_setuplib_testcase" lib/tests/setuplib_test.php

line on every failed/exceptional/skipped test. After some internal
discussion it was agreed that the normal phpunit output:

1) core_setuplib_testcase::test_localcachedir
Time is lower that allowed start value
Failed asserting that 1601976686 is equal to 1601976687 or is greater than 1601976687.

/var/www/html/lib/phpunit/classes/advanced_testcase.php:446
/var/www/html/lib/tests/setuplib_test.php:170
/var/www/html/lib/phpunit/classes/advanced_testcase.php:80

has already all the information at hand about how to rerun a test:

- vendor/bin/phpunit lib/tests/setuplib_test.php
- vendor/bin/phpunit --filter core_setuplib_testcase::test_localcachedir
- vendor/bin/phpunit --filter ::test_localcachedir
- vendor/bin/phpunit --testsuite componentname_testsuite
- vendor/bin/phpunit --config <<compoenent directory>>
- use --cache-result to get failed tests rerun with ease.
- ...

So better, let's use standard phpunit output and done. Also, note that,
with the upgrade to phpunit 8.5, the printer was not working correctly
any more, causing some switches, like --verbose ... to be ignored. Sure
it could have been fixed but, as commented above, no real need for all
that "parapheranlia" to print the rerun information.

4 years agoMDL-67673 phpunit: deprecate old phpunit/dbunit stuff
Eloy Lafuente (stronk7) [Wed, 7 Oct 2020 10:02:19 +0000 (12:02 +0200)]
MDL-67673 phpunit: deprecate old phpunit/dbunit stuff

Apply the standard deprecation procedure to the old APIs, to
be removed in Moodle 4.2 (MDL-69882). Existing unit tests
cover the deprecation debugging.

Originally MDL-64600