Andrew Nicols [Tue, 23 Mar 2021 00:03:36 +0000 (08:03 +0800)]
MDL-69256 tests: Fix random slow test failures in completion cron
Sara Arjona [Thu, 11 Mar 2021 16:18:40 +0000 (17:18 +0100)]
weekly release 4.0dev
Sara Arjona [Thu, 11 Mar 2021 16:18:36 +0000 (17:18 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Jun Pataleta [Thu, 11 Mar 2021 09:41:46 +0000 (17:41 +0800)]
Merge branch 'MDL-70911-master' of git://github.com/sarjona/moodle
Sara Arjona [Thu, 11 Mar 2021 07:58:29 +0000 (08:58 +0100)]
MDL-70911 core_badges: Add navigation menu in classic
Manage backpacks page wasn't displaying the navigation and administration
menus when using classic theme (it's unrelated to changes done here).
This patch fixes this unexpected behaviour (raised thanks to behat tests).
Adrian Greeve [Thu, 11 Mar 2021 03:46:34 +0000 (11:46 +0800)]
Merge branch 'MDL-66025' of git://github.com/paulholden/moodle
Adrian Greeve [Thu, 11 Mar 2021 03:04:23 +0000 (11:04 +0800)]
Merge branch 'MDL-71026-master' of git://github.com/ilyatregubov/moodle
Eloy Lafuente (stronk7) [Wed, 10 Mar 2021 23:11:15 +0000 (00:11 +0100)]
Merge branch 'MDL-70726-master' of https://github.com/NashTechOpenUniversity/moodle
Eloy Lafuente (stronk7) [Wed, 10 Mar 2021 22:52:16 +0000 (23:52 +0100)]
Merge branch 'MDL-70789' of git://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Wed, 10 Mar 2021 22:39:44 +0000 (23:39 +0100)]
Merge branch 'MDL-70891-master' of git://github.com/marinaglancy/moodle
Eloy Lafuente (stronk7) [Wed, 10 Mar 2021 22:39:25 +0000 (23:39 +0100)]
Merge branch 'MDL-70967-master' of git://github.com/marinaglancy/moodle
Sara Arjona [Wed, 10 Mar 2021 19:48:44 +0000 (20:48 +0100)]
Merge branch 'MDL-70287-master-3' of git://github.com/rezaies/moodle
Jun Pataleta [Wed, 10 Mar 2021 14:28:05 +0000 (22:28 +0800)]
MDL-70815 completion: Cast custom data to array
Since cm_info::customdata can be of any type, we need to cast it to an
array first before checking for custom completion rules. Otherwise,
an exception can be thrown (e.g. customdata has been set as an stdClass)
Jun Pataleta [Wed, 10 Mar 2021 15:39:30 +0000 (23:39 +0800)]
Merge branch 'MDL-45242-master' of https://github.com/sammarshallou/moodle
sam marshall [Wed, 21 Oct 2020 17:44:10 +0000 (18:44 +0100)]
MDL-45242 Course: Enrol feature supports custom profile fields
sam marshall [Tue, 20 Oct 2020 16:55:35 +0000 (17:55 +0100)]
MDL-45242 Course: Participants list supports custom profile fields
sam marshall [Tue, 20 Oct 2020 11:09:43 +0000 (12:09 +0100)]
MDL-45242 Admin: User list supports custom profile fields
sam marshall [Mon, 12 Oct 2020 16:51:20 +0000 (17:51 +0100)]
MDL-45242 Lib: Replace calls to deprecated functions
In all cases changes have been kept to a minimum while not making
the code completely horrible. For example, there are many instances
where it would probably be better to rewrite a query entirely, but
I have not done that (in order to reduce the risk of changes).
Jun Pataleta [Wed, 10 Mar 2021 08:15:43 +0000 (16:15 +0800)]
Merge branch 'MDL-70911-master' of git://github.com/sarjona/moodle
Sara Arjona [Wed, 17 Feb 2021 15:33:20 +0000 (16:33 +0100)]
MDL-70911 core_badges: Remove $CFG->badges_site_backpack
The $CFG->badges_site_backpack setting has been completely removed
because it's not required anymore. From now, the primary site
backpack will be the first one in the "Manage backpacks" list (so,
the one with lower sortorder value).
Sara Arjona [Wed, 17 Feb 2021 11:22:00 +0000 (12:22 +0100)]
MDL-70911 core_badges: Add support to backpacks sortorder
Before removing $CFG->badges_site_backpack setting, admins should be
able to re-order the existing site-backpacks (because then, the first
one will be treated as the default one).
This patch adds the sort order feature to the backpack list.
AMOS bot [Wed, 10 Mar 2021 00:07:42 +0000 (00:07 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Tue, 9 Mar 2021 23:19:31 +0000 (00:19 +0100)]
Merge branch 'MDL-63961-master' of git://github.com/sarjona/moodle
Sara Arjona [Tue, 9 Mar 2021 15:42:52 +0000 (16:42 +0100)]
Merge branch 'MDL-70608-master-langimportasync' of git://github.com/mudrd8mz/moodle
Sara Arjona [Tue, 9 Mar 2021 14:18:28 +0000 (15:18 +0100)]
Merge branch 'MDL-70815-master-6' of git://github.com/junpataleta/moodle
Sara Arjona [Tue, 9 Mar 2021 13:56:57 +0000 (14:56 +0100)]
Merge branch 'MDL-70855-master' of https://github.com/dmitriim/moodle
Jun Pataleta [Tue, 9 Mar 2021 12:14:46 +0000 (20:14 +0800)]
MDL-70815 completion: Test internal_get_state() with custom completion
Use the custom completion implementation for mod_choice to test
completion_info::get_state() to cover the case where the completion
state is being determined from the custom completion condition.
Jun Pataleta [Mon, 15 Feb 2021 18:20:45 +0000 (02:20 +0800)]
MDL-70815 mod_choice: Unit tests for the custom completion class
Jun Pataleta [Wed, 10 Feb 2021 02:37:06 +0000 (10:37 +0800)]
MDL-70815 mod_choice: Custom completion implementation
Jun Pataleta [Wed, 10 Feb 2021 03:05:42 +0000 (11:05 +0800)]
MDL-70815 core_completion: Update completion_info
* Update completion_info::get_data() to add other completion
information from a new method called get_other_cm_completion_data().
This allows the storage of the completion statuses of the following
completion rules to completion_info objects:
- 'Students must receive a grade' completion rule.
- Any custom completion rule defined by an activity.
This allows detailed completion information to be fetched for course
modules.
It also allows custom completion statuses to be cached which will help
reduce DB queries when fetching completion statuses.
* Update update_state() to fetch overall completion state from the
module's activity_custom_completion implementation. Falls back to the
*_get_completion_state() callback function.
* Update internal_set_data() to include the other cm completion data
in the updated cache data for the module instance.
Jun Pataleta [Wed, 10 Feb 2021 02:57:42 +0000 (10:57 +0800)]
MDL-70815 core_completion: completion_info::get_grade_completion()
Move the current logic for determining the completion status for the
"Student must receive grade" completion rule to a function so it cann
be reused.
Unit test included.
Jun Pataleta [Thu, 11 Feb 2021 01:39:36 +0000 (09:39 +0800)]
MDL-70815 core_completion: Fix unit tests
* Unit tests for completion_info::get_data() and
completion_info::internal_get_state are mocked which causes failures
with the new implementation. It's more straightforward and realistic
to generate real course and modules to test these methods.
Jun Pataleta [Sat, 13 Feb 2021 14:45:33 +0000 (22:45 +0800)]
MDL-70815 core_completion: Unit tests for activity_custom_completion
Tests cover
- get_overall_completion_state()
- is_available()
- validate_rule()
Tests don't cover
- methods that rely on static methods such as:
- is_defined()
- static methods in the class because they can't be mocked
- abstract methods that can be tested better by the plugins
that extend activity_custom_completion such as:
- get_state()
- get_defined_custom_rules()
- get_custom_rule_descriptions()
Jun Pataleta [Tue, 16 Feb 2021 02:04:41 +0000 (10:04 +0800)]
MDL-70815 core_completion: Activity custom completion details base class
* Base class for defining an activity module's custom completion details
Sara Arjona [Mon, 8 Mar 2021 10:39:13 +0000 (11:39 +0100)]
Merge branch 'MDL-70766-auth-config-log' of https://github.com/brendanheywood/moodle
sam marshall [Mon, 12 Oct 2020 16:33:17 +0000 (17:33 +0100)]
MDL-45242 Lib: Replace direct references to ->showuseridentity
sam marshall [Mon, 12 Oct 2020 14:18:31 +0000 (15:18 +0100)]
MDL-45242 Lib: Deprecate field-related library functions
sam marshall [Mon, 12 Oct 2020 14:24:07 +0000 (15:24 +0100)]
MDL-45242 Lib: Allow custom profile fields in showuseridentity
sam marshall [Wed, 30 Sep 2020 15:21:47 +0000 (16:21 +0100)]
MDL-45242 Testing: Generators for user profile fields
sam marshall [Wed, 30 Sep 2020 13:05:43 +0000 (14:05 +0100)]
MDL-45242 Admin: Added lazy-loading callback to multicheckbox
Currently admin_setting_configselect has lazy-loading support via a
callback function (so you don't have to make pointless single-use
classes for each unusual setting), but this is not present in other
similar types.
This commit adds identical support to
admin_setting_configmulticheckbox.
Sara Arjona [Tue, 16 Feb 2021 09:45:25 +0000 (10:45 +0100)]
MDL-70911 core_badges: Move "External backpack" to badges settings
Setting "External backpack connection" has been moved from "Backpack
settings" to "Badges settings" in order to make easier to find and
configure it.
Some extra tests have been added to cover existing behaviour and
confirm is still working as expected.
AMOS bot [Sun, 7 Mar 2021 00:07:46 +0000 (00:07 +0000)]
Automatically generated installer lang files
AMOS bot [Sat, 6 Mar 2021 00:07:51 +0000 (00:07 +0000)]
Automatically generated installer lang files
Sara Arjona [Fri, 5 Mar 2021 15:01:32 +0000 (16:01 +0100)]
weekly release 4.0dev
Sara Arjona [Fri, 5 Mar 2021 15:01:30 +0000 (16:01 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Amaia Anabitarte [Fri, 5 Feb 2021 16:36:24 +0000 (17:36 +0100)]
MDL-70726 behat: Fixing existing fail tests
Some of the current behat tests were wrong but not failing because of the bug in 'should not exist' step.
Once the bug is fixed, we must fix also wrong behats.
Ilya Tregubov [Thu, 4 Mar 2021 10:45:06 +0000 (12:45 +0200)]
MDL-69680 lib: Fix behat test backup_and_restore.feature
Ilya Tregubov [Tue, 16 Feb 2021 07:31:41 +0000 (09:31 +0200)]
MDL-69680 lib: Replace deprecated jQuery functions
Ilya Tregubov [Fri, 12 Feb 2021 07:39:18 +0000 (09:39 +0200)]
MDL-69680 lib: Update jQuery version in Moodle files
Ilya Tregubov [Fri, 12 Feb 2021 07:29:08 +0000 (09:29 +0200)]
MDL-69680 lib: Upgrade jQuery lib to 3.5.1
Eloy Lafuente (stronk7) [Wed, 3 Mar 2021 23:27:53 +0000 (00:27 +0100)]
Merge branch 'MDL-70424-auth-avoid-changes' of https://github.com/brendanheywood/moodle
Ilya Tregubov [Tue, 2 Mar 2021 13:59:43 +0000 (15:59 +0200)]
MDL-70767 feedback: Prevent xss in feedback answer text.
Sara Arjona [Wed, 3 Mar 2021 16:51:16 +0000 (17:51 +0100)]
Merge branch 'MDL-68721-master' of git://github.com/ferranrecio/moodle
Ferran Recio [Thu, 14 Jan 2021 15:03:33 +0000 (16:03 +0100)]
MDL-68721 mod_h5pactivity: report acceptance tests
Paul Holden [Wed, 3 Mar 2021 13:36:11 +0000 (13:36 +0000)]
MDL-65552 block_activity_results: correct Behat tests for idnumbers.
Teachers can see user idnumber fields only when they are configured
identity fields. Students cannot.
Marina Glancy [Mon, 1 Mar 2021 18:14:35 +0000 (19:14 +0100)]
MDL-65552 user: escape idnumber and email in table_sql
Paul Holden [Mon, 1 Mar 2021 14:20:02 +0000 (14:20 +0000)]
MDL-65552 user: escape idnumber field on output.
This commit also corrects parameter definition of the field to
match core_user.
Sara Arjona [Wed, 3 Mar 2021 14:47:16 +0000 (15:47 +0100)]
Merge branch 'MDL-70125_master-3' of git://github.com/mdjnelson/moodle
Sara Arjona [Wed, 3 Mar 2021 14:24:44 +0000 (15:24 +0100)]
Merge branch 'MDL-70921-master' of git://github.com/marinaglancy/moodle
Sara Arjona [Wed, 3 Mar 2021 10:45:28 +0000 (11:45 +0100)]
Merge branch 'MDL-67494-master' of git://github.com/lameze/moodle
Sara Arjona [Wed, 3 Mar 2021 10:11:29 +0000 (11:11 +0100)]
Merge branch 'MDL-67119-master' of git://github.com/aanabit/moodle
Ilya Tregubov [Wed, 3 Mar 2021 09:11:23 +0000 (11:11 +0200)]
MDL-71026 user: Fix incorrect get_string call.
Jun Pataleta [Wed, 3 Mar 2021 08:42:18 +0000 (16:42 +0800)]
Merge branch 'MDL-70987-master' of git://github.com/andrewnicols/moodle
Sara Arjona [Wed, 3 Mar 2021 08:30:41 +0000 (09:30 +0100)]
Merge branch 'MDL-70966-master' of git://github.com/marinaglancy/moodle
Jun Pataleta [Wed, 3 Mar 2021 08:22:50 +0000 (16:22 +0800)]
Merge branch 'MDL-71009' of https://github.com/timhunt/moodle
Sara Arjona [Wed, 3 Mar 2021 08:06:45 +0000 (09:06 +0100)]
Merge branch 'MDL-69097-master' of https://github.com/inigozendegi/moodle
Simey Lameze [Mon, 7 Sep 2020 09:31:16 +0000 (17:31 +0800)]
MDL-67494 calendar: user_delete_user should delete all user events
Simey Lameze [Mon, 7 Sep 2020 04:03:44 +0000 (12:03 +0800)]
MDL-67494 calendar: privacy provider should not delete shared events
Simey Lameze [Mon, 7 Sep 2020 08:56:23 +0000 (16:56 +0800)]
MDL-67494 calendar: shared subscriptions should not set userid to 0
Simey Lameze [Fri, 5 Feb 2021 08:09:52 +0000 (16:09 +0800)]
MDL-67494 calendar: only user overrides should retain userid
Simey Lameze [Mon, 24 Aug 2020 03:09:42 +0000 (11:09 +0800)]
MDL-67494 calendar: set userid to zero for shared events
Simey Lameze [Mon, 7 Sep 2020 08:04:57 +0000 (16:04 +0800)]
MDL-67494 calendar: step to set userid 0 to all shared events
Simey Lameze [Mon, 24 Aug 2020 03:08:00 +0000 (11:08 +0800)]
MDL-67494 calendar: add logic for category events in get_context
Jun Pataleta [Wed, 3 Mar 2021 07:05:36 +0000 (15:05 +0800)]
Merge branch 'MDL-70995' of https://github.com/paulholden/moodle
Jun Pataleta [Wed, 3 Mar 2021 06:35:06 +0000 (14:35 +0800)]
Merge branch 'MDL-69883' of https://github.com/paulholden/moodle
Andrew Nicols [Wed, 3 Mar 2021 04:23:04 +0000 (12:23 +0800)]
Merge branch 'MDL-70268-master-2' of git://github.com/peterRd/moodle
Peter Dias [Thu, 28 Jan 2021 03:46:19 +0000 (11:46 +0800)]
MDL-70268 core: Update the oauthlib to exclude scope if none provided
AMOS bot [Wed, 3 Mar 2021 00:07:43 +0000 (00:07 +0000)]
Automatically generated installer lang files
Paul Holden [Mon, 8 Feb 2021 08:23:12 +0000 (08:23 +0000)]
MDL-70822 enrol: respect capability to view other users profile.
When retrieving courses of another user via web services, we should
respect the capability to view that users profile in a given course.
Sander Wind [Tue, 19 Jan 2021 08:05:41 +0000 (16:05 +0800)]
MDL-70668 auth: Fix secret validation during user confirmation
Co-authored-by: Michael Hawkins <michaelh@moodle.com>
Eloy Lafuente (stronk7) [Tue, 2 Mar 2021 22:32:30 +0000 (23:32 +0100)]
Merge branch 'MDL-70340-master' of git://github.com/jleyva/moodle
Víctor Déniz [Tue, 2 Mar 2021 17:53:59 +0000 (17:53 +0000)]
Merge branch 'MDL-70676-master' of git://github.com/ilyatregubov/moodle
Fixed mod/workshop/db/upgrade.php: \xmldb_field::getNotNull()
does not verify if the column is nullable in the database.
Peter Dias [Thu, 25 Feb 2021 02:06:10 +0000 (10:06 +0800)]
MDL-59293 block_onlineusers: Update behat tests
Peter Dias [Fri, 28 Aug 2020 04:53:26 +0000 (12:53 +0800)]
MDL-59293 block_onlineusers: Check whether current user can view online users
- Removed block from site admin.
- Blocked guest from viewuserlist cap
Ilya Tregubov [Tue, 26 Jan 2021 12:21:33 +0000 (14:21 +0200)]
MDL-70676 workshop: Allow empty grades.
Sara Arjona [Tue, 2 Mar 2021 10:21:17 +0000 (11:21 +0100)]
Merge branch 'MDL-67515-master' of git://github.com/vmdef/moodle
Jun Pataleta [Tue, 2 Mar 2021 09:39:36 +0000 (17:39 +0800)]
Merge branch 'MDL-70457' of https://github.com/stronk7/moodle
Víctor Déniz [Tue, 2 Mar 2021 09:16:41 +0000 (09:16 +0000)]
Merge branch 'MDL-70172-master' of git://github.com/rezaies/moodle
Víctor Déniz [Wed, 10 Feb 2021 13:55:16 +0000 (13:55 +0000)]
MDL-67515 tool_customlang: Ignore invalid component strings
After uninstalling a plugin, the translated strings remain in
tool_customlang table, throwing an exception when trying to localise
any strings. Currently there is no mechanism to
clean up customlang tables and files during the uninstall process,
so with this patch the invalid components will be ignored.
Sara Arjona [Tue, 2 Mar 2021 08:29:17 +0000 (09:29 +0100)]
Merge branch 'MDL-70877' of https://github.com/stronk7/moodle
Jun Pataleta [Tue, 2 Mar 2021 08:02:52 +0000 (16:02 +0800)]
Merge branch 'MDL-70876' of https://github.com/stronk7/moodle
AMOS bot [Tue, 2 Mar 2021 00:07:42 +0000 (00:07 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 21:50:33 +0000 (22:50 +0100)]
Merge branch 'MDL-70898-master' of git://github.com/marinaglancy/moodle
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 21:33:17 +0000 (22:33 +0100)]
Merge branch 'MDL-67974-master' of git://github.com/sarjona/moodle
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 20:58:45 +0000 (21:58 +0100)]
Merge branch 'MDL-70916' of https://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 19:20:46 +0000 (20:20 +0100)]
Merge branch 'MDL-70899-master' of git://github.com/marinaglancy/moodle
Shamim Rezaie [Thu, 10 Dec 2020 12:23:49 +0000 (23:23 +1100)]
MDL-70172 output: pages with main logo should have a first-level header
Shamim Rezaie [Wed, 9 Dec 2020 17:02:09 +0000 (04:02 +1100)]
MDL-70172 output: Fix empty links
The approach taken is inline with font-awesome documentation:
https://fontawesome.com/how-to-use/on-the-web/other-topics/accessibility
Eloy Lafuente (stronk7) [Mon, 1 Mar 2021 15:47:28 +0000 (16:47 +0100)]
Merge branch 'MDL-70912-master' of git://github.com/sarjona/moodle
Sara Arjona [Mon, 1 Mar 2021 15:17:19 +0000 (16:17 +0100)]
Merge branch 'MDL-68735' of https://github.com/stronk7/moodle