Sara Arjona [Tue, 9 Apr 2019 12:06:21 +0000 (14:06 +0200)]
MDL-64819 course: fix behat errors with the move icon
Some errors have been detected when using Clean + Goutte.
Adrian Greeve [Tue, 9 Apr 2019 02:00:23 +0000 (10:00 +0800)]
Merge branch 'master_MDL-28505_Asynchronous_backup_and_restore' of https://github.com/mattporritt/moodle
Eloy Lafuente (stronk7) [Tue, 9 Apr 2019 00:30:49 +0000 (02:30 +0200)]
MDL-64783 analytics: Add new capability lang string
Matt Porritt [Thu, 20 Dec 2018 04:32:46 +0000 (15:32 +1100)]
MDL-28505 Backup: Asynchronous backup and restore
This patch adds asynchronous backup and restore functionality
to Moodle. This is an optional feature and is not enabled by
default. It can be enabled by site administrators.
Asynchronous backup and restores are actioned by the Moodle
adhoc task API. The progress of backup and restores is
displayedin the Moodle UI. Users can also be sent a message
when a backup or restore operation completes via the
Moodle messaging API.
Eloy Lafuente (stronk7) [Mon, 8 Apr 2019 22:46:47 +0000 (00:46 +0200)]
Merge branch 'MDL-65191-master' of git://github.com/lameze/moodle
David Monllaó [Mon, 8 Apr 2019 19:00:55 +0000 (21:00 +0200)]
MDL-64783 analytics: Send notifications using the receiver's language
David Monllaó [Fri, 5 Apr 2019 14:40:50 +0000 (16:40 +0200)]
MDL-64783 analytics: Activities due insight forwards to calendar
The patch includes changes applied after the peer review.
David Monllaó [Wed, 3 Apr 2019 19:06:04 +0000 (21:06 +0200)]
MDL-64783 analytics: Styles for insights sent through email
David Monllaó [Wed, 3 Apr 2019 17:46:03 +0000 (19:46 +0200)]
MDL-64783 analytics: Performance improvements
- Removed redundant query to analytics_predict_samples
- Analysers API now uses recordsets to iterate through the analysable
elements. They take the last analysed time into account.
- New method for targets so there is no need to always update the last
analysis time. Useful for lightweight targets.
David Monllaó [Mon, 1 Apr 2019 23:44:42 +0000 (01:44 +0200)]
MDL-64783 analytics: Updated insight subject for course_enrolments
David Monllaó [Mon, 1 Apr 2019 23:02:12 +0000 (01:02 +0200)]
MDL-64783 analytics: Discern prediction actions on insights generation
David Monllaó [Tue, 26 Mar 2019 16:45:01 +0000 (17:45 +0100)]
MDL-64783 analytics: Performance improvements and internal refactoring
The base classes analyser and time-splitting method had too many
reponsibilities. A new analysis class has been created.
David Monllaó [Mon, 1 Apr 2019 09:19:35 +0000 (11:19 +0200)]
MDL-64783 analytics: Install / upgrade for the new model
David Monllaó [Fri, 22 Mar 2019 11:06:13 +0000 (12:06 +0100)]
MDL-64783 analytics: Insights generation logic out of the target
David Monllaó [Thu, 14 Mar 2019 15:52:43 +0000 (16:52 +0100)]
MDL-64783 analytics: Improvements to the insights system
David Monllaó [Thu, 21 Mar 2019 12:08:31 +0000 (13:08 +0100)]
MDL-64783 analytics: Upcoming activities due and related API changes
David Monllaó [Thu, 21 Mar 2019 12:08:24 +0000 (13:08 +0100)]
MDL-64783 analytics: Reset PAGE after analytics processes
Eloy Lafuente (stronk7) [Mon, 8 Apr 2019 18:41:50 +0000 (20:41 +0200)]
Merge branch 'MDL-64954_master' of git://github.com/dmonllao/moodle
Eloy Lafuente (stronk7) [Mon, 8 Apr 2019 17:41:26 +0000 (19:41 +0200)]
MDL-65142 dataformat_pdf: added to standard core plugins
Eloy Lafuente (stronk7) [Mon, 8 Apr 2019 15:09:03 +0000 (17:09 +0200)]
Merge branch 'MDL-65142-master' of git://github.com/rezaies/moodle
Eloy Lafuente (stronk7) [Mon, 8 Apr 2019 14:03:29 +0000 (16:03 +0200)]
Merge branch 'MDL-65176-master-nofallback' of https://github.com/vmdef/moodle
Damyon Wiese [Mon, 8 Apr 2019 07:39:02 +0000 (15:39 +0800)]
MDL-64819 output: Hide icons with no title
When output from javascript they should match what gets output from php.
Damyon Wiese [Mon, 11 Feb 2019 01:34:18 +0000 (09:34 +0800)]
MDL-64819 output: Activity menu icons
Remove duplicate alt text from activity menu icons and the links to add new sections.
Sara Arjona [Mon, 8 Apr 2019 11:12:31 +0000 (13:12 +0200)]
Merge branch 'MDL-64669-master' of git://github.com/aanabit/moodle
Victor Deniz Falcon [Mon, 8 Apr 2019 09:17:02 +0000 (10:17 +0100)]
MDL-65176 analytics: target for students who don't get the minimum grade
Added new target to predict which students are at risk of not getting
the minimum grade to pass a course.
Adrian Greeve [Mon, 8 Apr 2019 08:53:43 +0000 (16:53 +0800)]
Merge branch 'MDL-65218-master' of git://github.com/damyon/moodle
Amaia Anabitarte [Fri, 5 Apr 2019 21:39:05 +0000 (23:39 +0200)]
MDL-64669 core_message: Waiting for buttons to hide before login out
Amaia Anabitarte [Tue, 5 Mar 2019 20:43:08 +0000 (21:43 +0100)]
MDL-64669 core_message: Behat tests for send messages
Amaia Anabitarte [Tue, 5 Mar 2019 20:42:32 +0000 (21:42 +0100)]
MDL-64669 core_message: New steps and selectors for messaging
Adrian Greeve [Sun, 7 Apr 2019 23:49:35 +0000 (07:49 +0800)]
Merge branch 'MDL-65075-master' of git://github.com/jleyva/moodle
David Monllaó [Fri, 5 Apr 2019 21:19:21 +0000 (23:19 +0200)]
MDL-64954 tool_analytics: More help for analytics api elements
Eloy Lafuente (stronk7) [Fri, 5 Apr 2019 16:33:19 +0000 (18:33 +0200)]
on-demand release 3.7dev+
David Monllaó [Fri, 5 Apr 2019 11:18:50 +0000 (13:18 +0200)]
MDL-64779 tool_analytics: Nice styles for the export modal
Mathew May [Fri, 5 Apr 2019 09:37:23 +0000 (17:37 +0800)]
MDL-64506 mod_choice: fix behat issue with screensize
We found issues in FireFox where Behat could not scroll to select
the student two checkbox.
Juan Leyva [Thu, 21 Mar 2019 14:39:21 +0000 (15:39 +0100)]
MDL-65075 tool_mobile: Allow auto-login keys only for requests from Moodle apps
This change enhances security and avoid any kind of XSS attack.
Adrian Greeve [Fri, 5 Apr 2019 01:33:13 +0000 (09:33 +0800)]
MDL-65019 core_course: Update to fix whitespace.
Adrian Greeve [Fri, 5 Apr 2019 01:14:23 +0000 (09:14 +0800)]
Merge branch 'MDL-65019-master' of git://github.com/jleyva/moodle
Adrian Greeve [Fri, 5 Apr 2019 01:09:16 +0000 (09:09 +0800)]
Merge branch 'MDL-65024-master' of git://github.com/jleyva/moodle
Eloy Lafuente (stronk7) [Thu, 4 Apr 2019 22:39:10 +0000 (00:39 +0200)]
Merge branch 'MDL-65029-master' of git://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Thu, 4 Apr 2019 22:21:20 +0000 (00:21 +0200)]
Merge branch 'MDL-65127-master' of git://github.com/sarjona/moodle
Eloy Lafuente (stronk7) [Thu, 4 Apr 2019 20:32:52 +0000 (22:32 +0200)]
Merge branch 'MDL-65094-master' of git://github.com/rezaies/moodle
Eloy Lafuente (stronk7) [Thu, 4 Apr 2019 18:41:40 +0000 (20:41 +0200)]
Merge branch 'MDL-65114-master' of https://github.com/snake/moodle
Eloy Lafuente (stronk7) [Thu, 4 Apr 2019 18:30:40 +0000 (20:30 +0200)]
Merge branch 'MDL-65038_master' of https://github.com/maksudr/moodle
Adrian Greeve [Thu, 4 Apr 2019 04:59:51 +0000 (12:59 +0800)]
Merge branch 'MDL-22077-master' of git://github.com/peterRd/moodle
Peter [Wed, 3 Apr 2019 02:46:11 +0000 (10:46 +0800)]
MDL-22077 mod_forum: external unit tests and vault updates
* Unit tests for external functions
* Use the new dml_table to fetch a table's columns
Jake Dallimore [Thu, 4 Apr 2019 03:37:07 +0000 (11:37 +0800)]
Merge branch 'MDL-65087' of git://github.com/stronk7/moodle
Peter [Sun, 31 Mar 2019 22:52:29 +0000 (06:52 +0800)]
MDL-22077 mod_forum: Grammatical and formatting updates
Andrew Nicols [Wed, 20 Mar 2019 07:20:48 +0000 (15:20 +0800)]
MDL-22077 forum: Update post.php to respect private replies
Andrew Nicols [Sat, 19 Mar 2016 01:25:35 +0000 (09:25 +0800)]
MDL-22077 forum: Add forum private replies
This patch adds new capabilities:
'mod/forum:postprivatereply' - whether a user is able to post private replies; and
'mod/forum:readprivatereplies' - whether a user is able to read private replies.
Private replies are only visible to the intended recipient (the author of
the parent post), the author of the private reply, and those with the
ability to read private replies.
If a post is private then it cannot be replied to further.
Andrew Nicols [Tue, 19 Mar 2019 02:53:50 +0000 (10:53 +0800)]
MDL-22077 forum: Deprecate unused helper trait
Jake Dallimore [Thu, 4 Apr 2019 03:16:42 +0000 (11:16 +0800)]
Merge branch 'MDL-64506' of git://github.com/Chocolate-lightning/moodle
Mathew May [Thu, 4 Apr 2019 03:00:09 +0000 (11:00 +0800)]
MDL-64506 mod_data: correct behat issue for saving items with tags
Jake Dallimore [Thu, 4 Apr 2019 02:41:42 +0000 (10:41 +0800)]
Merge branch 'MDL-64243' of https://github.com/Dagefoerde/moodle
Simey Lameze [Thu, 4 Apr 2019 01:29:27 +0000 (09:29 +0800)]
MDL-65191 core_badges: delete badges legacy cron file
Simey Lameze [Thu, 4 Apr 2019 01:17:43 +0000 (09:17 +0800)]
MDL-65191 core: convert legacy cron to scheduled task
Simey Lameze [Thu, 4 Apr 2019 01:14:45 +0000 (09:14 +0800)]
MDL-65191 core_badges: add badges_message_task task
Simey Lameze [Thu, 4 Apr 2019 01:28:47 +0000 (09:28 +0800)]
MDL-65191 core: shift badge_assemble_notification to badgeslib
Jun Pataleta [Thu, 4 Apr 2019 01:08:06 +0000 (09:08 +0800)]
Merge branch 'MDL-65204_oraclemssql_assert_equals' of git://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Wed, 3 Apr 2019 22:54:45 +0000 (00:54 +0200)]
MDL-65087 behat: Select the proper search button via xpath
By adding the "Search" aria label to a number of elements
any search of "Search" buttons, previously working in other
parts of the UI are not found anymore (because the hidden
ones are found before).
So, moving to click via xpath. Ideally we should be able to
find the target button in an easier, human readable way. But
there aren't many ids, names around to make it easier.
Eloy Lafuente (stronk7) [Wed, 3 Apr 2019 15:09:05 +0000 (17:09 +0200)]
MDL-65204 phpunit: more isEqual() strict string fixes
This is a followup of
85f47ba, where we were relaxing
the (new since phpunit 7.x) strict (===) isEqual()
comparison for strings. Copying the explanations for
easier understanding.
Link: https://github.com/sebastianbergmann/phpunit/issues/3185
Solution here is one of:
a) Return to the previous situation, making the comparison
softer. That can achieved by forcing different types, so
float == string works.
b) Changing APIs (both forms and database return strings) to
perform some conversion to floats. That would make float
comparison (with floats or strings) to work too.
The patch here follows the a) approach. Changing all the internals
for proper float handling sounds excesive when it has been working
perfectly since ever. So we went the easier route, just getting
rid of the new === comparisons when needed by changing expectation
types to float.
Sara Arjona [Wed, 3 Apr 2019 17:30:28 +0000 (19:30 +0200)]
Merge branch 'MDL-64506' of git://github.com/Chocolate-lightning/moodle
Shamim Rezaie [Tue, 2 Apr 2019 17:05:24 +0000 (04:05 +1100)]
MDL-65142 dataformat_pdf: Added privacy implementation
Shamim Rezaie [Tue, 2 Apr 2019 16:55:58 +0000 (03:55 +1100)]
MDL-65142 dataformat_pdf: New dataformat for pdf
Mathew May [Fri, 29 Mar 2019 04:16:36 +0000 (12:16 +0800)]
MDL-64506 templates: BS2 pull-x -> BS4 float-x
Mathew May [Fri, 29 Mar 2019 04:10:09 +0000 (12:10 +0800)]
MDL-64506 templates: replace spans where and col-x appears
Mathew May [Fri, 29 Mar 2019 03:39:23 +0000 (11:39 +0800)]
MDL-64506 templates: BS2 m-x-x to BS4 mx-x
Mathew May [Wed, 13 Mar 2019 01:54:10 +0000 (09:54 +0800)]
MDL-64506 behat: Modify usertours behat.
Original test relied on a 3rd theme to test against.
With only two themes in core now we need to make the test
theme/ suite specific.
Mathew May [Tue, 12 Mar 2019 03:09:06 +0000 (11:09 +0800)]
MDL-64506 Javascript: Remove docking JS.
Deprecate related lang strings & base functions now return false.
Mathew May [Thu, 7 Mar 2019 02:42:32 +0000 (10:42 +0800)]
MDL-64506 templates: Move BS2 labels to BS4 badges
Mathew May [Thu, 7 Mar 2019 01:54:01 +0000 (09:54 +0800)]
MDL-64506 templates: Move BS2 btns' to BS4 btns'
well bs2 class is now card in bs4
Mathew May [Thu, 7 Mar 2019 01:40:47 +0000 (09:40 +0800)]
MDL-64506 templates: Remove BS2 spans from elements.
Mathew May [Wed, 6 Mar 2019 08:38:29 +0000 (16:38 +0800)]
MDL-64506 upgrade: Add upgrade steps to remove BS2 themes.
Mathew May [Wed, 6 Mar 2019 03:57:32 +0000 (11:57 +0800)]
MDL-64506 grades: Fix regression of MDL-58428
Mathew May [Fri, 1 Mar 2019 06:14:47 +0000 (14:14 +0800)]
MDL-64506 theme: Update BSB references and upgrade texts
Mathew May [Fri, 1 Mar 2019 06:02:04 +0000 (14:02 +0800)]
MDL-64506 Grunt: Remove old Bootstrapbase tasks
Mathew May [Thu, 28 Feb 2019 05:42:23 +0000 (13:42 +0800)]
MDL-64506 phpunit: Update unit tests to use classic
Mathew May [Thu, 28 Feb 2019 04:03:38 +0000 (12:03 +0800)]
MDL-64506 theme_bootstrapbase: Remove bootstrapbase from core
Jun Pataleta [Wed, 3 Apr 2019 08:50:31 +0000 (16:50 +0800)]
Merge branch 'MDL-62307_master' of https://github.com/maksudr/moodle
Jun Pataleta [Wed, 3 Apr 2019 08:42:41 +0000 (16:42 +0800)]
Merge branch 'MDL-65168' of git://github.com/stronk7/moodle
Jun Pataleta [Wed, 3 Apr 2019 08:19:35 +0000 (16:19 +0800)]
Merge branch 'MDL-65112-master' of https://github.com/dmitriim/moodle
Adrian Greeve [Wed, 3 Apr 2019 06:57:38 +0000 (14:57 +0800)]
Merge branch 'session-debug' of https://github.com/tsmilan/moodle
Jake Dallimore [Wed, 3 Apr 2019 06:12:24 +0000 (14:12 +0800)]
Merge branch 'MDL-65087-master' of git://github.com/sarjona/moodle
Jake Dallimore [Wed, 3 Apr 2019 05:46:05 +0000 (13:46 +0800)]
Merge branch 'MDL-65247-master' of git://github.com/junpataleta/moodle
Adrian Greeve [Wed, 3 Apr 2019 05:39:28 +0000 (13:39 +0800)]
Merge branch 'MDL-65130-master' of git://github.com/andrewnicols/moodle
Trisha Milan [Tue, 2 Apr 2019 12:17:18 +0000 (23:17 +1100)]
MDL-64449 core: Added Session lock debugging option
Jun Pataleta [Wed, 3 Apr 2019 02:57:12 +0000 (10:57 +0800)]
Merge branch 'MDL-65204-master' of git://github.com/junpataleta/moodle
Jun Pataleta [Wed, 3 Apr 2019 02:44:24 +0000 (10:44 +0800)]
MDL-65204 phpunit: Fix valid CiBoT errors and warnings
Eloy Lafuente (stronk7) [Thu, 28 Mar 2019 00:37:28 +0000 (01:37 +0100)]
MDL-65204 phpunit: tweak constraint_object_is_equal_with_exceptions
In PHPUnit 7.x and above, IsEqual->value became private and, as far
as our with exceptions class inherits from it, we cannot access to
that anymore.
So, in order to avoid that, we are overriding the constructor, capturing
the original value for own use and forgetting.
A more formal, alternative, solution would be to make our
exceptional class to inherit from Constraint and make the
class a pure dispatcher to different constraints, with IsEqual being
just one of them.
But we followed the easiest path here. Not ideal, but efective.
Eloy Lafuente (stronk7) [Wed, 27 Mar 2019 12:05:35 +0000 (13:05 +0100)]
MDL-65204 phpunit: various fixes to assertions
Namely:
- 3rd param of assertEquals() cannot be null.
- Some incorrect uses of assertNotEmpty().
- Comparing 2 strings now uses strict (===) evaluation.
Link: https://github.com/sebastianbergmann/phpunit/issues/3185
Solution here is one of:
a) Return to the previous situation, making the comparison
softer. That can achieved by forcing different types, so
float == string works.
b) Changing APIs (both forms and database return strings) to
perform some conversion to floats. That would make float
comparison (with floats or strings) to work too.
The patch here follows the a) approach. Changing all the internals
for proper float handling sounds excesive when it has been working
perfectly since ever. So we went the easier route, just getting
rid of the new === comparisons when needed by changing expectation
types to float.
Eloy Lafuente (stronk7) [Sun, 24 Mar 2019 22:21:48 +0000 (23:21 +0100)]
MDL-65204 phpunit: make testcases match their expected signature
Eloy Lafuente (stronk7) [Sun, 24 Mar 2019 22:11:35 +0000 (23:11 +0100)]
MDL-65204 phpunit: update composer to use phpunit 7.5.x
To generate a new composer.lock for a given Moodle branch:
- Remove composer.lock
- Remove vendor
- Remove composer caches:
php composer.phar clearcache
- Using lower PHP version supported (7.1.x for Moodle 3.7), update:
php composer.phar update
https://docs.moodle.org/dev/Composer#How_to_prepare_and_submit_composer_changes
Mathew May [Wed, 6 Mar 2019 04:01:27 +0000 (12:01 +0800)]
MDL-64506 theme: Move templates from lib/form
Mathew May [Wed, 6 Mar 2019 04:01:15 +0000 (12:01 +0800)]
MDL-64506 theme: Create empty form templates
Mathew May [Thu, 28 Feb 2019 04:02:50 +0000 (12:02 +0800)]
MDL-64506 theme_clean: Remove Clean from core
Mathew May [Thu, 28 Feb 2019 04:01:40 +0000 (12:01 +0800)]
MDL-64506 theme_more: Remove More from core
Jun Pataleta [Wed, 3 Apr 2019 01:48:00 +0000 (09:48 +0800)]
Merge branch 'MDL-65214' of git://github.com/stronk7/moodle
Jake Dallimore [Wed, 3 Apr 2019 01:43:51 +0000 (09:43 +0800)]
Merge branch 'MDL-63569-email-header-master' of https://github.com/pauldamiani/moodle
Jun Pataleta [Wed, 3 Apr 2019 00:42:01 +0000 (08:42 +0800)]
MDL-65247 core: Fix action_modal Behat tests
Eloy Lafuente (stronk7) [Tue, 2 Apr 2019 22:22:54 +0000 (00:22 +0200)]
Merge branch 'MDL-65213-master' of git://github.com/sarjona/moodle
Eloy Lafuente (stronk7) [Tue, 2 Apr 2019 22:09:28 +0000 (00:09 +0200)]
Merge branch 'MDL-64994-master-pythonmlversion' of git://github.com/mudrd8mz/moodle