moodle.git
2 years agoMerge branch 'MDL-68165' of https://github.com/stronk7/moodle
Jake Dallimore [Thu, 2 Apr 2020 00:42:45 +0000 (08:42 +0800)]
Merge branch 'MDL-68165' of https://github.com/stronk7/moodle

2 years agoMerge branch 'MDL-67672-master' of git://github.com/lucaboesch/moodle
Eloy Lafuente (stronk7) [Wed, 1 Apr 2020 22:16:51 +0000 (00:16 +0200)]
Merge branch 'MDL-67672-master' of git://github.com/lucaboesch/moodle

2 years agoMDL-67672 user: Display name in user menu as elsewhere.
Luca Bösch [Wed, 1 Apr 2020 22:04:38 +0000 (00:04 +0200)]
MDL-67672 user: Display name in user menu as elsewhere.

2 years agoMerge branch 'MDL-67914-master' of git://github.com/lameze/moodle
Eloy Lafuente (stronk7) [Wed, 1 Apr 2020 21:41:38 +0000 (23:41 +0200)]
Merge branch 'MDL-67914-master' of git://github.com/lameze/moodle

2 years agoMerge branch 'MDL-68265-master' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Wed, 1 Apr 2020 21:29:13 +0000 (23:29 +0200)]
Merge branch 'MDL-68265-master' of git://github.com/andrewnicols/moodle

2 years agoMerge branch 'MDL-68193_master' of git://github.com/mdjnelson/moodle
Eloy Lafuente (stronk7) [Wed, 1 Apr 2020 21:22:25 +0000 (23:22 +0200)]
Merge branch 'MDL-68193_master' of git://github.com/mdjnelson/moodle

2 years agoMDL-68193 core: added new database_text_field_content_replaced event
Mark Nelson [Thu, 26 Mar 2020 22:19:19 +0000 (23:19 +0100)]
MDL-68193 core: added new database_text_field_content_replaced event

2 years agoMerge branch 'MDL-68191' of git://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Wed, 1 Apr 2020 18:18:25 +0000 (20:18 +0200)]
Merge branch 'MDL-68191' of git://github.com/timhunt/moodle

2 years agoMerge branch 'MDL-67995-master' of git://github.com/cescobedo/moodle
Eloy Lafuente (stronk7) [Wed, 1 Apr 2020 17:07:12 +0000 (19:07 +0200)]
Merge branch 'MDL-67995-master' of git://github.com/cescobedo/moodle

2 years agoMerge branch 'MDL-67672-master' of git://github.com/lucaboesch/moodle
Jake Dallimore [Wed, 1 Apr 2020 08:43:03 +0000 (16:43 +0800)]
Merge branch 'MDL-67672-master' of git://github.com/lucaboesch/moodle

2 years agoMerge branch 'MDL-68281' of https://github.com/stronk7/moodle
Sara Arjona [Wed, 1 Apr 2020 07:25:04 +0000 (09:25 +0200)]
Merge branch 'MDL-68281' of https://github.com/stronk7/moodle

2 years agoMerge branch 'MDL-68277' of https://github.com/timhunt/moodle
Sara Arjona [Wed, 1 Apr 2020 07:14:36 +0000 (09:14 +0200)]
Merge branch 'MDL-68277' of https://github.com/timhunt/moodle

2 years agoMDL-67914 core_table: unit tests for table view fetch webservice
Simey Lameze [Tue, 31 Mar 2020 06:55:07 +0000 (14:55 +0800)]
MDL-67914 core_table: unit tests for table view fetch webservice

2 years agoMDL-67914 core_table: implement dynamic table sorting
Simey Lameze [Tue, 31 Mar 2020 06:54:41 +0000 (14:54 +0800)]
MDL-67914 core_table: implement dynamic table sorting

2 years agoMDL-67672 user: Display name in user menu as elsewhere.
Luca Bösch [Mon, 20 Jan 2020 08:26:23 +0000 (09:26 +0100)]
MDL-67672 user: Display name in user menu as elsewhere.

2 years agoMerge branch 'MDL-68263-master' of git://github.com/mihailges/moodle
Sara Arjona [Wed, 1 Apr 2020 06:58:27 +0000 (08:58 +0200)]
Merge branch 'MDL-68263-master' of git://github.com/mihailges/moodle

2 years agoMDL-67612 mod_lti: tcguid default to siteid
Claude Vervoort [Fri, 3 Jan 2020 20:31:27 +0000 (15:31 -0500)]
MDL-67612 mod_lti: tcguid default to siteid

2 years agoMerge branch 'MDL-45227-master' of git://github.com/rezaies/moodle
Sara Arjona [Tue, 31 Mar 2020 17:23:01 +0000 (19:23 +0200)]
Merge branch 'MDL-45227-master' of git://github.com/rezaies/moodle

2 years agoMerge branch 'MDL-58964-master' of git://github.com/abias/moodle
Sara Arjona [Tue, 31 Mar 2020 17:13:15 +0000 (19:13 +0200)]
Merge branch 'MDL-58964-master' of git://github.com/abias/moodle

2 years agoMerge branch 'MDL-64494-master' of git://github.com/bmbrands/moodle
Eloy Lafuente (stronk7) [Tue, 31 Mar 2020 16:59:09 +0000 (18:59 +0200)]
Merge branch 'MDL-64494-master' of git://github.com/bmbrands/moodle

2 years agoMDL-64494 theme_boost: accessible theme colours
Bas Brands [Thu, 20 Feb 2020 10:38:47 +0000 (11:38 +0100)]
MDL-64494 theme_boost: accessible theme colours

2 years agoMerge branch 'MDL-68300' of https://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Tue, 31 Mar 2020 16:16:53 +0000 (18:16 +0200)]
Merge branch 'MDL-68300' of https://github.com/timhunt/moodle

2 years agoMerge branch 'MDL-66245-master' of git://github.com/junpataleta/moodle
Sara Arjona [Tue, 31 Mar 2020 13:09:06 +0000 (15:09 +0200)]
Merge branch 'MDL-66245-master' of git://github.com/junpataleta/moodle

2 years agoMDL-68300 questions: un-break duplicating questions without idnumbers
Tim Hunt [Tue, 31 Mar 2020 09:33:18 +0000 (10:33 +0100)]
MDL-68300 questions: un-break duplicating questions without idnumbers

This was a regression caused by MDL-67934

2 years agoMerge branch 'MDL-68225-master' of git://github.com/lameze/moodle
Jake Dallimore [Tue, 31 Mar 2020 07:16:37 +0000 (15:16 +0800)]
Merge branch 'MDL-68225-master' of git://github.com/lameze/moodle

2 years agoMDL-68225 core_user: add behat coverage for group modes
Simey Lameze [Fri, 27 Mar 2020 13:10:18 +0000 (21:10 +0800)]
MDL-68225 core_user: add behat coverage for group modes

2 years agoMerge branch 'MDL-68144-master' of git://github.com/lucaboesch/moodle
Jake Dallimore [Tue, 31 Mar 2020 05:59:27 +0000 (13:59 +0800)]
Merge branch 'MDL-68144-master' of git://github.com/lucaboesch/moodle

2 years agoMerge branch 'MDL-68269-master' of git://github.com/rezaies/moodle
Eloy Lafuente (stronk7) [Mon, 30 Mar 2020 20:53:33 +0000 (22:53 +0200)]
Merge branch 'MDL-68269-master' of git://github.com/rezaies/moodle

2 years agoMerge branch 'MDL-68049' of https://github.com/spvickers/moodle
Eloy Lafuente (stronk7) [Mon, 30 Mar 2020 11:26:21 +0000 (13:26 +0200)]
Merge branch 'MDL-68049' of https://github.com/spvickers/moodle

2 years agoMDL-68269 form: fieldset in group elements should be full width
Shamim Rezaie [Mon, 30 Mar 2020 07:29:23 +0000 (18:29 +1100)]
MDL-68269 form: fieldset in group elements should be full width

2 years agoMerge branch 'MDL-52319-master-environmentxml' of git://github.com/mudrd8mz/moodle
Andrew Nicols [Mon, 30 Mar 2020 06:35:20 +0000 (14:35 +0800)]
Merge branch 'MDL-52319-master-environmentxml' of git://github.com/mudrd8mz/moodle

2 years agoMDL-67995 format_singleactivity: Fix dropwdown type of activity
cescobedo [Thu, 27 Feb 2020 21:09:05 +0000 (22:09 +0100)]
MDL-67995 format_singleactivity: Fix dropwdown type of activity

2 years agoMDL-68263 course: Fix error when modules are not fully uninstalled
Mihail Geshoski [Mon, 30 Mar 2020 06:15:00 +0000 (14:15 +0800)]
MDL-68263 course: Fix error when modules are not fully uninstalled

2 years agoMDL-68265 core_question: Switch question import to request dir
Andrew Nicols [Thu, 26 Mar 2020 09:38:24 +0000 (17:38 +0800)]
MDL-68265 core_question: Switch question import to request dir

2 years agoMDL-68265 mod_lesson: Switch question import to request dir
Andrew Nicols [Thu, 26 Mar 2020 09:38:16 +0000 (17:38 +0800)]
MDL-68265 mod_lesson: Switch question import to request dir

2 years agoMDL-68281 unit test: Include required class
Eloy Lafuente (stronk7) [Sat, 28 Mar 2020 15:23:34 +0000 (16:23 +0100)]
MDL-68281 unit test: Include required class

Also, add missing line break, that I did not see 1 week ago.

2 years agoMDL-68277 qtype_essay: answer area in reviews should be right size
Tim Hunt [Fri, 27 Mar 2020 13:29:40 +0000 (13:29 +0000)]
MDL-68277 qtype_essay: answer area in reviews should be right size

The answer box size is set by teachers and provides a useful
visual cue how long a response was expected. Therefore, it is
useful to keep the space at least that size in quiz reviews, etc.

2 years agoMDL-68225 core_user: apply group filter to participants page
Simey Lameze [Tue, 24 Mar 2020 00:22:41 +0000 (08:22 +0800)]
MDL-68225 core_user: apply group filter to participants page

2 years agoMDL-68165 install: update the list of stale files for 3.9
Eloy Lafuente (stronk7) [Thu, 12 Mar 2020 23:43:43 +0000 (00:43 +0100)]
MDL-68165 install: update the list of stale files for 3.9

2 years agoMDL-45227 atto_align: Make IE follow css styling
Shamim Rezaie [Wed, 4 Mar 2020 12:01:37 +0000 (23:01 +1100)]
MDL-45227 atto_align: Make IE follow css styling

2 years agoMDL-45227 atto_rtl: Automatically set alignment when direction changes
Shamim Rezaie [Wed, 4 Mar 2020 11:59:21 +0000 (22:59 +1100)]
MDL-45227 atto_rtl: Automatically set alignment when direction changes

2 years agoMDL-45227 editor_atto: PR changes and improved behat
Shamim Rezaie [Mon, 3 Feb 2020 15:37:53 +0000 (02:37 +1100)]
MDL-45227 editor_atto: PR changes and improved behat

2 years agoMDL-45227 editor_atto: add behat test for RTL and LTR direction
Avi Levy [Fri, 31 Jan 2020 18:26:47 +0000 (05:26 +1100)]
MDL-45227 editor_atto: add behat test for RTL and LTR direction

2 years agoMDL-45227 editor_atto: Add direction to default ATTO generated markup
Nadav Kavalerchik [Fri, 31 Jan 2020 18:21:35 +0000 (05:21 +1100)]
MDL-45227 editor_atto: Add direction to default ATTO generated markup

2 years agoMDL-68144 mod_folder: make top margins less dominant for folder content
Luca Bösch [Tue, 10 Mar 2020 19:04:31 +0000 (20:04 +0100)]
MDL-68144 mod_folder: make top margins less dominant for folder content

2 years agoweekly release 3.9dev
Jake Dallimore [Fri, 27 Mar 2020 01:18:29 +0000 (09:18 +0800)]
weekly release 3.9dev

2 years agoMerge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Jake Dallimore [Fri, 27 Mar 2020 01:18:28 +0000 (09:18 +0800)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install

2 years agoMerge branch 'MDL-64429' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Thu, 26 Mar 2020 17:49:36 +0000 (18:49 +0100)]
Merge branch 'MDL-64429' of https://github.com/paulholden/moodle

2 years agoMDL-64429 tool_usertours: upgrade step to fix existing tours sortorder.
Paul Holden [Thu, 19 Mar 2020 09:52:58 +0000 (09:52 +0000)]
MDL-64429 tool_usertours: upgrade step to fix existing tours sortorder.

2 years agoMerge branch 'MDL-67072-oidc-additional-login-parameters' of https://github.com/cenga...
Jun Pataleta [Thu, 26 Mar 2020 04:15:24 +0000 (12:15 +0800)]
Merge branch 'MDL-67072-oidc-additional-login-parameters' of https://github.com/cengage/moodle

2 years agoMerge branch 'MDL-68183-master-mysqlpwdresetsql' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Thu, 26 Mar 2020 00:08:04 +0000 (01:08 +0100)]
Merge branch 'MDL-68183-master-mysqlpwdresetsql' of git://github.com/mudrd8mz/moodle

2 years agoMerge branch 'MDL-63865' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Wed, 25 Mar 2020 23:31:55 +0000 (00:31 +0100)]
Merge branch 'MDL-63865' of https://github.com/paulholden/moodle

2 years agoMerge branch 'MDL-68116-master' of git://github.com/sarjona/moodle
Eloy Lafuente (stronk7) [Wed, 25 Mar 2020 23:13:52 +0000 (00:13 +0100)]
Merge branch 'MDL-68116-master' of git://github.com/sarjona/moodle

2 years agoMerge branch 'MDL-67442' of https://github.com/jonof/moodle
Eloy Lafuente (stronk7) [Wed, 25 Mar 2020 23:04:05 +0000 (00:04 +0100)]
Merge branch 'MDL-67442' of https://github.com/jonof/moodle

2 years agoMerge branch 'MDL-68149' of https://github.com/timhunt/moodle
Jun Pataleta [Wed, 25 Mar 2020 16:10:01 +0000 (00:10 +0800)]
Merge branch 'MDL-68149' of https://github.com/timhunt/moodle

2 years agoMerge branch 'MDL-68153' of https://github.com/timhunt/moodle
Jun Pataleta [Wed, 25 Mar 2020 14:34:36 +0000 (22:34 +0800)]
Merge branch 'MDL-68153' of https://github.com/timhunt/moodle

2 years agoMerge branch 'MDL-68111-master' of https://github.com/snake/moodle
Jun Pataleta [Wed, 25 Mar 2020 00:43:28 +0000 (08:43 +0800)]
Merge branch 'MDL-68111-master' of https://github.com/snake/moodle

2 years agoMerge branch 'MDL-67024-master' of git://github.com/farhan6318/moodle
Jun Pataleta [Wed, 25 Mar 2020 00:34:41 +0000 (08:34 +0800)]
Merge branch 'MDL-67024-master' of git://github.com/farhan6318/moodle

2 years agoMerge branch 'MDL-67934' of https://github.com/timhunt/moodle
Jake Dallimore [Wed, 25 Mar 2020 00:28:27 +0000 (08:28 +0800)]
Merge branch 'MDL-67934' of https://github.com/timhunt/moodle

2 years agoMerge branch 'MDL-58413-master-take2' of git://github.com/lucaboesch/moodle
Jake Dallimore [Wed, 25 Mar 2020 00:04:47 +0000 (08:04 +0800)]
Merge branch 'MDL-58413-master-take2' of git://github.com/lucaboesch/moodle

2 years agoMerge branch 'MDL-67731' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Tue, 24 Mar 2020 22:59:26 +0000 (23:59 +0100)]
Merge branch 'MDL-67731' of https://github.com/paulholden/moodle

2 years agoMerge branch 'MDL-67930' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Tue, 24 Mar 2020 21:48:05 +0000 (22:48 +0100)]
Merge branch 'MDL-67930' of https://github.com/paulholden/moodle

2 years agoMerge branch 'MDL-68068-master' of git://github.com/cescobedo/moodle
Eloy Lafuente (stronk7) [Tue, 24 Mar 2020 21:38:59 +0000 (22:38 +0100)]
Merge branch 'MDL-68068-master' of git://github.com/cescobedo/moodle

2 years agoMerge branch 'MDL-68135-master' of git://github.com/rezaies/moodle
Jake Dallimore [Tue, 24 Mar 2020 04:10:33 +0000 (12:10 +0800)]
Merge branch 'MDL-68135-master' of git://github.com/rezaies/moodle

2 years agoAutomatically generated installer lang files
AMOS bot [Tue, 24 Mar 2020 00:10:58 +0000 (00:10 +0000)]
Automatically generated installer lang files

2 years agoMDL-58964 navigation: Reindex array when element is removed
Alexander Bias [Mon, 23 Mar 2020 20:33:47 +0000 (21:33 +0100)]
MDL-58964 navigation: Reindex array when element is removed

2 years agoMDL-52319 upgrade: Better report the environment checks in CLI scripts
David Mudrák [Fri, 13 Mar 2020 17:34:16 +0000 (18:34 +0100)]
MDL-52319 upgrade: Better report the environment checks in CLI scripts

Before we did not display the source of the environment check failure
(whether it was a core check or a plugin) and there was a missing space
before the "Error" status.

2 years agoMDL-52319 install: Fix some coding style issues
Tim Hunt [Fri, 13 Mar 2020 14:14:25 +0000 (14:14 +0000)]
MDL-52319 install: Fix some coding style issues

2 years agoMDL-52319 upgrade: Also run environment checks if plugins need upgrades
Tim Hunt [Fri, 13 Mar 2020 13:57:43 +0000 (13:57 +0000)]
MDL-52319 upgrade: Also run environment checks if plugins need upgrades

Also perform the environment checks if a plugin triggers the upgrade.
Core upgrade and CLI upgrade was doing this already.

2 years agoMDL-68111 core: add 'enablemoodlenet' setting to advanced features
Jake Dallimore [Thu, 5 Mar 2020 03:44:06 +0000 (11:44 +0800)]
MDL-68111 core: add 'enablemoodlenet' setting to advanced features

This will control whether any MoodleNet features are presented to users

2 years agoAutomatically generated installer lang files
AMOS bot [Mon, 23 Mar 2020 00:12:05 +0000 (00:12 +0000)]
Automatically generated installer lang files

2 years agoMDL-64429 tool_usertours: ensure tour sortorder can't move out of range.
Paul Holden [Fri, 31 Jan 2020 08:51:17 +0000 (08:51 +0000)]
MDL-64429 tool_usertours: ensure tour sortorder can't move out of range.

2 years agoMDL-63865 tool_dataprivacy: unit test for plugin privacy provider.
Paul Holden [Thu, 30 Jan 2020 23:25:23 +0000 (23:25 +0000)]
MDL-63865 tool_dataprivacy: unit test for plugin privacy provider.

2 years agoMDL-67731 backup: fix async restores in progress table listing.
Paul Holden [Fri, 13 Mar 2020 23:30:33 +0000 (23:30 +0000)]
MDL-67731 backup: fix async restores in progress table listing.

2 years agoMDL-67930 mod_forum: consistent default group image when hidden.
Paul Holden [Fri, 13 Mar 2020 20:42:37 +0000 (20:42 +0000)]
MDL-67930 mod_forum: consistent default group image when hidden.

2 years agoMDL-67072 mod_lti: OIDC additional login parameters
Adrian Hutchinson [Mon, 17 Feb 2020 17:29:38 +0000 (09:29 -0800)]
MDL-67072 mod_lti: OIDC additional login parameters

2 years agoMDL-58413 mod_url: support internationalized domain names.
Luca Bösch [Wed, 4 Mar 2020 09:23:25 +0000 (10:23 +0100)]
MDL-58413 mod_url: support internationalized domain names.

Internationalized domain names (IDN) do work in the URL resource.

2 years agoMDL-68116 atto_h5p: deprecate unused strings
Sara Arjona [Wed, 18 Mar 2020 13:25:59 +0000 (14:25 +0100)]
MDL-68116 atto_h5p: deprecate unused strings

2 years agoMDL-68116 atto_h5p: simplify fields to add H5P content
Sara Arjona [Wed, 18 Mar 2020 13:11:31 +0000 (14:11 +0100)]
MDL-68116 atto_h5p: simplify fields to add H5P content

The embed section has been removed in order to simplify this screen.
It was added to make easier include content coming from h5p.org but,
as soon users won't be able to use it, it makes no sense.
Users will still be able to use the "HTML" button to paste the
embed code.

2 years agoMDL-68116 filter_h5p: remove h5p.org from allowed sources
Sara Arjona [Tue, 17 Mar 2020 11:42:11 +0000 (12:42 +0100)]
MDL-68116 filter_h5p: remove h5p.org from allowed sources

h5p.org has to be removed as default value for the allowedsources in
the "Display H5P" filter because H5P is going to close it down completely
so that only the author can see the test content.

2 years agoMDL-68068 core_h5p: Replace $_SESSION by $SESSION
cescobedo [Sat, 29 Feb 2020 09:50:40 +0000 (10:50 +0100)]
MDL-68068 core_h5p: Replace $_SESSION by $SESSION

The third-party library H5P has some references to  instead of Moodle's.
That implies that the information is not saved to backends and other issues,
so only the Moodle one should be used by core (core should be free from  and always use .).

2 years agoMDL-67024 Lib: Check if user->mnethostid is set before using it
Farhan Karmali [Mon, 24 Feb 2020 08:17:14 +0000 (13:47 +0530)]
MDL-67024 Lib: Check if user->mnethostid is set before using it

2 years agoweekly release 3.9dev
Adrian Greeve [Fri, 20 Mar 2020 05:35:42 +0000 (13:35 +0800)]
weekly release 3.9dev

2 years agoMDL-58964 navigation: Add class attributes to Boost flat navigation
Alexander Bias [Thu, 19 Mar 2020 19:34:24 +0000 (20:34 +0100)]
MDL-58964 navigation: Add class attributes to Boost flat navigation

2 years agoMDL-60817 file: Populate header only if exists
Peter Dias [Thu, 19 Mar 2020 04:00:03 +0000 (12:00 +0800)]
MDL-60817 file: Populate header only if exists

2 years agoMDL-68049 mod_lti: Fix link-level memberships service
Stephen Vickers [Tue, 25 Feb 2020 21:01:52 +0000 (21:01 +0000)]
MDL-68049 mod_lti: Fix link-level memberships service

Fix cause of 404 error
Ensure personal name and email fields are included
Add ext_user_username field when being passed in LTI messages

2 years agoMerge branch 'MDL-68081-master' of https://github.com/kritisingh1/moodle
Adrian Greeve [Thu, 19 Mar 2020 03:26:25 +0000 (11:26 +0800)]
Merge branch 'MDL-68081-master' of https://github.com/kritisingh1/moodle

2 years agoMerge branch 'MDL-68014-master' of git://github.com/peterRd/moodle
Adrian Greeve [Thu, 19 Mar 2020 03:03:07 +0000 (11:03 +0800)]
Merge branch 'MDL-68014-master' of git://github.com/peterRd/moodle

2 years agoMerge branch 'MDL-67924' of https://github.com/Chocolate-lightning/moodle
Adrian Greeve [Thu, 19 Mar 2020 01:41:30 +0000 (09:41 +0800)]
Merge branch 'MDL-67924' of https://github.com/Chocolate-lightning/moodle

2 years agoMerge branch 'MDL-68108-master' of git://github.com/crazyserver/moodle
Jun Pataleta [Wed, 18 Mar 2020 15:01:08 +0000 (23:01 +0800)]
Merge branch 'MDL-68108-master' of git://github.com/crazyserver/moodle

2 years agoMerge branch 'MDL-60817-master-4' of git://github.com/mihailges/moodle
Víctor Déniz Falcón [Wed, 18 Mar 2020 14:26:30 +0000 (14:26 +0000)]
Merge branch 'MDL-60817-master-4' of git://github.com/mihailges/moodle

2 years agoMDL-68108 formslib: Add element password inline template
Pau Ferrer Ocaña [Wed, 4 Mar 2020 11:14:37 +0000 (12:14 +0100)]
MDL-68108 formslib: Add element password inline template

2 years agoMerge branch 'MDL-67901-master' of git://github.com/bmbrands/moodle
Adrian Greeve [Wed, 18 Mar 2020 01:57:41 +0000 (09:57 +0800)]
Merge branch 'MDL-67901-master' of git://github.com/bmbrands/moodle

2 years agoMDL-68191 CSS minification: apply upstream performance/accuracy fix
Tim Hunt [Tue, 17 Mar 2020 23:18:08 +0000 (23:18 +0000)]
MDL-68191 CSS minification: apply upstream performance/accuracy fix

There was a bug with the code to strip comments.
https://github.com/matthiasmullie/minify/issues/317

Applying the fix as a Moodle-specific change for now, because the
effect is significant.

2 years agoMerge branch 'MDL-68056-master' of https://github.com/snake/moodle
Jun Pataleta [Tue, 17 Mar 2020 23:21:22 +0000 (07:21 +0800)]
Merge branch 'MDL-68056-master' of https://github.com/snake/moodle

2 years agoMDL-68183 auth: Fix the performance of get_complete_user_data search
David Mudrák [Tue, 17 Mar 2020 13:44:50 +0000 (14:44 +0100)]
MDL-68183 auth: Fix the performance of get_complete_user_data search

When searching for the user by a case-insensitive field (email address
is the only one supported now), the performance may be very poor as the
DB cannot use the index due to the LOWER() operation and the full
sequential scan of all the user records is performed. On some DBs such
as MySQL, this can be significantly improved by pre-filtering the users
with accent-insensitive search.

So we first perform accent-insensitive search for potential candidates
in a subselect, which can use the index. Only then we perform the
additional accent-sensitive search on this limited set or records.

2 years agoMDL-68183 auth: Fix the performance of signup_validate_data search query
David Mudrák [Tue, 17 Mar 2020 12:04:07 +0000 (13:04 +0100)]
MDL-68183 auth: Fix the performance of signup_validate_data search query

When searching for other users with the same email address, we perform
the case-insensitive and accent-sensitive search. That may be expensive
as some DBs such as MySQL cannot use the index in that case. Instead,
sequential scan of all the user records is performed and the comparison
uses the LOWER function to filter the matching records. This leads to
significant performance heavy queries which in turn represent a surface
for DoS attacks.

For that reason, we first perform accent-insensitive search for
potential candidates in a subselect, which can use the index. Only then
we perform the additional accent-sensitive search on this limited set or
records.

2 years agoMDL-68183 auth: Fix the performance of forgotten password user search
David Mudrák [Mon, 16 Mar 2020 21:39:49 +0000 (22:39 +0100)]
MDL-68183 auth: Fix the performance of forgotten password user search

When searching for the user matching the given email address, we perform
the case-insensitive and accent-sensitive search. That may be expensive
as some DBs such as MySQL cannot use the index in that case. Instead,
sequential scan of all the user records is performed and the comparison
uses the LOWER function to filter the matching records. This leads to
significant performance heavy queries which in turn represent a surface
for DoS attacks.

For that reason, we first perform accent-insensitive search for
potential candidates, which can use the index. Only then we perform the
additional accent-sensitive search on this limited set or records.

2 years agoMerge branch 'MDL-67707-master' of git://github.com/ferranrecio/moodle
Sara Arjona [Tue, 17 Mar 2020 08:03:12 +0000 (09:03 +0100)]
Merge branch 'MDL-67707-master' of git://github.com/ferranrecio/moodle

2 years agoMerge branch 'MDL-67907-master' of git://github.com/dpalou/moodle
Adrian Greeve [Tue, 17 Mar 2020 08:01:26 +0000 (16:01 +0800)]
Merge branch 'MDL-67907-master' of git://github.com/dpalou/moodle