Sara Arjona [Wed, 22 May 2019 12:57:39 +0000 (14:57 +0200)]
Merge branch 'MDL-65661-master' of git://github.com/peterRd/moodle
Jun Pataleta [Wed, 22 May 2019 11:36:11 +0000 (19:36 +0800)]
Merge branch 'MDL-65636' of https://github.com/timhunt/moodle
Peter [Wed, 22 May 2019 11:30:48 +0000 (19:30 +0800)]
MDL-65661 block_myoverview: Truncate category name
Peter [Tue, 21 May 2019 09:43:28 +0000 (17:43 +0800)]
MDL-65661 core_course: Truncate long course names
Tim Hunt [Fri, 17 May 2019 11:22:19 +0000 (12:22 +0100)]
MDL-65636 filter_multilang: add some basic unit tests
This commit includes suggestions from Jun Pataleta on how to improve the
unit tests.
Adrian Greeve [Wed, 22 May 2019 08:29:52 +0000 (16:29 +0800)]
Merge branch 'MDL-65067_master' of https://github.com/dmonllao/moodle
Adrian Greeve [Wed, 22 May 2019 06:48:28 +0000 (14:48 +0800)]
Merge branch 'MDL-64784' of https://github.com/paulholden/moodle
Andrew Nicols [Wed, 22 May 2019 05:52:14 +0000 (13:52 +0800)]
Merge branch 'MDL-65590-master' of git://github.com/rezaies/moodle
Jun Pataleta [Wed, 22 May 2019 03:06:31 +0000 (11:06 +0800)]
Merge branch 'MDL-65591-master' of git://github.com/rezaies/moodle
Andrew Nicols [Wed, 22 May 2019 01:43:13 +0000 (09:43 +0800)]
Merge branch 'MDL-65630-master' of git://github.com/rezaies/moodle
Sara Arjona [Tue, 21 May 2019 11:47:31 +0000 (13:47 +0200)]
Merge branch 'MDL-65605-master' of git://github.com/rezaies/moodle
Jun Pataleta [Tue, 21 May 2019 10:49:33 +0000 (18:49 +0800)]
Merge branch 'MDL-65274-master' of git://github.com/jleyva/moodle
Jun Pataleta [Tue, 21 May 2019 10:44:52 +0000 (18:44 +0800)]
Merge branch 'MDL-60407-master' of git://github.com/vmdef/moodle
Adrian Greeve [Tue, 21 May 2019 07:19:29 +0000 (15:19 +0800)]
Merge branch 'MDL-65572-master' of git://github.com/damyon/moodle
Andrew Nicols [Tue, 21 May 2019 04:49:32 +0000 (12:49 +0800)]
Merge branch 'MDL-65644' of git://github.com/stronk7/moodle
Shamim Rezaie [Tue, 14 May 2019 06:18:10 +0000 (16:18 +1000)]
MDL-65590 tool_customlang: Escape html on the standard text field
Adrian Greeve [Tue, 21 May 2019 03:42:13 +0000 (11:42 +0800)]
Merge branch 'MDL-65655-37-forumcroninactiveusers' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Mon, 20 May 2019 17:35:05 +0000 (19:35 +0200)]
MDL-65644 upgrade: add 3.7.0 separation line to all upgrade scripts
David Mudrák [Mon, 20 May 2019 16:39:13 +0000 (18:39 +0200)]
MDL-65655 forum: Do not send notifications to inactive users
We cannot deliver notifications to users who had subscribed to a forum
or discussion and were later inactivated either by suspending or setting
the auth method to nologin. The deliver adhoc task cannot be run as
these users, throwing the "Suspended account" exception.
The solution is to make sure that fetch_subscribed_users() does not
include those inactive users.
Shamim Rezaie [Tue, 14 May 2019 04:40:26 +0000 (14:40 +1000)]
MDL-65591 tool_customlang: Re-adding the save buttons at the bottom
Juan Leyva [Tue, 14 May 2019 15:00:25 +0000 (17:00 +0200)]
MDL-65274 mod_quiz: Do not return a translated string
We should be returning proper error codes and the translated string can be part of the debug information.
Shamim Rezaie [Wed, 15 May 2019 07:52:17 +0000 (17:52 +1000)]
MDL-65605 core_question: Fix the issue when get_draft_files returns nul
Shamim Rezaie [Wed, 15 May 2019 07:47:50 +0000 (17:47 +1000)]
MDL-65605 mod_lesson: Fix the issue when get_draft_files returns null
Shamim Rezaie [Mon, 20 May 2019 12:56:57 +0000 (22:56 +1000)]
MDL-65630 mod_quiz: Allow redo within an attempt with random questions
Shamim Rezaie [Mon, 20 May 2019 05:30:01 +0000 (15:30 +1000)]
MDL-65630 mod_quiz: Move logging in to the start of tests
The background is for set up, the scenario is for the test. Logging in
to start the test is the start of the test and the end of the background
itself.
Andrew Nicols [Mon, 20 May 2019 06:24:49 +0000 (14:24 +0800)]
Merge branch 'MDL-65643' of git://github.com/stronk7/moodle
Damyon Wiese [Mon, 13 May 2019 03:41:43 +0000 (11:41 +0800)]
MDL-65572 messaging: Loginas upgrade check
When using login as, we also need to check if there are legacy messages that
need updating and set the user preference if required.
Eloy Lafuente (stronk7) [Sun, 19 May 2019 19:11:05 +0000 (21:11 +0200)]
MDL-65643 backup: Bump release to 3.8
Eloy Lafuente (stronk7) [Sun, 19 May 2019 09:24:14 +0000 (11:24 +0200)]
weekly back-to-dev release 3.8dev
Eloy Lafuente (stronk7) [Sun, 19 May 2019 09:18:33 +0000 (11:18 +0200)]
Moodle release 3.7
Eloy Lafuente (stronk7) [Sun, 19 May 2019 09:18:34 +0000 (11:18 +0200)]
NOBUG: Change travis.yml back to master
Eloy Lafuente (stronk7) [Sun, 19 May 2019 09:18:34 +0000 (11:18 +0200)]
NOBUG: Change travis.yml to MOODLE_37_STABLE
Eloy Lafuente (stronk7) [Sun, 19 May 2019 09:18:30 +0000 (11:18 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Eloy Lafuente (stronk7) [Sat, 18 May 2019 18:41:52 +0000 (20:41 +0200)]
MDL-65635 forum: Small improvement to the submit inline-reply
This commit mimics 100% the behavior achieved with the
parent commit of this when using the advance option.
1) Rename the 'tohtml' option to 'topreferredformat' to better
represent what it's doing.
2) Always honor the preferred format (this is a new post).
3) Only perform the conversion to HTML when the preferred format is
HTML.
That way any user, no matter thy are using format MOODLE (plain textbox),
MARKDOWN (marklar editor) or HTML (atto and tinymce editor) will
get always the format correct and the contents ready to be edited if
desired. HTML ones converted to HTML and TEXT ones unmodified.
Eloy Lafuente (stronk7) [Sat, 18 May 2019 17:49:39 +0000 (19:49 +0200)]
MDL-65635 forum: Small improvement to the advanced button
1) Always honor the preferred format (this is a new post).
2) Only perform the conversion to HTML when the preferred format is
HTML.
This way, users having HTML as format (because of their editor
preference) will get the inline-reply converted to HTML and the
editor displayed.
And users not having HTML as format (because of their edito preference)
will get the format set to their format (PLAIN, MOODLE or MARKDOWN) with the
contents unmodified. Of course, if anybody is using a PLAIN, MOODLE or
MARKDOWN editor... it will be displayed.
Sara Arjona [Fri, 17 May 2019 19:39:57 +0000 (21:39 +0200)]
MDL-65635 forum: convert inline reply format when opening the advanced
When a inline reply post is written and the user changes to the
advanced edition, the post format has to be converted from FORMAT_MOODLE.
Sara Arjona [Fri, 17 May 2019 17:55:29 +0000 (19:55 +0200)]
MDL-65635 forum: Add messageformat and tohtml params to inline-reply
The messageformat and tohtml params have been added to the addDiscussionPost
method to send the original format the contents are written and to force
to convert them from "messageformat" to HTML.
Eloy Lafuente (stronk7) [Fri, 17 May 2019 18:44:48 +0000 (20:44 +0200)]
MDL-65635 forum: add_discussion_post() format support changes
While keeping BC as possible (format will be saved as FORMAT_HTML
as default and content not modified), this commit includes these
changes:
- A new parameter 'messageformat', defaults to FORMAT_HTML.
- A new option 'tohtml', enabling the function to convert content
in other formats to FORMAT_HTML before saving them.
Eloy Lafuente (stronk7) [Sun, 19 May 2019 08:23:36 +0000 (10:23 +0200)]
Merge branch 'MDL-65641' of git://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Fri, 17 May 2019 23:54:52 +0000 (01:54 +0200)]
MDL-65641 forum: Make forum post form to honor existing MOODLE_FORMAT
Since the night of the times (MDL-16698) we have been performing
that simple empty($post->messageformat) check to decide if the
preferred editor format should be used, instead of any existing format.
Problem is that FORMAT_MOODLE == 0, so the condition evaluates
to to true and then the preferred editor takes the baton when it should
not. Exiting format must win always!
So this just makes the condition a little better, checking if the
attribute is set and that it's numerical (accepting both n and 'n').
That covers the FORMAT_MOODLE case and any other valid format. Only if the
conditions aren't met the preferred editor format takes the baton. Only
then.
AMOS bot [Sat, 18 May 2019 00:12:30 +0000 (00:12 +0000)]
Automatically generated installer lang files
David Monllaó [Fri, 17 May 2019 14:57:46 +0000 (16:57 +0200)]
MDL-65067 tool_analytics: Limit update_end_date to format_weeks
Didier 'OdyX' Raboud [Thu, 14 Mar 2019 13:00:27 +0000 (14:00 +0100)]
MDL-65067 analytics: Strengthen format_weeks detection
The public function get_section_dates($section, $startdate = false) is
only defined in format_weeks, not in format_base.
As other formats can (and format_topcoll has) declare a different
get_section_dates public method, merely checking that it exists is not
sufficient to guarantee that it can be called with just a section object.
Check that the format either is, or is a subclass of format_weeks.
AMOS bot [Fri, 17 May 2019 00:14:21 +0000 (00:14 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Thu, 16 May 2019 08:57:08 +0000 (10:57 +0200)]
Moodle release 3.7rc2
Jake Dallimore [Thu, 16 May 2019 07:14:27 +0000 (15:14 +0800)]
Merge branch 'MDL-65619-master' of git://github.com/aanabit/moodle
Jun Pataleta [Thu, 16 May 2019 07:05:47 +0000 (15:05 +0800)]
Merge branch 'MDL-65608-master' of https://github.com/ryanwyllie/moodle
Adrian Greeve [Thu, 16 May 2019 05:23:22 +0000 (13:23 +0800)]
Merge branch 'MDL-65601_master' of git://github.com/dmonllao/moodle
Jun Pataleta [Thu, 16 May 2019 04:56:51 +0000 (12:56 +0800)]
Merge branch 'MDL-65607-master' of git://github.com/mihailges/moodle
Mihail Geshoski [Thu, 16 May 2019 03:49:37 +0000 (11:49 +0800)]
MDL-65607 forum: Add prefix to forum global functions
Jun Pataleta [Thu, 16 May 2019 03:01:57 +0000 (11:01 +0800)]
Merge branch 'MDL-65603-master' of git://github.com/peterRd/moodle
Jun Pataleta [Thu, 16 May 2019 02:35:59 +0000 (10:35 +0800)]
Merge branch 'MDL-65610-master' of git://github.com/damyon/moodle
Ryan Wyllie [Wed, 15 May 2019 05:57:09 +0000 (13:57 +0800)]
MDL-65608 forum: check if group exists in discussion exporter
Eloy Lafuente (stronk7) [Wed, 15 May 2019 17:48:15 +0000 (19:48 +0200)]
Merge branch 'MDL-65566-master-jake' of https://github.com/snake/moodle
Amaia Anabitarte [Wed, 15 May 2019 16:35:56 +0000 (18:35 +0200)]
MDL-65619 core_message: Don't unset default notification preferences
Default notification preferences are not kept when a notification provider is disabled.
Sara Arjona [Wed, 15 May 2019 12:19:45 +0000 (14:19 +0200)]
Merge branch 'MDL-65596-master' of git://github.com/bmbrands/moodle
Jake Dallimore [Wed, 15 May 2019 10:28:15 +0000 (18:28 +0800)]
MDL-65566 core_message: let get_self_conversation use lazy init too
Jake Dallimore [Wed, 15 May 2019 10:15:56 +0000 (18:15 +0800)]
MDL-65566 core_message: fix bug allowing duplicate unique conversations
Individual and self conversations may exist once only, so we need to
enforce this in the creation method.
Jake Dallimore [Wed, 15 May 2019 07:27:17 +0000 (15:27 +0800)]
MDL-65566 core_user: remove the conversation creation code from lib.php
These are now lazy created in the messaging APIs, so we don't need
to create them on user creation any more.
Sara Arjona [Fri, 10 May 2019 14:09:16 +0000 (16:09 +0200)]
MDL-65566 core_message: create the self-conversation when needed
Instead of creating all the self-conversations during the upgrading,
some code has been added to the get_conversations and to the
get_conversation_counts to create it whe it doesn't exist.
Sara Arjona [Wed, 15 May 2019 10:14:46 +0000 (12:14 +0200)]
Merge branch 'MDL-65528-master' of git://github.com/peterRd/moodle
Peter [Wed, 15 May 2019 08:50:49 +0000 (16:50 +0800)]
MDL-65603 mod_forum: Add check for property existence
Jun Pataleta [Wed, 15 May 2019 07:57:05 +0000 (15:57 +0800)]
Merge branch 'MDL-65583_master' of git://github.com/dmonllao/moodle
David Monllaó [Tue, 14 May 2019 17:16:50 +0000 (19:16 +0200)]
MDL-65601 analytics: Add missing set_modelid calls
Jun Pataleta [Wed, 15 May 2019 07:24:12 +0000 (15:24 +0800)]
Merge branch 'MDL-65599-master' of git://github.com/damyon/moodle
Jun Pataleta [Wed, 15 May 2019 06:58:35 +0000 (14:58 +0800)]
Merge branch 'MDL-65570-master' of git://github.com/lameze/moodle
Jun Pataleta [Wed, 15 May 2019 05:47:26 +0000 (13:47 +0800)]
Merge branch 'MDL-65577-master' of https://github.com/ryanwyllie/moodle
Damyon Wiese [Wed, 15 May 2019 05:46:56 +0000 (13:46 +0800)]
MDL-65610 lti: ltiversion field optional
The ltiversion field only exists for some preconfigured tool types.
Ryan Wyllie [Tue, 14 May 2019 03:56:33 +0000 (11:56 +0800)]
MDL-65577 forum: move forum focus outline onto post div
Jun Pataleta [Wed, 15 May 2019 02:52:57 +0000 (10:52 +0800)]
Merge branch 'MDL-65393-master' of git://github.com/rezaies/moodle
Damyon Wiese [Wed, 15 May 2019 02:02:04 +0000 (10:02 +0800)]
MDL-65599 competencies: Javascript optional param
The module id is expected to be an integer for this webservice, passing
an empty string will generate an exception.
Peter [Wed, 15 May 2019 01:50:46 +0000 (09:50 +0800)]
MDL-65603 mod_forum: Recall inline private reply
Simey Lameze [Wed, 15 May 2019 01:05:37 +0000 (09:05 +0800)]
MDL-65570 qtype_multianswer: use unique id function
Shamim Rezaie [Tue, 14 May 2019 16:30:48 +0000 (02:30 +1000)]
MDL-65393 core: Peer review amendments
- defining and using constand properties instead of hard-coded values
- Fixing the docblock for the cleanup_recent_session_locks function
Ilya Tregubov [Tue, 23 Apr 2019 01:40:17 +0000 (11:40 +1000)]
MDL-65393 core: Make session history cleanup more aggressive.
Bas Brands [Tue, 14 May 2019 10:08:42 +0000 (12:08 +0200)]
MDL-65596 core_message: dropdown menu blocked by contact request message
Sara Arjona [Tue, 14 May 2019 10:11:25 +0000 (12:11 +0200)]
Moodle release 3.7rc1
Jun Pataleta [Tue, 14 May 2019 04:53:50 +0000 (12:53 +0800)]
Merge branch 'MDL-65569-master' of git://github.com/andrewnicols/moodle
Peter [Tue, 14 May 2019 04:47:32 +0000 (12:47 +0800)]
MDL-65528 mod_forum: Do not render add discussion if not permitted
Andrew Nicols [Tue, 14 May 2019 01:56:33 +0000 (09:56 +0800)]
MDL-65569 mod_forum: Correct rules for SSD
In a Single Simple Discussion forum, the first post can only be edited
by a user with the manageactivities capability, but all other posts
behave as normal.
Andrew Nicols [Tue, 14 May 2019 04:17:25 +0000 (12:17 +0800)]
Merge branch 'MDL-65574-master' of https://github.com/ryanwyllie/moodle
Jun Pataleta [Tue, 14 May 2019 03:32:02 +0000 (11:32 +0800)]
Merge branch 'MDL-65536-master' of https://github.com/snake/moodle
Andrew Nicols [Fri, 10 May 2019 06:10:37 +0000 (14:10 +0800)]
MDL-65536 mod_lti: JWT should use the class loader
Damyon Wiese [Fri, 10 May 2019 02:01:56 +0000 (10:01 +0800)]
MDL-65536 mod_lti: OpenSSL configuration
LTI 1.3 requires working openssl functions to generate a private
key used for the JWT. Some installs (e.g. windows) can have the
functions available - but require configuration in php before they
actually do anything.
Ryan Wyllie [Tue, 14 May 2019 02:43:37 +0000 (10:43 +0800)]
MDL-65574 forum: fix return type for get_first_post_for_discussion_ids
Adrian Greeve [Tue, 14 May 2019 02:20:45 +0000 (10:20 +0800)]
Merge branch 'MDL-65582_master' of git://github.com/dmonllao/moodle
Jun Pataleta [Tue, 14 May 2019 01:52:36 +0000 (09:52 +0800)]
Merge branch 'MDL-65557-master' of https://github.com/ryanwyllie/moodle
Ryan Wyllie [Mon, 13 May 2019 08:25:14 +0000 (16:25 +0800)]
MDL-65557 forum: increase default image size of author profile url
Víctor Déniz Falcón [Tue, 14 May 2019 00:06:00 +0000 (01:06 +0100)]
MDL-60407 report_insights: Fix redirect when action on last prediction
When an actions is taken on the last prediction, the predictions
list page is reloaded.
David Monllaó [Mon, 13 May 2019 11:34:07 +0000 (13:34 +0200)]
MDL-65583 tool_analytics: Model name from a data attribute
The credit and the patch using this approach goes to David Mudrák.
Sara Arjona [Mon, 13 May 2019 19:19:11 +0000 (21:19 +0200)]
Merge branch 'MDL-65581-master' of git://github.com/bmbrands/moodle
David Monllaó [Mon, 13 May 2019 11:00:17 +0000 (13:00 +0200)]
MDL-65582 analytics: Upcoming activities due enabled by default
Bas Brands [Mon, 13 May 2019 10:02:44 +0000 (12:02 +0200)]
MDL-65581 core_blocks: change classname for hidden blocks
Changing the added class .invisible to .ivisibleblock to avoid hiding the block completely
Sara Arjona [Mon, 13 May 2019 08:39:10 +0000 (10:39 +0200)]
Merge branch 'MDL-65564-master' of git://github.com/marinaglancy/moodle
Sara Arjona [Mon, 13 May 2019 08:02:31 +0000 (10:02 +0200)]
Merge branch 'MDL-65224-master' of https://github.com/ewallah/moodle
Jun Pataleta [Mon, 13 May 2019 07:47:52 +0000 (15:47 +0800)]
Merge branch 'MDL-65571' of git://github.com/stronk7/moodle
Sara Arjona [Mon, 13 May 2019 07:40:37 +0000 (09:40 +0200)]
Merge branch 'MDL-65544-master' of git://github.com/damyon/moodle
Ryan Wyllie [Mon, 13 May 2019 07:03:26 +0000 (15:03 +0800)]
MDL-65574 forum: discussion_list vault uses post table for author
Update the discussion_list vault to use the first post record from
the posts table join to get the author of the first post rather
than relying on it's own "userid" column which can be incorrect in
the case of split discussions.
Damyon Wiese [Fri, 10 May 2019 06:34:51 +0000 (14:34 +0800)]
MDL-65544 badges: Any all criteria
When testing any vs all aggregation method, we expect a different result
when we have looped all the competencies and they all passed or failed.
Adrian Greeve [Mon, 13 May 2019 01:43:58 +0000 (09:43 +0800)]
Merge branch 'MDL-65560-master' of git://github.com/lameze/moodle