Jun Pataleta [Wed, 6 Nov 2019 08:12:46 +0000 (16:12 +0800)]
Merge branch 'MDL-67097-master-2' of https://github.com/snake/moodle
Sara Arjona [Wed, 6 Nov 2019 07:30:41 +0000 (08:30 +0100)]
Merge branch 'MDL-66984-change_password_url-with-user' of https://github.com/brendanheywood/moodle
cescobedo [Thu, 31 Oct 2019 18:27:32 +0000 (19:27 +0100)]
MDL-67082 core_h5p: Add new contexts to check h5p file permissions
cescobedo [Wed, 30 Oct 2019 12:50:14 +0000 (13:50 +0100)]
MDL-67082 core_h5p: Check component_callback called for right context
Jake Dallimore [Wed, 6 Nov 2019 03:48:21 +0000 (11:48 +0800)]
Merge branch 'MDL-67074-master' of git://github.com/andrewnicols/moodle
Jake Dallimore [Mon, 4 Nov 2019 03:14:46 +0000 (11:14 +0800)]
MDL-67097 libraries: add unit test verifying rtl directive failure case
When a closing comment is used, such as when we wrap css with the
rtl:begin:ignore and rtl:end:ignore (the latter being the closing),
it is ignored in the following case:
- If the closing comment is the last item in a csslist like:
div {/*rtl:begin:ignore*/left:20px; text-align:left/*rtl:end:ignore*/}
in which case there is no css rule following the comment for it to be
associated with. It is therefore not seen and registered, meaning we
continue ignoring rtl (a bug).
In such cases, we should either:
- ensure the comment is not the final element in the css list
- use self-closing (/*rtl:ignore*/) comments for each rule instead.
- use a self-closing comment on the entire css list, if applicable.
Jake Dallimore [Mon, 4 Nov 2019 02:27:04 +0000 (10:27 +0800)]
MDL-67097 libraries: update upgrade notes for sabberworm/php-css-parser
Until the upstream patch is accepted, we need to patch this locally.
Jake Dallimore [Fri, 1 Nov 2019 05:21:17 +0000 (13:21 +0800)]
MDL-67097 libraries: fix comment parsing in php-css-parser library
This fixes a bug when parsing the following rule-level and list-level
comments.
div {/*rtl:ignore*/left:10px;/*rtl:ignore*/ display:inline;}
/*rtl:ignore*/div {left:10px;} /*rtl:ignore*/ a {left:10px}
The latter rtl directive was being swallowed by the parser in these
cases and was not being properly allocated as a property of the rule
or csslist.
This restores the correct behaviour of the rtlcss library, which depends
on php-css-parser.
Jake Dallimore [Fri, 1 Nov 2019 01:51:04 +0000 (09:51 +0800)]
MDL-67097 libraries: add unit tests for the core_rtlcss class
The core_rtlcss class extends the \MoodleHQ\RTLCSS\RTLCSS class. This
upstream library had tests, but these were not included in core. This
change uses those test cases to test core_rtlcss, to make sure future
lib changes don't break the css parsing.
Michael Hawkins [Tue, 29 Oct 2019 08:29:46 +0000 (16:29 +0800)]
MDL-66161 output: Escaping fatal error message and URL strings
Juan Leyva [Fri, 16 Aug 2019 13:01:38 +0000 (14:01 +0100)]
MDL-66377 user: Only allow active users to retrieve files via tokenpluginfile.php
Paul Holden [Wed, 24 Jul 2019 10:46:31 +0000 (11:46 +0100)]
MDL-66228 mod_lesson: ensure return URL parameters are always local.
Eloy Lafuente (stronk7) [Tue, 5 Nov 2019 12:34:51 +0000 (13:34 +0100)]
on-demand release 3.8dev+
Eloy Lafuente (stronk7) [Tue, 5 Nov 2019 12:34:50 +0000 (13:34 +0100)]
NOBUG: Fixed SVG browser compatibility
Eloy Lafuente (stronk7) [Tue, 5 Nov 2019 12:34:49 +0000 (13:34 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Sara Arjona [Tue, 5 Nov 2019 10:06:14 +0000 (11:06 +0100)]
Merge branch 'MDL-66399-master-fix' of git://github.com/andrewnicols/moodle
Andrew Nicols [Tue, 5 Nov 2019 06:19:08 +0000 (14:19 +0800)]
MDL-66399 editor: Only set h5p settings if user can deploy
Adrian Greeve [Tue, 5 Nov 2019 05:09:06 +0000 (13:09 +0800)]
Merge branch 'MDL-67047-master' of git://github.com/jleyva/moodle
Andrew Nicols [Tue, 5 Nov 2019 04:10:51 +0000 (12:10 +0800)]
MDL-67074 forum: Add a new toast region when in full screen mode
Andrew Nicols [Tue, 5 Nov 2019 03:58:56 +0000 (11:58 +0800)]
Merge branch 'MDL-66381-master' of git://github.com/Chocolate-lightning/moodle_forum-project
Mathew May [Fri, 1 Nov 2019 03:56:46 +0000 (11:56 +0800)]
MDL-66381 mod_forum: User search and dropdown
Jake Dallimore [Tue, 5 Nov 2019 03:42:48 +0000 (11:42 +0800)]
Merge branch 'MDL-66455-master' of git://github.com/lameze/moodle
AMOS bot [Tue, 5 Nov 2019 00:10:17 +0000 (00:10 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Tue, 5 Nov 2019 00:03:58 +0000 (01:03 +0100)]
Merge branch 'MDL-67117-master-2' of git://github.com/marinaglancy/moodle
Jun Pataleta [Mon, 4 Nov 2019 11:39:24 +0000 (19:39 +0800)]
Merge branch 'MDL-66582-master' of git://github.com/jleyva/moodle
Adrian Greeve [Mon, 4 Nov 2019 07:45:36 +0000 (15:45 +0800)]
Merge branch 'MDL-66679-master' of https://github.com/sammarshallou/moodle
Jake Dallimore [Mon, 4 Nov 2019 07:36:34 +0000 (15:36 +0800)]
Merge branch 'MDL-67093-master' of git://github.com/andrewnicols/moodle
Adrian Greeve [Mon, 4 Nov 2019 04:56:34 +0000 (12:56 +0800)]
Merge branch 'MDL-66770-master-2' of https://github.com/ryanwyllie/moodle
Jun Pataleta [Mon, 4 Nov 2019 03:53:40 +0000 (11:53 +0800)]
Merge branch 'MDL-67039_master' of git://github.com/dmonllao/moodle
Jun Pataleta [Mon, 4 Nov 2019 02:41:39 +0000 (10:41 +0800)]
Merge branch 'MDL-66373-master-2' of https://github.com/Chocolate-lightning/moodle_forum-project
Adrian Greeve [Mon, 4 Nov 2019 01:22:17 +0000 (09:22 +0800)]
Merge branch 'MDL-43189-master' of git://github.com/snake/moodle
Eloy Lafuente (stronk7) [Sun, 3 Nov 2019 22:15:05 +0000 (23:15 +0100)]
Merge branch 'MDL-66990-master-enfix' of git://github.com/mudrd8mz/moodle
Adrian Greeve [Fri, 1 Nov 2019 06:39:31 +0000 (14:39 +0800)]
Merge branch 'MDL-46779-master' of https://github.com/ryanwyllie/moodle
Adrian Greeve [Fri, 1 Nov 2019 06:12:38 +0000 (14:12 +0800)]
Merge branch 'MDL-46779-master' of https://github.com/ryanwyllie/moodle
Adrian Greeve [Fri, 1 Nov 2019 05:25:11 +0000 (13:25 +0800)]
Merge branch 'MDL-66770-master-2' of https://github.com/ryanwyllie/moodle
Andrew Nicols [Fri, 1 Nov 2019 05:16:56 +0000 (13:16 +0800)]
Merge branch 'MDL-67087-master' of git://github.com/marinaglancy/moodle
Ryan Wyllie [Mon, 4 Nov 2019 03:29:29 +0000 (11:29 +0800)]
MDL-66770 mod_forum: fix subscription behat tests
Michael Hawkins [Fri, 6 Sep 2019 05:06:27 +0000 (13:06 +0800)]
MDL-66373 forumreport_summary: Introduced dates filter
Added the dates data filter, and refactored summaryreport_table to
handle passing filter content into the base SQL. Previously it was only
possible to add filter content into a separate part of the query.
Michael Hawkins [Wed, 30 Oct 2019 09:14:21 +0000 (17:14 +0800)]
MDL-66373 calendar: Added datetimes to timestamps conversion web service
David Monllaó [Mon, 4 Nov 2019 01:30:36 +0000 (09:30 +0800)]
MDL-67039 analytics: Unit tests for unidimensional arrays
David Monllaó [Mon, 4 Nov 2019 01:06:52 +0000 (09:06 +0800)]
MDL-67039 analytics: Unidimensional array if no predictions
Marina Glancy [Sun, 3 Nov 2019 13:48:23 +0000 (14:48 +0100)]
MDL-67117 filter_mathjaxloader: do not position to hash
AMOS bot [Sat, 2 Nov 2019 00:09:21 +0000 (00:09 +0000)]
Automatically generated installer lang files
Helen Foster [Fri, 1 Nov 2019 10:16:10 +0000 (11:16 +0100)]
MDL-66990 lang: Import fixed English strings (en_fix)
Significant string changes:
* hidegrader_help,mod_assign - note about setting having no effect on
comments box
* configdefaultrequestcategory, configenablecourserequests,
configlockrequestcategory, lockrequestcategory, core_admin - clearer
explanation
* configenablecompletion,core_completion - including reason for setting
activity completion conditions
* emailstop,core - clearer wording
* setuplink_desc,tool_mobile - including where the app download page
link is displayed and leaving the setting empty
Shamim Rezaie [Tue, 20 Aug 2019 05:40:38 +0000 (15:40 +1000)]
MDL-43189 core: improve validating db settings during cli install
Shamim Rezaie [Mon, 8 Jul 2019 05:58:56 +0000 (15:58 +1000)]
MDL-43189 core: Validate db prefix during installation
Ryan Wyllie [Fri, 1 Nov 2019 06:34:14 +0000 (14:34 +0800)]
MDL-46779 editor: fix case of emoji picker lang string
Ryan Wyllie [Tue, 22 Oct 2019 05:29:08 +0000 (13:29 +0800)]
MDL-66770 mod_forum: put nested v2 display mode behind user preference
Ryan Wyllie [Tue, 22 Oct 2019 03:16:53 +0000 (11:16 +0800)]
MDL-66770 mod_forum: rename modern display mode to nested v2
Ryan Wyllie [Mon, 14 Oct 2019 06:37:18 +0000 (14:37 +0800)]
MDL-66770 mod_forum: move view selector out of settings drawer
Ryan Wyllie [Mon, 14 Oct 2019 06:05:03 +0000 (14:05 +0800)]
MDL-66770 mod_forum: move permalink into menu in modern display
Ryan Wyllie [Fri, 11 Oct 2019 05:28:42 +0000 (13:28 +0800)]
MDL-66770 theme: change switch styling from iOS to Material Design
Ryan Wyllie [Thu, 10 Oct 2019 05:08:36 +0000 (13:08 +0800)]
MDL-66770 mod_forum: change columns in discussion list table
Show the last post user, remove discussion author image, and fix
column widths to the size of the content.
Ryan Wyllie [Tue, 22 Oct 2019 06:57:58 +0000 (14:57 +0800)]
MDL-66770 mod_forum: move subscription from menu into toggle
Ryan Wyllie [Thu, 17 Oct 2019 07:44:01 +0000 (15:44 +0800)]
MDL-46779 editor: add emoji picker atto plugin
Mathew May [Mon, 14 Oct 2019 07:21:45 +0000 (15:21 +0800)]
MDL-66381 core_course: Modify get_enrolled_users_by_cmid
We need to also provide a user's picture along with the current information
Andrew Nicols [Fri, 1 Nov 2019 03:07:40 +0000 (11:07 +0800)]
Merge branch 'MDL-67100-master' of git://github.com/sarjona/moodle
Andrew Nicols [Fri, 1 Nov 2019 02:45:22 +0000 (10:45 +0800)]
Merge branch 'MDL-66399-master-6' of git://github.com/bmbrands/moodle
Andrew Nicols [Fri, 1 Nov 2019 02:39:08 +0000 (10:39 +0800)]
Merge branch 'MDL-66398-master' of git://github.com/aanabit/moodle
Jun Pataleta [Fri, 1 Nov 2019 02:07:13 +0000 (10:07 +0800)]
Merge branch 'MDL-67067-master' of git://github.com/mihailges/moodle
Ryan Wyllie [Tue, 22 Oct 2019 05:33:48 +0000 (13:33 +0800)]
MDL-66770 mod_forum: general UI tweaks
Andrew Nicols [Thu, 31 Oct 2019 04:39:40 +0000 (12:39 +0800)]
MDL-67093 grading: Fetch cm with get_fast_modinfo
Eloy Lafuente (stronk7) [Thu, 31 Oct 2019 23:08:16 +0000 (00:08 +0100)]
Merge branch 'MDL-66807_master' of git://github.com/dmonllao/moodle
Juan Leyva [Wed, 30 Oct 2019 09:28:20 +0000 (10:28 +0100)]
MDL-67047 block_myoverview: Return custom fields selector values
Eloy Lafuente (stronk7) [Thu, 31 Oct 2019 12:35:27 +0000 (13:35 +0100)]
on-demand release 3.8dev+
Eloy Lafuente (stronk7) [Thu, 31 Oct 2019 12:35:20 +0000 (13:35 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Juan Leyva [Thu, 24 Oct 2019 12:31:50 +0000 (14:31 +0200)]
MDL-66582 tool_mobile: Clean URLs from auth plugins
In order to avoid the WebService to break we must double check that URLs coming from auth plugins are valid.
Johan Dobbelstein [Mon, 2 Sep 2019 15:30:46 +0000 (17:30 +0200)]
MDL-66582 auth: Fix empty auth_logo in CAS/Shibboleth auth plugins
* set $idp['iconurl'] = null if no auth_logo
* lib/templates/loginform.mustache will skip NULL iconurls
* lib/ajax/service?info=tool_mobile_get_public_config will validate the NULL values
Simey Lameze [Wed, 11 Sep 2019 06:29:28 +0000 (14:29 +0800)]
MDL-66455 calendar: add coverage for event types in subscription page
Simey Lameze [Sun, 1 Sep 2019 22:59:03 +0000 (06:59 +0800)]
MDL-66455 calendar: show site level subscriptions
Jake Dallimore [Thu, 31 Oct 2019 07:53:19 +0000 (15:53 +0800)]
MDL-67086 css: Reverting MDL-66982, causing global RTL problems
Revert "Merge branch 'MDL-66982_master' of https://github.com/nadavkav/moodle"
This reverts commit
7ddf5ab75ef9d0a2f2935a0cbe34a3fc8d4a81e5, reversing
changes made to
32b625b6deb8f2ae793673bba8e80b58063e8a74.
Sara Arjona [Thu, 31 Oct 2019 10:07:16 +0000 (11:07 +0100)]
MDL-67100 core_h5p: Add autoloader to the h5p_file_storage_test
Bas Brands [Wed, 16 Oct 2019 13:33:26 +0000 (15:33 +0200)]
MDL-66399 atto_h5p: allow h5p file uploads in atto
Adrian Greeve [Thu, 31 Oct 2019 07:33:37 +0000 (15:33 +0800)]
Merge branch 'MDL-66074-OCT28' of git://github.com/Chocolate-lightning/moodle_forum-project
Mathew May [Thu, 31 Oct 2019 07:30:48 +0000 (15:30 +0800)]
MDL-66074 mod_forum: Correct 0 length styles
Adrian Greeve [Thu, 31 Oct 2019 06:34:52 +0000 (14:34 +0800)]
Merge branch 'MDL-66247-master' of git://github.com/andrewnicols/moodle
Adrian Greeve [Thu, 31 Oct 2019 05:38:49 +0000 (13:38 +0800)]
Merge branch 'MDL-66074-OCT28' of git://github.com/Chocolate-lightning/moodle_forum-project
Mathew May [Thu, 31 Oct 2019 04:55:55 +0000 (12:55 +0800)]
MDL-66074 tool_dataprivacy: Raise the expected download file size
David Monllaó [Wed, 23 Oct 2019 03:33:32 +0000 (11:33 +0800)]
MDL-66807 analytics: Fix templates for gmail
Andrew Nicols [Thu, 31 Oct 2019 03:07:56 +0000 (11:07 +0800)]
Merge branch 'MDL-67088-master' of git://github.com/marinaglancy/moodle
Andrew Nicols [Mon, 23 Sep 2019 02:01:44 +0000 (10:01 +0800)]
MDL-66247 accessibility: Correct notification alert role support
Eloy Lafuente (stronk7) [Wed, 30 Oct 2019 23:28:45 +0000 (00:28 +0100)]
Merge branch 'MDL-67038_master' of git://github.com/dmonllao/moodle
Marina Glancy [Wed, 30 Oct 2019 18:04:32 +0000 (19:04 +0100)]
MDL-67088 mod_assign: compare time without case for MacOS compat
Eloy Lafuente (stronk7) [Wed, 30 Oct 2019 18:19:12 +0000 (19:19 +0100)]
MDL-66074 mod_forum: fix SQL whitespace causing oracle to fail
Marina Glancy [Wed, 30 Oct 2019 17:52:22 +0000 (18:52 +0100)]
MDL-67087 cachestore_redis: fix warning in phpunit
sam marshall [Mon, 16 Sep 2019 13:48:40 +0000 (14:48 +0100)]
MDL-66679 Forms: Submit button remains disabled after file download
When you download a file directly from a Moodle form submit button,
the submit button disables when you click it, but you remain on that
page so we need to re-enable the button.
This commit causes it to re-enable once the file download finishes,
setting a temporary cookie to indicate this to the JavaScript code.
It also adds a method to disable the system on a given form by
setting data-double-submit-protection="off".
Amaia Anabitarte [Tue, 29 Oct 2019 20:51:29 +0000 (21:51 +0100)]
MDL-66398 filter_displayh5p: Enabled by default. Fixing Unit tests
Amaia Anabitarte [Tue, 29 Oct 2019 20:51:49 +0000 (21:51 +0100)]
MDL-66398 filter_h5p: Improve H5P filter to allow internal file URLs
Eloy Lafuente (stronk7) [Wed, 30 Oct 2019 10:19:40 +0000 (11:19 +0100)]
Merge branch 'MDL-66593-master' of git://github.com/cescobedo/moodle
Mihail Geshoski [Wed, 30 Oct 2019 06:05:45 +0000 (14:05 +0800)]
MDL-67067 core_h5p: Fix coding style issues and undocumented functions
Mihail Geshoski [Wed, 30 Oct 2019 05:15:16 +0000 (13:15 +0800)]
MDL-67067 core_h5p: Remove unused method in framework implementation
Mihail Geshoski [Wed, 30 Oct 2019 07:21:57 +0000 (15:21 +0800)]
MDL-67067 core_h5p: Load cached assets by default
Jake Dallimore [Wed, 30 Oct 2019 06:33:01 +0000 (14:33 +0800)]
Merge branch 'MDL-64254-master' of git://github.com/jleyva/moodle
cescobedo [Fri, 4 Oct 2019 13:55:44 +0000 (15:55 +0200)]
MDL-66593 core_backup: Replace h5p/embed.php url for H5PEMBED@$
Adrian Greeve [Wed, 30 Oct 2019 05:44:32 +0000 (13:44 +0800)]
Merge branch 'MDL-66074-OCT28' of git://github.com/Chocolate-lightning/moodle_forum-project
Mathew May [Mon, 28 Oct 2019 05:23:25 +0000 (13:23 +0800)]
MDL-66074 mod_forum: Forum grading GDPR provider
Mathew May [Mon, 28 Oct 2019 05:22:48 +0000 (13:22 +0800)]
MDL-66074 mod_forum: Mustache and PHP documentation for grading
Mathew May [Mon, 28 Oct 2019 05:16:51 +0000 (13:16 +0800)]
MDL-66074 mod_forum: Add sorting in WS for discussion fetching
Mathew May [Mon, 28 Oct 2019 05:14:39 +0000 (13:14 +0800)]
MDL-66074 mod_forum: Grader module documentation
Mathew May [Mon, 28 Oct 2019 05:05:32 +0000 (13:05 +0800)]
MDL-66074 mod_forum: Grader interface documentation