moodle.git
4 months agoMerge branch 'MDL-70373_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE
Sara Arjona [Wed, 16 Dec 2020 11:40:52 +0000 (12:40 +0100)]
Merge branch 'MDL-70373_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70322-310' of git://github.com/roland04/moodle into MOODLE_310_STABLE
Sara Arjona [Wed, 16 Dec 2020 11:04:22 +0000 (12:04 +0100)]
Merge branch 'MDL-70322-310' of git://github.com/roland04/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-54907_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE
Jun Pataleta [Wed, 16 Dec 2020 02:26:58 +0000 (10:26 +0800)]
Merge branch 'MDL-54907_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70422-310' of https://github.com/paulholden/moodle into MOODLE_310_...
Sara Arjona [Tue, 15 Dec 2020 15:43:02 +0000 (16:43 +0100)]
Merge branch 'MDL-70422-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70409-310' of git://github.com/merrill-oakland/moodle into MOODLE_3...
Sara Arjona [Tue, 15 Dec 2020 15:15:50 +0000 (16:15 +0100)]
Merge branch 'MDL-70409-310' of git://github.com/merrill-oakland/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70342-310' of git://github.com/abias/moodle into MOODLE_310_STABLE
Sara Arjona [Tue, 15 Dec 2020 14:29:18 +0000 (15:29 +0100)]
Merge branch 'MDL-70342-310' of git://github.com/abias/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70357-310-cronlibthrowables' of git://github.com/mudrd8mz/moodle...
Sara Arjona [Tue, 15 Dec 2020 13:56:04 +0000 (14:56 +0100)]
Merge branch 'MDL-70357-310-cronlibthrowables' of git://github.com/mudrd8mz/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-67623-310_blocks_myoverview_pagination_regression' of https://githu...
Jake Dallimore [Tue, 15 Dec 2020 10:22:11 +0000 (18:22 +0800)]
Merge branch 'MDL-67623-310_blocks_myoverview_pagination_regression' of https://github.com/tomdickman/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70361-dlrlid-310' of https://github.com/cengage/moodle into MOODLE_...
Jun Pataleta [Tue, 15 Dec 2020 03:17:25 +0000 (11:17 +0800)]
Merge branch 'MDL-70361-dlrlid-310' of https://github.com/cengage/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70397-310' of git://github.com/andrewnicols/moodle into MOODLE_310_...
Sara Arjona [Mon, 14 Dec 2020 16:12:05 +0000 (17:12 +0100)]
Merge branch 'MDL-70397-310' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70324-3.10' of https://github.com/JBThong/moodle into MOODLE_310_STABLE
Jake Dallimore [Mon, 14 Dec 2020 03:30:16 +0000 (11:30 +0800)]
Merge branch 'MDL-70324-3.10' of https://github.com/JBThong/moodle into MOODLE_310_STABLE

4 months agoMDL-67623 block overview: fix pagination regression
Tom Dickman [Thu, 19 Nov 2020 04:40:09 +0000 (15:40 +1100)]
MDL-67623 block overview: fix pagination regression

Fixed a regression caused by MDL-64194 resulting in Dashboard - Course
overview pagination not working from second page of courses onwards.

Course overview block should now do the following:
- Display no pagination controls when user has no courses
- Display no pagination controls when less than 12 courses to display
- Only display pagination controls up to the number of courses user is
enrolled in
- Work correctly when on a page greater than the second page.

4 months agoMDL-70322 core_search: consistent search icon
Mikel Martín [Tue, 24 Nov 2020 17:09:28 +0000 (18:09 +0100)]
MDL-70322 core_search: consistent search icon

4 months agoweekly release 3.10+
Víctor Déniz [Thu, 10 Dec 2020 21:10:47 +0000 (21:10 +0000)]
weekly release 3.10+

4 months agoMerge branch 'install_310_STABLE' of https://git.in.moodle.com/amosbot/moodle-install...
Víctor Déniz [Thu, 10 Dec 2020 21:10:40 +0000 (21:10 +0000)]
Merge branch 'install_310_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_310_STABLE

4 months agoMDL-69301 theme_boost: Remove the special handling of Escape key
Shamim Rezaie [Thu, 10 Dec 2020 06:42:14 +0000 (17:42 +1100)]
MDL-69301 theme_boost: Remove the special handling of Escape key

4 months agoMerge branch 'MDL-70320-310' of https://github.com/andrewnicols/moodle into MOODLE_31...
Jake Dallimore [Thu, 10 Dec 2020 00:13:37 +0000 (08:13 +0800)]
Merge branch 'MDL-70320-310' of https://github.com/andrewnicols/moodle into MOODLE_310_STABLE

4 months agoMDL-70320 behat: User full path to page admin node
Andrew Nicols [Wed, 9 Dec 2020 23:53:56 +0000 (07:53 +0800)]
MDL-70320 behat: User full path to page admin node

4 months agoMerge branch 'MDL-63683-310' of https://github.com/dravek/moodle into MOODLE_310_STABLE
Víctor Déniz [Wed, 9 Dec 2020 12:47:52 +0000 (12:47 +0000)]
Merge branch 'MDL-63683-310' of https://github.com/dravek/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70151-310' of git://github.com/andrewnicols/moodle into MOODLE_310_...
Jake Dallimore [Wed, 9 Dec 2020 06:46:14 +0000 (14:46 +0800)]
Merge branch 'MDL-70151-310' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE

4 months agoMDL-69301 behat: comment a test out
Shamim Rezaie [Wed, 9 Dec 2020 05:26:23 +0000 (16:26 +1100)]
MDL-69301 behat: comment a test out

The e.key is not filled correctly by Geckodriver on the verssion of
Firefox that we use.

4 months agoMerge branch 'MDL-70320_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE
Andrew Nicols [Wed, 9 Dec 2020 04:06:22 +0000 (12:06 +0800)]
Merge branch 'MDL-70320_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-62707-310' of https://github.com/paulholden/moodle into MOODLE_310_...
Andrew Nicols [Wed, 9 Dec 2020 00:53:27 +0000 (08:53 +0800)]
Merge branch 'MDL-62707-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70285_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE
Jake Dallimore [Tue, 8 Dec 2020 08:33:43 +0000 (16:33 +0800)]
Merge branch 'MDL-70285_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE

4 months agoAutomatically generated installer lang files
AMOS bot [Tue, 8 Dec 2020 00:07:22 +0000 (00:07 +0000)]
Automatically generated installer lang files

4 months agoMDL-70422 restore: fix for undefined question answer ordering in test.
Paul Holden [Fri, 4 Dec 2020 18:53:38 +0000 (18:53 +0000)]
MDL-70422 restore: fix for undefined question answer ordering in test.

4 months agoMerge branch 'MDL-69301-310' of git://github.com/rezaies/moodle into MOODLE_310_STABLE
Adrian Greeve [Mon, 7 Dec 2020 01:29:24 +0000 (09:29 +0800)]
Merge branch 'MDL-69301-310' of git://github.com/rezaies/moodle into MOODLE_310_STABLE

4 months agoAutomatically generated installer lang files
AMOS bot [Sun, 6 Dec 2020 00:07:27 +0000 (00:07 +0000)]
Automatically generated installer lang files

4 months agoMDL-70409 chat: Use require_once to import lib.php
Eric Merrill [Fri, 4 Dec 2020 15:43:46 +0000 (10:43 -0500)]
MDL-70409 chat: Use require_once to import lib.php

4 months agoMDL-62707 search: account for no matching courses when listing areas.
Paul Holden [Tue, 4 Feb 2020 08:19:02 +0000 (08:19 +0000)]
MDL-62707 search: account for no matching courses when listing areas.

When limiting the list of courses during retrieval of the search areas
the user can access, make sure we have some contexts before looking
for blocks.

4 months agoMDL-63683 enrol: Fix plugin settings when no role has student archetype
David Matamoros [Fri, 20 Nov 2020 16:09:37 +0000 (17:09 +0100)]
MDL-63683 enrol: Fix plugin settings when no role has student archetype

4 months agoMDL-70397 behat: Prevent browser restarting after initial start
Andrew Nicols [Fri, 13 Nov 2020 06:21:22 +0000 (14:21 +0800)]
MDL-70397 behat: Prevent browser restarting after initial start

4 months agoweekly release 3.10+
Jake Dallimore [Fri, 4 Dec 2020 00:42:48 +0000 (08:42 +0800)]
weekly release 3.10+

4 months agoMerge branch 'install_310_STABLE' of https://git.in.moodle.com/amosbot/moodle-install...
Jake Dallimore [Fri, 4 Dec 2020 00:42:45 +0000 (08:42 +0800)]
Merge branch 'install_310_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70326-MOODLE_310_STABLE' of https://github.com/durzo/moodle into...
Jake Dallimore [Thu, 3 Dec 2020 03:54:18 +0000 (11:54 +0800)]
Merge branch 'MDL-70326-MOODLE_310_STABLE' of https://github.com/durzo/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70327-310' of git://github.com/cescobedo/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 3 Dec 2020 03:51:59 +0000 (11:51 +0800)]
Merge branch 'MDL-70327-310' of git://github.com/cescobedo/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70321_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 3 Dec 2020 03:39:54 +0000 (11:39 +0800)]
Merge branch 'MDL-70321_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-69411-310' of git://github.com/dravek/moodle into MOODLE_310_STABLE
Jake Dallimore [Thu, 3 Dec 2020 03:37:00 +0000 (11:37 +0800)]
Merge branch 'MDL-69411-310' of git://github.com/dravek/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-67460-310_profile_secure' of https://github.com/beenet-dev/moodle...
Jake Dallimore [Thu, 3 Dec 2020 03:16:31 +0000 (11:16 +0800)]
Merge branch 'MDL-67460-310_profile_secure' of https://github.com/beenet-dev/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'wip_MDL-70267_m310' of git://github.com/gjb2048/moodle into MOODLE_310_...
Adrian Greeve [Thu, 3 Dec 2020 02:56:37 +0000 (10:56 +0800)]
Merge branch 'wip_MDL-70267_m310' of git://github.com/gjb2048/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70167-310' of git://github.com/andrewnicols/moodle into MOODLE_310_...
Adrian Greeve [Thu, 3 Dec 2020 01:57:42 +0000 (09:57 +0800)]
Merge branch 'MDL-70167-310' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE

4 months agoAutomatically generated installer lang files
AMOS bot [Thu, 3 Dec 2020 00:07:26 +0000 (00:07 +0000)]
Automatically generated installer lang files

4 months agoMerge branch 'MDL-69868-310' of git://github.com/ilya-catalyst/moodle into MOODLE_310...
Andrew Nicols [Wed, 2 Dec 2020 23:47:48 +0000 (07:47 +0800)]
Merge branch 'MDL-69868-310' of git://github.com/ilya-catalyst/moodle into MOODLE_310_STABLE

4 months agoMDL-70373 qtype_essay: missing border on atto input
Tim Hunt [Wed, 2 Dec 2020 20:08:53 +0000 (20:08 +0000)]
MDL-70373 qtype_essay: missing border on atto input

4 months agoMDL-69301 theme_boost: Use event.key in aria.js
Shamim Rezaie [Wed, 2 Dec 2020 17:18:01 +0000 (04:18 +1100)]
MDL-69301 theme_boost: Use event.key in aria.js

Both event.which and event.keyCode are deprecated. So
We switched to using event.key. We can only do so now
because IE is no longer supported.

4 months agoMDL-69301 course: Remove custom keyboard navigation code
Shamim Rezaie [Wed, 16 Sep 2020 16:43:18 +0000 (02:43 +1000)]
MDL-69301 course: Remove custom keyboard navigation code

4 months agoMDL-69301 core: Enhanced WAI-ARIA support for tab elements
Shamim Rezaie [Wed, 16 Sep 2020 15:12:54 +0000 (01:12 +1000)]
MDL-69301 core: Enhanced WAI-ARIA support for tab elements

4 months agoMDL-69301 theme_boost: convert aria.js to es6 module
Shamim Rezaie [Wed, 16 Sep 2020 13:25:36 +0000 (23:25 +1000)]
MDL-69301 theme_boost: convert aria.js to es6 module

4 months agoMerge branch 'MDL-67514-310' of https://github.com/paulholden/moodle into MOODLE_310_...
Jake Dallimore [Wed, 2 Dec 2020 08:23:54 +0000 (16:23 +0800)]
Merge branch 'MDL-67514-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE

4 months agoAutomatically generated installer lang files
AMOS bot [Wed, 2 Dec 2020 00:07:23 +0000 (00:07 +0000)]
Automatically generated installer lang files

4 months agoMDL-70324 Question: get_all_response_file_areas() not work correctly
Thong Bui [Tue, 1 Dec 2020 09:02:18 +0000 (16:02 +0700)]
MDL-70324 Question: get_all_response_file_areas() not work correctly

4 months agoAutomatically generated installer lang files
AMOS bot [Tue, 1 Dec 2020 00:07:30 +0000 (00:07 +0000)]
Automatically generated installer lang files

4 months agoMDL-70361 mod_lti: deeplinking multiple preserve resourceid and tag
Claude Vervoort [Mon, 30 Nov 2020 19:41:13 +0000 (14:41 -0500)]
MDL-70361 mod_lti: deeplinking multiple preserve resourceid and tag

4 months agoMDL-70357 cron: Catch Throwables not just Exceptions when running tasks
David Mudrák [Mon, 30 Nov 2020 16:20:10 +0000 (17:20 +0100)]
MDL-70357 cron: Catch Throwables not just Exceptions when running tasks

Starting from PHP 7, most language errors throw Error exceptions. We
want to deal with those equally as with any other exception so we need
to catch all Throwables here.

4 months agoMDL-70342 block_timeline: Get rid of double quotes
Alexander Bias [Mon, 30 Nov 2020 09:45:23 +0000 (10:45 +0100)]
MDL-70342 block_timeline: Get rid of double quotes

This commit gets rid of double quotes around the activity name and course name
which have sneaked into block_timeline's view in MDL-65183.

4 months agoMDL-70267 ux, theme: Course user profile inconsistent page layout.
Gareth Barnard [Fri, 20 Nov 2020 16:22:01 +0000 (16:22 +0000)]
MDL-70267 ux, theme: Course user profile inconsistent page layout.

4 months agoAutomatically generated installer lang files
AMOS bot [Sun, 29 Nov 2020 00:07:31 +0000 (00:07 +0000)]
Automatically generated installer lang files

4 months agoMDL-54907 quiz unit tests: clean up code style in attempts_test.php
Tim Hunt [Fri, 27 Nov 2020 14:25:33 +0000 (14:25 +0000)]
MDL-54907 quiz unit tests: clean up code style in attempts_test.php

4 months agoMDL-54907 quiz: better timefinish for attempts finished asynchronously
Tim Hunt [Thu, 26 Nov 2020 21:16:41 +0000 (21:16 +0000)]
MDL-54907 quiz: better timefinish for attempts finished asynchronously

There are serveral ways a quiz attempt can be submitted:

1. The student click the Submit and finish button. In this case,
   no problem. We record the current time as the finish time
   for the quiz attempt.

2. The student is activly working away at the quiz, and the
   count-down timer reachers zero. In this case, we also record
   the current time. Note that, if the server is under high load,
   then this could well end up being a few seconds after the
   theoretical end time, so you could have a quiz with a 30 minute
   time limit, with an attempt that lasted 30:07. However, this
   is just an accurate reflection of what happened, so should
   be recorded like this.

3. If the student is offline when the time expires, then
   (depending on the quiz settings) the attempt may be
   automatically submitted by cron, but this will happen with
   at least some delay (to prevent race conditions between cron
   and a student working online) and if cron is running slow
   on the server, it could be a lot later. Previously, this led
   to, say, a 30 minute quiz where an attempt seemed to have
   lasted 67 minutes, which confused people.

   Now, in this situation, the finsh time for the quiz attempt is
   recorded as the time when the time limit ran out. This is not
   just less confusing for teachers looking at the quiz report,
   it is also more accurate. That is the latest time at which
   students could have made any changes to their responses.

4 months agoMDL-54907 quiz generator: defaults should match a new Moodle install
Tim Hunt [Fri, 27 Nov 2020 13:59:52 +0000 (13:59 +0000)]
MDL-54907 quiz generator: defaults should match a new Moodle install

4 months agoMDL-54907 dml: Correct incorrect PHPdoc
Tim Hunt [Fri, 27 Nov 2020 13:21:34 +0000 (13:21 +0000)]
MDL-54907 dml: Correct incorrect PHPdoc

4 months agoweekly release 3.10+
Sara Arjona [Fri, 27 Nov 2020 06:50:48 +0000 (07:50 +0100)]
weekly release 3.10+

4 months agoMerge branch 'install_310_STABLE' of https://git.in.moodle.com/amosbot/moodle-install...
Sara Arjona [Fri, 27 Nov 2020 06:50:45 +0000 (07:50 +0100)]
Merge branch 'install_310_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_310_STABLE

4 months agoAutomatically generated installer lang files
AMOS bot [Fri, 27 Nov 2020 06:21:03 +0000 (06:21 +0000)]
Automatically generated installer lang files

4 months agoMerge branch 'MDL-70276_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE
Sara Arjona [Thu, 26 Nov 2020 14:04:30 +0000 (15:04 +0100)]
Merge branch 'MDL-70276_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE

4 months agoMDL-70153 qtype_essay: Whitespace/behat fixes
Andrew Nicols [Thu, 26 Nov 2020 03:26:15 +0000 (11:26 +0800)]
MDL-70153 qtype_essay: Whitespace/behat fixes

4 months agoMerge branch 'MDL-70153-310' of git://github.com/dpalou/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 26 Nov 2020 03:27:14 +0000 (11:27 +0800)]
Merge branch 'MDL-70153-310' of git://github.com/dpalou/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70237-310' of git://github.com/rezaies/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 26 Nov 2020 03:04:29 +0000 (11:04 +0800)]
Merge branch 'MDL-70237-310' of git://github.com/rezaies/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70242-310' of git://github.com/marinaglancy/moodle into MOODLE_310_...
Andrew Nicols [Thu, 26 Nov 2020 02:49:19 +0000 (10:49 +0800)]
Merge branch 'MDL-70242-310' of git://github.com/marinaglancy/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-65852-310' of git://github.com/ilya-catalyst/moodle into MOODLE_310...
Andrew Nicols [Thu, 26 Nov 2020 02:04:11 +0000 (10:04 +0800)]
Merge branch 'MDL-65852-310' of git://github.com/ilya-catalyst/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70248-310' of https://github.com/HuongNV13/moodle into MOODLE_310_S...
Sara Arjona [Wed, 25 Nov 2020 15:22:59 +0000 (16:22 +0100)]
Merge branch 'MDL-70248-310' of https://github.com/HuongNV13/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70265_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE
Sara Arjona [Wed, 25 Nov 2020 14:46:50 +0000 (15:46 +0100)]
Merge branch 'MDL-70265_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE

4 months agoMDL-69868 h5pactivity: Prevent breaking $USER when seeing
Ilya Tregubov [Thu, 26 Nov 2020 10:13:55 +0000 (12:13 +0200)]
MDL-69868 h5pactivity: Prevent breaking $USER when seeing

                       attempt report.

4 months agoMDL-70276 github actions: First cut, phpunit and grunt checks
Eloy Lafuente (stronk7) [Sat, 21 Nov 2020 12:05:22 +0000 (13:05 +0100)]
MDL-70276 github actions: First cut, phpunit and grunt checks

First working version, supports phpunit (using build matrix):

- php72 (lowest), running mysql.
- php74 (highest), running postgres.

Also verifies that the branch has been "gruntified" and there
isn't any missing change (build js/css files).

TODO: Verify the remaining checks currently in .travis.yml, namely:
 - CITEST
 - Add caching
 - Better health-check for DB images.
 - Support from the tracker (satus badges and enable check).
 - Support from CiBoT (status and enable check).
 - Consider moving both the common setup (git, composer...)
   and the database (mysql, postgres) to own actions for
   easier tweaking.

4 months agoMDL-70320 permission overrides: role names were double-escaped
Tim Hunt [Tue, 24 Nov 2020 17:20:12 +0000 (17:20 +0000)]
MDL-70320 permission overrides: role names were double-escaped

4 months agoMDL-70327 core_h5p: Add preventredirect to the player
cescobedo [Wed, 25 Nov 2020 15:30:04 +0000 (16:30 +0100)]
MDL-70327 core_h5p: Add preventredirect to the player

4 months agoMDL-70326 antivirus: fixing regression in MDL-66222
Jordan Tomkinson [Wed, 25 Nov 2020 10:28:56 +0000 (11:28 +0100)]
MDL-70326 antivirus: fixing regression in MDL-66222

4 months agoMDL-65852 user: Fix permission check to download course participants.
Ilya Tregubov [Fri, 13 Nov 2020 09:02:52 +0000 (11:02 +0200)]
MDL-65852 user: Fix permission check to download course participants.

4 months agoMDL-70321 question backup: fix MDL-47178 unit tests
Tim Hunt [Tue, 24 Nov 2020 15:26:32 +0000 (15:26 +0000)]
MDL-70321 question backup: fix MDL-47178 unit tests

They were failing if you had CodeRunner installed

4 months agoMDL-67460 profile: User profile link to use HTTPS
Simon Mok [Tue, 24 Nov 2020 12:48:52 +0000 (20:48 +0800)]
MDL-67460 profile: User profile link to use HTTPS

4 months agoMDL-70285 completion upgrade: fix performance of the MDL-69687 code
Tim Hunt [Mon, 23 Nov 2020 20:45:46 +0000 (20:45 +0000)]
MDL-70285 completion upgrade: fix performance of the MDL-69687 code

4 months agoMDL-69411 core_message: Fix return structure for empty result set
David Matamoros [Sun, 22 Nov 2020 15:22:03 +0000 (16:22 +0100)]
MDL-69411 core_message: Fix return structure for empty result set

Passing a timefrom higher than last message timecreated needs to
return a formatted response so it does not break ws.

4 months agoMDL-70265 travis: Completely remove the UPGRADE check
Eloy Lafuente (stronk7) [Mon, 23 Nov 2020 12:40:52 +0000 (13:40 +0100)]
MDL-70265 travis: Completely remove the UPGRADE check

It was broken since ages ago, see MDL-64874, so no sense
to keep it eating minutes for nothing.

4 months agoMerge branch 'MDL-67668-310-2' of git://github.com/andrewnicols/moodle into MOODLE_31...
Adrian Greeve [Mon, 23 Nov 2020 07:37:44 +0000 (15:37 +0800)]
Merge branch 'MDL-67668-310-2' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-70160-function-cache-310' of https://github.com/Peterburnett/moodle...
Jake Dallimore [Mon, 23 Nov 2020 07:22:49 +0000 (15:22 +0800)]
Merge branch 'MDL-70160-function-cache-310' of https://github.com/Peterburnett/moodle into MOODLE_310_STABLE

4 months agoMDL-70151 assign: Fix bulk change for behat
Andrew Nicols [Tue, 17 Dec 2019 02:44:32 +0000 (10:44 +0800)]
MDL-70151 assign: Fix bulk change for behat

Behat does not play well with confirmation dialogues and in some
situations it does not wait for the page to reload before starting the
next step.

This change adds a pending_js call which is only resolved if the cancel
button was pressed, otherwise it remains in-progress until the page
reloads resetting the entire state of it.

4 months agoMDL-70167 behat: Rewrite attribute check steps
Andrew Nicols [Mon, 23 Nov 2020 01:00:13 +0000 (09:00 +0800)]
MDL-70167 behat: Rewrite attribute check steps

This commit updates the following steps to use the
`the_attribute_of_should_be_set` step under the hood:
- the [element] [type] should be disabled
- the [element] [type] should be enabled
- the [element] [type] should be readonly
- the [element] [type] should not be readonly

This reduces unnecssary code duplication.

4 months agoMDL-70167 behat: Boolean attributes should either exist or not
Andrew Nicols [Tue, 23 Jun 2020 03:37:20 +0000 (11:37 +0800)]
MDL-70167 behat: Boolean attributes should either exist or not

4 months agoMDL-67668 behat: Update tests for inplace editable field type
Andrew Nicols [Wed, 17 Jun 2020 05:45:37 +0000 (13:45 +0800)]
MDL-67668 behat: Update tests for inplace editable field type

4 months agoMDL-67668 behat: Add inplace editable field type
Andrew Nicols [Wed, 17 Jun 2020 05:45:15 +0000 (13:45 +0800)]
MDL-67668 behat: Add inplace editable field type

This commit promotes the Inplace Editable field to a first-class form
element by introducing a new partial selector for inplace editable
fields, and teaching the field manager how to recognise these, then
introducing a new field type which can handle setting values for this
field.

4 months agoMDL-67668 behat: Share behat_behat functionality with forms
Andrew Nicols [Tue, 10 Nov 2020 07:10:30 +0000 (15:10 +0800)]
MDL-67668 behat: Share behat_behat functionality with forms

Behat form fields are implemented in a way completely isolated from the
rest of the Behat Context system. Whereas regular step definitions have
access to execute steps, to call `find`, check for JS running, and other
related functionality, the Moodle implementation of a field type does
not have any access to this.

By moving the core functionality of behat_base to a new trait, and the
constants to a new interface, the functionality can also be used in
behat form fields in the same way as elsewhere.

4 months agoMDL-67668 behat: Correct js pending check
Andrew Nicols [Thu, 12 Nov 2020 00:17:34 +0000 (08:17 +0800)]
MDL-67668 behat: Correct js pending check

Pending checks should only run when JS is running, but some uses were
not apply this check.

4 months agoMDL-67668 behat: Support NodeElement when fetching node in container
Andrew Nicols [Thu, 12 Nov 2020 00:15:55 +0000 (08:15 +0800)]
MDL-67668 behat: Support NodeElement when fetching node in container

This is similar to change made in MDL-69136 to allow an already-fetched
NodeElement to be provided to the get_node_in_container() function and
makes it easier to be deterministic when writing steps.

4 months agoMDL-70265 travis: Only run highest phpunit if configured via env
Eloy Lafuente (stronk7) [Fri, 20 Nov 2020 15:20:18 +0000 (16:20 +0100)]
MDL-70265 travis: Only run highest phpunit if configured via env

By default only lowest php version will be executed, and only pgsql.

This default behavior can be changed with a new variable:

MOODLE_PHP = [all]
MOODLE_DATABASE = [pgsql | mysqli | all]

4 months agoweekly release 3.10+
Eloy Lafuente (stronk7) [Fri, 20 Nov 2020 22:17:06 +0000 (23:17 +0100)]
weekly release 3.10+

4 months agoMDL-70248 qtype_ddimageortext: Drop zones have UI issue in Editing form
Huong Nguyen [Wed, 18 Nov 2020 09:09:05 +0000 (16:09 +0700)]
MDL-70248 qtype_ddimageortext: Drop zones have UI issue in Editing form

4 months agoMerge branch 'MOODLE_310_STABLE-MDL-67636' of https://github.com/yao9394/moodle into...
Adrian Greeve [Thu, 19 Nov 2020 03:57:33 +0000 (11:57 +0800)]
Merge branch 'MOODLE_310_STABLE-MDL-67636' of https://github.com/yao9394/moodle into MOODLE_310_STABLE

4 months agoMDL-67636 gradebook: Prevent exposing hidden grade in locked category
John Yao [Thu, 19 Nov 2020 01:36:32 +0000 (12:36 +1100)]
MDL-67636 gradebook: Prevent exposing hidden grade in locked category

4 months agoMerge branch 'MDL-56653-310' of git://github.com/lameze/moodle into MOODLE_310_STABLE
Adrian Greeve [Thu, 19 Nov 2020 03:10:48 +0000 (11:10 +0800)]
Merge branch 'MDL-56653-310' of git://github.com/lameze/moodle into MOODLE_310_STABLE

4 months agoMerge branch 'MDL-69809-310' of https://github.com/paulholden/moodle into MOODLE_310_...
Andrew Nicols [Thu, 19 Nov 2020 02:47:46 +0000 (10:47 +0800)]
Merge branch 'MDL-69809-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE