Jake Dallimore [Mon, 30 Jul 2018 06:14:54 +0000 (14:14 +0800)]
MDL-62947 core_form: fix remote code execution exploit in QuickForms
Applies the patch found upstream:
https://github.com/pear/HTML_QuickForm/commit/
d3a6d5c44dedf3c164c6c79198e4ef479bcedcd2 and make util methods static
for php7 compatibility.
Damyon Wiese [Mon, 16 Jul 2018 07:58:49 +0000 (15:58 +0800)]
MDL-62748 course: maxsections is a limit
For course formats shipped with core, maxsections should be a limit to the number of sections
allowed in the course.
Mihail Geshoski [Mon, 20 Aug 2018 16:48:12 +0000 (18:48 +0200)]
MDL-62857 theme_boost: Better filtering on navbar / breadcrumbs
Tim Hunt [Mon, 9 Jul 2018 17:37:45 +0000 (18:37 +0100)]
MDL-62880 qtype_ddwtos: drop support for legacy import format
It was more than 8 years since we wrote in that format.
Eloy Lafuente (stronk7) [Tue, 4 Sep 2018 20:34:51 +0000 (22:34 +0200)]
Merge branch 'MDL-63249-master-enfix' of git://github.com/mudrd8mz/moodle
Jun Pataleta [Tue, 4 Sep 2018 13:18:02 +0000 (21:18 +0800)]
Merge branch 'MDL-60578-master' of git://github.com/jleyva/moodle
David Monllao [Tue, 4 Sep 2018 12:33:50 +0000 (14:33 +0200)]
Merge branch 'MDL-62342-master' of git://github.com/mihailges/moodle
Juan Leyva [Thu, 26 Oct 2017 10:43:28 +0000 (12:43 +0200)]
MDL-60578 mod_feedback: Handle correctly site feedbacks
Marina Glancy [Wed, 25 Oct 2017 05:41:32 +0000 (13:41 +0800)]
MDL-60578 mod_feedback: pass courseid to WS
David Monllao [Tue, 4 Sep 2018 12:08:50 +0000 (14:08 +0200)]
MDL-62347 output: Fix phpdoc param name
David Monllao [Tue, 4 Sep 2018 12:05:41 +0000 (14:05 +0200)]
Merge branch 'MDL-62347-master' of git://github.com/bmbrands/moodle
David Monllao [Tue, 4 Sep 2018 11:07:00 +0000 (13:07 +0200)]
Merge branch 'MDL-60820-master-workshopsubmissiontypes' of git://github.com/mudrd8mz/moodle
David Monllao [Tue, 4 Sep 2018 10:15:36 +0000 (12:15 +0200)]
Merge branch 'MDL-62944' of https://github.com/NeillM/moodle
David Monllao [Tue, 4 Sep 2018 08:51:28 +0000 (10:51 +0200)]
Merge branch 'MDL-55993-master' of https://github.com/albertolarah/moodle
Helen Foster [Tue, 4 Sep 2018 06:40:48 +0000 (08:40 +0200)]
MDL-63249 lang: Merge English strings from the en_fix language pack
Significant string changes:
* completionpass_help, gradetopassnotset in mod_quiz - grade to pass set
in quiz settings not gradebook
* namecolumnmissing,core_cohort - fixing incorrect message about adding
users to a cohort
Jun Pataleta [Tue, 4 Sep 2018 02:17:23 +0000 (10:17 +0800)]
Merge branch 'MDL-60901' of git://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Mon, 3 Sep 2018 21:39:07 +0000 (23:39 +0200)]
Merge branch 'MDL-48846-master' of git://github.com/sarjona/moodle
Eloy Lafuente (stronk7) [Mon, 3 Sep 2018 21:31:00 +0000 (23:31 +0200)]
Merge branch 'MDL-63255-master' of git://github.com/vmdef/moodle
Eloy Lafuente (stronk7) [Mon, 3 Sep 2018 21:23:12 +0000 (23:23 +0200)]
Merge branch 'MDL-61742-master-inactiveproviders' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Mon, 3 Sep 2018 20:52:31 +0000 (22:52 +0200)]
Merge branch 'MDL-62848-master-placeholderwidth' of git://github.com/mudrd8mz/moodle
David Monllao [Mon, 3 Sep 2018 10:44:50 +0000 (12:44 +0200)]
Merge branch 'MDL-38301-master' of git://github.com/junpataleta/moodle
David Monllao [Mon, 3 Sep 2018 10:27:25 +0000 (12:27 +0200)]
Merge branch 'MDL-55744-master_atto_should_not_autosave_on_not_loggedin_users' of https://github.com/dravek/moodle
Alberto Lara Hernández [Mon, 3 Sep 2018 10:18:58 +0000 (12:18 +0200)]
Merge branch 'MDL-55993-master' of https://github.com/albertolarah/moodle into MDL-55993-master
Alberto Lara Hernández [Fri, 24 Aug 2018 10:47:20 +0000 (12:47 +0200)]
MDL-55993 mod_assign: web services don´t set a URL.
David Monllao [Mon, 3 Sep 2018 08:36:16 +0000 (10:36 +0200)]
Merge branch 'MDL-63238-master' of git://github.com/bmbrands/moodle
Eloy Lafuente (stronk7) [Mon, 3 Sep 2018 00:15:17 +0000 (02:15 +0200)]
MDL-60901 environment: 3.6 requirements
Changes include:
- MySQL 5.6 is required.
- PostgreSQL 8.4 is required.
- Oracle 11.2 is required.
- 64bits architecture is recommended.
Víctor Déniz Falcón [Mon, 3 Sep 2018 05:53:40 +0000 (06:53 +0100)]
MDL-63255 core_user: fix harcoded sql table aliases
Mihail Geshoski [Wed, 29 Aug 2018 03:48:55 +0000 (11:48 +0800)]
MDL-62342 privacy: Fix strings used in the consent on behalf modal
Mihail Geshoski [Wed, 25 Jul 2018 07:50:41 +0000 (15:50 +0800)]
MDL-62342 privacy: Use singular/plural form in labels
Mihail Geshoski [Thu, 30 Aug 2018 06:45:09 +0000 (14:45 +0800)]
MDL-56998 blog: Remove associated blog posts when module is deleted
David Mudrák [Mon, 16 Jul 2018 19:50:49 +0000 (21:50 +0200)]
MDL-62848 form: Fix width of the autocomplete input field
Make sure that the autcomplete input field is wide enough to display the
placeholder text.
David Mudrák [Mon, 16 Jul 2018 19:45:13 +0000 (21:45 +0200)]
MDL-62848 form: Fix missing support for {{#js}} helper in autocomplete
The form-autocomplete module uses three Mustache templates
core/form_autocomplete_input, core/form_autocomplete_suggestions and
core/form_autocomplete_selection. However, it did not support executing
the JS that is eventually part of those templates.
Mark Johnson [Fri, 17 Nov 2017 10:21:47 +0000 (10:21 +0000)]
MDL-60820 workshop: Allow teacher to specify submission types
This allows the teacher to define what students are supposed to submit
(online text and/or attachment) and if the given submission part is
required or optional.
Dan Poltawski [Fri, 31 Aug 2018 10:35:12 +0000 (12:35 +0200)]
MDL-48846 filter: Stop reffering to invalid moodle.org/download/mimetex
David Mudrák [Thu, 15 Feb 2018 19:34:50 +0000 (20:34 +0100)]
MDL-61742 messaging: Do not send messages from inactive providers
Before this patch, we only checked that the given provider has been
configured in the user or system preferences. However, if the provider's
component is disabled, it does not even appear in these preferences.
Additionally, there was no check that the message / notification
provider is among providers allowed to be consumed by the recipient.
The patch checks that the message origin is among providers returned by
the message_get_providers_for_user() so disabled plugins can't act as
sources of messages and users can't receive messages from providers they
do not have capability for. This mitigates the risk of abusing a plugin
as a source of spam, for example.
Unit test is fixed and extended. When the $CFG->messaging is disabled,
no messages between users should be sent (I can't understand why the
unit test was written in an opposite way). Added assertions for the
raised debugging message.
Neill Magill [Fri, 24 Aug 2018 09:06:11 +0000 (10:06 +0100)]
MDL-62944 calendar: Clarify the intended use of $checkcapability
Simey Lameze [Mon, 6 Aug 2018 04:55:17 +0000 (12:55 +0800)]
MDL-62944 calendar: Fix actionevent logic on template
During the calendar work, we have added the feature of
drag and drop activity event or "action events".
The problem at that time was, action events could not be
editable through the calendar UI, but should be allowed
to drag and drop. So, we couldn't use the return of
calendar_edit_event_allowed() because it can return true
(in case of teachers, that have permission to change the
activity) and the attribute isactionevent was created to
control on the UI if the user is viewing an action event.
So what my patch does is just add the check if we are
viewing an action event, and in this case, it won't display
the cog to edit that event.
Neill Magill [Thu, 19 Jul 2018 09:55:32 +0000 (10:55 +0100)]
MDL-62944 activities: Activities should not require capability
Activities should not require the user manipulating them to have
calendar capabilities for their events to be added to the Moodle
calendar
Neill Magill [Fri, 3 Aug 2018 13:26:57 +0000 (14:26 +0100)]
MDL-62944 activities: Test adding activities with no calendar capability
Neill Magill [Thu, 19 Jul 2018 09:46:02 +0000 (10:46 +0100)]
MDL-62944 completion: Calendar capabilities should not be required
The completion API should not require a user to have the capability to
add calendar events for it to function correctly.
Neill Magill [Fri, 3 Aug 2018 13:26:14 +0000 (14:26 +0100)]
MDL-62944 completion: Test that completion dates add events to calendar
When a user does not have calendar capabilities completion dates should
still be created correctly.
Neill Magill [Mon, 6 Aug 2018 08:46:44 +0000 (09:46 +0100)]
MDL-62944 mod_data: Action menu missing from database pages
The action menu was missing from many of the database activity pages,
which meant that it could not be accessed until enough had been done to
the activity to make the editing tabs that used view.php accessible.
Eloy Lafuente (stronk7) [Thu, 30 Aug 2018 17:03:58 +0000 (19:03 +0200)]
weekly release 3.6dev
Eloy Lafuente (stronk7) [Thu, 30 Aug 2018 17:03:55 +0000 (19:03 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Andrew Nicols [Thu, 30 Aug 2018 05:49:15 +0000 (13:49 +0800)]
Merge branch 'MDL-62535-master-fix' of github.com:abgreeve/moodle
Adrian Greeve [Thu, 30 Aug 2018 05:19:21 +0000 (13:19 +0800)]
MDL-62535 grading methods: Unit test update for fix.
Adrian Greeve [Thu, 30 Aug 2018 03:35:52 +0000 (11:35 +0800)]
MDL-62535 grading methods: Fix for multiple intances.
We were only exporting the one instance per item id.
Instead we should have been exporting all instances for each
item id.
AMOS bot [Thu, 30 Aug 2018 00:07:55 +0000 (00:07 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Wed, 29 Aug 2018 23:19:57 +0000 (01:19 +0200)]
Merge branch 'MDL-62535-master' of git://github.com/abgreeve/moodle
Eloy Lafuente (stronk7) [Wed, 29 Aug 2018 12:38:40 +0000 (14:38 +0200)]
MDL-63165 question: Bump expected size of question exports (take II)
Jake Dallimore [Wed, 29 Aug 2018 04:33:29 +0000 (12:33 +0800)]
Merge branch 'MDL-63165-master-fix' of https://github.com/andrewnicols/moodle
Andrew Nicols [Wed, 29 Aug 2018 02:43:21 +0000 (10:43 +0800)]
MDL-63165 question: Bump expected size of question exports
Jake Dallimore [Wed, 29 Aug 2018 01:30:07 +0000 (09:30 +0800)]
Merge branch 'MDL-62657-master' of git://github.com/junpataleta/moodle
Andrew Nicols [Wed, 29 Aug 2018 00:31:08 +0000 (08:31 +0800)]
Merge branch 'wip-MDL-62742-master' of git://github.com/marinaglancy/moodle
Eloy Lafuente (stronk7) [Tue, 28 Aug 2018 21:53:58 +0000 (23:53 +0200)]
Merge branch 'MDL-63094-master' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Tue, 28 Aug 2018 21:14:15 +0000 (23:14 +0200)]
Merge branch 'MDL-62914-master' of git://github.com/lameze/moodle
David Monllao [Tue, 28 Aug 2018 10:28:25 +0000 (12:28 +0200)]
Merge branch 'wip-MDL-63165-master' of https://github.com/Beedell/moodle
Marina Glancy [Sat, 16 Jun 2018 03:57:27 +0000 (11:57 +0800)]
MDL-62742 core: rename coursecat->core_course_category
Also rename course_in_list -> core_course_list_element
Deprecate class coursecat_sortable_records
Jake Dallimore [Tue, 28 Aug 2018 08:55:07 +0000 (16:55 +0800)]
Merge branch 'MDL-63101-master' of git://github.com/andrewnicols/moodle
Jake Dallimore [Tue, 28 Aug 2018 00:47:43 +0000 (08:47 +0800)]
Merge branch 'MDL-63086-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Mon, 27 Aug 2018 23:06:22 +0000 (07:06 +0800)]
Merge branch 'MDL-62782-master' of git://github.com/damyon/moodle
Eloy Lafuente (stronk7) [Mon, 27 Aug 2018 15:51:20 +0000 (17:51 +0200)]
Merge branch 'MDL-62989-master' of git://github.com/mihailges/moodle
Jun Pataleta [Mon, 27 Aug 2018 14:34:33 +0000 (22:34 +0800)]
MDL-63187 tool_dataprivacy: Behat fixes for confirmation lang strings
David Monllao [Mon, 27 Aug 2018 13:06:55 +0000 (15:06 +0200)]
Merge branch 'MDL-63174-master-emptyusername' of git://github.com/mudrd8mz/moodle
David Monllao [Mon, 27 Aug 2018 10:21:00 +0000 (12:21 +0200)]
Merge branch 'MDL-63179-master' of https://github.com/lucaboesch/moodle
David Monllao [Mon, 27 Aug 2018 10:11:53 +0000 (12:11 +0200)]
MDL-63187 tool_dataprivacy: Update delete purpose and category lang strings
David Monllao [Mon, 27 Aug 2018 09:54:24 +0000 (11:54 +0200)]
Merge branch 'MDL-63187-master' of git://github.com/junpataleta/moodle
David Monllao [Mon, 27 Aug 2018 09:46:27 +0000 (11:46 +0200)]
Merge branch 'MDL-63210_master' of git://github.com/markn86/moodle
David Monllao [Mon, 27 Aug 2018 09:32:09 +0000 (11:32 +0200)]
Merge branch 'MDL-63234-master' of git://github.com/andrewnicols/moodle
David Monllao [Mon, 27 Aug 2018 09:22:27 +0000 (11:22 +0200)]
Merge branch 'MDL-62867-missing_colon_in_query' of https://github.com/bitumin/moodle
Bas Brands [Mon, 27 Aug 2018 08:50:49 +0000 (10:50 +0200)]
MDL-63238 theme boost: set background for #region-main
Andrew Nicols [Thu, 16 Aug 2018 00:54:13 +0000 (08:54 +0800)]
MDL-63086 block_rss_client: Move skip time calculation to task
Andrew Nicols [Mon, 27 Aug 2018 07:45:57 +0000 (15:45 +0800)]
Merge branch 'MDL-53024-master' of git://github.com/damyon/moodle
Zig Tan [Mon, 18 Jun 2018 08:41:53 +0000 (16:41 +0800)]
MDL-38301 mod_assign: Fix date validation logic & message consistency
Andrew Nicols [Thu, 9 Aug 2018 06:09:00 +0000 (14:09 +0800)]
MDL-63101 cache: Improve accuracy of cache event invalidation
Andrew Nicols [Mon, 27 Aug 2018 01:43:30 +0000 (09:43 +0800)]
Merge branch 'MDL-59169-master' of https://github.com/nwp90/moodle
Andrew Nicols [Sat, 25 Aug 2018 00:39:03 +0000 (08:39 +0800)]
MDL-63234 blocks_recent_activity; Ensure courselib is loaded
Alberto Lara Hernández [Fri, 24 Aug 2018 10:47:20 +0000 (12:47 +0200)]
MDL-55993 mod_assign: web services don´t set a URL.
John Beedell [Mon, 20 Aug 2018 13:24:19 +0000 (14:24 +0100)]
MDL-63165 Question: xml import of question categories
Mitxel Moriana [Thu, 23 Aug 2018 07:01:05 +0000 (09:01 +0200)]
MDL-62867 tags: Fix missing colon in sql placeholder
Due to a missing colon in an sql query field value placeholder
the calculation of the ordering field for a newly added tag
was ignoring itemid.
Luca Bösch [Fri, 17 Aug 2018 11:57:53 +0000 (13:57 +0200)]
MDL-63179 enrol_self: String and @return tag corrected.
Mihail Geshoski [Fri, 24 Aug 2018 07:32:34 +0000 (15:32 +0800)]
MDL-62989 privacy: Improve data request order for users
Jake Dallimore [Fri, 24 Aug 2018 05:08:47 +0000 (13:08 +0800)]
weekly release 3.6dev
Mark Nelson [Fri, 24 Aug 2018 03:31:32 +0000 (11:31 +0800)]
MDL-63210 core: convert for loop to forEach in JS
Eloy Lafuente (stronk7) [Thu, 23 Aug 2018 10:48:41 +0000 (12:48 +0200)]
Merge branch 'MDL-63028-master' of git://github.com/bmbrands/moodle
Bas Brands [Thu, 23 Aug 2018 08:55:26 +0000 (10:55 +0200)]
MDL-63028 Theme boost: fix footer maintenance page
Jun Pataleta [Thu, 23 Aug 2018 08:53:03 +0000 (16:53 +0800)]
MDL-63187 tool_dataprivacy: Improve confirm message lang strings
* Updated the delete confirmation messages so that the category/purpose
names are shown in italics. This makes it easier for the privacy officer
to see the category/purpose that is being deleted.
Andrew Nicols [Thu, 23 Aug 2018 07:47:28 +0000 (15:47 +0800)]
Merge branch 'MDL-57281-master-fix' of https://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 23 Aug 2018 07:44:23 +0000 (15:44 +0800)]
MDL-57281 question: Correct path to Quiz admin in test
Jake Dallimore [Thu, 23 Aug 2018 00:20:13 +0000 (08:20 +0800)]
Merge branch 'MDL-57281-master-fix' of https://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 23 Aug 2018 00:08:59 +0000 (08:08 +0800)]
MDL-57281 enrol_lti: Nav to Published as LTI tools
Víctor Déniz Falcón [Wed, 22 Aug 2018 16:19:19 +0000 (18:19 +0200)]
MDL-57281 behat: Fix some goutte tests (cannot click on li)
Simply they are not needed, without JS everything is expanded.
Jake Dallimore [Wed, 22 Aug 2018 08:20:36 +0000 (16:20 +0800)]
MDL-36255 core_grade: fix to ensure correct context used for filters
Some grade object (outcomes,scales) can be created at site or course
context, so this patch just makes sure we use the respective context
when applying format_string to the name in the get_name() function.
Damyon Wiese [Thu, 23 Nov 2017 09:22:23 +0000 (17:22 +0800)]
MDL-53024 assign: Remove incorrect logic in query
We are simplifying this query so it will return grades if the attempt matches
the submission attempt, or there is no submission. The case where there is a grade
but no submission can happen only for group assignments.
Andrew Nicols [Thu, 9 Aug 2018 06:10:59 +0000 (14:10 +0800)]
MDL-63094 tool_policy: Fix the cookie banner to the bottom
Floating banners cause issues with clickability in Behat as it is unable
to understand that it cannot interact with the elements underneath the
floating banner, or that it needs to scroll the page so that the
required content is no longer beneath the floating banner.
Changing the banner to be fixed to the bottom of the page during Behat
runes is a reliable fix.
Andrew Nicols [Wed, 8 Aug 2018 01:58:44 +0000 (09:58 +0800)]
MDL-63094 js: Do not check visibility before hiding backdrop
It's possible for the backdrop to be created during the show, before the
modal is actually fully shown.
This check is unnecessary because the getBackdrop() function always
returns a value and will always succeed.
Andrew Nicols [Wed, 8 Aug 2018 01:58:22 +0000 (09:58 +0800)]
MDL-63094 tool_policy: Fix race condition in modal display
The way in which the modal was displayed meant that there were no
pending JS items, whilst the modal was rendered, causing random behat
fails.
This JS has been restructured to create the Modal and pass it a set of
Promises for both the title, and body.
Henning Bostelmann [Fri, 13 Jul 2018 17:25:28 +0000 (18:25 +0100)]
MDL-62914 Calendar: handle TZURL iCal property
Andrew Nicols [Wed, 22 Aug 2018 00:02:47 +0000 (08:02 +0800)]
Merge branch 'MDL-62660' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Tue, 21 Aug 2018 21:57:35 +0000 (23:57 +0200)]
MDL-62660 xmldb: fix tool_dataprivacy_request_>status to int(2)
So the new defined statuses fit in the column for all databases.