moodle.git
18 months agoMDL-66958 core_grade: Add comparison js for grade saves
Mathew May [Tue, 5 Nov 2019 02:48:28 +0000 (10:48 +0800)]
MDL-66958 core_grade: Add comparison js for grade saves

18 months agoMDL-66958 core_grade: Correct documentation in normalise js
Mathew May [Tue, 5 Nov 2019 02:46:06 +0000 (10:46 +0800)]
MDL-66958 core_grade: Correct documentation in normalise js

18 months agoweekly release 3.8dev+
Sara Arjona [Fri, 8 Nov 2019 14:39:36 +0000 (15:39 +0100)]
weekly release 3.8dev+

18 months agoNOBUG: Fixed SVG browser compatibility
Sara Arjona [Fri, 8 Nov 2019 14:39:33 +0000 (15:39 +0100)]
NOBUG: Fixed SVG browser compatibility

18 months agoMerge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Sara Arjona [Fri, 8 Nov 2019 14:39:33 +0000 (15:39 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install

18 months agoMDL-67058 h5p: Correct PHPUNIT_LONGTEST usage
Andrew Nicols [Fri, 8 Nov 2019 07:21:10 +0000 (15:21 +0800)]
MDL-67058 h5p: Correct PHPUNIT_LONGTEST usage

18 months agoMDL-67058 h5p: Content fetch should use save_h5p API
Andrew Nicols [Fri, 8 Nov 2019 07:20:49 +0000 (15:20 +0800)]
MDL-67058 h5p: Content fetch should use save_h5p API

18 months agoMDL-67058 h5p: System user has permission
Andrew Nicols [Fri, 8 Nov 2019 07:20:17 +0000 (15:20 +0800)]
MDL-67058 h5p: System user has permission

18 months agoMerge branch 'MDL-66893-master-3' of https://github.com/ryanwyllie/moodle
Jun Pataleta [Fri, 8 Nov 2019 03:59:44 +0000 (11:59 +0800)]
Merge branch 'MDL-66893-master-3' of https://github.com/ryanwyllie/moodle

18 months agoMerge branch 'MDL-66297-master' of git://github.com/mickhawkins/moodle
Andrew Nicols [Fri, 8 Nov 2019 03:17:38 +0000 (11:17 +0800)]
Merge branch 'MDL-66297-master' of git://github.com/mickhawkins/moodle

18 months agoMDL-66297 mod_forum: Added word/char count column headings to export
Michael Hawkins [Wed, 6 Nov 2019 02:08:01 +0000 (10:08 +0800)]
MDL-66297 mod_forum: Added word/char count column headings to export

18 months agoMDL-66297 forumreport_summary: Added filter data to forum export links
Michael Hawkins [Fri, 1 Nov 2019 06:19:04 +0000 (14:19 +0800)]
MDL-66297 forumreport_summary: Added filter data to forum export links

From/to date filter timestamps, as well as discussion IDs of any
filtered groups.

18 months agoMDL-66297 mod_forum: Prepared export to handle URL filters
Michael Hawkins [Fri, 1 Nov 2019 06:16:11 +0000 (14:16 +0800)]
MDL-66297 mod_forum: Prepared export to handle URL filters

Added the ability for discussion IDs and from/to timestamps to be
passed in via URL (to match filters available in the summary report,
which will link to the export). Also fixed a bug where "all users"
would fail as an optional array param.

18 months agoMDL-66297 forumreport_summary: add export links to the report
Shamim Rezaie [Mon, 14 Oct 2019 16:45:30 +0000 (03:45 +1100)]
MDL-66297 forumreport_summary: add export links to the report

18 months agoMDL-66297 mod_forum: The export form can take params from URL
Shamim Rezaie [Mon, 14 Oct 2019 15:27:22 +0000 (02:27 +1100)]
MDL-66297 mod_forum: The export form can take params from URL

18 months agoMerge branch 'MDL-67169' of https://github.com/stronk7/moodle
Adrian Greeve [Fri, 8 Nov 2019 02:43:05 +0000 (10:43 +0800)]
Merge branch 'MDL-67169' of https://github.com/stronk7/moodle

18 months agoMerge branch 'MDL-67016-master-user-profile-see-own-courses' of https://github.com...
Jake Dallimore [Fri, 8 Nov 2019 02:22:02 +0000 (10:22 +0800)]
Merge branch 'MDL-67016-master-user-profile-see-own-courses' of https://github.com/danowar2k/moodle

18 months agoMerge branch 'MDL-67149-master' of https://github.com/sammarshallou/moodle
Andrew Nicols [Fri, 8 Nov 2019 02:09:58 +0000 (10:09 +0800)]
Merge branch 'MDL-67149-master' of https://github.com/sammarshallou/moodle

18 months agoMerge branch 'MDL-67122-master' of https://github.com/mickhawkins/moodle
Jun Pataleta [Fri, 8 Nov 2019 01:57:20 +0000 (09:57 +0800)]
Merge branch 'MDL-67122-master' of https://github.com/mickhawkins/moodle

18 months agoMerge branch 'MDL-66404-master' of git://github.com/cescobedo/moodle
Andrew Nicols [Fri, 8 Nov 2019 01:24:10 +0000 (09:24 +0800)]
Merge branch 'MDL-66404-master' of git://github.com/cescobedo/moodle

18 months agoMDL-67043 h5p: Whitespace fix
Andrew Nicols [Fri, 8 Nov 2019 00:25:58 +0000 (08:25 +0800)]
MDL-67043 h5p: Whitespace fix

18 months agoMerge branch 'MDL-67043-master' of git://github.com/cescobedo/moodle
Andrew Nicols [Fri, 8 Nov 2019 00:25:14 +0000 (08:25 +0800)]
Merge branch 'MDL-67043-master' of git://github.com/cescobedo/moodle

18 months agoMerge branch 'MDL-67048_master' of https://github.com/adpe/moodle
Eloy Lafuente (stronk7) [Thu, 7 Nov 2019 23:45:05 +0000 (00:45 +0100)]
Merge branch 'MDL-67048_master' of https://github.com/adpe/moodle

18 months agoMerge branch 'MDL-67058-master' of git://github.com/vmdef/moodle
Eloy Lafuente (stronk7) [Thu, 7 Nov 2019 23:30:08 +0000 (00:30 +0100)]
Merge branch 'MDL-67058-master' of git://github.com/vmdef/moodle

18 months agoMerge branch 'MDL-67153' of https://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Thu, 7 Nov 2019 18:49:42 +0000 (19:49 +0100)]
Merge branch 'MDL-67153' of https://github.com/timhunt/moodle

18 months agoMerge branch 'MDL-66683-master' of git://github.com/cescobedo/moodle
Sara Arjona [Thu, 7 Nov 2019 16:41:22 +0000 (17:41 +0100)]
Merge branch 'MDL-66683-master' of git://github.com/cescobedo/moodle

18 months agoMDL-66683 core: Revert MDL-66181 because created regressions
cescobedo [Thu, 7 Nov 2019 09:17:28 +0000 (10:17 +0100)]
MDL-66683 core: Revert MDL-66181 because created regressions

This reverts commit ed080a580ffd0eea70ad3eaa9214234cf2463034.
This issue reverts the behaviour modified in MDL-66181, as that change
negatively impacted course-creation workflows. As this appears to be
the intended functionality, the Security team has agreed to revert
this change.

18 months agoMDL-67122 forumreport_summary: Fix template context eg and line length
Michael Hawkins [Thu, 7 Nov 2019 06:38:26 +0000 (14:38 +0800)]
MDL-67122 forumreport_summary: Fix template context eg and line length

The template context needed updating now it populates a single select
and the summary_table constructor params should be broken over 2 lines

18 months agoMDL-66257 tool_cohortroles: unit test for users in multiple cohorts
Jake Dallimore [Thu, 7 Nov 2019 03:48:50 +0000 (11:48 +0800)]
MDL-66257 tool_cohortroles: unit test for users in multiple cohorts

18 months agoMDL-66257 tool_cohortroles: Unassign the role on removal cohortroles.
cescobedo [Wed, 6 Nov 2019 12:37:09 +0000 (13:37 +0100)]
MDL-66257 tool_cohortroles: Unassign the role on removal cohortroles.

18 months agoMDL-67122 forumreport_summary: Apply filters to report download
Michael Hawkins [Mon, 4 Nov 2019 07:51:39 +0000 (15:51 +0800)]
MDL-67122 forumreport_summary: Apply filters to report download

18 months agoMerge branch 'MDL-67166-master' of git://github.com/bmbrands/moodle
Sara Arjona [Thu, 7 Nov 2019 15:30:18 +0000 (16:30 +0100)]
Merge branch 'MDL-67166-master' of git://github.com/bmbrands/moodle

18 months agoMDL-67169 phpunit: fix clear flaw in unit test provider
Eloy Lafuente (stronk7) [Wed, 6 Nov 2019 22:58:30 +0000 (23:58 +0100)]
MDL-67169 phpunit: fix clear flaw in unit test provider

Basically the provider is ignoring the CRLF to LF normalization
results and loading the original file again.

This doesn't have any impact normally, because all moodle
files are LF ones and people using other systems have their
git configurations set to work that way (not modify or force LF).

But there may be checkouts out there (for example travis) where
the git configuration by defult is to convert to the OS, causing
windows runs to fail badly there. See the issue for more info
and links.

18 months agoMerge branch 'MDL-67084-master' of git://github.com/junpataleta/moodle
Jun Pataleta [Thu, 7 Nov 2019 11:40:55 +0000 (19:40 +0800)]
Merge branch 'MDL-67084-master' of git://github.com/junpataleta/moodle

18 months agoMDL-67084 core_form: duration element should export arrays
Marina Glancy [Mon, 4 Nov 2019 13:37:46 +0000 (14:37 +0100)]
MDL-67084 core_form: duration element should export arrays

18 months agoMDL-66598 auth_oauth2: OAuth2 upgrade step
Jun Pataleta [Tue, 5 Nov 2019 08:12:26 +0000 (16:12 +0800)]
MDL-66598 auth_oauth2: OAuth2 upgrade step

This basically does two things:
1. Updates all non-Facebook/Google/Microsoft issuers and sets their
'requireconfirmation' field to 1 so that future OAuth2 logins on these
issuers will always have an email confirmation sent to them.
2. Deletes the linked logins of users with non-Facebook/Google/Microsoft
OAuth2 issuers.

18 months agoMDL-66598 auth_oauth2: Add warning messages in confirm emails
Jun Pataleta [Tue, 5 Nov 2019 06:25:22 +0000 (14:25 +0800)]
MDL-66598 auth_oauth2: Add warning messages in confirm emails

18 months agoMDL-66598 tool_oauth2: Make account confirmation required by default
Jun Pataleta [Wed, 30 Oct 2019 09:00:36 +0000 (17:00 +0800)]
MDL-66598 tool_oauth2: Make account confirmation required by default

* Only Facebook, Google, and Microsoft issuers can optionally offer to
require account confirmation via email. We will require email
confirmation for the rest of the issuers.

18 months agoMDL-67166 theme_classic: H5P embedded styles
Bas Brands [Thu, 7 Nov 2019 09:57:39 +0000 (10:57 +0100)]
MDL-67166 theme_classic: H5P embedded styles

18 months agoMDL-66404 core_h5p: Add new h5p_deleted event
cescobedo [Tue, 5 Nov 2019 21:46:22 +0000 (22:46 +0100)]
MDL-66404 core_h5p: Add new h5p_deleted event

18 months agoMDL-66404 core_h5p: Add new h5p_viewed event
cescobedo [Tue, 5 Nov 2019 19:47:06 +0000 (20:47 +0100)]
MDL-66404 core_h5p: Add new h5p_viewed event

18 months agoMDL-67110 filter_h5p: Removing wildcard characters
Amaia Anabitarte [Mon, 4 Nov 2019 14:32:51 +0000 (15:32 +0100)]
MDL-67110 filter_h5p: Removing wildcard characters

18 months agoMDL-67059 core_h5p: UI to manually upload H5P content type libraries
Amaia Anabitarte [Mon, 4 Nov 2019 23:35:51 +0000 (00:35 +0100)]
MDL-67059 core_h5p: UI to manually upload H5P content type libraries

Co-authored by: Mihail Geshoski <mihail@moodle.com>

18 months agoMDL-67043 core_h5p: Add new ws to get the H5P trusted file
cescobedo [Thu, 7 Nov 2019 07:47:25 +0000 (08:47 +0100)]
MDL-67043 core_h5p: Add new ws to get the H5P trusted file

18 months agoMerge branch 'MDL-66701_master' of git://github.com/dmonllao/moodle
Jun Pataleta [Thu, 7 Nov 2019 07:41:45 +0000 (15:41 +0800)]
Merge branch 'MDL-66701_master' of git://github.com/dmonllao/moodle

18 months agoMDL-66701 report_insights: Target's extra info on the insights report
David Monllaó [Tue, 17 Sep 2019 07:11:03 +0000 (15:11 +0800)]
MDL-66701 report_insights: Target's extra info on the insights report

18 months agoMDL-66701 analytics: Insights report descriptions
emdalton [Fri, 25 Oct 2019 06:25:31 +0000 (02:25 -0400)]
MDL-66701 analytics: Insights report descriptions

18 months agoMDL-66893 mod_forum: move grade button into region main
Ryan Wyllie [Thu, 7 Nov 2019 03:01:28 +0000 (11:01 +0800)]
MDL-66893 mod_forum: move grade button into region main

18 months agoMDL-66893 mod_forum: add nested v2 support to grader
Ryan Wyllie [Wed, 6 Nov 2019 08:06:05 +0000 (16:06 +0800)]
MDL-66893 mod_forum: add nested v2 support to grader

18 months agoMDL-66893 mod_forum: update grader search
Ryan Wyllie [Wed, 6 Nov 2019 05:28:27 +0000 (13:28 +0800)]
MDL-66893 mod_forum: update grader search

18 months agoMDL-66893 mod_forum: add grader status to grader UI
Ryan Wyllie [Tue, 5 Nov 2019 05:41:58 +0000 (13:41 +0800)]
MDL-66893 mod_forum: add grader status to grader UI

18 months agoMDL-66893 mod_forum: update user picker in grader UI
Ryan Wyllie [Tue, 5 Nov 2019 05:34:34 +0000 (13:34 +0800)]
MDL-66893 mod_forum: update user picker in grader UI

18 months agoMDL-66893 mod_forum: show expand conversation in nested view
Ryan Wyllie [Tue, 5 Nov 2019 05:32:59 +0000 (13:32 +0800)]
MDL-66893 mod_forum: show expand conversation in nested view

18 months agoMDL-66893 mod_forum: update user content region in grader UI
Ryan Wyllie [Tue, 5 Nov 2019 05:29:36 +0000 (13:29 +0800)]
MDL-66893 mod_forum: update user content region in grader UI

18 months agoMDL-66893 mod_forum: update navigation bar in grader UI
Ryan Wyllie [Tue, 5 Nov 2019 05:24:20 +0000 (13:24 +0800)]
MDL-66893 mod_forum: update navigation bar in grader UI

18 months agoMDL-66893 mod_forum: update grading panel UI in grader
Ryan Wyllie [Tue, 5 Nov 2019 05:15:12 +0000 (13:15 +0800)]
MDL-66893 mod_forum: update grading panel UI in grader

18 months agoMerge branch 'MDL-66372' of https://github.com/Chocolate-lightning/moodle_forum-project
Jun Pataleta [Thu, 7 Nov 2019 05:22:32 +0000 (13:22 +0800)]
Merge branch 'MDL-66372' of https://github.com/Chocolate-lightning/moodle_forum-project

18 months agoMDL-66372 forumreport_summary: Tidy up per page and bulk ops handling
Michael Hawkins [Thu, 7 Nov 2019 04:40:21 +0000 (12:40 +0800)]
MDL-66372 forumreport_summary: Tidy up per page and bulk ops handling

18 months agoMDL-66372 forumreport_summary: Added ability to select pagination size
Michael Hawkins [Mon, 14 Oct 2019 15:35:39 +0000 (23:35 +0800)]
MDL-66372 forumreport_summary: Added ability to select pagination size

This also includes some refactoring of the bulk actions menu, so both
elements are correctly position within the page, as well as fixing the
alignment of the bulk dropdown with the download dropdown.

18 months agoMDL-66372 forumreport_summary: Improved generate with filters override
Michael Hawkins [Tue, 15 Oct 2019 07:56:15 +0000 (15:56 +0800)]
MDL-66372 forumreport_summary: Improved generate with filters override

Previously this override simply appended any GET params from the
action it was overriding to the final action URL, now it can handle
overriding param values, so that they are updated or added as needed

18 months agoMDL-66372 forumreport_summary: Report template cleanup
Michael Hawkins [Tue, 15 Oct 2019 07:36:01 +0000 (15:36 +0800)]
MDL-66372 forumreport_summary: Report template cleanup

18 months agoMerge branch 'MDL-67057-master' of git://github.com/andrewnicols/moodle
Adrian Greeve [Thu, 7 Nov 2019 03:59:00 +0000 (11:59 +0800)]
Merge branch 'MDL-67057-master' of git://github.com/andrewnicols/moodle

18 months agoMDL-67057 h5p: Set framework file when saving package
Andrew Nicols [Thu, 7 Nov 2019 03:48:36 +0000 (11:48 +0800)]
MDL-67057 h5p: Set framework file when saving package

18 months agoMerge branch 'MDL-66359-master' of git://github.com/Chocolate-lightning/moodle_forum...
Andrew Nicols [Thu, 7 Nov 2019 02:48:33 +0000 (10:48 +0800)]
Merge branch 'MDL-66359-master' of git://github.com/Chocolate-lightning/moodle_forum-project

18 months agoMDL-66359 mod_forum: Restrict grader by groups
Mathew May [Fri, 1 Nov 2019 05:39:48 +0000 (13:39 +0800)]
MDL-66359 mod_forum: Restrict grader by groups

18 months agoMDL-66359 core_course: Modify get_enrolled_users_by_cmid
Mathew May [Fri, 1 Nov 2019 05:39:10 +0000 (13:39 +0800)]
MDL-66359 core_course: Modify get_enrolled_users_by_cmid

We need to also provide a user's group along with the current information

18 months agoMerge branch 'MDL-66592_master' of git://github.com/dmonllao/moodle
Jun Pataleta [Thu, 7 Nov 2019 02:35:21 +0000 (10:35 +0800)]
Merge branch 'MDL-66592_master' of git://github.com/dmonllao/moodle

18 months agoMerge branch 'MDL-66890-master' of https://github.com/Chocolate-lightning/moodle_foru...
Adrian Greeve [Thu, 7 Nov 2019 02:08:54 +0000 (10:08 +0800)]
Merge branch 'MDL-66890-master' of https://github.com/Chocolate-lightning/moodle_forum-project

18 months agoMerge branch 'MDL-67076-master' of git://github.com/sarjona/moodle
Andrew Nicols [Thu, 7 Nov 2019 01:44:35 +0000 (09:44 +0800)]
Merge branch 'MDL-67076-master' of git://github.com/sarjona/moodle

18 months agoMDL-67057 h5p: Language string fix
Andrew Nicols [Thu, 7 Nov 2019 01:37:27 +0000 (09:37 +0800)]
MDL-67057 h5p: Language string fix

18 months agoMerge branch 'MDL-67057-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 7 Nov 2019 01:20:27 +0000 (09:20 +0800)]
Merge branch 'MDL-67057-master' of git://github.com/andrewnicols/moodle

18 months agoMDL-67057 h5p: Remove unreachable code
Andrew Nicols [Thu, 7 Nov 2019 01:13:25 +0000 (09:13 +0800)]
MDL-67057 h5p: Remove unreachable code

18 months agoMDL-66762 tool_dataprivacy: Sanitize the extra fields in the webservice
Mihail Geshoski [Wed, 6 Nov 2019 07:34:35 +0000 (15:34 +0800)]
MDL-66762 tool_dataprivacy: Sanitize the extra fields in the webservice

18 months agoMDL-66762 user: escape extra/email user fields.
Paul Holden [Mon, 7 Oct 2019 16:33:48 +0000 (17:33 +0100)]
MDL-66762 user: escape extra/email user fields.

18 months agoMDL-66762 user: stricter email validation.
Paul Holden [Fri, 1 Nov 2019 13:04:48 +0000 (13:04 +0000)]
MDL-66762 user: stricter email validation.

18 months agoMDL-66592 analytics: Split text and link
David Monllaó [Wed, 6 Nov 2019 03:24:11 +0000 (11:24 +0800)]
MDL-66592 analytics: Split text and link

18 months agoMDL-66592 report_insights: Help icon for indicator calculations desc
David Monllaó [Fri, 18 Oct 2019 06:52:08 +0000 (14:52 +0800)]
MDL-66592 report_insights: Help icon for indicator calculations desc

18 months agoMDL-67057 core_h5p: Add capability to update content-type libraries
Sara Arjona [Wed, 30 Oct 2019 08:07:51 +0000 (09:07 +0100)]
MDL-67057 core_h5p: Add capability to update content-type libraries

18 months agoMDL-67057 core_h5p: New method to get latest library version
Sara Arjona [Wed, 30 Oct 2019 07:45:24 +0000 (08:45 +0100)]
MDL-67057 core_h5p: New method to get latest library version

18 months agoMDL-67057 core_h5p: Improve displaying errors
Sara Arjona [Wed, 30 Oct 2019 07:32:50 +0000 (08:32 +0100)]
MDL-67057 core_h5p: Improve displaying errors

18 months agoMDL-67057 core_h5p: Add helper class
Sara Arjona [Tue, 29 Oct 2019 19:19:33 +0000 (20:19 +0100)]
MDL-67057 core_h5p: Add helper class

18 months agoMerge branch 'MDL-42638-master' of https://github.com/lucaboesch/moodle
Eloy Lafuente (stronk7) [Wed, 6 Nov 2019 21:32:56 +0000 (22:32 +0100)]
Merge branch 'MDL-42638-master' of https://github.com/lucaboesch/moodle

18 months agoMerge branch 'MDL-67127-master' of git://github.com/ferranrecio/moodle
Eloy Lafuente (stronk7) [Wed, 6 Nov 2019 21:31:15 +0000 (22:31 +0100)]
Merge branch 'MDL-67127-master' of git://github.com/ferranrecio/moodle

18 months agoMDL-67153 question bank: let qtype add actions to the edit menu
Tim Hunt [Wed, 6 Nov 2019 19:32:15 +0000 (19:32 +0000)]
MDL-67153 question bank: let qtype add actions to the edit menu

18 months agoMDL-67058 core_h5p: task to get latest content types version from H5P
Victor Deniz Falcon [Wed, 6 Nov 2019 18:17:34 +0000 (18:17 +0000)]
MDL-67058 core_h5p: task to get latest content types version from H5P

18 months agoMerge branch 'MDL-67140' of https://github.com/paulholden/moodle
Sara Arjona [Wed, 6 Nov 2019 17:53:22 +0000 (18:53 +0100)]
Merge branch 'MDL-67140' of https://github.com/paulholden/moodle

18 months agoMDL-67149 Accessibility: Help popups fail WCAG 1.4.13 (Dismissable)
sam marshall [Wed, 6 Nov 2019 16:24:27 +0000 (16:24 +0000)]
MDL-67149 Accessibility: Help popups fail WCAG 1.4.13 (Dismissable)

It must be possible to dismiss the help popups (popovers) with the
Escape key, without changing focus.

18 months agoMDL-66890 forumreport_summary: Improved filter close keyboard response
Michael Hawkins [Wed, 6 Nov 2019 09:07:12 +0000 (17:07 +0800)]
MDL-66890 forumreport_summary: Improved filter close keyboard response

18 months agoMerge branch 'MDL-67097-master-2' of https://github.com/snake/moodle
Jun Pataleta [Wed, 6 Nov 2019 08:12:46 +0000 (16:12 +0800)]
Merge branch 'MDL-67097-master-2' of https://github.com/snake/moodle

18 months agoMerge branch 'MDL-66984-change_password_url-with-user' of https://github.com/brendanh...
Sara Arjona [Wed, 6 Nov 2019 07:30:41 +0000 (08:30 +0100)]
Merge branch 'MDL-66984-change_password_url-with-user' of https://github.com/brendanheywood/moodle

18 months agoMDL-66890 forumreport_summary: Added the ability to close filters
Michael Hawkins [Tue, 22 Oct 2019 03:37:53 +0000 (11:37 +0800)]
MDL-66890 forumreport_summary: Added the ability to close filters

Previously, filters could only be closed by saving/submitting them.
Now, you are able to close and reopen them by opening another filter,
using the escape key, or clicking outside of the filter.
As per UX recommendations, filters retain any changes until the page
is reloaded (either via refresh or by saving a different filter).

18 months agoMDL-66893 grade: update rubric template for grader
Ryan Wyllie [Tue, 5 Nov 2019 05:02:25 +0000 (13:02 +0800)]
MDL-66893 grade: update rubric template for grader

18 months agoMDL-66893 grade: update marking guide template for grader
Ryan Wyllie [Tue, 5 Nov 2019 04:59:03 +0000 (12:59 +0800)]
MDL-66893 grade: update marking guide template for grader

18 months agoMDL-67082 core_h5p: Add new contexts to check h5p file permissions
cescobedo [Thu, 31 Oct 2019 18:27:32 +0000 (19:27 +0100)]
MDL-67082 core_h5p: Add new contexts to check h5p file permissions

18 months agoMDL-67082 core_h5p: Check component_callback called for right context
cescobedo [Wed, 30 Oct 2019 12:50:14 +0000 (13:50 +0100)]
MDL-67082 core_h5p: Check component_callback called for right context

18 months agoMerge branch 'MDL-67074-master' of git://github.com/andrewnicols/moodle
Jake Dallimore [Wed, 6 Nov 2019 03:48:21 +0000 (11:48 +0800)]
Merge branch 'MDL-67074-master' of git://github.com/andrewnicols/moodle

18 months agoMDL-67097 libraries: add unit test verifying rtl directive failure case
Jake Dallimore [Mon, 4 Nov 2019 03:14:46 +0000 (11:14 +0800)]
MDL-67097 libraries: add unit test verifying rtl directive failure case

When a closing comment is used, such as when we wrap css with the
rtl:begin:ignore and rtl:end:ignore (the latter being the closing),
it is ignored in the following case:
- If the closing comment is the last item in a csslist like:
div {/*rtl:begin:ignore*/left:20px; text-align:left/*rtl:end:ignore*/}
in which case there is no css rule following the comment for it to be
associated with. It is therefore not seen and registered, meaning we
continue ignoring rtl (a bug).
In such cases, we should either:
- ensure the comment is not the final element in the css list
- use self-closing (/*rtl:ignore*/) comments for each rule instead.
- use a self-closing comment on the entire css list, if applicable.

18 months agoMDL-67097 libraries: update upgrade notes for sabberworm/php-css-parser
Jake Dallimore [Mon, 4 Nov 2019 02:27:04 +0000 (10:27 +0800)]
MDL-67097 libraries: update upgrade notes for sabberworm/php-css-parser

Until the upstream patch is accepted, we need to patch this locally.

18 months agoMDL-67097 libraries: fix comment parsing in php-css-parser library
Jake Dallimore [Fri, 1 Nov 2019 05:21:17 +0000 (13:21 +0800)]
MDL-67097 libraries: fix comment parsing in php-css-parser library

This fixes a bug when parsing the following rule-level and list-level
comments.

div {/*rtl:ignore*/left:10px;/*rtl:ignore*/ display:inline;}
/*rtl:ignore*/div {left:10px;} /*rtl:ignore*/ a {left:10px}

The latter rtl directive was being swallowed by the parser in these
cases and was not being properly allocated as a property of the rule
or csslist.

This restores the correct behaviour of the rtlcss library, which depends
on php-css-parser.

18 months agoMDL-67097 libraries: add unit tests for the core_rtlcss class
Jake Dallimore [Fri, 1 Nov 2019 01:51:04 +0000 (09:51 +0800)]
MDL-67097 libraries: add unit tests for the core_rtlcss class

The core_rtlcss class extends the \MoodleHQ\RTLCSS\RTLCSS class. This
upstream library had tests, but these were not included in core. This
change uses those test cases to test core_rtlcss, to make sure future
lib changes don't break the css parsing.