Jake Dallimore [Wed, 15 May 2019 10:15:56 +0000 (18:15 +0800)]
MDL-65566 core_message: fix bug allowing duplicate unique conversations
Individual and self conversations may exist once only, so we need to
enforce this in the creation method.
Jake Dallimore [Wed, 15 May 2019 07:27:17 +0000 (15:27 +0800)]
MDL-65566 core_user: remove the conversation creation code from lib.php
These are now lazy created in the messaging APIs, so we don't need
to create them on user creation any more.
Sara Arjona [Fri, 10 May 2019 14:09:16 +0000 (16:09 +0200)]
MDL-65566 core_message: create the self-conversation when needed
Instead of creating all the self-conversations during the upgrading,
some code has been added to the get_conversations and to the
get_conversation_counts to create it whe it doesn't exist.
Sara Arjona [Tue, 14 May 2019 10:11:25 +0000 (12:11 +0200)]
Moodle release 3.7rc1
Jun Pataleta [Tue, 14 May 2019 04:53:50 +0000 (12:53 +0800)]
Merge branch 'MDL-65569-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Tue, 14 May 2019 01:56:33 +0000 (09:56 +0800)]
MDL-65569 mod_forum: Correct rules for SSD
In a Single Simple Discussion forum, the first post can only be edited
by a user with the manageactivities capability, but all other posts
behave as normal.
Andrew Nicols [Tue, 14 May 2019 04:17:25 +0000 (12:17 +0800)]
Merge branch 'MDL-65574-master' of https://github.com/ryanwyllie/moodle
Jun Pataleta [Tue, 14 May 2019 03:32:02 +0000 (11:32 +0800)]
Merge branch 'MDL-65536-master' of https://github.com/snake/moodle
Andrew Nicols [Fri, 10 May 2019 06:10:37 +0000 (14:10 +0800)]
MDL-65536 mod_lti: JWT should use the class loader
Damyon Wiese [Fri, 10 May 2019 02:01:56 +0000 (10:01 +0800)]
MDL-65536 mod_lti: OpenSSL configuration
LTI 1.3 requires working openssl functions to generate a private
key used for the JWT. Some installs (e.g. windows) can have the
functions available - but require configuration in php before they
actually do anything.
Ryan Wyllie [Tue, 14 May 2019 02:43:37 +0000 (10:43 +0800)]
MDL-65574 forum: fix return type for get_first_post_for_discussion_ids
Adrian Greeve [Tue, 14 May 2019 02:20:45 +0000 (10:20 +0800)]
Merge branch 'MDL-65582_master' of git://github.com/dmonllao/moodle
Jun Pataleta [Tue, 14 May 2019 01:52:36 +0000 (09:52 +0800)]
Merge branch 'MDL-65557-master' of https://github.com/ryanwyllie/moodle
Ryan Wyllie [Mon, 13 May 2019 08:25:14 +0000 (16:25 +0800)]
MDL-65557 forum: increase default image size of author profile url
Sara Arjona [Mon, 13 May 2019 19:19:11 +0000 (21:19 +0200)]
Merge branch 'MDL-65581-master' of git://github.com/bmbrands/moodle
David Monllaó [Mon, 13 May 2019 11:00:17 +0000 (13:00 +0200)]
MDL-65582 analytics: Upcoming activities due enabled by default
Bas Brands [Mon, 13 May 2019 10:02:44 +0000 (12:02 +0200)]
MDL-65581 core_blocks: change classname for hidden blocks
Changing the added class .invisible to .ivisibleblock to avoid hiding the block completely
Sara Arjona [Mon, 13 May 2019 08:39:10 +0000 (10:39 +0200)]
Merge branch 'MDL-65564-master' of git://github.com/marinaglancy/moodle
Sara Arjona [Mon, 13 May 2019 08:02:31 +0000 (10:02 +0200)]
Merge branch 'MDL-65224-master' of https://github.com/ewallah/moodle
Jun Pataleta [Mon, 13 May 2019 07:47:52 +0000 (15:47 +0800)]
Merge branch 'MDL-65571' of git://github.com/stronk7/moodle
Sara Arjona [Mon, 13 May 2019 07:40:37 +0000 (09:40 +0200)]
Merge branch 'MDL-65544-master' of git://github.com/damyon/moodle
Ryan Wyllie [Mon, 13 May 2019 07:03:26 +0000 (15:03 +0800)]
MDL-65574 forum: discussion_list vault uses post table for author
Update the discussion_list vault to use the first post record from
the posts table join to get the author of the first post rather
than relying on it's own "userid" column which can be incorrect in
the case of split discussions.
Damyon Wiese [Fri, 10 May 2019 06:34:51 +0000 (14:34 +0800)]
MDL-65544 badges: Any all criteria
When testing any vs all aggregation method, we expect a different result
when we have looped all the competencies and they all passed or failed.
Adrian Greeve [Mon, 13 May 2019 01:43:58 +0000 (09:43 +0800)]
Merge branch 'MDL-65560-master' of git://github.com/lameze/moodle
Jake Dallimore [Thu, 9 May 2019 02:59:13 +0000 (10:59 +0800)]
MDL-65536 mod_lti: fix stale platformid when wwwroot is changed
If the site is installed, and then the wwwroot changed, the plugin
config value for platformid for mod_lti is then stale, resulting in
OIDC errors. Given this config value was set using the wwwroot, we
should just be able to use the value of $CFG->wwwroot direcly, thus
avoiding this problem.
Eloy Lafuente (stronk7) [Sun, 12 May 2019 21:48:17 +0000 (23:48 +0200)]
MDL-65571 versions: main version bump
Eloy Lafuente (stronk7) [Sun, 12 May 2019 21:46:34 +0000 (23:46 +0200)]
MDL-65571 versions: bump all versions and requires near release
version =
2019052000 release version
requires=
2019051100 current beta (week6roll2) version
Eloy Lafuente (stronk7) [Fri, 10 May 2019 18:31:46 +0000 (20:31 +0200)]
Moodle release 3.7beta
Eloy Lafuente (stronk7) [Fri, 10 May 2019 18:07:50 +0000 (20:07 +0200)]
Merge branch 'MDL-65537-master-enfix' of git://github.com/mudrd8mz/moodle
David Mudrák [Fri, 10 May 2019 08:26:26 +0000 (10:26 +0200)]
MDL-65537 lang: Use fixed strings in tests, too
Sara Arjona [Fri, 10 May 2019 09:58:50 +0000 (11:58 +0200)]
Merge branch 'MDL-65518-master-fix1' of https://github.com/damyon/moodle
Eloy Lafuente (stronk7) [Fri, 10 May 2019 09:29:53 +0000 (11:29 +0200)]
Merge branch 'MDL-65558-master' of git://github.com/andrewnicols/moodle
Marina Glancy [Fri, 10 May 2019 09:01:18 +0000 (11:01 +0200)]
MDL-65564 core_customfield: fix inplace editable
Helen Foster [Fri, 10 May 2019 08:17:47 +0000 (10:17 +0200)]
MDL-65537 lang: Import fixed English strings (en_fix)
Significant string changes:
* isdataunique_help and isfieldrequired_help,core_customfield -
explanatory wording
* forum:cantogglefavourite,mod_forum - 'Can toggle favourites.'
changed to 'Star discussions'
Jun Pataleta [Fri, 10 May 2019 07:59:16 +0000 (15:59 +0800)]
Merge branch 'MDL-65540-master' of git://github.com/andrewnicols/moodle
Damyon Wiese [Fri, 10 May 2019 07:47:04 +0000 (15:47 +0800)]
MDL-65518 badges: Require the issuercontact
For Badges V2 we can't use just any email address to issue badges, it needs to be a valid
account on the backpack.
Simey Lameze [Fri, 10 May 2019 05:28:50 +0000 (13:28 +0800)]
MDL-65560 qtype_multichoice: prevent form change dialog
Andrew Nicols [Fri, 10 May 2019 04:24:05 +0000 (12:24 +0800)]
MDL-65558 enrol_database: use , as port separator
Andrew Nicols [Fri, 10 May 2019 04:23:49 +0000 (12:23 +0800)]
MDL-65558 auth_db: use , as port separator
Andrew Nicols [Fri, 10 May 2019 03:46:34 +0000 (11:46 +0800)]
Merge branch 'MDL-65520-master' of git://github.com/peterRd/moodle
Andrew Nicols [Fri, 10 May 2019 03:40:52 +0000 (11:40 +0800)]
MDL-63959 feedback: Adjust unit test for perf
Andrew Nicols [Fri, 10 May 2019 03:41:11 +0000 (11:41 +0800)]
Merge branch 'MDL-63959-master' of git://github.com/tobiasreischmann/moodle
Adrian Greeve [Fri, 10 May 2019 02:42:34 +0000 (10:42 +0800)]
Merge branch 'MDL-65457-master' of git://github.com/peterRd/moodle
Peter [Thu, 2 May 2019 05:44:34 +0000 (13:44 +0800)]
MDL-65457 mod_forum: Provide latest post's author
Provide an updated private replies restriction to latest post
Get the latest post's author and time which takes into account private replies.
Eloy Lafuente (stronk7) [Thu, 9 May 2019 19:48:26 +0000 (21:48 +0200)]
Merge branch 'MDL-65423-master' of git://github.com/jleyva/moodle
Eloy Lafuente (stronk7) [Thu, 9 May 2019 18:01:54 +0000 (20:01 +0200)]
Merge branch 'MDL-65197' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Thu, 9 May 2019 17:49:31 +0000 (19:49 +0200)]
Merge branch 'MDL-29320-master' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Thu, 9 May 2019 17:25:55 +0000 (19:25 +0200)]
Merge branch 'MDL-65543-master' of git://github.com/andrewnicols/moodle
Sara Arjona [Thu, 9 May 2019 14:48:05 +0000 (16:48 +0200)]
Merge branch 'master_MDL-65502' of https://github.com/danmarsden/moodle
Sara Arjona [Thu, 9 May 2019 11:56:58 +0000 (13:56 +0200)]
MDL-65518 badges: some language improvements
Helen has suggested some wording changes to make easier to understand
some of the backpack settings.
Thanks a lot Helen!! :-)
Sara Arjona [Thu, 9 May 2019 14:19:05 +0000 (16:19 +0200)]
Merge branch 'MDL-65518-master' of git://github.com/damyon/moodle
Andrew Nicols [Thu, 9 May 2019 11:34:01 +0000 (19:34 +0800)]
MDL-65543 mod_forum: Move require_login before cap check
Jun Pataleta [Thu, 9 May 2019 07:58:45 +0000 (15:58 +0800)]
Merge branch 'MDL-65445-qtype_ddwtos' of https://github.com/jonof/moodle
Shamim Rezaie [Thu, 9 May 2019 07:29:02 +0000 (15:29 +0800)]
MDL-65540 core_search: Explicit component name in the str helper
Shamim Rezaie [Thu, 9 May 2019 07:24:50 +0000 (15:24 +0800)]
MDL-65540 tool_dataprivacy: Explicit component name in the str helper
Andrew Nicols [Thu, 9 May 2019 07:03:54 +0000 (15:03 +0800)]
Merge branch 'MDL-65479' of git://github.com/stronk7/moodle
Damyon Wiese [Thu, 9 May 2019 06:50:15 +0000 (14:50 +0800)]
MDL-65518 badges: Retry auth test
When testing the site backpack login credentials, don't rely on a previous login
because the username and password could have changed.
Damyon Wiese [Wed, 8 May 2019 06:50:51 +0000 (14:50 +0800)]
MDL-65518 badges: Default Issuer name
If the issuer name is not set, use the site name.
Damyon Wiese [Wed, 8 May 2019 05:25:07 +0000 (13:25 +0800)]
MDL-65518 badges: Admin settings warning
If the backpack is changed to Open Badges V2 backpack,
attempt the authenticate with the site settings and return a warning
if it fails.
Andrew Nicols [Thu, 9 May 2019 06:51:05 +0000 (14:51 +0800)]
Merge branch 'MDL-65435' of git://github.com/stronk7/moodle
Sara Arjona [Thu, 9 May 2019 06:46:30 +0000 (08:46 +0200)]
Merge branch 'MDL-65523-master' of git://github.com/marinaglancy/moodle
Peter [Tue, 7 May 2019 13:06:38 +0000 (21:06 +0800)]
MDL-65520 mod_forum: Add lock icon to indicate locked discussions
Jun Pataleta [Thu, 9 May 2019 04:29:25 +0000 (12:29 +0800)]
Merge branch 'MDL-65141-master' of git://github.com/jleyva/moodle
Adrian Greeve [Thu, 9 May 2019 03:32:19 +0000 (11:32 +0800)]
Merge branch 'MDL-58315_master_boost_block_classes' of https://github.com/zpottie/moodle
Adrian Greeve [Thu, 9 May 2019 03:22:38 +0000 (11:22 +0800)]
Merge branch 'MDL-65387-master' of https://github.com/lucaboesch/moodle
Andrew Nicols [Thu, 9 May 2019 02:51:19 +0000 (10:51 +0800)]
Merge branch 'MDL-65373-master' of https://github.com/ryanwyllie/moodle
Adrian Greeve [Thu, 9 May 2019 01:31:47 +0000 (09:31 +0800)]
Merge branch 'MDL-65519-master' of https://github.com/ryanwyllie/moodle
Ryan Wyllie [Mon, 29 Apr 2019 03:50:57 +0000 (11:50 +0800)]
MDL-65373 forum: accessibility changes for discussion
Dan Marsden [Mon, 6 May 2019 02:10:36 +0000 (14:10 +1200)]
MDL-65502 blocks: Correct check for my dashboard page.
Eloy Lafuente (stronk7) [Sun, 28 Apr 2019 18:35:11 +0000 (20:35 +0200)]
MDL-65435 behat: Support any arg type with behat reruns
Right now, when executing a single rerun of a parallel run
using vendor/bin/behat, not all the argument alternatives
are supported (equal or space). This commit allows both to work.
Luca Bösch [Fri, 19 Apr 2019 11:55:17 +0000 (13:55 +0200)]
MDL-65387 dataformats: Table download formats choose pulldown style.
Eloy Lafuente (stronk7) [Sat, 4 May 2019 10:02:58 +0000 (12:02 +0200)]
MDL-65479 repository_url: make regexp PCRE2 compatible
PHP 7.3 comes with the newer PCRE2 engine that is slightly stricter,
more specifically about using unescaped "-" within classes. They
now hat to be at the end of the class or escaped.
This is the only case we have found in core to make it compatible.
Also note that the file changes is, apparently an imported library,
but we have not it registered and already have performed changes to
it, so I've ignored that point. In fact, it has tabs and so on, I've
not modified that either.
Michael Hawkins [Mon, 18 Mar 2019 07:23:59 +0000 (15:23 +0800)]
MDL-61738 messageinbound: Fix quota checks & filesize for email uploads
Private files uploaded by email will now honour the file quota limit,
because the filesize is set correctly and checked against users'
remaining personal quota limit. Previously, attachment size was always
set to zero, and quota was checked against the draft area (this is
not valid for email uploads, because each file is moved out of the
draft area as it is processed, so multiple files totalling greater
than the remaining quota would still pass the check).
Dan Marsden [Wed, 1 May 2019 01:23:15 +0000 (13:23 +1200)]
MDL-64708 cohort: Return url is not used anywhere in core.
Mark Nelson [Tue, 16 Apr 2019 10:40:16 +0000 (18:40 +0800)]
MDL-65365 core_message: prevent users from viewing all conversations
Eloy Lafuente (stronk7) [Wed, 8 May 2019 15:49:03 +0000 (17:49 +0200)]
on-demand release 3.7dev+
Eloy Lafuente (stronk7) [Wed, 8 May 2019 15:49:02 +0000 (17:49 +0200)]
NOBUG: Fixed file access permissions
Eloy Lafuente (stronk7) [Wed, 8 May 2019 15:49:01 +0000 (17:49 +0200)]
NOBUG: Fixed SVG browser compatibility
Jun Pataleta [Wed, 8 May 2019 04:15:38 +0000 (12:15 +0800)]
Merge branch 'MDL-44484-master' of https://github.com/Chocolate-lightning/moodle
Mathew May [Wed, 8 May 2019 03:55:57 +0000 (15:55 +1200)]
MDL-44484 admin: Remove existing user theme check
Jake Dallimore [Wed, 8 May 2019 03:48:51 +0000 (11:48 +0800)]
Merge branch 'MDL-62599-master' of https://github.com/snake/moodle
Adrian Greeve [Wed, 8 May 2019 03:21:59 +0000 (11:21 +0800)]
Merge branch 'MDL-65484-master' of git://github.com/damyon/moodle
Jake Dallimore [Wed, 8 May 2019 03:16:21 +0000 (11:16 +0800)]
MDL-62599 mod_lti: fix coding style issues
Damyon Wiese [Wed, 8 May 2019 03:08:31 +0000 (11:08 +0800)]
MDL-65518 badges: Language change "Site backpack"
Peter [Mon, 6 May 2019 13:35:09 +0000 (21:35 +0800)]
MDL-65508 mod_forum: Add private to the quick forum reply
Jun Pataleta [Wed, 8 May 2019 02:53:37 +0000 (10:53 +0800)]
Merge branch 'MDL-44484-master' of https://github.com/Chocolate-lightning/moodle
Adrian Greeve [Wed, 8 May 2019 02:47:25 +0000 (10:47 +0800)]
Merge branch 'MDL-65188-master' of git://github.com/andrewnicols/moodle
Mathew May [Mon, 8 Apr 2019 07:35:24 +0000 (15:35 +0800)]
MDL-44484 admin: Theme can be null and create user
Adrian Greeve [Wed, 8 May 2019 02:27:18 +0000 (10:27 +0800)]
Merge branch 'MDL-65516-master' of git://github.com/mihailges/moodle
Andrew Nicols [Wed, 8 May 2019 02:14:52 +0000 (10:14 +0800)]
Merge branch 'MDL-65417-master' of git://github.com/bmbrands/moodle
Jun Pataleta [Wed, 8 May 2019 02:13:13 +0000 (10:13 +0800)]
Merge branch 'MDL-65470-master' of git://github.com/bmbrands/moodle
Andrew Nicols [Wed, 8 May 2019 01:50:32 +0000 (09:50 +0800)]
Merge branch 'MDL-65154' of git://github.com/stronk7/moodle
Andrew Nicols [Wed, 8 May 2019 01:47:04 +0000 (09:47 +0800)]
Merge branch 'MDL-35396-master' of git://github.com/mihailges/moodle
Adrian Greeve [Wed, 8 May 2019 01:37:27 +0000 (09:37 +0800)]
Merge branch 'MDL-65511-master' of git://github.com/mihailges/moodle
Ryan Wyllie [Wed, 8 May 2019 01:32:22 +0000 (09:32 +0800)]
MDL-65519 forum: remove profile link from started by column
Jake Dallimore [Wed, 8 May 2019 01:28:23 +0000 (09:28 +0800)]
MDL-62599 lti_gradebookservices: use correct key in get_permitted_scopes
This was missing from the revert commit,
a464331db2594c, causing scopes
to be empty.
Eloy Lafuente (stronk7) [Tue, 7 May 2019 20:54:37 +0000 (22:54 +0200)]
MDL-65154 competencies: FF 47 does not digest null/missing JS params
So we are defaulting to 0 when the page is initially called,
instead of current null. That's exactly the same behavior
than when you pick "No filters applied" from the filter menu.
Note that other browsers seems to accept perfectly the missing param
but FF 47.0.1 does not.
Amaia Anabitarte [Tue, 7 May 2019 09:49:05 +0000 (11:49 +0200)]
MDL-64993 core_message: fix unit test for non-ordered queries
Adrian Greeve [Tue, 7 May 2019 09:09:40 +0000 (17:09 +0800)]
NOBUG: Fix white space issue due to history rewrite.
Marina Glancy [Tue, 7 May 2019 10:01:26 +0000 (12:01 +0200)]
MDL-65523 customfield_checkbox: allow to set as required