Eloy Lafuente (stronk7) [Sun, 23 Apr 2017 16:13:02 +0000 (18:13 +0200)]
MDL-58681 behat: Split checkbox and advcheckbox tests
MDL-58267 converted "Display description on course page" to advcheckbox
(see
7f53e8aa22d555ba5f94530b7fc04a4e95f35c98).
Advanced checkboxes cannot be tested without real browser because Goutte
does not support the hidden+checkbox duality (MDL-55386).
So this patch does:
- Convert the NON-JS checks to use the "Force format" field (normal checkbox).
- Move the "Display description on course page" (adv. checkbox) to the JS scenario.
- Complete the 2 groups of checks above so the two ways to tick and untick are covered:
- I set the field "xxxx" to "yyyy"
- I set the following fields to these values:
- Complete the 2 groups of checks above so the two ways to verify the values are covered:
- the field "xxxx" [matches|does not match] value "yyyy"
- the following fields [match|do not match] these values:
That's all! The scenario is a bit spaghetti but it's way off the scope
of the issue to fix that.
Dan Poltawski [Fri, 21 Apr 2017 14:48:31 +0000 (15:48 +0100)]
Moodle release 3.3beta
Dan Poltawski [Fri, 21 Apr 2017 14:48:28 +0000 (15:48 +0100)]
NOBUG: Fixed SVG browser compatibility
Dan Poltawski [Fri, 21 Apr 2017 14:48:27 +0000 (15:48 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Dan Poltawski [Fri, 21 Apr 2017 14:37:51 +0000 (15:37 +0100)]
Merge branch 'MDL-58138-master-bulkcompletefix' of https://github.com/mudrd8mz/moodle
David Mudrák [Fri, 21 Apr 2017 14:22:50 +0000 (16:22 +0200)]
MDL-58138 completion: Fix capability required for setting defaults
As per core_completion\manager::get_available_completion_tabs() the
required capability for this feature is moodle/course:manageactivities,
not moodle/course:update.
Dan Poltawski [Fri, 21 Apr 2017 08:04:43 +0000 (09:04 +0100)]
Merge branch 'wip-MDL-58138-fix2' of https://github.com/marinaglancy/moodle
Marina Glancy [Fri, 21 Apr 2017 07:01:32 +0000 (15:01 +0800)]
MDL-58138 completion: manual completion may have expected date
David Monllao [Fri, 21 Apr 2017 06:30:52 +0000 (14:30 +0800)]
Merge branch 'MDL-58621-master-fix' of git://github.com/lameze/moodle
Simey Lameze [Fri, 21 Apr 2017 05:09:06 +0000 (13:09 +0800)]
MDL-58621 block_myoverview: remove behat steps checking dates
David Monllao [Fri, 21 Apr 2017 05:10:50 +0000 (13:10 +0800)]
Merge branch 'MDL-58349-int-fix-1' of github.com:ryanwyllie/moodle
Ryan Wyllie [Fri, 21 Apr 2017 04:45:48 +0000 (04:45 +0000)]
MDL-58349 mod_assign: text wrap for comment search while grading
Jun Pataleta [Fri, 21 Apr 2017 03:52:35 +0000 (11:52 +0800)]
Merge branch 'MDL-58566_master' of github.com:markn86/moodle
Jun Pataleta [Fri, 21 Apr 2017 03:37:57 +0000 (11:37 +0800)]
Merge branch 'MDL-58636-master' of git://github.com/andrewnicols/moodle
Mark Nelson [Fri, 21 Apr 2017 03:27:14 +0000 (11:27 +0800)]
MDL-58566 calendar: fixed comment's reference to non-existent function
Andrew Nicols [Wed, 19 Apr 2017 02:35:37 +0000 (10:35 +0800)]
MDL-58636 course: Ensure that the drag constraint has height
Andrew Nicols [Fri, 21 Apr 2017 02:39:41 +0000 (10:39 +0800)]
Merge branch 'MDL-58490-master-fix' of https://github.com/lameze/moodle
Simey Lameze [Fri, 21 Apr 2017 02:33:36 +0000 (10:33 +0800)]
MDL-58490 block_myoverview: add missing completionlib include
Jake Dallimore [Fri, 21 Apr 2017 02:26:00 +0000 (10:26 +0800)]
Merge branch 'MDL-58613-master-workshopfullname' of git://github.com/mudrd8mz/moodle
Marina Glancy [Fri, 21 Apr 2017 02:05:59 +0000 (10:05 +0800)]
MDL-57457 mod_book: Chapters are not userdata plus some improvements
Andrew Hancox [Wed, 19 Apr 2017 10:27:26 +0000 (11:27 +0100)]
MDL-57457 mod_book: Fix bug with edit form when tagging disabled
Andrew Hancox [Wed, 19 Apr 2017 08:38:31 +0000 (09:38 +0100)]
MDL-57457 mod_book: performance improvement for tags backup/restore
Andrew Hancox [Fri, 24 Mar 2017 15:34:45 +0000 (15:34 +0000)]
MDL-57457 mod_book: Implement tagging
David Monllao [Fri, 21 Apr 2017 02:03:59 +0000 (10:03 +0800)]
Merge branch 'MDL-58590' of https://github.com/sk-unikent/moodle
Jun Pataleta [Fri, 21 Apr 2017 01:04:32 +0000 (09:04 +0800)]
Merge branch 'MDL-58482-master' of git://github.com/lameze/moodle
Andrew Nicols [Fri, 21 Apr 2017 00:52:15 +0000 (08:52 +0800)]
Merge branch 'MDL-58490-master' of git://github.com/lameze/moodle
Simey Lameze [Wed, 19 Apr 2017 07:42:00 +0000 (15:42 +0800)]
MDL-58482 theme_boost: css fixes for view badge page
AMOS bot [Thu, 20 Apr 2017 16:09:48 +0000 (00:09 +0800)]
Automatically generated installer lang files
Dan Poltawski [Thu, 20 Apr 2017 12:14:00 +0000 (13:14 +0100)]
Merge branch 'MDL-58621-master' of git://github.com/ryanwyllie/moodle
Dan Poltawski [Thu, 20 Apr 2017 09:33:53 +0000 (10:33 +0100)]
Merge branch 'MDL-58426-master-bigicons' of git://github.com/mudrd8mz/moodle
David Mudrák [Mon, 17 Apr 2017 18:26:39 +0000 (20:26 +0200)]
MDL-58426 icons: Fix CSS for displaying big icons
The expected size of icons in the pix/b/ (big) folder was not respected
and they were displayed as 16x16 px.
Skylar Kelty [Thu, 13 Apr 2017 09:36:05 +0000 (10:36 +0100)]
MDL-58590 mobile: Cache mobile-supporting plugins
Jun Pataleta [Thu, 20 Apr 2017 08:11:31 +0000 (16:11 +0800)]
Merge branch 'MDL-58415-master' of git://github.com/jleyva/moodle
David Monllao [Thu, 20 Apr 2017 08:08:52 +0000 (16:08 +0800)]
Merge branch 'MDL-58623_master' of git://github.com/markn86/moodle
Juan Leyva [Wed, 19 Apr 2017 07:49:59 +0000 (09:49 +0200)]
MDL-58415 mod_lesson: Fix code styles and missing declaration
Found by the integrator review:
- Some incorrect code style declaration and phpdocs
- Missing $USER declaration
- Incorrect use of $lesson (should be $this)
Juan Leyva [Tue, 18 Apr 2017 08:33:39 +0000 (10:33 +0200)]
MDL-58415 mod_lesson: Add missing answer fields
There were a couple of fields missing when returning the complete
answer information required for offline usage.
Juan Leyva [Tue, 18 Apr 2017 08:28:38 +0000 (10:28 +0200)]
MDL-58415 mod_lesson: EOL var must be always numeric
Otherwise it will break the Web Service return description.
Juan Leyva [Thu, 6 Apr 2017 08:57:52 +0000 (10:57 +0200)]
MDL-58415 mod_lesson: Out of time should be a string
process_eol_page expects a string, right now we are passing a boolean.
We should convert it to the correct string when is set to true, that is
‘normal’
Juan Leyva [Thu, 30 Mar 2017 14:23:39 +0000 (16:23 +0200)]
MDL-58415 mod_lesson: Return always allowofflineattempts
We need this field always to be able to display if the lesson is
available or not for download
Juan Leyva [Tue, 28 Mar 2017 09:01:57 +0000 (11:01 +0200)]
MDL-58415 mod_lesson: Handle correctly review mode
Juan Leyva [Tue, 28 Mar 2017 08:58:52 +0000 (10:58 +0200)]
MDL-58415 mod_lesson: Avoid API http redirections
Deep in the lesson API there are some http redirections in special
pages like clusters.
We need to handle it via new parameters to avoid redirections.
Juan Leyva [Tue, 28 Mar 2017 08:22:09 +0000 (10:22 +0200)]
MDL-58415 mod_lesson: Force int type for calculated progress
Under some circumstances the value returned by the function needs
casting.
Dan Poltawski [Thu, 20 Apr 2017 07:26:54 +0000 (08:26 +0100)]
Merge branch 'MDL-58538-master' of git://github.com/junpataleta/moodle
Mark Nelson [Thu, 20 Apr 2017 07:16:56 +0000 (15:16 +0800)]
MDL-58623 course: allow course summaries to be null in exporter
Andrew Nicols [Thu, 20 Apr 2017 07:23:50 +0000 (15:23 +0800)]
Merge branch 'MDL-58494-master' of git://github.com/ryanwyllie/moodle
David Monllao [Thu, 20 Apr 2017 07:17:59 +0000 (15:17 +0800)]
Merge branch 'MDL-58349-master' of git://github.com/damyon/moodle
Jake Dallimore [Thu, 20 Apr 2017 07:10:21 +0000 (15:10 +0800)]
Merge branch 'wip-MDL-58452-master' of git://github.com/marinaglancy/moodle
Simey Lameze [Thu, 20 Apr 2017 02:06:09 +0000 (10:06 +0800)]
MDL-58490 block_myoverview: separate course and activity completion
Dan Poltawski [Thu, 20 Apr 2017 06:44:56 +0000 (07:44 +0100)]
Merge branch 'MDL-58498-master' of git://github.com/ryanwyllie/moodle
Dan Poltawski [Thu, 20 Apr 2017 06:27:56 +0000 (07:27 +0100)]
Merge branch 'MDL-58637_master' of git://github.com/markn86/moodle
Dan Poltawski [Thu, 20 Apr 2017 06:19:17 +0000 (07:19 +0100)]
Merge branch 'MDL-58617-master' of git://github.com/lameze/moodle
David Monllao [Thu, 20 Apr 2017 06:05:39 +0000 (14:05 +0800)]
Merge branch 'MDL-58278-master' of git://github.com/damyon/moodle
Simey Lameze [Thu, 20 Apr 2017 01:11:25 +0000 (09:11 +0800)]
MDL-58617 core_output: add mapping for dashboard on user menu
Andrew Nicols [Thu, 20 Apr 2017 05:54:43 +0000 (13:54 +0800)]
Merge branch 'wip-MDL-58138-fix' of https://github.com/marinaglancy/moodle
Mark Nelson [Thu, 20 Apr 2017 05:53:42 +0000 (13:53 +0800)]
MDL-58637 format_*: fixed incorrect CSS selector
Ryan Wyllie [Mon, 10 Apr 2017 04:35:21 +0000 (04:35 +0000)]
MDL-58494 mod_feedback: no action after feedback submitted
Don't provide an action in the action event callback if the user has
already submitted their feedback or if they don't have permission to
submit.
Marina Glancy [Thu, 20 Apr 2017 05:42:07 +0000 (13:42 +0800)]
MDL-58138 completion: mform wants 0-based indexes for arrays
Andrew Nicols [Thu, 20 Apr 2017 05:47:21 +0000 (13:47 +0800)]
MDL-58515
Andrew Nicols [Thu, 20 Apr 2017 05:03:34 +0000 (13:03 +0800)]
Merge branch 'MDL-58515-master' of https://github.com/lucisgit/moodle
Andrew Nicols [Thu, 20 Apr 2017 04:58:48 +0000 (12:58 +0800)]
Merge branch 'MDL-58370-master' of git://github.com/damyon/moodle
Andrew Nicols [Thu, 20 Apr 2017 04:38:05 +0000 (12:38 +0800)]
Merge branch 'MDL-57456_master-fix' of git://github.com/dmonllao/moodle
David Monllao [Thu, 20 Apr 2017 04:32:05 +0000 (12:32 +0800)]
MDL-57456 mod_glossary: Proper course access in behat test
David Monllao [Thu, 20 Apr 2017 04:05:42 +0000 (12:05 +0800)]
Merge branch 'MDL-58280-master' of git://github.com/damyon/moodle
Damyon Wiese [Thu, 16 Mar 2017 12:28:50 +0000 (20:28 +0800)]
MDL-58278 mod_assign: Ignore send notify with mw
When marking workflow is on and the grade is not released we never send notifications anyway.
Instead of preventing the grading form from submitting (validation error) we silently ignore it.
Damyon Wiese [Thu, 20 Apr 2017 03:27:25 +0000 (11:27 +0800)]
MDL-58280 fileconverter_googledrive: More helpful errors
Detect some config errors and give a better error message.
Damyon Wiese [Fri, 24 Mar 2017 07:37:45 +0000 (15:37 +0800)]
MDL-58280 fileconverter_googledrive: Fix cibot complaints
Damyon Wiese [Thu, 16 Mar 2017 07:45:22 +0000 (15:45 +0800)]
MDL-58280 fileconverter_googledrive: Is born.
Damyon Wiese [Mon, 10 Apr 2017 06:17:38 +0000 (14:17 +0800)]
MDL-58370 theme: Tiny alignment fixes for icons
The group / completion icons on the course page do not quite line up perfectly in boost or clean.
This tweaks them.
Jake Dallimore [Thu, 20 Apr 2017 01:56:10 +0000 (09:56 +0800)]
Merge branch 'MDL-58412-master' of git://github.com/jleyva/moodle
AMOS bot [Wed, 19 Apr 2017 16:06:41 +0000 (00:06 +0800)]
Automatically generated installer lang files
David Mudrák [Wed, 19 Apr 2017 11:40:10 +0000 (13:40 +0200)]
MDL-58613 workshop: Provide all data to display user name
Additional fields such as middlename, alternatename and others were not
passed to the fullname(), causing a debugging message.
Juan Leyva [Wed, 19 Apr 2017 09:37:15 +0000 (11:37 +0200)]
MDL-58412 mod_feedback: Use constant for anonymous feedback
We were using hardcoded values instead the correct constant
FEEDBACK_ANONYMOUS_NO
Jun Pataleta [Wed, 19 Apr 2017 08:55:14 +0000 (16:55 +0800)]
Merge branch 'wip-MDL-58530-master' of git://github.com/marinaglancy/moodle
Jun Pataleta [Wed, 19 Apr 2017 08:20:21 +0000 (16:20 +0800)]
Merge branch 'MDL-58642-master' of git://github.com/lameze/moodle
Jake Dallimore [Wed, 19 Apr 2017 07:50:48 +0000 (15:50 +0800)]
Merge branch 'MDL-58520-master' of git://github.com/ryanwyllie/moodle
David Monllao [Wed, 19 Apr 2017 07:44:37 +0000 (15:44 +0800)]
MDL-57456 glossary: Refine patch changes
David Monllao [Wed, 19 Apr 2017 07:42:29 +0000 (15:42 +0800)]
Merge branch 'wip-MDL-57456-master' of git://github.com/marinaglancy/moodle
Simey Lameze [Wed, 19 Apr 2017 06:32:08 +0000 (14:32 +0800)]
MDL-58642 mod_glossary: add mapping for minus icon
Andrew Nicols [Wed, 19 Apr 2017 05:50:28 +0000 (13:50 +0800)]
Merge branch 'MDL-58536-master' of git://github.com/ryanwyllie/moodle
Ryan Wyllie [Thu, 6 Apr 2017 07:58:13 +0000 (07:58 +0000)]
MDL-58520 block_myoverview: change display name to Course overview
Change the display name of the my overview block to Course overview to
match the block it is replacing (and the UX prototype).
The use of "My" is no longer recommended when naming things in Moodle.
Ryan Wyllie [Fri, 7 Apr 2017 06:29:15 +0000 (06:29 +0000)]
MDL-58536 block_myoverview: use moodle user timezone for midnight calc
Pass the user's midnight timestamp to the javascript to ensure that a
user's timezone is respected when calculating the categories the events
should be placed in on the event list.
Jun Pataleta [Fri, 7 Apr 2017 09:25:44 +0000 (17:25 +0800)]
MDL-58538 repository_onedrive: Use image_url() instead of pix_url()
Jun Pataleta [Fri, 7 Apr 2017 09:22:06 +0000 (17:22 +0800)]
MDL-58538 core: Set proper PHP Documentation for pix_url()
Add @deprecated tag for theme_config::pix_url(). Add PHPDoc block for
renderer_base::pix_url().
Andrew Nicols [Wed, 19 Apr 2017 03:53:40 +0000 (11:53 +0800)]
Merge branch 'MDL-58138-master-v2' of git://github.com/snake/moodle
Jake Dallimore [Wed, 12 Apr 2017 03:50:43 +0000 (11:50 +0800)]
MDL-58138 completion: Fixes for a number of small issues.
Ryan Wyllie [Wed, 19 Apr 2017 03:30:44 +0000 (03:30 +0000)]
MDL-58621 block_myoverview: align course icon when no progress
David Monllao [Wed, 19 Apr 2017 03:30:03 +0000 (11:30 +0800)]
Merge branch 'MDL-54901' of git://github.com/stronk7/moodle
Ryan Wyllie [Wed, 19 Apr 2017 03:08:17 +0000 (03:08 +0000)]
MDL-58621 block_myoverview: don't display course start and end dates
Marina Glancy [Wed, 5 Apr 2017 05:04:13 +0000 (13:04 +0800)]
MDL-58138 completion: changes after rebasing
The defaults for the completion have been changed in MDL-55611
Marina Glancy [Mon, 3 Apr 2017 02:45:18 +0000 (10:45 +0800)]
MDL-58460 mod_data: work with bulk completion API
Part of MDL-58138 epic
Jake Dallimore [Mon, 3 Apr 2017 00:56:27 +0000 (08:56 +0800)]
MDL-58460 completion: add callbacks to mod_data for bulk completion
Part of MDL-58138 epic
Marina Glancy [Fri, 31 Mar 2017 06:57:59 +0000 (14:57 +0800)]
MDL-58408 completion: can not require grade if grading is not available
Part of MDL-58138 epic
Jake Dallimore [Fri, 31 Mar 2017 06:32:44 +0000 (14:32 +0800)]
MDL-58138 completion: consolidate bulk edit notifications to single call
Part of MDL-58138 epic
Jake Dallimore [Wed, 29 Mar 2017 06:46:12 +0000 (14:46 +0800)]
MDL-58138 completion: move new lang strings to the completion lang file
Part of MDL-58138 epic
Jake Dallimore [Fri, 24 Mar 2017 06:09:09 +0000 (14:09 +0800)]
MDL-58138 completion: conditional state buttons and css fixes
Part of MDL-58138 epic
Jake Dallimore [Fri, 24 Mar 2017 03:51:45 +0000 (11:51 +0800)]
MDL-58138 completion: rebase on font-awesome changes.
Part of MDL-58138 epic
Jake Dallimore [Tue, 21 Mar 2017 07:09:56 +0000 (15:09 +0800)]
MDL-58138 completion: Assorted linting fixes.
Part of MDL-58138 epic
Jake Dallimore [Thu, 16 Mar 2017 07:27:25 +0000 (15:27 +0800)]
MDL-58138 tests: unit and behat tests covering bulk and default tabs
Part of MDL-58138 epic
Marina Glancy [Tue, 21 Mar 2017 06:11:02 +0000 (14:11 +0800)]
MDL-58267 completion: style and capabilities cleanup
Part of MDL-58138 epic
Marina Glancy [Fri, 17 Mar 2017 07:24:59 +0000 (15:24 +0800)]
MDL-58267 completion: allow to set default activity completion
Part of MDL-58138 epic