Andrew Nicols [Thu, 18 Jun 2020 11:19:41 +0000 (19:19 +0800)]
MDL-69086 theme_boost: Improve pendingJs checks for bootstrap
Where an element, like an `alert`, is closed it is removed from the DOM
before the event fires (this is a correct behaviour).
This means that the final event confirming that the action happened
(i.e. close => closed) fires, but does not bubble up the DOM to the
document.body.
This change moves the end event listener to only be added after a start
event has been fired, and to attach directly to the HTMLElement where it
will be fired. This means that the Event handler will still be called,
even though it has been removed from the DOM, because it does not need
to bubble up to the body.
Sara Arjona [Thu, 18 Jun 2020 12:14:26 +0000 (14:14 +0200)]
weekly on-sync release 4.0dev
Sara Arjona [Thu, 18 Jun 2020 12:14:23 +0000 (14:14 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Victor Deniz Falcon [Thu, 18 Jun 2020 03:16:53 +0000 (04:16 +0100)]
Merge branch 'MDL-66899-log-quiz-regrade' of https://github.com/rboyatt/moodle
Víctor Déniz Falcón [Wed, 17 Jun 2020 22:38:15 +0000 (23:38 +0100)]
Merge branch 'MDL-69060-master' of git://github.com/lucaboesch/moodle
Jun Pataleta [Wed, 17 Jun 2020 11:53:29 +0000 (19:53 +0800)]
Merge branch 'MDL-68890-master' of https://github.com/DinhHien0307/moodle
Jake Dallimore [Wed, 17 Jun 2020 06:57:42 +0000 (14:57 +0800)]
Merge branch 'MDL-68215-master' of git://github.com/lucaboesch/moodle
Jun Pataleta [Wed, 17 Jun 2020 03:36:12 +0000 (11:36 +0800)]
Merge branch 'MDL-68971' of https://github.com/timhunt/moodle
Jun Pataleta [Wed, 17 Jun 2020 02:33:55 +0000 (10:33 +0800)]
Merge branch 'MDL-67294-master' of git://github.com/mihailges/moodle
Víctor Déniz Falcón [Tue, 16 Jun 2020 17:05:42 +0000 (18:05 +0100)]
Merge branch 'MDL-69049-master' of git://github.com/junpataleta/moodle
Mihail Geshoski [Fri, 12 Jun 2020 00:55:30 +0000 (08:55 +0800)]
MDL-67294 assignsubmission_file: Make sure record exists before updating
Jun Pataleta [Tue, 16 Jun 2020 06:38:44 +0000 (14:38 +0800)]
Merge branch 'MDL-68436' of https://github.com/timhunt/moodle
Jun Pataleta [Mon, 15 Jun 2020 14:47:22 +0000 (22:47 +0800)]
MDL-69049 tool_dataprivacy: Add possibly missing comment format columns
The earlier CONTRIB plugin versions of the tool (<33.2.0, <34.2.0) were
missing the following columns in the data requests table:
* commentsformat
* dpocommentformat
And the upgrade scripts for the merged tool failed in
Moodle 3.3.8+/3.3.0+ failed to add these columns.
So a site which uses the CONTRIB plugin and eventually upgrading to 3.9
will encounter an error during upgrade because of the missing
dpocommentformat column.
Víctor Déniz Falcón [Mon, 15 Jun 2020 16:21:49 +0000 (17:21 +0100)]
Merge branch 'MDL-69044' of https://github.com/stronk7/moodle
Víctor Déniz Falcón [Mon, 15 Jun 2020 14:55:22 +0000 (15:55 +0100)]
Merge branch 'MDL-69043' of https://github.com/stronk7/moodle
Luca Bösch [Sat, 21 Mar 2020 10:54:06 +0000 (11:54 +0100)]
MDL-68215 block_activity_result: Format elements more nicely.
Luca Bösch [Mon, 15 Jun 2020 11:35:43 +0000 (13:35 +0200)]
MDL-69060 core_contentbank: fix contenbank typos.
hiendinh [Tue, 2 Jun 2020 07:07:03 +0000 (14:07 +0700)]
MDL-68890 progressbar: prevent display exist file's progress bar
Eloy Lafuente (stronk7) [Sun, 14 Jun 2020 11:08:09 +0000 (13:08 +0200)]
MDL-69044 upgrade: add 3.9.0 separation line to all upgrade scripts
Eloy Lafuente (stronk7) [Sun, 14 Jun 2020 10:53:38 +0000 (12:53 +0200)]
MDL-69043 backup: Bump release to 4.0
AMOS bot [Sun, 14 Jun 2020 00:07:18 +0000 (00:07 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Sat, 13 Jun 2020 18:11:29 +0000 (20:11 +0200)]
weekly back-to-dev release 4.0dev
Eloy Lafuente (stronk7) [Sat, 13 Jun 2020 18:04:50 +0000 (20:04 +0200)]
NOBUG: Change travis.yml back to master
Eloy Lafuente (stronk7) [Sat, 13 Jun 2020 18:04:49 +0000 (20:04 +0200)]
Moodle release 3.9
Eloy Lafuente (stronk7) [Sat, 13 Jun 2020 18:04:49 +0000 (20:04 +0200)]
NOBUG: Change travis.yml to MOODLE_39_STABLE
Eloy Lafuente (stronk7) [Fri, 12 Jun 2020 17:52:26 +0000 (19:52 +0200)]
Merge branch 'MDL-68632' of git://github.com/aolley/moodle
Victor Deniz Falcon [Fri, 12 Jun 2020 11:32:06 +0000 (12:32 +0100)]
Moodle release 3.9rc3
Jun Pataleta [Fri, 12 Jun 2020 03:58:59 +0000 (11:58 +0800)]
Merge branch 'MDL-69026-master' of git://github.com/andrewnicols/moodle
Adam Olley [Thu, 7 May 2020 04:28:23 +0000 (13:58 +0930)]
MDL-68632 quizaccess_seb: Limit privacy queriyes to the quiz module
Without this, joins are performed against the course_modules table purely on
the instance id - other modules can share this ID, resulting in incorrect
contexts being pulled in.
Andrew Nicols [Fri, 12 Jun 2020 01:39:25 +0000 (09:39 +0800)]
MDL-69026 user: Correct statuses => status in test
Andrew Nicols [Fri, 12 Jun 2020 00:46:46 +0000 (08:46 +0800)]
MDL-69026 user: Wrap sub-query in brackets
It is perfectly valid to have a query like:
Match None of the following:
- Role is ANY of the following:
-- 'Teacher'
-- 'Editing teacher'
-- 'Manager'; AND
- Keyword is NONE of the following:
-- 'Kevin'
However, due to the way in which the query is constructed, this leads to
a query which includes
WHERE NOT ef.id IS NOT NULL
AND NOT
u.id IN (SELECT userid FROM {role_assignments} WHERE roleid IN (...) AND contextid IN (...))
AND NOT
NOT (u.firstname || ' ' || u.lastname LIKE '%Kevin%')
The use of NOT NOT is valid in Postgres, MariaDB, MySQL, and MSSQL, but
not in Oracle.
To counter this when the outer jointype is of type NONE, we must wrap
each of the inner WHERE clauses in a set of brackets, which makes the
query:
WHERE NOT ef.id IS NOT NULL
AND NOT
(u.id IN (SELECT userid FROM {role_assignments} WHERE roleid IN (...) AND contextid IN (...)))
AND NOT
(NOT (u.firstname || ' ' || u.lastname LIKE '%Kevin%'))
Whilst Oracle does not support the use of `AND NOT NOT ...`, it does support
`AND NOT (NOT ...)`
Sara Arjona [Thu, 11 Jun 2020 16:05:14 +0000 (18:05 +0200)]
Moodle release 3.9rc2
Sara Arjona [Thu, 11 Jun 2020 10:50:49 +0000 (12:50 +0200)]
Merge branch 'MDL-69022' of https://github.com/Chocolate-lightning/moodle
Mathew May [Thu, 11 Jun 2020 09:16:12 +0000 (17:16 +0800)]
MDL-69022 tool_moodlenet: Disable integration by default
Jun Pataleta [Thu, 11 Jun 2020 08:59:04 +0000 (16:59 +0800)]
Merge branch 'MDL-69017-master' of git://github.com/andrewnicols/moodle
Sara Arjona [Thu, 11 Jun 2020 08:22:38 +0000 (10:22 +0200)]
Merge branch 'MDL-69004-master' of git://github.com/rezaies/moodle
Jake Dallimore [Thu, 11 Jun 2020 08:18:08 +0000 (16:18 +0800)]
Merge branch 'MDL-69020-master' of git://github.com/mihailges/moodle
Mihail Geshoski [Thu, 11 Jun 2020 07:23:54 +0000 (15:23 +0800)]
MDL-69020 tool_moodlenet: Modify defaultmoodlenet_desc string
Andrew Nicols [Thu, 11 Jun 2020 04:13:09 +0000 (12:13 +0800)]
MDL-69017 user: Show all links should work for students
Jun Pataleta [Thu, 11 Jun 2020 06:22:48 +0000 (14:22 +0800)]
Merge branch 'MDL-67070-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 11 Jun 2020 04:59:26 +0000 (12:59 +0800)]
Merge branch 'MDL-69006-master' of git://github.com/bmbrands/moodle
Jake Dallimore [Thu, 11 Jun 2020 04:27:16 +0000 (12:27 +0800)]
Merge branch 'MDL-68991-master' of git://github.com/rezaies/moodle
Jake Dallimore [Thu, 11 Jun 2020 04:01:22 +0000 (12:01 +0800)]
Merge branch 'MDL-69010' of https://github.com/Chocolate-lightning/moodle
Jun Pataleta [Thu, 11 Jun 2020 03:28:31 +0000 (11:28 +0800)]
Merge branch 'MDL-69013-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 11 Jun 2020 03:08:14 +0000 (11:08 +0800)]
Merge branch 'MDL-69002-master' of git://github.com/sarjona/moodle
Andrew Nicols [Thu, 11 Jun 2020 03:05:27 +0000 (11:05 +0800)]
MDL-67070 tool_usertours: Fix assumption that tours exist
Jun Pataleta [Thu, 11 Jun 2020 03:01:05 +0000 (11:01 +0800)]
Merge branch 'MDL-68912' of https://github.com/rlorenzo/moodle
Adrian Greeve [Thu, 11 Jun 2020 02:43:13 +0000 (10:43 +0800)]
MDL-66601 atto_image: Removing bad js build files.
Mathew May [Wed, 10 Jun 2020 12:38:11 +0000 (20:38 +0800)]
MDL-69010 tool_moodlenet: Migrate default MoodleNet instance setting
Andrew Nicols [Thu, 11 Jun 2020 01:43:38 +0000 (09:43 +0800)]
MDL-69013 core: Add quizaccess_safebrowser to deleted plugins
Adrian Greeve [Thu, 11 Jun 2020 01:43:07 +0000 (09:43 +0800)]
Merge branch 'MDL-66601-master' of git://github.com/mihailges/moodle
Andrew Nicols [Thu, 11 Jun 2020 00:05:45 +0000 (08:05 +0800)]
MDL-67070 tool_usertours: Remove old tour JSON files
Andrew Nicols [Wed, 10 Jun 2020 23:50:40 +0000 (07:50 +0800)]
MDL-67070 tool_usertours: Disable old tours
Shamim Rezaie [Wed, 10 Jun 2020 16:37:45 +0000 (02:37 +1000)]
MDL-69004 core: Encourage admins to enable user feedback
As part of this commit, the default for the user feedback feature
has changed to disable.
Rex Lorenzo [Thu, 4 Jun 2020 06:02:02 +0000 (23:02 -0700)]
MDL-68912 user: "Send a message" select all not working
Eloy Lafuente (stronk7) [Wed, 10 Jun 2020 21:53:35 +0000 (23:53 +0200)]
Merge branch 'MDL-68954-master' of git://github.com/mihailges/moodle
Eloy Lafuente (stronk7) [Wed, 10 Jun 2020 21:31:11 +0000 (23:31 +0200)]
Merge branch 'MDL-68994-master' of git://github.com/andrewnicols/moodle
Victor Deniz Falcon [Wed, 10 Jun 2020 20:41:56 +0000 (21:41 +0100)]
Merge branch 'MDL-68980-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Wed, 10 Jun 2020 16:03:54 +0000 (00:03 +0800)]
Merge branch 'MDL-68989-master' of git://github.com/mickhawkins/moodle
Sara Arjona [Wed, 10 Jun 2020 15:57:40 +0000 (17:57 +0200)]
Merge branch 'MDL-68902-master' of git://github.com/ferranrecio/moodle
Eloy Lafuente (stronk7) [Wed, 10 Jun 2020 15:52:53 +0000 (17:52 +0200)]
Merge branch 'MDL-69005' of https://github.com/paulholden/moodle
Ferran Recio [Tue, 9 Jun 2020 11:21:50 +0000 (13:21 +0200)]
MDL-68902 mod_h5pactivity: fix result report output
Bas Brands [Wed, 10 Jun 2020 13:08:41 +0000 (15:08 +0200)]
MDL-69006 repository_flickr: flickr authentication fails
- Flickr does not like useragents including the word "Bot"
Tim Hunt [Wed, 10 Jun 2020 12:40:15 +0000 (13:40 +0100)]
MDL-68436 atto_recordrtc: only works once per page
Víctor Déniz Falcón [Wed, 10 Jun 2020 12:12:58 +0000 (13:12 +0100)]
Merge branch 'MDL-68986-master' of git://github.com/merrill-oakland/moodle
Peter Dias [Wed, 10 Jun 2020 04:24:11 +0000 (12:24 +0800)]
MDL-69002 core_badges: performance update to set default sitebackpack
Sara Arjona [Wed, 10 Jun 2020 10:27:40 +0000 (12:27 +0200)]
MDL-69002 core_badges: move backpack validation to a separate page
Instead of running the site backpack validation every time badges/backpacks.php
page is loaded, an action button has been added to the backpacks with OB set
to 2.0 to let admins running manually this verification when needed.
Sara Arjona [Wed, 10 Jun 2020 10:23:26 +0000 (12:23 +0200)]
MDL-69002 core_badges: add methods to support backpack validation
A more generic method has been added to the API to validate the
backpack connection (for now, there was only one method for
validating current backpack).
Besides, a renderer has been added to display this information
depending on the backpackid.
Sara Arjona [Wed, 10 Jun 2020 10:05:40 +0000 (12:05 +0200)]
MDL-69002 core_badges: remove site backpack verification from settings
This site backpack verification is not required so, instead of
running it always here, it will be moved to a separate page to let
admins decide when to check it.
Paul Holden [Wed, 10 Jun 2020 08:34:25 +0000 (09:34 +0100)]
MDL-69005 cache: fix private $store access in loader.
Andrew Nicols [Wed, 10 Jun 2020 08:23:58 +0000 (16:23 +0800)]
MDL-68980 user: Add additional groupmode participants tests
Jake Dallimore [Wed, 10 Jun 2020 08:13:57 +0000 (16:13 +0800)]
Merge branch 'MDL-68973' of https://github.com/stronk7/moodle
Jake Dallimore [Wed, 10 Jun 2020 07:36:44 +0000 (15:36 +0800)]
Merge branch 'MDL-68977-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Tue, 9 Jun 2020 11:09:03 +0000 (19:09 +0800)]
MDL-68994 user: Reset filterverb value when resetting filter
Marina Glancy [Wed, 10 Jun 2020 06:15:25 +0000 (14:15 +0800)]
MDL-68980 user: Test for groupmode participants behaviour
Andrew Nicols [Tue, 9 Jun 2020 07:52:37 +0000 (15:52 +0800)]
MDL-68980 core_user: Show user participation group when groupmode set
Shamim Rezaie [Tue, 9 Jun 2020 12:42:04 +0000 (22:42 +1000)]
MDL-68991 core: delete core_get_userfeedback_url webservice
Shamim Rezaie [Tue, 9 Jun 2020 11:34:44 +0000 (21:34 +1000)]
MDL-68991 core: Prevent popup blockers blocking feedback window
Some browsers like Firefox are very inflexible with window.open()
and block it if it is not instantly invoked after the user click.
Also according to https://stackoverflow.com/a/
6807615 it is best
practice to replace self:: with static::
Shamim Rezaie [Fri, 5 Jun 2020 09:48:07 +0000 (19:48 +1000)]
MDL-68931 core: No feedback link on footer if the feature is disabled
Sara Arjona [Wed, 10 Jun 2020 06:06:05 +0000 (08:06 +0200)]
Merge branch 'MDL-68955' of https://github.com/Chocolate-lightning/moodle
Mihail Geshoski [Wed, 10 Jun 2020 04:08:13 +0000 (12:08 +0800)]
MDL-66601 atto_image: Set the max-height of the image selection dialogue
Jun Pataleta [Wed, 10 Jun 2020 03:26:13 +0000 (11:26 +0800)]
Merge branch 'MDL-68864-master' of git://github.com/junpataleta/moodle
Jun Pataleta [Wed, 10 Jun 2020 03:20:22 +0000 (11:20 +0800)]
MDL-68864 qtype_multichoice: Rebuild clearchoice source map
Bas Brands [Tue, 9 Jun 2020 13:56:51 +0000 (15:56 +0200)]
MDL-68864 qtype_multichoice: clearchoice button styles
- display the clearchoice link as a button to improve the way
it looks when using keyboard focus
Bas Brands [Tue, 9 Jun 2020 13:39:34 +0000 (15:39 +0200)]
MDL-68864 qtype_multichoice: shift focus to first option on keyboard tab
- This prevents losing focus when using keyboard navigation.
Bas Brands [Wed, 3 Jun 2020 15:40:33 +0000 (17:40 +0200)]
MDL-68864 qtype_multichoice: clearchoice
- Reverted changes from MDL-67901
Mathew May [Mon, 8 Jun 2020 04:13:09 +0000 (12:13 +0800)]
MDL-68955 mod_h5pactivity: Enable dndupload to H5P activity
Adrian Greeve [Wed, 10 Jun 2020 01:39:45 +0000 (09:39 +0800)]
Merge branch 'MDL-68985-master' of git://github.com/sarjona/moodle
Jake Dallimore [Wed, 10 Jun 2020 01:14:46 +0000 (09:14 +0800)]
Merge branch 'MDL-68972-master-enfix' of git://github.com/mudrd8mz/moodle
Jake Dallimore [Wed, 10 Jun 2020 00:53:21 +0000 (08:53 +0800)]
Merge branch 'MDL-68995' of https://github.com/paulholden/moodle
Jake Dallimore [Wed, 10 Jun 2020 00:37:46 +0000 (08:37 +0800)]
Merge branch 'MDL-68999-master-homemoodlenet' of git://github.com/mudrd8mz/moodle
Jake Dallimore [Wed, 10 Jun 2020 00:33:38 +0000 (08:33 +0800)]
Merge branch 'MDL-68998-master' of git://github.com/marinaglancy/moodle
Andrew Nicols [Wed, 10 Jun 2020 00:16:03 +0000 (08:16 +0800)]
MDL-68977 enrol_manual: Add pending promises to enrol modal
Andrew Nicols [Tue, 9 Jun 2020 07:15:24 +0000 (15:15 +0800)]
MDL-68977 core_user: Refresh table after removing all filters
Previously the update function was called for each row as it was
removed. This patch changes the behaviouro to only remove one row at at
ime.
David Mudrák [Tue, 9 Jun 2020 20:16:00 +0000 (22:16 +0200)]
MDL-68999 moodlenet: Make the default instance name translatable
Admins can change the value as they want / need. Still, it will be nice
if the default value (the name of the default MoodleNet instance) is
controlled by the language pack.
Beside that, it will allow us to more easily change the value should we
need it in the future (via the en_fix process).
Helen Foster [Tue, 9 Jun 2020 18:56:34 +0000 (20:56 +0200)]
MDL-68972 lang: Import fixed English strings (en_fix)
Eloy Lafuente (stronk7) [Tue, 9 Jun 2020 18:27:30 +0000 (20:27 +0200)]
MDL-68973 versions: Fix other small details
Thanks to Luca Bösch and Matteo Scaramuccia that detected
these 2 minor, but ugly details in core version files:
1) Adding comments pointed to versions (3.x,
20190801...) is not
recommended, they easily come outdated.
2) Using plugin->release in core is no sense. Core plugins belong
to the core release.
This commit just gets rid of them. That's all.
Marina Glancy [Tue, 9 Jun 2020 15:52:43 +0000 (17:52 +0200)]
MDL-68998 core_course: do not expect that assign is the first module
Ferran Recio [Tue, 9 Jun 2020 14:57:43 +0000 (16:57 +0200)]
MDL-68902 core_h5p: add essay h5p package
Jun Pataleta [Tue, 9 Jun 2020 14:53:04 +0000 (22:53 +0800)]
Merge branch 'MDL-68931-master' of git://github.com/rezaies/moodle