Víctor Déniz Falcón [Wed, 1 Jul 2020 08:37:46 +0000 (09:37 +0100)]
MDL-69093 enrol_manual: added check for allowed roles a user can assign
Andrew Nicols [Tue, 7 Jul 2020 06:15:54 +0000 (14:15 +0800)]
Merge branch 'MDL-69106-39' of git.in.moodle.com:cameron/moodle into MOODLE_39_STABLE
Eloy Lafuente (stronk7) [Mon, 6 Jul 2020 22:17:26 +0000 (00:17 +0200)]
Merge branch 'MDL-60827-39' of git://github.com/mihailges/moodle into MOODLE_39_STABLE
Andrew Nicols [Mon, 6 Jul 2020 05:25:31 +0000 (13:25 +0800)]
MDL-69110 table: Remove commented code
Andrew Nicols [Mon, 6 Jul 2020 05:26:00 +0000 (13:26 +0800)]
Merge branch 'MDL-69110-39' of git://github.com/junpataleta/moodle into MOODLE_39_STABLE
Andrew Nicols [Mon, 6 Jul 2020 04:12:12 +0000 (12:12 +0800)]
Merge branch 'MDL-69158-39' of git://github.com/lucaboesch/moodle into MOODLE_39_STABLE
Jake Dallimore [Mon, 6 Jul 2020 02:44:34 +0000 (10:44 +0800)]
Merge branch 'MDL-69136-39' of git://github.com/andrewnicols/moodle into MOODLE_39_STABLE
Mihail Geshoski [Thu, 2 Jul 2020 08:37:05 +0000 (16:37 +0800)]
MDL-60827 oauth2: Consider requireconfirmation setting on login
Michael Hawkins [Fri, 26 Jun 2020 02:01:17 +0000 (10:01 +0800)]
MDL-69128 admin: Convert HTML entities when populating tasklogs filter
Jun Pataleta [Fri, 3 Jul 2020 16:47:14 +0000 (00:47 +0800)]
MDL-69110 core: Unset the correct sort data element
Eloy Lafuente (stronk7) [Fri, 3 Jul 2020 16:41:38 +0000 (18:41 +0200)]
weekly release 3.9+
Eloy Lafuente (stronk7) [Fri, 3 Jul 2020 16:41:32 +0000 (18:41 +0200)]
Merge branch 'install_39_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_39_STABLE
Jake Dallimore [Thu, 2 Jul 2020 04:08:37 +0000 (12:08 +0800)]
Merge branch 'MDL-69130-39-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_39_STABLE
Jake Dallimore [Thu, 2 Jul 2020 03:57:18 +0000 (11:57 +0800)]
Merge branch 'MDL-69149-39' of git://github.com/andrewnicols/moodle into MOODLE_39_STABLE
Jake Dallimore [Thu, 2 Jul 2020 03:49:19 +0000 (11:49 +0800)]
Merge branch 'MDL-69122-39' of git://github.com/bmbrands/moodle into MOODLE_39_STABLE
AMOS bot [Thu, 2 Jul 2020 00:08:08 +0000 (00:08 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Wed, 1 Jul 2020 21:21:00 +0000 (23:21 +0200)]
Merge branch 'MDL-69072-39' of git://github.com/andrewnicols/moodle into MOODLE_39_STABLE
Andrew Nicols [Tue, 16 Jun 2020 00:24:52 +0000 (08:24 +0800)]
MDL-69072 behat: Remove restart_browser_after feature
This is no longer required as the Mink session is restarted after every
test regardless.
Luca Bösch [Fri, 1 May 2020 22:06:28 +0000 (00:06 +0200)]
MDL-68584 core_question: flexbox compatible separator for question types
* the br tag does not work well in a flexbox context, a 100% with div
works in both classic and boost.
Paul Holden [Fri, 26 Jun 2020 16:11:44 +0000 (17:11 +0100)]
MDL-69150 message_airnotifier: correct apps portal link.
Paul Holden [Fri, 26 Jun 2020 16:31:37 +0000 (17:31 +0100)]
MDL-69151 message_airnotifier: start output before accesskey request.
This allows debugging generated by the request to be shown on the
page.
Cameron Ball [Tue, 30 Jun 2020 02:12:33 +0000 (10:12 +0800)]
MDL-69106 assignfeedback_editpdf: Keep files in conversion queue
In some circumstances, a submission waiting to be converted needs to persist
in the conversion queue so that it can be polled on subsequent cron runs.
Luca Bösch [Mon, 8 Jul 2019 13:07:17 +0000 (15:07 +0200)]
MDL-69158 block_blog_menu: format search form.
Andrew Nicols [Thu, 25 Jun 2020 03:08:47 +0000 (11:08 +0800)]
MDL-69136 behat: Improve reliability of navigation steps
Andrew Nicols [Mon, 29 Jun 2020 03:27:05 +0000 (11:27 +0800)]
MDL-69136 behat: Support find on a NodeElement
Andrew Nicols [Tue, 16 Jun 2020 00:23:33 +0000 (08:23 +0800)]
MDL-69072 mod_scorm: Stop mink reset after tests
This is now done for all scenarios. It is no longer necessary to do so
specifically for mod_scorm.
Andrew Nicols [Mon, 15 Jun 2020 02:37:52 +0000 (10:37 +0800)]
MDL-69072 behat: Relaunch browser session between scenarios
Andrew Nicols [Fri, 26 Jun 2020 11:59:56 +0000 (19:59 +0800)]
MDL-69149 core_grade: Correct xpath attribute selector
Helen Foster [Thu, 25 Jun 2020 12:27:58 +0000 (14:27 +0200)]
MDL-69130 lang: Import fixed English strings (en_fix)
Significant string change:
- presentationoraltrequired,atto_image - wording changed to mention
'decorative only' checkbox
Eloy Lafuente (stronk7) [Thu, 25 Jun 2020 16:06:36 +0000 (18:06 +0200)]
weekly release 3.9+
Eloy Lafuente (stronk7) [Thu, 25 Jun 2020 16:06:31 +0000 (18:06 +0200)]
Merge branch 'install_39_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_39_STABLE
Bas Brands [Wed, 24 Jun 2020 07:06:21 +0000 (09:06 +0200)]
MDL-69122 report_competency: fix clearfix
- a misplaced clearfix caused part of the recontrols to be
inaccessible
Nicolas Martignoni [Fri, 12 Jun 2020 15:20:18 +0000 (17:20 +0200)]
MDL-68992 Privacy: Update default minimal digital age of consent
Updating default minimal digital age of consent according to current legislation,
that was updated for several countries since 2018.
Peter Dias [Tue, 16 Jun 2020 01:30:40 +0000 (09:30 +0800)]
MDL-69065 course: Provide the id for the sr param
* Pass the section return id to the activity chooser
* Additional behat test to cover the case
Andrew Nicols [Mon, 15 Jun 2020 02:37:17 +0000 (10:37 +0800)]
MDL-66568 behat: Reset theme CSS between scenarios
Andrew Nicols [Mon, 15 Jun 2020 02:35:38 +0000 (10:35 +0800)]
MDL-66568 behat: Support building of themes for behat
Andrew Nicols [Mon, 15 Jun 2020 02:34:40 +0000 (10:34 +0800)]
MDL-66568 core_output: Return built theme CSS
AMOS bot [Tue, 23 Jun 2020 12:25:17 +0000 (12:25 +0000)]
Automatically generated installer lang files
Bas Brands [Thu, 11 Jun 2020 08:22:00 +0000 (10:22 +0200)]
MDL-69021 theme_boost: improve link styles in alerts
- provide default styles for links in alerts if the .alert-link
css class is omitted.
hiendinh [Thu, 11 Jun 2020 08:25:25 +0000 (15:25 +0700)]
MDL-68841 Modal dialogs: Wrong behavior of popup
Víctor Déniz Falcón [Mon, 22 Jun 2020 16:20:10 +0000 (17:20 +0100)]
Merge branch 'MDL-69099-39-disabledtasks' of git://github.com/mudrd8mz/moodle into MOODLE_39_STABLE
David Mudrák [Fri, 19 Jun 2020 15:02:08 +0000 (17:02 +0200)]
MDL-69099 tasks: Do not mark the non-enabled plugin's task as disabled
The `core\plugininfo\base::is_enabled()` uses three-state logic for its
return value. It can return null as a valid value as per its
documentation. We need to test for the explicit false value in this
case.
To make the attached Behat test able to identify the table, the caption
is added. It seems to be helpful for all users so I leave it displayed
without using the accesshide mechanism.
Jake Dallimore [Mon, 22 Jun 2020 04:41:28 +0000 (12:41 +0800)]
Merge branch 'MDL-69047-39' of git://github.com/aanabit/moodle into MOODLE_39_STABLE
Adrian Greeve [Mon, 22 Jun 2020 02:41:47 +0000 (10:41 +0800)]
Merge branch 'MDL-69077_39' of https://github.com/timhunt/moodle into MOODLE_39_STABLE
Jun Pataleta [Wed, 10 Jun 2020 15:18:10 +0000 (23:18 +0800)]
MDL-69008 core: Fix accessibility issues in paged content templates
* Added menuitem role for the "Show x per page" menu.
* Added appropriate aria-labels for the links in the paging bar.
Amaia Anabitarte [Tue, 16 Jun 2020 14:23:39 +0000 (16:23 +0200)]
MDL-69047 core_contentbank: Hard coding status messages
Sara Arjona [Thu, 18 Jun 2020 12:14:00 +0000 (14:14 +0200)]
weekly release 3.9+
Russell Boyatt [Tue, 9 Jun 2020 08:50:34 +0000 (09:50 +0100)]
MDL-66899 quiz: Adding test for regrading quiz event.
Russell Boyatt [Sat, 2 May 2020 08:47:51 +0000 (09:47 +0100)]
MDL-66899 quiz: Log a regrading event when quiz attempt is regraded.
Víctor Déniz Falcón [Wed, 17 Jun 2020 22:44:40 +0000 (23:44 +0100)]
Merge branch 'MDL-69060-39' of git://github.com/lucaboesch/moodle into MOODLE_39_STABLE
Tim Hunt [Wed, 17 Jun 2020 12:06:57 +0000 (13:06 +0100)]
MDL-69077 questions: question tag capabilties are relevant
hiendinh [Tue, 2 Jun 2020 07:07:03 +0000 (14:07 +0700)]
MDL-68890 progressbar: prevent display exist file's progress bar
Jake Dallimore [Wed, 17 Jun 2020 06:58:35 +0000 (14:58 +0800)]
Merge branch 'MDL-68215-39' of git://github.com/lucaboesch/moodle into MOODLE_39_STABLE
Tim Hunt [Mon, 8 Jun 2020 16:28:08 +0000 (17:28 +0100)]
MDL-68971 webservice: errors should give enough info to find the problem
Jun Pataleta [Wed, 17 Jun 2020 02:36:14 +0000 (10:36 +0800)]
Merge branch 'MDL-67294-39' of git://github.com/mihailges/moodle into MOODLE_39_STABLE
Jun Pataleta [Mon, 15 Jun 2020 14:47:22 +0000 (22:47 +0800)]
MDL-69049 tool_dataprivacy: Add possibly missing comment format columns
The earlier CONTRIB plugin versions of the tool (<33.2.0, <34.2.0) were
missing the following columns in the data requests table:
* commentsformat
* dpocommentformat
And the upgrade scripts for the merged tool failed in
Moodle 3.3.8+/3.3.0+ failed to add these columns.
So a site which uses the CONTRIB plugin and eventually upgrading to 3.9
will encounter an error during upgrade because of the missing
dpocommentformat column.
Mihail Geshoski [Fri, 12 Jun 2020 00:55:30 +0000 (08:55 +0800)]
MDL-67294 assignsubmission_file: Make sure record exists before updating
Tim Hunt [Wed, 10 Jun 2020 12:40:15 +0000 (13:40 +0100)]
MDL-68436 atto_recordrtc: only works once per page
Víctor Déniz Falcón [Mon, 15 Jun 2020 16:36:32 +0000 (17:36 +0100)]
Merge branch 'MDL-69044_39' of https://github.com/stronk7/moodle into MOODLE_39_STABLE
Luca Bösch [Sat, 21 Mar 2020 10:54:06 +0000 (11:54 +0100)]
MDL-68215 block_activity_result: Format elements more nicely.
Luca Bösch [Mon, 15 Jun 2020 11:35:43 +0000 (13:35 +0200)]
MDL-69060 core_contentbank: fix contenbank typos.
Eloy Lafuente (stronk7) [Sun, 14 Jun 2020 11:08:09 +0000 (13:08 +0200)]
MDL-69044 upgrade: add 3.9.0 separation line to all upgrade scripts
Eloy Lafuente (stronk7) [Sat, 13 Jun 2020 18:04:49 +0000 (20:04 +0200)]
Moodle release 3.9
Eloy Lafuente (stronk7) [Sat, 13 Jun 2020 18:04:49 +0000 (20:04 +0200)]
NOBUG: Change travis.yml to MOODLE_39_STABLE
Eloy Lafuente (stronk7) [Fri, 12 Jun 2020 17:52:26 +0000 (19:52 +0200)]
Merge branch 'MDL-68632' of git://github.com/aolley/moodle
Victor Deniz Falcon [Fri, 12 Jun 2020 11:32:06 +0000 (12:32 +0100)]
Moodle release 3.9rc3
Jun Pataleta [Fri, 12 Jun 2020 03:58:59 +0000 (11:58 +0800)]
Merge branch 'MDL-69026-master' of git://github.com/andrewnicols/moodle
Adam Olley [Thu, 7 May 2020 04:28:23 +0000 (13:58 +0930)]
MDL-68632 quizaccess_seb: Limit privacy queriyes to the quiz module
Without this, joins are performed against the course_modules table purely on
the instance id - other modules can share this ID, resulting in incorrect
contexts being pulled in.
Andrew Nicols [Fri, 12 Jun 2020 01:39:25 +0000 (09:39 +0800)]
MDL-69026 user: Correct statuses => status in test
Andrew Nicols [Fri, 12 Jun 2020 00:46:46 +0000 (08:46 +0800)]
MDL-69026 user: Wrap sub-query in brackets
It is perfectly valid to have a query like:
Match None of the following:
- Role is ANY of the following:
-- 'Teacher'
-- 'Editing teacher'
-- 'Manager'; AND
- Keyword is NONE of the following:
-- 'Kevin'
However, due to the way in which the query is constructed, this leads to
a query which includes
WHERE NOT ef.id IS NOT NULL
AND NOT
u.id IN (SELECT userid FROM {role_assignments} WHERE roleid IN (...) AND contextid IN (...))
AND NOT
NOT (u.firstname || ' ' || u.lastname LIKE '%Kevin%')
The use of NOT NOT is valid in Postgres, MariaDB, MySQL, and MSSQL, but
not in Oracle.
To counter this when the outer jointype is of type NONE, we must wrap
each of the inner WHERE clauses in a set of brackets, which makes the
query:
WHERE NOT ef.id IS NOT NULL
AND NOT
(u.id IN (SELECT userid FROM {role_assignments} WHERE roleid IN (...) AND contextid IN (...)))
AND NOT
(NOT (u.firstname || ' ' || u.lastname LIKE '%Kevin%'))
Whilst Oracle does not support the use of `AND NOT NOT ...`, it does support
`AND NOT (NOT ...)`
Sara Arjona [Thu, 11 Jun 2020 16:05:14 +0000 (18:05 +0200)]
Moodle release 3.9rc2
Sara Arjona [Thu, 11 Jun 2020 10:50:49 +0000 (12:50 +0200)]
Merge branch 'MDL-69022' of https://github.com/Chocolate-lightning/moodle
Mathew May [Thu, 11 Jun 2020 09:16:12 +0000 (17:16 +0800)]
MDL-69022 tool_moodlenet: Disable integration by default
Jun Pataleta [Thu, 11 Jun 2020 08:59:04 +0000 (16:59 +0800)]
Merge branch 'MDL-69017-master' of git://github.com/andrewnicols/moodle
Sara Arjona [Thu, 11 Jun 2020 08:22:38 +0000 (10:22 +0200)]
Merge branch 'MDL-69004-master' of git://github.com/rezaies/moodle
Jake Dallimore [Thu, 11 Jun 2020 08:18:08 +0000 (16:18 +0800)]
Merge branch 'MDL-69020-master' of git://github.com/mihailges/moodle
Mihail Geshoski [Thu, 11 Jun 2020 07:23:54 +0000 (15:23 +0800)]
MDL-69020 tool_moodlenet: Modify defaultmoodlenet_desc string
Andrew Nicols [Thu, 11 Jun 2020 04:13:09 +0000 (12:13 +0800)]
MDL-69017 user: Show all links should work for students
Jun Pataleta [Thu, 11 Jun 2020 06:22:48 +0000 (14:22 +0800)]
Merge branch 'MDL-67070-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 11 Jun 2020 04:59:26 +0000 (12:59 +0800)]
Merge branch 'MDL-69006-master' of git://github.com/bmbrands/moodle
Jake Dallimore [Thu, 11 Jun 2020 04:27:16 +0000 (12:27 +0800)]
Merge branch 'MDL-68991-master' of git://github.com/rezaies/moodle
Jake Dallimore [Thu, 11 Jun 2020 04:01:22 +0000 (12:01 +0800)]
Merge branch 'MDL-69010' of https://github.com/Chocolate-lightning/moodle
Jun Pataleta [Thu, 11 Jun 2020 03:28:31 +0000 (11:28 +0800)]
Merge branch 'MDL-69013-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 11 Jun 2020 03:08:14 +0000 (11:08 +0800)]
Merge branch 'MDL-69002-master' of git://github.com/sarjona/moodle
Andrew Nicols [Thu, 11 Jun 2020 03:05:27 +0000 (11:05 +0800)]
MDL-67070 tool_usertours: Fix assumption that tours exist
Jun Pataleta [Thu, 11 Jun 2020 03:01:05 +0000 (11:01 +0800)]
Merge branch 'MDL-68912' of https://github.com/rlorenzo/moodle
Adrian Greeve [Thu, 11 Jun 2020 02:43:13 +0000 (10:43 +0800)]
MDL-66601 atto_image: Removing bad js build files.
Mathew May [Wed, 10 Jun 2020 12:38:11 +0000 (20:38 +0800)]
MDL-69010 tool_moodlenet: Migrate default MoodleNet instance setting
Andrew Nicols [Thu, 11 Jun 2020 01:43:38 +0000 (09:43 +0800)]
MDL-69013 core: Add quizaccess_safebrowser to deleted plugins
Adrian Greeve [Thu, 11 Jun 2020 01:43:07 +0000 (09:43 +0800)]
Merge branch 'MDL-66601-master' of git://github.com/mihailges/moodle
Andrew Nicols [Thu, 11 Jun 2020 00:05:45 +0000 (08:05 +0800)]
MDL-67070 tool_usertours: Remove old tour JSON files
Andrew Nicols [Wed, 10 Jun 2020 23:50:40 +0000 (07:50 +0800)]
MDL-67070 tool_usertours: Disable old tours
Shamim Rezaie [Wed, 10 Jun 2020 16:37:45 +0000 (02:37 +1000)]
MDL-69004 core: Encourage admins to enable user feedback
As part of this commit, the default for the user feedback feature
has changed to disable.
Rex Lorenzo [Thu, 4 Jun 2020 06:02:02 +0000 (23:02 -0700)]
MDL-68912 user: "Send a message" select all not working
Eloy Lafuente (stronk7) [Wed, 10 Jun 2020 21:53:35 +0000 (23:53 +0200)]
Merge branch 'MDL-68954-master' of git://github.com/mihailges/moodle
Eloy Lafuente (stronk7) [Wed, 10 Jun 2020 21:31:11 +0000 (23:31 +0200)]
Merge branch 'MDL-68994-master' of git://github.com/andrewnicols/moodle
Victor Deniz Falcon [Wed, 10 Jun 2020 20:41:56 +0000 (21:41 +0100)]
Merge branch 'MDL-68980-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Wed, 10 Jun 2020 16:03:54 +0000 (00:03 +0800)]
Merge branch 'MDL-68989-master' of git://github.com/mickhawkins/moodle
Sara Arjona [Wed, 10 Jun 2020 15:57:40 +0000 (17:57 +0200)]
Merge branch 'MDL-68902-master' of git://github.com/ferranrecio/moodle
Eloy Lafuente (stronk7) [Wed, 10 Jun 2020 15:52:53 +0000 (17:52 +0200)]
Merge branch 'MDL-69005' of https://github.com/paulholden/moodle