Simey Lameze [Wed, 3 Aug 2016 06:23:44 +0000 (14:23 +0800)]
MDL-55367 report_log: declare log array indexes to avoid errors
Andrew Nicols [Wed, 3 Aug 2016 02:45:15 +0000 (10:45 +0800)]
Merge branch 'MDL-55355-master-fix' of https://github.com/lameze/moodle
Simey Lameze [Wed, 3 Aug 2016 02:22:58 +0000 (10:22 +0800)]
MDL-55355 mod_feedback: Change show chart data step to avoid errors
Simey Lameze [Wed, 3 Aug 2016 01:42:27 +0000 (09:42 +0800)]
MDL-55355 core: Fix incorrect chart link selector
Eloy Lafuente (stronk7) [Wed, 3 Aug 2016 01:22:16 +0000 (03:22 +0200)]
Merge branch 'MDL-24343-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Mon, 11 Jul 2016 06:05:47 +0000 (14:05 +0800)]
MDL-24343 core: Deprecate unzip_file
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 23:01:51 +0000 (01:01 +0200)]
Merge branch 'MDL-55276-master' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 22:50:19 +0000 (00:50 +0200)]
Merge branch 'MDL-54656_m32v3' of https://github.com/sbourget/moodle
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 22:33:58 +0000 (00:33 +0200)]
Merge branch 'MDL-55166-master-blocksettings' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 22:29:45 +0000 (00:29 +0200)]
Merge branch 'MDL-54941-master' of git://github.com/jleyva/moodle
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 22:12:10 +0000 (00:12 +0200)]
Merge branch 'MDL-55322-master' of https://github.com/snake/moodle
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 21:13:25 +0000 (23:13 +0200)]
Merge branch 'MDL-54745_master' of https://github.com/snake/moodle
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 19:25:24 +0000 (21:25 +0200)]
Merge branch 'MDL-44369_m32v3' of https://github.com/sbourget/moodle
Dan Poltawski [Tue, 2 Aug 2016 19:11:27 +0000 (20:11 +0100)]
MDL-54847 tests: fix unused var
Dan Poltawski [Tue, 2 Aug 2016 19:09:45 +0000 (20:09 +0100)]
Merge branch 'MDL-54847-master-fix' of git://github.com/cameron1729/moodle
Cameron Ball [Tue, 2 Aug 2016 18:52:12 +0000 (02:52 +0800)]
MDL-54847 weblib: Test media attributes individually
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 17:54:00 +0000 (19:54 +0200)]
Merge branch 'MDL-55167-master' of git://github.com/danpoltawski/moodle
Dan Poltawski [Tue, 2 Aug 2016 17:52:41 +0000 (18:52 +0100)]
MDL-55167 npm: add stylelint-checkstyle-formatter
Useful for automations (like the Moodle prechecker)
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 16:54:49 +0000 (18:54 +0200)]
Merge branch 'MDL-55167-master' of git://github.com/danpoltawski/moodle
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 15:16:07 +0000 (17:16 +0200)]
Merge branch 'MDL-55314-master' of https://github.com/mrmark/moodle
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 15:07:16 +0000 (17:07 +0200)]
Merge branch 'MDL-55315-master' of https://github.com/mrmark/moodle
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 15:01:46 +0000 (17:01 +0200)]
Merge branch 'MDL-55316-master' of https://github.com/mrmark/moodle
Eloy Lafuente (stronk7) [Tue, 2 Aug 2016 14:48:26 +0000 (16:48 +0200)]
Merge branch 'MDL-55348-master' of git://github.com/dpalou/moodle
Dan Poltawski [Tue, 2 Aug 2016 11:20:11 +0000 (12:20 +0100)]
Merge branch 'wip-MDL-33741-master' of git://github.com/marinaglancy/moodle
Dan Poltawski [Tue, 2 Aug 2016 11:17:03 +0000 (12:17 +0100)]
Merge branch 'MDL-45734_m32v4' of https://github.com/sbourget/moodle
Dan Poltawski [Tue, 2 Aug 2016 09:54:28 +0000 (10:54 +0100)]
Merge branch 'MDL-55357_master' of git://github.com/dmonllao/moodle
Dan Poltawski [Tue, 2 Aug 2016 09:54:21 +0000 (10:54 +0100)]
Merge branch 'MDL-54847-master' of git://github.com/cameron1729/moodle
Cameron Ball [Thu, 21 Jul 2016 08:04:29 +0000 (16:04 +0800)]
MDL-54847 MDL-54847 weblib: Support basic HTML media tags
Andrew Nicols [Tue, 2 Aug 2016 02:29:30 +0000 (10:29 +0800)]
Merge branch 'MDL-55355-master' of git://github.com/lameze/moodle
Andrew Nicols [Tue, 2 Aug 2016 02:10:38 +0000 (10:10 +0800)]
Merge branch 'MDL-55352-master-fix' of https://github.com/lameze/moodle
Simey Lameze [Tue, 2 Aug 2016 01:23:18 +0000 (09:23 +0800)]
MDL-55352 mod_feedback: Change series labels on multi choice rated
Andrew Nicols [Tue, 2 Aug 2016 01:10:19 +0000 (09:10 +0800)]
Merge branch 'MDL-54879-master' of git://github.com/junpataleta/moodle
Andrew Nicols [Tue, 2 Aug 2016 00:48:36 +0000 (08:48 +0800)]
Merge branch 'MDL-55140_m32v2' of https://github.com/sbourget/moodle
Dan Poltawski [Mon, 1 Aug 2016 17:57:00 +0000 (18:57 +0100)]
Merge branch 'MDL-55360-master-workshopgradepass' of git://github.com/mudrd8mz/moodle
Dan Poltawski [Mon, 1 Aug 2016 15:07:43 +0000 (16:07 +0100)]
MDL-55376 assign: trailing whitespace
Dan Poltawski [Mon, 1 Aug 2016 15:07:00 +0000 (16:07 +0100)]
Merge branch 'MDL-55376-master' of git://github.com/cameron1729/moodle
Dan Poltawski [Mon, 1 Aug 2016 13:25:38 +0000 (14:25 +0100)]
Merge branch 'MDL-55367-master' of git://github.com/lameze/moodle
Dan Poltawski [Mon, 1 Aug 2016 12:58:20 +0000 (13:58 +0100)]
Merge branch 'MDL-55323-master' of git://github.com/junpataleta/moodle
Dan Poltawski [Mon, 1 Aug 2016 12:50:37 +0000 (13:50 +0100)]
Merge branch 'MDL-55374-master' of git://github.com/damyon/moodle
Dan Poltawski [Mon, 1 Aug 2016 08:30:33 +0000 (09:30 +0100)]
Merge branch 'MDL-55352-master' of git://github.com/lameze/moodle
Andrew Nicols [Mon, 1 Aug 2016 07:04:17 +0000 (15:04 +0800)]
Merge branch 'MDL-53152-master' of git://github.com/junpataleta/moodle
Jun Pataleta [Mon, 18 Jul 2016 05:31:30 +0000 (13:31 +0800)]
MDL-53152 theme: Add parentheses to variable calculations
Simey Lameze [Thu, 28 Jul 2016 07:58:14 +0000 (15:58 +0800)]
MDL-55367 report_log: Prevent invalid time to be passed to Charts API
Jake Dallimore [Fri, 27 May 2016 03:22:55 +0000 (11:22 +0800)]
MDL-54745 mod_assign: Remove leftover changegradewarning string and js
Andrew Nicols [Mon, 1 Aug 2016 02:49:15 +0000 (10:49 +0800)]
Merge branch 'MDL-55266-master' of git://github.com/jleyva/moodle
Andrew Nicols [Mon, 1 Aug 2016 01:54:06 +0000 (09:54 +0800)]
Merge branch 'MDL-50286_m32v3' of https://github.com/sbourget/moodle
Stephen Bourget [Mon, 1 Aug 2016 01:45:27 +0000 (21:45 -0400)]
MDL-50286 report_log: Allow filtering by event origin.
Jake Dallimore [Mon, 25 Jul 2016 03:56:43 +0000 (11:56 +0800)]
MDL-55322 assignfeedback_editpdf: Prevent scroll when moving comments
Prevent the default scroll behaviour when using gestures to move
comments on the mobile site.
Simey Lameze [Fri, 29 Jul 2016 02:13:37 +0000 (10:13 +0800)]
MDL-55355 core: Change chart link text when status change
Marina Glancy [Thu, 28 Jul 2016 03:42:40 +0000 (11:42 +0800)]
MDL-33741 file_info: show courses in hidden categories
This also has a couple of bugfixes:
- file_info_context_system::get_children() was looking for courses with parent=0, it is impossible, block removed;
- file_info_context_coursecat::get_area_coursecat_description() was checking the wrong capability to view files in description
Marina Glancy [Fri, 19 Jul 2013 07:02:33 +0000 (17:02 +1000)]
MDL-33741 file_info: check capability when serving file in coursecat description
Andrew Nicols [Mon, 1 Aug 2016 00:46:54 +0000 (08:46 +0800)]
Merge branch 'MDL-55289-master-exsubmission' of git://github.com/mudrd8mz/moodle
Dan Poltawski [Fri, 8 Jul 2016 16:26:11 +0000 (17:26 +0100)]
MDL-55167 stylelint: disable some rules in grunt
These will be fixed in a later issue
Dan Poltawski [Wed, 6 Jul 2016 20:01:24 +0000 (21:01 +0100)]
MDL-55167 less: Add some stylelint exceptions to deal with later
1) Use of REM units in course.less
2) CSS hacks (MDL-55142)
Dan Poltawski [Wed, 6 Jul 2016 19:58:13 +0000 (20:58 +0100)]
MDL-55167 less: fix line over length
Dan Poltawski [Wed, 6 Jul 2016 14:29:41 +0000 (15:29 +0100)]
MDL-55167 less: remove empty blocks
Dan Poltawski [Tue, 5 Jul 2016 21:36:24 +0000 (22:36 +0100)]
MDL-55167 less: reformat one line statemets into multiple lines
Dan Poltawski [Tue, 5 Jul 2016 21:59:19 +0000 (22:59 +0100)]
MDL-55167 less: add missing linebreak seperators
Detected by
http://stylelint.io/user-guide/rules/at-rule-empty-line-before/
Dan Poltawski [Tue, 5 Jul 2016 21:22:06 +0000 (22:22 +0100)]
MDL-55167 less: fix spacing of selectors
Detected by
http://stylelint.io/user-guide/rules/block-opening-brace-space-before/
http://stylelint.io/user-guide/rules/selector-combinator-space-after/
http://stylelint.io/user-guide/rules/at-rule-name-space-after/
http://stylelint.io/user-guide/rules/selector-list-comma-space-before/
http://stylelint.io/user-guide/rules/media-feature-colon-space-before/
http://stylelint.io/user-guide/rules/selector-list-comma-newline-after/
Dan Poltawski [Tue, 5 Jul 2016 21:03:56 +0000 (22:03 +0100)]
MDL-55167 less: fix missing semi colons
Detected by:
http://stylelint.io/user-guide/rules/declaration-block-trailing-semicolon/
Dan Poltawski [Tue, 5 Jul 2016 20:18:36 +0000 (21:18 +0100)]
MDL-55167 less: fix spacing on properties
Detected by stylelint rules:
http://stylelint.io/user-guide/rules/declaration-colon-space-after/
http://stylelint.io/user-guide/rules/declaration-colon-space-before/
http://stylelint.io/user-guide/rules/function-comma-space-after/
http://stylelint.io/user-guide/rules/declaration-bang-space-before/
Dan Poltawski [Tue, 5 Jul 2016 14:56:53 +0000 (15:56 +0100)]
MDL-55167 grunt: add stylelint css linting
Stephen Bourget [Sat, 30 Jul 2016 01:51:05 +0000 (21:51 -0400)]
MDL-45734 Badges: Add additional events
Stephen Bourget [Fri, 29 Jul 2016 12:56:20 +0000 (08:56 -0400)]
MDL-44369 Calendar: add events for subscriptions
Cameron Ball [Fri, 29 Jul 2016 09:39:10 +0000 (17:39 +0800)]
MDL-55376 mod_assign: Fix bug stopping admin from editing submissions
David Monllao [Fri, 29 Jul 2016 05:59:32 +0000 (13:59 +0800)]
MDL-55357 search: Contents include UTF8 characters, adding u modifier
Simey Lameze [Fri, 29 Jul 2016 04:42:24 +0000 (12:42 +0800)]
MDL-55352 core: Label values series should override tooltip
Damyon Wiese [Fri, 29 Jul 2016 02:43:25 +0000 (10:43 +0800)]
MDL-55374 mod_assign: Force utf-8 for DOMDocument
This prevents charset issues on some sites.
Andrew Nicols [Mon, 11 Jul 2016 05:14:44 +0000 (13:14 +0800)]
MDL-24343 core: Deprecate zip_files
Juan Leyva [Thu, 21 Jul 2016 14:42:58 +0000 (15:42 +0100)]
MDL-55266 user: New WS core_user_get_user_preferences
Juan Leyva [Tue, 12 Jul 2016 15:38:38 +0000 (16:38 +0100)]
MDL-54941 webservice: Refactor file handling in WS
This commit reduces boilerplate code.
It also forces WS returning files to always return the following
fields: filename, filepath, mimetype, filesize, timemodified and
fileurl.
Dani Palou [Wed, 27 Jul 2016 07:05:58 +0000 (09:05 +0200)]
MDL-55348 wiki: Convert 'section' WS params to PARAM_RAW
David Mudrák [Wed, 27 Jul 2016 15:11:39 +0000 (17:11 +0200)]
MDL-55360 workshop: Add tests for setting grades to pass via mod form
These scenarios should cover common cases of defining the grades to pass
pass via the workshop settings form. Note that behaviour of the fields
in terms of locale-specific decimals input (MDL-51806) is not covered
with these tests as I want to avoid installation of additional language
pack. Instead, I assume that functionality of unformat_float() is tested
separately in the core.
David Mudrák [Wed, 27 Jul 2016 14:22:12 +0000 (16:22 +0200)]
MDL-55360 workshop: Emptying grades to pass should set them to zero
When editing existing workshop with a grade to pass defined, when the
field is emptied, it should be interpreted as setting it to zero. This
was not happening because unformat_float replaces the field with null,
therefore effectively unsetting it.
By casting to float, we interpret all empty values (including null) as
zeros. This behaviour is consistent with how gradebook setup UI works.
David Mudrák [Wed, 27 Jul 2016 14:20:18 +0000 (16:20 +0200)]
MDL-55360 workshop: Allow creating workshops with empty grades to pass
As a regression of MDL-55360, it was not possible to create new
workshops if the field "Submission grade to pass" or "Assessment grade
to pass" was left empty. The validation failed with "You must enter a
number here".
The fields submissiongradepass and gradinggradepass are always present
as we explicitly define them in the mod form. So the isset() condition
in the validation was useless and it did not allow to submit the form
with these fields empty.
Additionally, the unformat_float() returns null only if it receives
empty value on the input. Which can't happen in our case so I am
removing this condition to improve the readability of the code.
David Mudrák [Mon, 25 Jul 2016 17:40:26 +0000 (19:40 +0200)]
MDL-55289 workshop: Fix files processing in example submissions
While testing the issue MDL-55289 I realized that attaching files to
workshop example submissions does not work at all and throws an error.
The reason was that in MDL-50794 (
996f7e82), the variables $contentopts
and $attachmentopts were replaced with the result of the methods
submission_content_options() and submission_attachment_options().
But I forgot to perform the full refactoring in exsubmission.php too.
Attached behat test should cover both issues on this branch.
David Mudrák [Mon, 25 Jul 2016 17:30:30 +0000 (19:30 +0200)]
MDL-55289 workshop: Include repository/lib.php to use its constants
As a result of MDL-41556 (
146893d6), the repository/lib.php was included
in submission.php so that its constant FILE_INTERNAL could be used in
field options. Recent development in MDL-50794 (
996f7e8) moved the
options declaration to standalone methods but we forgot to check they
work in exsubmission.php too.
This patch moves the repository/lib.php inclusion to where the
library is actually needed.
Additionally it unifies how options are set for overall feedback content
and overall feedback attachment fields.
Jun Pataleta [Mon, 25 Jul 2016 06:40:45 +0000 (14:40 +0800)]
MDL-55323 enrol_lti: Remove unused required parameter
Jun Pataleta [Tue, 19 Jul 2016 07:06:00 +0000 (15:06 +0800)]
MDL-55276 html: New down arrow entity output $OUTPUT->darrow
Jun Pataleta [Thu, 9 Jun 2016 08:45:31 +0000 (16:45 +0800)]
MDL-54879 mod_lti: Add fallback options for error message upon failure
David Monllao [Thu, 28 Jul 2016 04:07:20 +0000 (12:07 +0800)]
weekly release 3.2dev
David Mudrák [Wed, 27 Jul 2016 20:49:49 +0000 (22:49 +0200)]
MDL-55166 admin: Fix display of misleading debug warning on manage block
Blocks can declare has_config() as true without actually using the
default node in the admin tree. Typical use case is when the block
injects its settings to other parts of the admin tree and it assigns
null to its $setting node in its settings.php file.
As Janek L.B. correctly spotted, this led to false debugging message
on admin/blocks.php as the code interpreted it as missing settings.php
file.
The patch adds explicit file existence test for this rare case.
Mark Nielsen [Fri, 22 Jul 2016 18:10:10 +0000 (11:10 -0700)]
MDL-55314 mod_lti: Several fixes to lti_load_cartridge
* Fixed XML loading when there is an error
* Fixed exception thrown by lti_load_cartridge
* By default, don't allow LTI mod generator to
use a toolurl as that results in a cURL call.
Stephen Bourget [Wed, 27 Jul 2016 11:18:54 +0000 (07:18 -0400)]
MDL-55140 mod_choice: Allow independent open and close dates
Dan Poltawski [Wed, 27 Jul 2016 06:58:33 +0000 (07:58 +0100)]
Merge branch 'MDL-55287_master-fix' of git://github.com/dmonllao/moodle
David Monllao [Wed, 27 Jul 2016 05:56:31 +0000 (13:56 +0800)]
MDL-55287 search: Custom error message if solr extension is not installed
Correcting engine is not installed lang string as well.
David Monllao [Wed, 27 Jul 2016 05:17:33 +0000 (13:17 +0800)]
Merge branch 'wip-mdl-54987' of https://github.com/rajeshtaneja/moodle
Mark Nelson [Wed, 27 Jul 2016 03:42:47 +0000 (11:42 +0800)]
MDL-54984 core_cache: corrected exception message
Rajesh Taneja [Wed, 27 Jul 2016 03:00:54 +0000 (11:00 +0800)]
MDL-54987 behat: Fixed feedback scenarios to display chart data
Now chart data is not visible by default,
we need to click 'Show chart data' to view.
Also, extra space is not required between
% as it's done by chart library
Eloy Lafuente (stronk7) [Tue, 26 Jul 2016 22:59:19 +0000 (00:59 +0200)]
Merge branch 'MDL-50267-master' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Tue, 26 Jul 2016 22:19:40 +0000 (00:19 +0200)]
Merge branch 'MDL-55244-master' of git://github.com/danpoltawski/moodle
Eloy Lafuente (stronk7) [Tue, 26 Jul 2016 21:44:54 +0000 (23:44 +0200)]
Merge branch 'MDL-55245-master' of https://github.com/lucisgit/moodle
Eloy Lafuente (stronk7) [Tue, 26 Jul 2016 18:15:13 +0000 (20:15 +0200)]
Merge branch 'wip-MDL-51735-master' of git://github.com/abgreeve/moodle
Eloy Lafuente (stronk7) [Tue, 26 Jul 2016 17:56:20 +0000 (19:56 +0200)]
Merge branch 'MDL-54657_m32v1' of https://github.com/sbourget/moodle
Eloy Lafuente (stronk7) [Tue, 26 Jul 2016 17:54:53 +0000 (19:54 +0200)]
Merge branch 'MDL-54801-master' of git://github.com/jleyva/moodle
Eloy Lafuente (stronk7) [Tue, 26 Jul 2016 17:45:18 +0000 (19:45 +0200)]
MDL-55046 assign: document the new return values
Eloy Lafuente (stronk7) [Tue, 26 Jul 2016 17:40:52 +0000 (19:40 +0200)]
Merge branch 'MDL-55046-master' of git://github.com/dpalou/moodle
Eloy Lafuente (stronk7) [Tue, 26 Jul 2016 11:12:07 +0000 (13:12 +0200)]
Merge branch 'wip-mdl-55337' of https://github.com/rajeshtaneja/moodle
Rajesh Taneja [Tue, 26 Jul 2016 02:14:53 +0000 (10:14 +0800)]
MDL-55337 behat: Added 1 sec delay between post
Ensure post is created at different timestamp, else
returned posts will be different and test fails.
This will happen on a fast machine.
Dan Poltawski [Tue, 26 Jul 2016 10:57:09 +0000 (11:57 +0100)]
Merge branch 'MDL-55278_master' of https://github.com/dmonllao/moodle