Jun Pataleta [Tue, 23 Oct 2018 01:22:14 +0000 (09:22 +0800)]
Merge branch 'MDL-62560-master-fix' of git://github.com/andrewnicols/moodle
Andrew Nicols [Tue, 23 Oct 2018 00:50:40 +0000 (08:50 +0800)]
Merge branch 'MDL-63408_master' of git://github.com/markn86/moodle
Andrew Nicols [Tue, 23 Oct 2018 00:17:18 +0000 (08:17 +0800)]
MDL-62560 tool_dataprivacy: Behat fix for protected check
Damyon Wiese [Wed, 19 Sep 2018 08:09:37 +0000 (16:09 +0800)]
MDL-61391 forum: Improve semantics for permalinks
Replace the anchor tags in forum posts containing the postid but no href with
an id on the element containing the post. Use rel="bookmark" for perma links
and update the styling so they look visually the same.
David Monllao [Mon, 22 Oct 2018 14:50:47 +0000 (16:50 +0200)]
Merge branch 'MDL-61391-master' of git://github.com/damyon/moodle
David Monllao [Mon, 22 Oct 2018 14:48:56 +0000 (16:48 +0200)]
Merge branch 'MDL-61388-master' of git://github.com/damyon/moodle
David Monllao [Mon, 22 Oct 2018 14:33:17 +0000 (16:33 +0200)]
Merge branch 'MDL-62144-master' of git://github.com/damyon/moodle
David Monllao [Mon, 22 Oct 2018 14:28:41 +0000 (16:28 +0200)]
Merge branch 'MDL-62309-master-optionalpolicies' of git://github.com/mudrd8mz/moodle
David Monllao [Mon, 22 Oct 2018 12:41:12 +0000 (14:41 +0200)]
Merge branch 'MDL-63625-master' of git://github.com/marinaglancy/moodle
David Monllao [Mon, 22 Oct 2018 12:36:23 +0000 (14:36 +0200)]
Merge branch 'MDL-61052-master' of git://github.com/damyon/moodle
David Monllao [Mon, 22 Oct 2018 10:52:58 +0000 (12:52 +0200)]
Merge branch 'MDL-62560-master'
Andrew Nicols [Thu, 18 Oct 2018 06:16:57 +0000 (14:16 +0800)]
MDL-62560 tool_dataprivacy: Add a purpose override cache
Andrew Nicols [Thu, 18 Oct 2018 06:16:31 +0000 (14:16 +0800)]
MDL-62560 tool_dataprivacy: Fetch user purpose once
Andrew Nicols [Wed, 17 Oct 2018 05:11:51 +0000 (13:11 +0800)]
MDL-62560 tool_dataprivacy: Add status logging
Andrew Nicols [Wed, 17 Oct 2018 04:53:27 +0000 (12:53 +0800)]
MDL-62560 tool_dataprivacy: Add unit test for filtered userlist
Mihail Geshoski [Fri, 12 Oct 2018 03:28:51 +0000 (11:28 +0800)]
MDL-63636 block_recent_activity: Support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Thu, 11 Oct 2018 06:23:29 +0000 (14:23 +0800)]
MDL-63621 core_cohort: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Mon, 15 Oct 2018 02:36:37 +0000 (10:36 +0800)]
MDL-63633 block_comments: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Fri, 12 Oct 2018 03:11:36 +0000 (11:11 +0800)]
MDL-63635 block_community: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Wed, 10 Oct 2018 08:21:34 +0000 (16:21 +0800)]
MDL-63593 auth_mnet: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Wed, 10 Oct 2018 08:17:19 +0000 (16:17 +0800)]
MDL-63592 auth_oauth2: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Fri, 12 Oct 2018 05:12:42 +0000 (13:12 +0800)]
MDL-63637 block_rss_client: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Fri, 12 Oct 2018 05:16:43 +0000 (13:16 +0800)]
MDL-63638 block_tag_flickr: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Fri, 12 Oct 2018 05:43:23 +0000 (13:43 +0800)]
MDL-63639 core_fileconverter: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Shamim Rezaie [Sat, 13 Oct 2018 15:02:45 +0000 (02:02 +1100)]
MDL-63647 enrol_flatfile: Improving existing unit tests
This issue is a part of the MDL-62560 Epic.
Shamim Rezaie [Sat, 13 Oct 2018 14:39:58 +0000 (01:39 +1100)]
MDL-63647 enrol_flatfile: support removal of multiple users in context
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Mon, 15 Oct 2018 09:35:54 +0000 (17:35 +0800)]
MDL-63659 tool_monitor: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Mihail Geshoski [Thu, 11 Oct 2018 02:52:50 +0000 (10:52 +0800)]
MDL-63615 message_airnotifier: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Thu, 11 Oct 2018 03:10:11 +0000 (11:10 +0800)]
MDL-63616 message_email: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Thu, 11 Oct 2018 03:22:10 +0000 (11:22 +0800)]
MDL-63617 message_jabber: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Adrian Greeve [Thu, 11 Oct 2018 05:55:39 +0000 (13:55 +0800)]
MDL-63618 core_plagiarism: Added support to remove users in a context.
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Wed, 10 Oct 2018 07:58:53 +0000 (15:58 +0800)]
MDL-63572 profilefield_checkbox: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Wed, 10 Oct 2018 08:02:26 +0000 (16:02 +0800)]
MDL-63575 profilefield_datetime: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Wed, 10 Oct 2018 08:06:24 +0000 (16:06 +0800)]
MDL-63586 profilefield_menu: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Wed, 10 Oct 2018 08:09:53 +0000 (16:09 +0800)]
MDL-63587 profilefield_text: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Wed, 10 Oct 2018 08:13:17 +0000 (16:13 +0800)]
MDL-63588 profilefield_textarea: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Michael Hawkins [Fri, 5 Oct 2018 05:13:49 +0000 (13:13 +0800)]
MDL-63538 repository_onedrive: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Fri, 5 Oct 2018 02:13:42 +0000 (10:13 +0800)]
MDL-63538 repository_youtube: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Fri, 5 Oct 2018 02:11:18 +0000 (10:11 +0800)]
MDL-63538 repository_wikimedia: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Fri, 5 Oct 2018 02:09:37 +0000 (10:09 +0800)]
MDL-63538 repository_picasa: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Fri, 5 Oct 2018 02:08:16 +0000 (10:08 +0800)]
MDL-63538 repository_merlot: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Fri, 5 Oct 2018 02:06:45 +0000 (10:06 +0800)]
MDL-63538 repository_googledocs: Support removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Fri, 5 Oct 2018 02:04:03 +0000 (10:04 +0800)]
MDL-63538 repository_flickr_public: Support removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Thu, 4 Oct 2018 09:18:44 +0000 (17:18 +0800)]
MDL-63538 repository_flickr: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Thu, 4 Oct 2018 09:10:06 +0000 (17:10 +0800)]
MDL-63538 repository_dropbox: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Thu, 4 Oct 2018 09:04:33 +0000 (17:04 +0800)]
MDL-63538 repository_boxnet: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Mihail Geshoski [Wed, 10 Oct 2018 07:54:54 +0000 (15:54 +0800)]
MDL-63536 core_repository: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Wed, 10 Oct 2018 07:47:27 +0000 (15:47 +0800)]
MDL-63534 core_user: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Wed, 10 Oct 2018 07:28:59 +0000 (15:28 +0800)]
MDL-63532 core_portfolio: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Wed, 10 Oct 2018 07:19:22 +0000 (15:19 +0800)]
MDL-63529 core_enrol: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Michael Hawkins [Wed, 3 Oct 2018 09:56:04 +0000 (17:56 +0800)]
MDL-63514 mod_wiki: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Wed, 3 Oct 2018 04:18:11 +0000 (12:18 +0800)]
MDL-63510 mod_survey: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Wed, 3 Oct 2018 02:15:37 +0000 (10:15 +0800)]
MDL-63501 mod_scorm: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Mon, 1 Oct 2018 09:13:31 +0000 (17:13 +0800)]
MDL-63497 mod_lesson: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Mon, 1 Oct 2018 06:46:07 +0000 (14:46 +0800)]
MDL-63497 mod_feedback: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Fri, 21 Sep 2018 07:05:10 +0000 (15:05 +0800)]
MDL-63497 mod_glossary: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Also added missing ratings include and test to mod_glossary unit tests.
Michael Hawkins [Wed, 19 Sep 2018 07:59:08 +0000 (15:59 +0800)]
MDL-63497 tool_dataprivacy: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Wed, 12 Sep 2018 05:17:37 +0000 (13:17 +0800)]
MDL-63497 block_html: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
Michael Hawkins [Mon, 10 Sep 2018 10:00:59 +0000 (18:00 +0800)]
MDL-63497 mod_chat: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Shamim Rezaie [Fri, 5 Oct 2018 13:12:18 +0000 (23:12 +1000)]
MDL-63554 cachestore_session: Support for removal of context users
This issue is part of the MDL-62560 Epic.
Shamim Rezaie [Fri, 5 Oct 2018 13:08:29 +0000 (23:08 +1000)]
MDL-63554 cachestore_redis: Support for removal of context users
This issue is part of the MDL-62560 Epic.
Shamim Rezaie [Fri, 5 Oct 2018 13:05:36 +0000 (23:05 +1000)]
MDL-63554 cachestore_mongodb: Support for removal of context users
This issue is part of the MDL-62560 Epic.
Shamim Rezaie [Fri, 5 Oct 2018 09:09:04 +0000 (19:09 +1000)]
MDL-63554 cachestore_memcached: Support for removal of context users
This issue is part of the MDL-62560 Epic.
Shamim Rezaie [Thu, 4 Oct 2018 20:29:40 +0000 (06:29 +1000)]
MDL-63500 enrol_cohort: refactoring get_contexts_for_userid
This issue is part of the MDL-62560 Epic.
Shamim Rezaie [Thu, 4 Oct 2018 20:27:34 +0000 (06:27 +1000)]
MDL-63500 enrol_meta: refactoring get_contexts_for_userid
This issue is part of the MDL-62560 Epic.
Shamim Rezaie [Thu, 4 Oct 2018 20:20:32 +0000 (06:20 +1000)]
MDL-63500 core_group: get_contexts_for_userid should respect component
The get_contexts_for_userid method should not return contexts for all group memberships.
It should only return the contexts in where there is manual group
membership.
This issue is part of the MDL-62560 Epic.
Shamim Rezaie [Thu, 4 Oct 2018 18:18:37 +0000 (04:18 +1000)]
MDL-63500 enrol_cohort: Support for removal of multiple context users
This issue is part of the MDL-62560 Epic.
Shamim Rezaie [Thu, 4 Oct 2018 17:09:08 +0000 (03:09 +1000)]
MDL-63500 enrol_meta: Support for removal of multiple context users
This issue is part of the MDL-62560 Epic.
Shamim Rezaie [Thu, 4 Oct 2018 11:33:30 +0000 (21:33 +1000)]
MDL-63500 core_group: support removal of multiple users in a context
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Thu, 4 Oct 2018 06:49:28 +0000 (14:49 +0800)]
MDL-63533 core_webservice: Unit tests for removal of context users
This issue is part of the MDL-62560 Epic.
Mihail Geshoski [Thu, 4 Oct 2018 06:48:53 +0000 (14:48 +0800)]
MDL-63533 core_webservice: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Adrian Greeve [Wed, 3 Oct 2018 05:28:57 +0000 (13:28 +0800)]
MDL-63513 mod_assignment: Add removal of context users.
This issue is part of the MDL-62560 Epic.
Michael Hawkins [Tue, 2 Oct 2018 08:28:04 +0000 (16:28 +0800)]
MDL-63498 mod_lti: Add support for removal of context users
This issue is part of the MDL-62560 Epic.
Michael Hawkins [Mon, 8 Oct 2018 07:36:43 +0000 (15:36 +0800)]
MDL-63495 comment: Added provider::get_users_in_context_from_sql
This issue is part of the MDL-62560 Epic.
David Mudrák [Fri, 5 Oct 2018 20:54:41 +0000 (22:54 +0200)]
MDL-62309 tool_policy: Add Behat scenarios for the optional policies
David Mudrák [Fri, 5 Oct 2018 15:09:29 +0000 (17:09 +0200)]
MDL-62309 tool_policy: Amend behaviour of handler's accept() method
When accepting the policies via the sitepolicy handler, only compulsory
policies are to be marked as accepted. Optional policies will be left as
pending. Users must express their consent explicitly for them.
As a side product of the change, unit tests are added for the whole
handler class.
David Mudrák [Fri, 5 Oct 2018 11:04:17 +0000 (13:04 +0200)]
MDL-62309 tool_policy: Improve permission evaluation methods
Please refer to the unit tests for the specification of the expected
behaviour.
David Mudrák [Mon, 1 Oct 2018 12:41:07 +0000 (14:41 +0200)]
MDL-62309 tool_policy: Update user acceptances reports
This adds support for optional policies to the user acceptance reports.
Distinguished are "Pending" acceptances (we did not hear yet) from
"Declined" (user did not agree). The status workflow updated to support
new transitions: pending -> declined and declined -> accepted.
David Mudrák [Thu, 27 Sep 2018 12:57:00 +0000 (14:57 +0200)]
MDL-62309 tool_policy: New icons for user acceptances report
There was an accessibility issue with the previous icons that we used
the same "checked" shape just in different colours for different
meanings. New icons added for the new statuses:
* partial - a warning icon for the overall status column that the user
has only some policies accepted, not all.
* pending - that we did not hear yet from the user - whcih is different
from a declined policy.
David Mudrák [Mon, 24 Sep 2018 17:03:58 +0000 (19:03 +0200)]
MDL-62309 tool_policy: Optional policies can be declined by the user
For optional policies, we provide a radio selector to let the user
choose the acceptance status on the consent page. For policies displayed
on their own page, we display a link to decline the policy.
The way how we pass the list of policy version ids to index.php has
changed so that we can now not only pass the list of ids, but also the
actual acceptance status (accepted / declined).
David Mudrák [Fri, 5 Oct 2018 09:00:30 +0000 (11:00 +0200)]
MDL-62309 tool_policy: Add api::get_agreement_optional() method
This method allows to quickly check if the given policy version is
marked as optional or compulsory. This will be needed in other places
such as permissions check.
David Mudrák [Mon, 24 Sep 2018 12:51:40 +0000 (14:51 +0200)]
MDL-62309 tool_policy: New API method to decline a policy
Policy can be declined. Optional policies do not need to be accepted to
use the site. But we still want to hear explicitly from the user.
David Mudrák [Mon, 24 Sep 2018 12:20:43 +0000 (14:20 +0200)]
MDL-62309 tool_policy: Improve api::is_user_version_accepted() return
The method now returns three-state logic. A bool value true/false is
returned if the user has accepted/rejected the policy, respectively. A
null value is returned if the user did not express their agreement in
either way yet.
This allows to distinguish between "rejected the policy" and "did not
say anything about it yet" cases.
David Mudrák [Tue, 18 Sep 2018 21:55:43 +0000 (23:55 +0200)]
MDL-62309 tool_policy: Add new field to hold the optional policy flag
The patch adds a new column to the database table to hold the
information if giving agreement to the policy is compulsory or optional.
The flag can be defined via the policy editing form and is displayed at
the policies management screen.
The last modified time merged with the version column at the policies
management screen to save a bit of horizontal space - needed as we
display more information now at the first column.
Jun Pataleta [Mon, 22 Oct 2018 04:26:14 +0000 (12:26 +0800)]
Merge branch 'MDL-62777-master' of git://github.com/junpataleta/moodle
Jun Pataleta [Mon, 22 Oct 2018 04:24:58 +0000 (12:24 +0800)]
MDL-62777 administration: Remove unnecessary whitespace
Damyon Wiese [Mon, 2 Jul 2018 06:35:39 +0000 (14:35 +0800)]
MDL-61052 assign: Do not queue conversions
Identical submissions do not require individual conversions from the document converter. Text passing through
format_text cannot be trusted and is likely to be unique each time, even for the same text.
Zig Tan [Fri, 29 Jun 2018 04:25:41 +0000 (12:25 +0800)]
MDL-61052 assign: Improve strip_images() to avoid HTML5 tags errors
Matt Porritt [Mon, 22 Oct 2018 02:09:58 +0000 (13:09 +1100)]
MDL-62777 Administration: CLI upgrade new setting notification
During a CLI upgrade when there are new settings in core or in
a plugin, the settings are set to the defined defaults
automatically. There is no ouput shown on the CLI about which
new settings have been introduced or what default values the
setting are set to.
This patch outputs the name of the new setting and what the
default value being is set is to the CLI during an upgrade.
Objects and arrays are expanded into a human readable format.
This plugin also makes the function that sets the defaults to
be more robust so it isno longer required to be called multiple
times to ensure all settings are set.
Damyon Wiese [Wed, 19 Sep 2018 08:09:37 +0000 (16:09 +0800)]
MDL-61391 forum: Improve semantics for permalinks
Replace the anchor tags in forum posts containing the postid but no href with
an id on the element containing the post. Use rel="bookmark" for perma links
and update the styling so they look visually the same.
Andrew Nicols [Mon, 22 Oct 2018 02:54:56 +0000 (10:54 +0800)]
Merge branch 'MDL-63213-master-2' of https://github.com/snake/moodle
Damyon Wiese [Mon, 17 Sep 2018 07:58:34 +0000 (15:58 +0800)]
MDL-61388 output: Use alertdialog role for confirm
Damyon Wiese [Mon, 17 Sep 2018 07:41:23 +0000 (15:41 +0800)]
MDL-61388 forum: accessibility
Show success alert to confirm the last action.
Damyon Wiese [Mon, 17 Sep 2018 05:39:43 +0000 (13:39 +0800)]
MDL-61388 boost: accessibility
Dynamically show and focus on an alert that was written on page load. This ensures JAWS will read it
as soon as the page is ready, otherwise JAWS would choose to ignore it as per
https://www.w3.org/TR/wai-aria-practices/#alert.
Andrew Nicols [Mon, 22 Oct 2018 02:45:15 +0000 (10:45 +0800)]
Merge branch 'MDL-63691_master' of git://github.com/markn86/moodle
Damyon Wiese [Mon, 3 Sep 2018 07:08:38 +0000 (15:08 +0800)]
MDL-62144 user menu: Accessibility
Ensure user menu passes the accessibility tests.
Damyon Wiese [Fri, 10 Aug 2018 04:41:04 +0000 (12:41 +0800)]
MDL-62139 output: Accessible action menus
Add label on the "gear" menu and default keyboard and focus controls.
Mark Nelson [Sat, 20 Oct 2018 08:39:40 +0000 (16:39 +0800)]
MDL-63408 core_message: removed usage of deprecated method in tests
Also, added tests to ensure exception is thrown if you try to
add or remove members to/from an individual conversation.
Mark Nelson [Sat, 20 Oct 2018 08:55:22 +0000 (16:55 +0800)]
MDL-63408 core_message: remove no longer needed code
We only allow the functionality of adding/removing
members on group conversations, which will never have
a conversation hash.
Mark Nelson [Sat, 20 Oct 2018 08:30:30 +0000 (16:30 +0800)]
MDL-63408 core_message: add check to ensure it is a group conversation
