David Mudrák [Wed, 4 Dec 2019 08:10:51 +0000 (09:10 +0100)]
MDL-67447 form: Fix the duplicate autocomplete selection node
When the autocomplete selection is updated, the content of the selection
wrapper is replaced with the new list of selected items. We must replace
only the content of the selection wrapper and not to nest it into
itself.
Adrian Greeve [Fri, 24 Jan 2020 02:16:48 +0000 (10:16 +0800)]
weekly release 3.9dev
Adrian Greeve [Fri, 24 Jan 2020 02:16:48 +0000 (10:16 +0800)]
NOBUG: Fixed file access permissions
Adrian Greeve [Fri, 24 Jan 2020 02:16:39 +0000 (10:16 +0800)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Eloy Lafuente (stronk7) [Thu, 23 Jan 2020 10:13:33 +0000 (11:13 +0100)]
Merge branch 'MDL-51225-master' of git://github.com/junpataleta/moodle
Jun Pataleta [Thu, 23 Jan 2020 07:23:25 +0000 (15:23 +0800)]
MDL-51225 mod_forum: Revert @javascript tag removal
Put back the removed @javascript tag to prevent random goutte
fails.
Jun Pataleta [Thu, 23 Jan 2020 04:55:38 +0000 (12:55 +0800)]
Merge branch 'MDL-67118' of https://github.com/stronk7/moodle
Jun Pataleta [Thu, 23 Jan 2020 03:43:39 +0000 (11:43 +0800)]
Merge branch 'MDL-67115' of https://github.com/stronk7/moodle
Adrian Greeve [Thu, 23 Jan 2020 03:09:05 +0000 (11:09 +0800)]
Merge branch 'MDL-67703-master' of git://github.com/lameze/moodle
Adrian Greeve [Thu, 23 Jan 2020 02:50:37 +0000 (10:50 +0800)]
Merge branch 'MDL-65775-master' of git://github.com/ferranrecio/moodle
Jun Pataleta [Thu, 23 Jan 2020 02:45:19 +0000 (10:45 +0800)]
Merge branch 'MDL-65952' of https://github.com/fabiendallet/moodle
Eloy Lafuente (stronk7) [Wed, 22 Jan 2020 22:46:06 +0000 (23:46 +0100)]
Merge branch 'MDL-67296-master' of git://github.com/vmdef/moodle
Víctor Déniz Falcón [Wed, 22 Jan 2020 20:40:12 +0000 (20:40 +0000)]
MDL-67296 core_h5p: tests modified to use exttests
Jun Pataleta [Wed, 22 Jan 2020 15:17:14 +0000 (23:17 +0800)]
Merge branch 'MDL-66897-master-1' of git://github.com/mihailges/moodle
Víctor Déniz Falcón [Wed, 22 Jan 2020 14:48:16 +0000 (14:48 +0000)]
MDL-67296 core_h5p: minor changes
core.php-Avoid to use the factory for each content type
h5p_get_content_types_task-new method to simplify test execution
framework.php-returns error if you get a 404 response after requesting a file
Adrian Greeve [Wed, 22 Jan 2020 05:56:33 +0000 (13:56 +0800)]
Merge branch 'MDL-67424-master' of git://github.com/rezaies/moodle
Mihail Geshoski [Wed, 22 Jan 2020 05:37:07 +0000 (13:37 +0800)]
MDL-66897 mod_assign: Properly display error messages in quick grading
Adrian Greeve [Wed, 22 Jan 2020 05:29:01 +0000 (13:29 +0800)]
Merge branch 'MDL-67438' of https://github.com/stronk7/moodle
Adrian Greeve [Wed, 22 Jan 2020 05:12:27 +0000 (13:12 +0800)]
Merge branch 'MDL-67456' of https://github.com/stronk7/moodle
Adrian Greeve [Wed, 22 Jan 2020 03:02:35 +0000 (11:02 +0800)]
Merge branch 'MDL-67653' of https://github.com/timhunt/moodle
Adrian Greeve [Wed, 22 Jan 2020 02:41:03 +0000 (10:41 +0800)]
Merge branch 'MDL-67660-master-v2' of https://github.com/TobiGa/moodle
Jun Pataleta [Wed, 22 Jan 2020 02:38:13 +0000 (10:38 +0800)]
Merge branch 'MDL-67684-master' of git://github.com/andrewnicols/moodle
Adrian Greeve [Wed, 22 Jan 2020 02:28:23 +0000 (10:28 +0800)]
Merge branch 'MDL-67680-master' of git://github.com/marinaglancy/moodle
Adrian Greeve [Wed, 22 Jan 2020 01:44:17 +0000 (09:44 +0800)]
Merge branch 'MDL-67656-master' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Wed, 22 Jan 2020 00:57:18 +0000 (01:57 +0100)]
Merge branch 'MDL-66858' of https://github.com/stronk7/moodle
Michael Milette [Mon, 13 Jan 2020 21:19:31 +0000 (16:19 -0500)]
MDL-66858 master: Enable <header> tags in Atto editor.
(amended to add the src/editor/js/clean.js
file that was originally missing)
Eloy Lafuente (stronk7) [Tue, 21 Jan 2020 22:33:19 +0000 (23:33 +0100)]
Merge branch 'MDL-51225-master' of git://github.com/junpataleta/moodle
Adrian Greeve [Tue, 21 Jan 2020 03:08:27 +0000 (11:08 +0800)]
Merge branch 'MDL-66237-master' of git://github.com/mickhawkins/moodle
Jun Pataleta [Tue, 21 Jan 2020 01:51:24 +0000 (09:51 +0800)]
Merge branch 'MDL-66108' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Mon, 20 Jan 2020 21:47:17 +0000 (22:47 +0100)]
Merge branch 'MDL-66024' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Mon, 20 Jan 2020 21:33:45 +0000 (22:33 +0100)]
Merge branch 'MDL-66220-master' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Mon, 20 Jan 2020 21:27:20 +0000 (22:27 +0100)]
Merge branch 'MDL-66712-master-selfautounenrol' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Mon, 20 Jan 2020 19:13:29 +0000 (20:13 +0100)]
Merge branch 'MDL-65884' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Mon, 20 Jan 2020 09:53:18 +0000 (10:53 +0100)]
Merge branch 'MDL-67724-master' of git://github.com/junpataleta/moodle
Jun Pataleta [Mon, 20 Jan 2020 08:36:40 +0000 (16:36 +0800)]
Merge branch 'MDL-66883-master' of git://github.com/bmbrands/moodle
Sara Arjona [Mon, 20 Jan 2020 07:18:49 +0000 (08:18 +0100)]
Merge branch 'MDL-67245' of https://github.com/paulholden/moodle
Simey Lameze [Thu, 21 Nov 2019 10:36:05 +0000 (18:36 +0800)]
MDL-67312 core_user: clean subs events on user deletion
Simey Lameze [Thu, 21 Nov 2019 00:36:22 +0000 (08:36 +0800)]
MDL-67312 calendar: upgrade step to delete orphaned events
Simey Lameze [Mon, 25 Nov 2019 12:23:05 +0000 (20:23 +0800)]
MDL-67312 core: change db upgrade step to use get_fieldset_sql
Adrian Greeve [Mon, 20 Jan 2020 06:40:19 +0000 (14:40 +0800)]
Merge branch 'MDL-66761-master' of git://github.com/mickhawkins/moodle
Adrian Greeve [Mon, 20 Jan 2020 05:34:31 +0000 (13:34 +0800)]
Merge branch 'MDL-67583-master' of https://github.com/KietChan/moodle
Adrian Greeve [Mon, 20 Jan 2020 02:38:51 +0000 (10:38 +0800)]
Merge branch 'MDL-59594-SIGINT' of https://github.com/brendanheywood/moodle
Adrian Greeve [Mon, 20 Jan 2020 01:53:27 +0000 (09:53 +0800)]
Merge branch 'MDL-62815_mod_lti' of git://github.com/davosmith/moodle
Simey Lameze [Thu, 16 Jan 2020 01:38:16 +0000 (09:38 +0800)]
MDL-67703 calendar: change manage subscription form to hideIf
Eloy Lafuente (stronk7) [Sun, 19 Jan 2020 17:35:25 +0000 (18:35 +0100)]
MDL-67115 google: php74 params order for implode()
Passing parameters to implode() in reverse order is deprecated, use
implode($glue, $parts) instead of implode($parts, $glue).
This commit corresponds to general search of wrong cases.
Eloy Lafuente (stronk7) [Sun, 19 Jan 2020 17:23:11 +0000 (18:23 +0100)]
MDL-67115 htmlpurifier: php74 params order for implode()
Passing parameters to implode() in reverse order is deprecated, use
implode($glue, $parts) instead of implode($parts, $glue).
This commit corresponds to general search of wrong cases.
Eloy Lafuente (stronk7) [Sun, 3 Nov 2019 22:04:10 +0000 (23:04 +0100)]
MDL-67115 minify: php74 params order for implode()/join()
Passing parameters to implode() in reverse order is deprecated, use
implode($glue, $parts) instead of implode($parts, $glue).
This commit corresponds to phpunit detections, minify library.
Eloy Lafuente (stronk7) [Sun, 3 Nov 2019 21:59:10 +0000 (22:59 +0100)]
MDL-67115 core: php74 params order for implode()/join()
Passing parameters to implode() in reverse order is deprecated, use
implode($glue, $parts) instead of implode($parts, $glue).
This commit corresponds to phpunit and manual detections, core files.
hanna [Wed, 4 Dec 2019 16:51:09 +0000 (18:51 +0200)]
MDL-67456 admin: Update Maximum number of backups kept
AMOS bot [Sat, 18 Jan 2020 00:10:41 +0000 (00:10 +0000)]
Automatically generated installer lang files
fdallet [Tue, 25 Jun 2019 09:16:41 +0000 (11:16 +0200)]
MDL-65952 mod_scorm: Fix unwanted changes to require status
Paul Holden [Mon, 2 Dec 2019 22:36:54 +0000 (22:36 +0000)]
MDL-66108 course: fix false positives when bulk moving categories.
Paul Holden [Tue, 17 Dec 2019 19:17:00 +0000 (19:17 +0000)]
MDL-67245 group: Behat updates to account for member identity fields.
Paul Holden [Tue, 7 Jan 2020 16:18:56 +0000 (16:18 +0000)]
MDL-67245 group: observe viewfullnames capability.
Paul Holden [Fri, 29 Nov 2019 07:45:55 +0000 (07:45 +0000)]
MDL-67245 group: display user identity fields for group members.
Eloy Lafuente (stronk7) [Fri, 29 Nov 2019 23:16:15 +0000 (00:16 +0100)]
MDL-67438 wiki: Formating changes (file doc block + whitespace fixes)
Also:
- change 2 variable/property names, both internal.
- format empty function.
Towards getting it fully phpcs compliant. Note this does not
fix the missing (in all methods) phpdoc blocks.
Jun Pataleta [Fri, 17 Jan 2020 09:48:06 +0000 (17:48 +0800)]
MDL-67724 mod_glossary: Improve Behat test
Improve the "Glossary entries are not always editable" scenario by:
* No need to use the @javascript tag
* The maxediting time can be set to a lower value to
reduce the overall wait time.
Tobias Garske [Thu, 16 Jan 2020 09:45:40 +0000 (10:45 +0100)]
MDL-67660 core_message: Messages search change input focus
Sara Arjona [Fri, 17 Jan 2020 08:30:11 +0000 (09:30 +0100)]
Merge branch 'MDL-67372-master' of git://github.com/rezaies/moodle
Jun Pataleta [Tue, 14 Jan 2020 09:04:10 +0000 (17:04 +0800)]
MDL-51225 mod_forum: Use can_view_post to determine whether to show post
Use \mod_forum\local\managers\capability::can_view_post() to
consistently determine whether a forum post will be rendered in the
recent activity block.
This helps the recent activity block to provide a more consistent
behaviour with the forum's discussion view itself.
Jun Pataleta [Wed, 15 Jan 2020 08:38:06 +0000 (16:38 +0800)]
MDL-51225 mod_forum: Create behat tests for forum recent activity
Michael Hawkins [Wed, 25 Sep 2019 03:58:59 +0000 (11:58 +0800)]
MDL-66761 forumreport_summary: Added groups filter behat testing
Michael Hawkins [Thu, 21 Nov 2019 09:32:16 +0000 (17:32 +0800)]
MDL-66761 mod_forum: Behat support group ID in bulk discussion adding
Jun Pataleta [Wed, 15 Jan 2020 16:11:24 +0000 (00:11 +0800)]
MDL-51225 mod_forum: New behat step for creating question discussion
AMOS bot [Fri, 17 Jan 2020 00:12:11 +0000 (00:12 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Wed, 27 Nov 2019 22:40:09 +0000 (23:40 +0100)]
MDL-67118 enrol_ldap: add pagesize/subcontexts provider
With that provider we'll be explicitly checking that any
pagesize and subcontexts search is returning results consistently
so the internal paging/servercontrols work as expected.
Eloy Lafuente (stronk7) [Wed, 27 Nov 2019 22:17:20 +0000 (23:17 +0100)]
MDL-67118 enrol_ldap: paged results functions deprecated php74 and up
Starting with php74 the following functions are deprecated:
- ldap_control_paged_result()
- ldap_control_paged_result_response()
Starting with php73, ldap servercontrols were included. One of those
servercontrols, LDAP_CONTROL_PAGEDRESULTS, is the one in charge of
controlling paged results.
So, we are going to add some conditional code here:
1) if php < 7.3, use old paged result functions.
2) if php >= 7.3, switch to LDAP_CONTROL_PAGEDRESULTS servercontrol.
With a TODO about removing 1) in Moodle 4.1, once php73 becomes required.
Eloy Lafuente (stronk7) [Wed, 27 Nov 2019 09:51:16 +0000 (10:51 +0100)]
MDL-67118 auth_ldap: add pagesize/subcontexts test provider
With that provider we'll be explicitly covering that any
pagesize and subcontexts search is returning results consistently
so the internal paging/servercontrols work as expected.
Eloy Lafuente (stronk7) [Tue, 26 Nov 2019 22:43:18 +0000 (23:43 +0100)]
MDL-67118 auth_ldap: paged results functions deprecated php74 and up
Starting with php74 the following functions are deprecated:
- ldap_control_paged_result()
- ldap_control_paged_result_response()
Starting with php73, ldap servercontrols were included. One of those
servercontrols, LDAP_CONTROL_PAGEDRESULTS, is the one in charge of
controlling paged results.
So, we are going to add some conditional code here:
1) if php < 7.3, use old paged result functions.
2) if php >= 7.3, switch to LDAP_CONTROL_PAGEDRESULTS servercontrol.
With a TODO about removing 1) in Moodle 4.1, once php73 becomes required.
Sara Arjona [Thu, 16 Jan 2020 16:19:10 +0000 (17:19 +0100)]
weekly release 3.9dev
Sara Arjona [Thu, 16 Jan 2020 16:19:07 +0000 (17:19 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
David Mudrák [Thu, 16 Jan 2020 12:35:01 +0000 (13:35 +0100)]
MDL-66712 enrol: Fix the reported days of inactivity on unenrolment
There were two problems here. Firstly, the $days was not correctly
calculated due to missing parentheses. Secondly, the sentence had
grammar issues.
Jun Pataleta [Mon, 13 Jan 2020 05:11:40 +0000 (13:11 +0800)]
MDL-66220 mod_forum: Prevent from replying to a post the user can't see
Jun Pataleta [Mon, 13 Jan 2020 05:09:14 +0000 (13:09 +0800)]
MDL-66220 mod_forum: Cache result of forum_user_can_see_post()
* Cache the result of this function to avoid doing multiple DB calls
for the same post when loading posts in a discussion.
Jun Pataleta [Fri, 10 Jan 2020 08:51:23 +0000 (16:51 +0800)]
MDL-66220 mod_forum: Additional unit test for can_reply_to_post
Andrew Nicols [Thu, 16 Jan 2020 04:10:31 +0000 (12:10 +0800)]
Merge branch 'mdl-59562' of https://github.com/Peterburnett/moodle
Andrew Nicols [Thu, 16 Jan 2020 03:42:16 +0000 (11:42 +0800)]
Merge branch 'wip-MDL-66918-master' of https://github.com/Beedell/moodle
Shamim Rezaie [Wed, 11 Dec 2019 00:57:12 +0000 (11:57 +1100)]
MDL-67372 libraries: Upgrade HTML Purifier to version 4.12.0
Peter Burnett [Thu, 16 Jan 2020 01:58:31 +0000 (11:58 +1000)]
MDL-59562 core: updated type hint of new function
Andrew Nicols [Thu, 16 Jan 2020 02:24:40 +0000 (10:24 +0800)]
Merge branch 'MDL-67384-master' of git://github.com/rezaies/moodle
Eloy Lafuente (stronk7) [Wed, 15 Jan 2020 23:29:09 +0000 (00:29 +0100)]
Merge branch 'MDL-67631' of git://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Wed, 15 Jan 2020 23:26:13 +0000 (00:26 +0100)]
Merge branch 'MDL-67625-master' of git://github.com/lucaboesch/moodle
Eloy Lafuente (stronk7) [Wed, 15 Jan 2020 23:06:30 +0000 (00:06 +0100)]
Merge branch 'MDL-67040_master' of git://github.com/dmonllao/moodle
Sara Arjona [Wed, 15 Jan 2020 21:12:15 +0000 (22:12 +0100)]
Merge branch 'MDL-67379-master' of git://github.com/rezaies/moodle
Víctor Déniz Falcón [Wed, 15 Jan 2020 20:51:41 +0000 (20:51 +0000)]
Merge branch 'MDL-67377-master' of git://github.com/ferranrecio/moodle
Eloy Lafuente (stronk7) [Wed, 15 Jan 2020 17:55:45 +0000 (18:55 +0100)]
Merge branch 'MDL-67622_master' of git://github.com/dmonllao/moodle
Shamim Rezaie [Mon, 2 Dec 2019 04:33:27 +0000 (15:33 +1100)]
MDL-67424 mod_forum: error on complete report when no rating or grade
Shamim Rezaie [Wed, 15 Jan 2020 15:24:33 +0000 (02:24 +1100)]
MDL-67424 report_outline: behat user report with a no-grade forum
Shamim Rezaie [Mon, 16 Dec 2019 10:35:35 +0000 (21:35 +1100)]
MDL-67379 libraries: Upgrade scssphp to 1.0.6
Sara Arjona [Wed, 15 Jan 2020 11:43:00 +0000 (12:43 +0100)]
Merge branch 'MDL-67617-master' of git://github.com/lucaboesch/moodle
Sara Arjona [Wed, 15 Jan 2020 11:19:34 +0000 (12:19 +0100)]
Merge branch 'MDL-67638_master' of https://github.com/nguyenphuctien/moodle
Andrew Nicols [Wed, 15 Jan 2020 05:53:22 +0000 (13:53 +0800)]
Merge branch 'MDL-67486-swap-cron-lock' of https://github.com/brendanheywood/moodle
Andrew Nicols [Wed, 15 Jan 2020 05:51:04 +0000 (13:51 +0800)]
Merge branch 'mdl-59562' of https://github.com/Peterburnett/moodle
Peter Burnett [Wed, 15 Jan 2020 05:46:46 +0000 (15:46 +1000)]
MDL-59562 core: changed branch behaviour during initial install.
Andrew Nicols [Wed, 15 Jan 2020 04:40:19 +0000 (12:40 +0800)]
Merge branch 'mdl-59562' of https://github.com/Peterburnett/moodle
[Peter Burnett] [Wed, 25 Sep 2019 05:51:21 +0000 (15:51 +1000)]
MDL-59562 upgrade: Plugins can declare supported moodle versions
* Plugins can now explicitly declare supported and incompatible Moodle
versions in version.php
- $plugin->supported[37,39];
supported takes an array of ascending numbers, that correspond to a
range of branch numbers of supported versions, inclusive. Moodle
versions that are outside of this range will produce a message
notifying at install time, but will allow for installation.
- $plugin->incompatible = 36;
incompatible takes a single int corresponding to the first incompatible
branch. Any Moodle versions including and below this will be prevented
from installing the plugin, and a message will be given when
attempting installation.
Mark Johnson [Mon, 13 Jan 2020 11:37:09 +0000 (11:37 +0000)]
MDL-67674 Cache: Lock rebuilding of the course category tree cache
Rossco Hellmans [Wed, 13 Mar 2019 01:41:13 +0000 (11:41 +1000)]
MDL-64310 backup: allow session to be released during backup/restore
Amended to fix a wrong call to backup_controller() constructor,
originally not passing USER->id
Sara Arjona [Tue, 14 Jan 2020 18:50:58 +0000 (19:50 +0100)]
Merge branch 'MDL-66213-master-fixcap' of github.com:sarjona/moodle
Eloy Lafuente (stronk7) [Tue, 14 Jan 2020 18:46:17 +0000 (19:46 +0100)]
MDL-66253 update: bump version (missed that on the review)