Eloy Lafuente (stronk7) [Tue, 21 Jun 2016 21:37:59 +0000 (23:37 +0200)]
MDL-54778 form: Make it all js style (eslint) compliant
The changes in this commit should not be problematic, just:
- different whitespace.
- some docs.
- 1 variable to camelCase.
And then, less trivial, but safe enough IMO:
- a change to camelCase some identifiers and their calculation.
Eloy Lafuente (stronk7) [Tue, 21 Jun 2016 23:29:39 +0000 (01:29 +0200)]
Merge branch 'MDL-54778-master' of git://github.com/andrewnicols/moodle
Dan Poltawski [Tue, 21 Jun 2016 19:56:32 +0000 (12:56 -0700)]
Merge branch 'MDL-54983-master' of git://github.com/damyon/moodle
Damyon Wiese [Tue, 21 Jun 2016 18:05:28 +0000 (11:05 -0700)]
MDL-54983 docs: Improve phpdocs for create_user_key
Also fixed the docs for get_user_key.
Eloy Lafuente (stronk7) [Tue, 21 Jun 2016 18:00:36 +0000 (20:00 +0200)]
Merge branch 'MDL-54939-master' of git://github.com/danpoltawski/moodle
Andrew Nicols [Tue, 21 Jun 2016 11:00:33 +0000 (19:00 +0800)]
Merge branch 'wip-mdl-54940' of https://github.com/rajeshtaneja/moodle
Rajesh Taneja [Tue, 21 Jun 2016 10:53:03 +0000 (18:53 +0800)]
MDL-54940 behat: No need to press save
Previous step press save button, so no need to press again
Eloy Lafuente (stronk7) [Tue, 21 Jun 2016 09:48:10 +0000 (11:48 +0200)]
Merge branch 'MDL-54948-master' of git://github.com/lameze/moodle
Andrew Nicols [Tue, 21 Jun 2016 06:59:00 +0000 (14:59 +0800)]
MDL-51789 users: Correct deprecation version
Andrew Nicols [Tue, 21 Jun 2016 06:38:51 +0000 (14:38 +0800)]
Merge branch 'MDL-51789' of https://github.com/mr-russ/moodle
Russell Smith [Thu, 15 Oct 2015 08:34:58 +0000 (19:34 +1100)]
MDL-51789 users: Allow picture update from webservices.
useredit_update_picture as moved to user_update_picture
as it's more general. It was also moved to user/lib.php
so it can be used by both webservices and edit without more include files.
Andrew Nicols [Tue, 21 Jun 2016 06:15:41 +0000 (14:15 +0800)]
Merge branch 'MDL-54920-master' of https://github.com/sammarshallou/moodle
Andrew Nicols [Tue, 21 Jun 2016 04:09:09 +0000 (12:09 +0800)]
Merge branch 'MDL-54894-master' of git://github.com/crazyserver/moodle
Andrew Nicols [Tue, 21 Jun 2016 03:53:05 +0000 (11:53 +0800)]
Merge branch 'MDL-54940-master' of https://github.com/LukeCarrier/moodle
Andrew Nicols [Tue, 21 Jun 2016 03:31:19 +0000 (11:31 +0800)]
Merge branch 'MDL-54881' of https://github.com/mr-russ/moodle
Andrew Nicols [Tue, 21 Jun 2016 03:26:42 +0000 (11:26 +0800)]
Merge branch 'MDL-54652-master' of git://github.com/danpoltawski/moodle
Andrew Nicols [Tue, 21 Jun 2016 03:18:03 +0000 (11:18 +0800)]
Merge branch 'MDL-35104-master-2' of git://github.com/cameron1729/moodle
Cameron Ball [Tue, 31 May 2016 09:56:33 +0000 (17:56 +0800)]
MDL-35104 auth: Don't allow modification of username
Presently it is either unreliable, or not possible to change
the username of a user created with an authentication plugin.
In some cases it is even hard coded to fail. Ideally we would
sync the username, and the issue MDL-21928 exists to address
that. However, in the mean time we should not allow the
username of an external user to be modified.
Andrew Nicols [Tue, 21 Jun 2016 02:30:22 +0000 (10:30 +0800)]
Merge branch 'MDL-51505-master' of git://github.com/FMCorz/moodle
Andrew Nicols [Tue, 21 Jun 2016 01:58:18 +0000 (09:58 +0800)]
Merge branch 'MDL-54654-master' of git://github.com/danpoltawski/moodle
Simey Lameze [Tue, 21 Jun 2016 01:38:01 +0000 (09:38 +0800)]
MDL-54948 core_upgrade: fix unoconv check on the environment page
Simey Lameze [Tue, 21 Jun 2016 01:36:44 +0000 (09:36 +0800)]
MDL-54948 core_files: make the check consistent on unoconv test page
Andrew Nicols [Tue, 21 Jun 2016 01:03:48 +0000 (09:03 +0800)]
Merge branch 'wip-MDL-53399' of https://github.com/JoeyAndres/moodle
Andrew Nicols [Tue, 21 Jun 2016 00:46:38 +0000 (08:46 +0800)]
Merge branch 'wip-MDL-53292-master' of https://github.com/marinaglancy/moodle
Andrew Nicols [Tue, 7 Jun 2016 05:26:42 +0000 (13:26 +0800)]
MDL-54778 form: Fix lots of issues with form dependencies
The original issue here was that each loop of the named values did not
check for prototypal properties. As a result, if there were input fields
with names such as 'sort', 'valueOf', 'constructor', etc. these would
return their prototypal functions instead of a falsy value, and be treated
as though they are array - hence the 'Cannot push to Function' type error.
Following on from this I discovered that the data stores were being created
as arrays, but used as objects. This can also cause issues with some form
input names -- e.g. if they are numeric.
These two issues were resolved together by correctly storing them in
objects, and checking that those objects had real properties
(hasOwnProperty). This itself has to use the prototypal function to cater
for the potential of a field name called 'hasOwnProperty'.
I also found that the instance value stores were being initialised in the
prototype (and therefore shared), which meant that there were numerous
issues if two forms were present on the same page, or one form replaced an
existing one (e.g. forms initialised in JS).
In addition, it also became apparant that several values were being used
outside of scope, or in the wrong scope. This caused further issues when
creating multiple forms on a page.
Russell Smith [Mon, 20 Jun 2016 22:31:26 +0000 (08:31 +1000)]
MDL-54881 quiz: Ensure user attempts are deterministic for testing.
Eloy Lafuente (stronk7) [Mon, 20 Jun 2016 22:03:45 +0000 (00:03 +0200)]
Merge branch 'MDL-37554-master-test' of git://github.com/cameron1729/moodle
Pau Ferrer Ocaña [Fri, 10 Jun 2016 14:36:00 +0000 (16:36 +0200)]
MDL-54894 comments: Get course from context if not informed
Andrew Nicols [Mon, 20 Jun 2016 06:09:54 +0000 (14:09 +0800)]
Merge branch 'wip-MDL-54590-master-test' of git://github.com/abgreeve/moodle
Vadim Dvorovenko [Sat, 28 May 2016 16:07:16 +0000 (23:07 +0700)]
MDL-54590 Installer: Additional info about database name
Additional info that creating database name containing dots is not
supported
Andrew Nicols [Mon, 20 Jun 2016 03:09:47 +0000 (11:09 +0800)]
Merge branch 'MDL-51163-master' of git://github.com/cameron1729/moodle
Luke Carrier [Sun, 19 Jun 2016 16:22:17 +0000 (17:22 +0100)]
MDL-54940 behat: use the fixed step
Luke Carrier [Thu, 16 Jun 2016 10:09:25 +0000 (11:09 +0100)]
MDL-54940 behat: rectify section edit regression in MDL-53381
Dan Poltawski [Thu, 16 Jun 2016 18:40:21 +0000 (19:40 +0100)]
MDL-54939 amd: build modified files
Dan Poltawski [Thu, 16 Jun 2016 18:24:34 +0000 (19:24 +0100)]
MDL-54939 amd: fix lint issues
Mostly correcting jsdoc, some other line wrapping rules and empty
functions.
Dan Poltawski [Fri, 20 May 2016 15:24:26 +0000 (16:24 +0100)]
MDL-54654 mod: fix forum/scorm invalid css
Dan Poltawski [Fri, 20 May 2016 11:30:23 +0000 (12:30 +0100)]
MDL-54654 mod_data: fix invalid css for image gallery preset
Dan Poltawski [Fri, 20 May 2016 11:11:37 +0000 (12:11 +0100)]
MDL-54654 choice: remove CSS definitions
The 'inherit' for border colour was not valid and so no border was
displayed.
The display:inline does not work with floated elemenets.
Dan Poltawski [Fri, 20 May 2016 11:17:07 +0000 (12:17 +0100)]
MDL-54654 choice: reformat CSS
Dan Poltawski [Fri, 20 May 2016 11:02:40 +0000 (12:02 +0100)]
MDL-54654 book: silence csslint warning
(Important is by design for print layout)
Dan Poltawski [Fri, 20 May 2016 11:00:08 +0000 (12:00 +0100)]
MDL-54654 assignfeedback_editpdf: remove invalid CSS
The 'left' positioing was invalid and conflicting with the
right definition anyway, so wasn't necessary.
Dan Poltawski [Thu, 19 May 2016 22:25:32 +0000 (23:25 +0100)]
MDL-54652 singleview: remove invalid css decleration
margin-bottom can't be used with display: inline, so use padding
instead.
Dan Poltawski [Thu, 19 May 2016 22:14:41 +0000 (23:14 +0100)]
MDL-54652 grade_report: fix css lint issues
max-width: initial isn't valid css and in my testing it makes no
difference, so is removed.
We also remove invalid css on exception.
This reverts commit
72ece42858643c789d2c2f86fccdab0afefa18d0
Dan Poltawski [Thu, 19 May 2016 16:47:50 +0000 (17:47 +0100)]
MDL-54652 block_community: remove unused css
Fixing lint errors
Dan Poltawski [Thu, 19 May 2016 16:41:47 +0000 (17:41 +0100)]
MDL-54652 filter_mediaplugin: refomat css
Dan Poltawski [Thu, 19 May 2016 16:40:57 +0000 (17:40 +0100)]
MDL-54652 filter_mediaplugin: removed unused invalid css
It is override by core styles anyway.
Dan Poltawski [Thu, 19 May 2016 16:24:34 +0000 (17:24 +0100)]
MDL-54652 tool_lp: remove invalid css on comeptency menu bar
Dan Poltawski [Thu, 19 May 2016 16:16:45 +0000 (17:16 +0100)]
MDL-54652 tool_health: make css more specific to avoid '!important'
This admin tool is unsupported anyway..
Dan Poltawski [Thu, 16 Jun 2016 18:20:08 +0000 (19:20 +0100)]
MDL-54939 eslint: tweak rules
1) Allow jsdoc descriptions to be empty. I think that matches our phpdoc
checker, and I think its probably better than me filling the
descriptions in poorly.
2) For the captilisation rules, don't apply to object properties (this
is because jQuery has lots of violators of this rule)
Dan Poltawski [Thu, 16 Jun 2016 14:56:12 +0000 (15:56 +0100)]
MDL-54939 amd: Fix lint issues fixable with eslint --fix
Eloy Lafuente (stronk7) [Thu, 16 Jun 2016 15:01:29 +0000 (17:01 +0200)]
weekly release 3.2dev
Eloy Lafuente (stronk7) [Thu, 16 Jun 2016 15:01:25 +0000 (17:01 +0200)]
NOBUG: Fixed SVG browser compatibility
Andrew Nicols [Thu, 16 Jun 2016 02:38:19 +0000 (10:38 +0800)]
Merge branch 'MDL-52127-eloy' of https://github.com/danpoltawski/moodle
Andrew Nicols [Wed, 15 Jun 2016 01:58:53 +0000 (09:58 +0800)]
Merge branch 'wip-mdl-54899' of git://github.com/rajeshtaneja/moodle
Andrew Nicols [Wed, 15 Jun 2016 01:54:49 +0000 (09:54 +0800)]
Merge branch 'MDL-45762-master' of https://github.com/xow/moodle
Andrew Nicols [Wed, 15 Jun 2016 01:10:43 +0000 (09:10 +0800)]
Merge branch 'MDL-53788_modlti_master' of git://github.com/nhoobin/moodle
Andrew Nicols [Wed, 15 Jun 2016 00:46:17 +0000 (08:46 +0800)]
Merge branch 'MDL-54649-master' of git://github.com/danpoltawski/moodle
Andrew Nicols [Wed, 15 Jun 2016 00:23:25 +0000 (08:23 +0800)]
Merge branch 'MDL-54559-int-master' of https://github.com/merrill-oakland/moodle
Eric Merrill [Tue, 14 Jun 2016 15:00:01 +0000 (11:00 -0400)]
MDL-54559 theme: Recenter search box
Dan Poltawski [Tue, 14 Jun 2016 16:25:56 +0000 (17:25 +0100)]
Merge branch 'MDL-35628' of https://github.com/mr-russ/moodle
Dan Poltawski [Tue, 14 Jun 2016 16:15:01 +0000 (17:15 +0100)]
Merge branch 'MDL-54563-master' of git://github.com/cameron1729/moodle
Dan Poltawski [Tue, 14 Jun 2016 16:10:05 +0000 (17:10 +0100)]
Merge branch 'MDL-51749-master' of git://github.com/junpataleta/moodle
Dan Poltawski [Tue, 14 Jun 2016 15:55:26 +0000 (16:55 +0100)]
Merge branch 'MASTER_MDL-53306' of https://github.com/jacac/moodle
Dan Poltawski [Tue, 14 Jun 2016 15:41:46 +0000 (16:41 +0100)]
Merge branch 'MDL-54617-master' of git://github.com/cameron1729/moodle
Dan Poltawski [Tue, 14 Jun 2016 15:38:30 +0000 (16:38 +0100)]
Merge branch 'MDL-54036_master' of https://github.com/liorgil/moodle
Dan Poltawski [Tue, 14 Jun 2016 15:38:19 +0000 (16:38 +0100)]
Merge branch 'MDL-54622_m32v1' of https://github.com/sbourget/moodle
Andrew Nicols [Tue, 14 Jun 2016 07:33:49 +0000 (15:33 +0800)]
Merge branch 'MDL-54712-master' of git://github.com/junpataleta/moodle
Andrew Nicols [Tue, 14 Jun 2016 06:15:27 +0000 (14:15 +0800)]
Merge branch 'MDL-54559-master' of git://github.com/junpataleta/moodle
Andrew Nicols [Tue, 14 Jun 2016 05:24:47 +0000 (13:24 +0800)]
Merge branch 'MDL-54797' of git://github.com/aolley/moodle
Andrew Nicols [Tue, 14 Jun 2016 03:50:18 +0000 (11:50 +0800)]
Merge branch 'MDL-54787_master' of https://github.com/snake/moodle
Andrew Nicols [Tue, 14 Jun 2016 03:24:00 +0000 (11:24 +0800)]
Merge branch 'MDL-54576_themeSelector' of https://github.com/mrmark/moodle
Andrew Nicols [Tue, 14 Jun 2016 03:00:28 +0000 (11:00 +0800)]
Merge branch 'MDL-54859_master' of git://github.com/dmonllao/moodle
Andrew Nicols [Tue, 14 Jun 2016 01:05:53 +0000 (09:05 +0800)]
Merge branch 'MDL-52127-master' of git://github.com/danpoltawski/moodle
Andrew Nicols [Tue, 14 Jun 2016 00:49:41 +0000 (08:49 +0800)]
Merge branch 'MDL-51978-master' of https://github.com/jtc/moodle
Eloy Lafuente (stronk7) [Mon, 13 Jun 2016 18:05:13 +0000 (20:05 +0200)]
Merge branch 'MDL-54890-master' of git://github.com/danpoltawski/moodle
Dan Poltawski [Mon, 13 Jun 2016 08:48:47 +0000 (09:48 +0100)]
Merge branch 'MDL-51683-master' of git://github.com/FMCorz/moodle
Dan Poltawski [Wed, 15 Jun 2016 14:50:46 +0000 (15:50 +0100)]
MDL-52127 grunt: add .eslingingore file, keep task
Eloy prefers we keep the ignorefiles grunt task
Guy Thomas [Tue, 3 Jun 2014 16:57:23 +0000 (09:57 -0700)]
MDL-45762 course: Error when accessing a conditionally hidden section
Show a nice error when the user accidentally views a section
that is conditionally hidden. Otherwise, continue to show
original error when section is just hidden to them.
Nicholas Hoobin [Wed, 15 Jun 2016 00:49:28 +0000 (10:49 +1000)]
MDL-53788 multilangupgrade: fix aggressive course cache rebuilding
Nicholas Hoobin [Tue, 3 May 2016 04:29:20 +0000 (14:29 +1000)]
MDL-53788 user: fix aggressive course cache rebuilding
Nicholas Hoobin [Tue, 3 May 2016 04:25:51 +0000 (14:25 +1000)]
MDL-53788 mod_lti: fix aggressive course cache rebuilding
sam marshall [Tue, 14 Jun 2016 10:33:20 +0000 (11:33 +0100)]
MDL-54920 Behat: Allow viewport size to be set consistently
Provides a new Behat step
And I set viewport size to "800x600"
Dan Poltawski [Thu, 19 May 2016 11:45:34 +0000 (12:45 +0100)]
MDL-52127 grunt: fix coding style issues in gruntfile
Dan Poltawski [Fri, 13 May 2016 20:20:21 +0000 (21:20 +0100)]
MDL-52127 grunt: be aware of third party paths
1) Parse thirdpartylibs.xml and generate an array of third party
file paths to use in grunt tasks
2) In the lint tasks, we filter third party files from being linted
3) We add a new task to generate ignore files - currently for eslint,
but will be potentially useful for other things in the future
4) Remove .eslintignore from source control
Why have the ability to generate a .eslintignore file? For tooling
integration - by having the eslintignore file people can use other
eslint tools without having to just use grunt (e.g. editor
integrations).
Dan Poltawski [Sat, 14 May 2016 10:10:13 +0000 (11:10 +0100)]
MDL-52127 js: switch to a more YUI tolerant eslint config
Instead of having the stricter configuration for all files, use
the less strict default config and switch to the stricter config
for building AMD modules.
This means that the eslint commandline/editor inspections will work
better for all files and not generate false positives when using editor
integrations. But since grunt is required to build AMD modules we still
get the stricter checking for those files on build.
Dan Poltawski [Mon, 13 Jun 2016 08:35:58 +0000 (09:35 +0100)]
Merge branch 'MDL-54772-master' of git://github.com/junpataleta/moodle
Joby Harding [Sun, 12 Jun 2016 17:07:36 +0000 (18:07 +0100)]
MDL-51505 tool_templatelibrary: Prevent jumping when selecting template
Dan Poltawski [Mon, 13 Jun 2016 08:17:49 +0000 (09:17 +0100)]
Merge branch 'MDL-54562_master' of git://github.com/dmonllao/moodle
Dan Poltawski [Mon, 13 Jun 2016 07:51:56 +0000 (08:51 +0100)]
Merge branch 'MDL-54837-master' of git://github.com/marinaglancy/moodle
Dan Poltawski [Mon, 13 Jun 2016 07:36:38 +0000 (08:36 +0100)]
Merge branch 'MDL-54842-master' of git://github.com/junpataleta/moodle
Marina Glancy [Tue, 1 Mar 2016 02:51:37 +0000 (10:51 +0800)]
MDL-53292 core: deprecate callback delete_course
Cameron Ball [Fri, 8 Jan 2016 06:02:47 +0000 (14:02 +0800)]
MDL-51163 course: Remove course/category.php
eWallah [Sun, 27 Mar 2016 00:50:01 +0000 (18:50 -0600)]
MDL-37554 activities select all option
Jun Pataleta [Fri, 3 Jun 2016 02:10:06 +0000 (10:10 +0800)]
MDL-54772 mod_assign: Fixes for PDF editor
* Render the annotations and comments within the drawing canvas, not in
the drawing region.
* Remove edit-related event bindings for stamp annotations.
Andrew Nicols [Mon, 13 Jun 2016 01:17:53 +0000 (09:17 +0800)]
Merge branch 'MDL-24064-master' of git://github.com/FMCorz/moodle
Rajesh Taneja [Sun, 12 Jun 2016 23:26:14 +0000 (07:26 +0800)]
MDL-54899 behat: Tag for MOODLE 32 version
Dan Poltawski [Wed, 11 May 2016 10:38:46 +0000 (11:38 +0100)]
MDL-52127 js: check YUI modules with eslint
Because we don't have the entire YUI rollup, we can't apply some of the
rules safely, so we ignore some rules.
At this point I am not 100% certain this configuration is robust enough,
to deal with the lack fo rollup knowledge although its a good sign that
there are no errors on our entire yui codebase.
Dan Poltawski [Wed, 11 May 2016 09:19:30 +0000 (10:19 +0100)]
MDL-52127 js: check amd files with eslint grunt task
I have spent quite a lot of time working through the current list of
eslint options and configuring them for Moodle style and I think this is
a very good basis to start us at (as well as taking some of out jshint
options out with https://www.npmjs.com/package/polyjuice ). Thanks to
Andrew Nicols, Mark Johnson and Frédéric Massart for some refinements.
With this configuration the grunt build will fail if errors are present
in the js (though you can of course tell jshint to ignore some errors,
as I have done in admin/tool/lp/amd/src/competency_rule_points.js and
defining the Y global in lib/amd/src/yui.js ).
The grunt task will not report warnings by default, but a new
--show-lint-warnings flag will help achieve that. Editor
integrations/stanadalone eslint tool will surely be a better way of
getting eslint errors rather than using the grunt task.
Jake Dallimore [Fri, 10 Jun 2016 06:29:28 +0000 (14:29 +0800)]
MDL-54787 mod_quiz: Fix notification error on regrade
Dan Poltawski [Sat, 14 May 2016 08:06:56 +0000 (09:06 +0100)]
MDL-54890 course: remove erranous duplicated switch label
Detected by eslint rule 'no-duplicate-case'