moodle.git
10 months agoMDL-69128 admin: Convert HTML entities when populating tasklogs filter
Michael Hawkins [Fri, 26 Jun 2020 02:01:17 +0000 (10:01 +0800)]
MDL-69128 admin: Convert HTML entities when populating tasklogs filter

10 months agoweekly release 4.0dev
Eloy Lafuente (stronk7) [Fri, 3 Jul 2020 16:41:01 +0000 (18:41 +0200)]
weekly release 4.0dev

10 months agoMerge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Eloy Lafuente (stronk7) [Fri, 3 Jul 2020 16:40:55 +0000 (18:40 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install

10 months agoMerge branch 'MDL-68714-master' of https://github.com/andrewnicols/moodle
Jake Dallimore [Fri, 3 Jul 2020 03:58:17 +0000 (11:58 +0800)]
Merge branch 'MDL-68714-master' of https://github.com/andrewnicols/moodle

10 months agoMDL-68714 clilib: Check set_process_title exists
Andrew Nicols [Fri, 3 Jul 2020 01:49:08 +0000 (09:49 +0800)]
MDL-68714 clilib: Check set_process_title exists

The web cron script at /admin/cron.php pretends to be a CLI script which
means that it is not possible to rely upon the CLI_SCRIPT constant.

10 months agoMDL-68714 cron: Check value of CLI_SCRIPT not existence
Andrew Nicols [Fri, 3 Jul 2020 01:04:05 +0000 (09:04 +0800)]
MDL-68714 cron: Check value of CLI_SCRIPT not existence

10 months agoMerge branch 'MDL-63254' of https://github.com/Chocolate-lightning/moodle
Jake Dallimore [Thu, 2 Jul 2020 04:22:17 +0000 (12:22 +0800)]
Merge branch 'MDL-63254' of https://github.com/Chocolate-lightning/moodle

10 months agoMerge branch 'MDL-69130-master-enfix' of git://github.com/mudrd8mz/moodle
Jake Dallimore [Thu, 2 Jul 2020 04:07:58 +0000 (12:07 +0800)]
Merge branch 'MDL-69130-master-enfix' of git://github.com/mudrd8mz/moodle

10 months agoMerge branch 'MDL-69149-master' of git://github.com/andrewnicols/moodle
Jake Dallimore [Thu, 2 Jul 2020 03:57:04 +0000 (11:57 +0800)]
Merge branch 'MDL-69149-master' of git://github.com/andrewnicols/moodle

10 months agoMerge branch 'MDL-69122-master' of git://github.com/bmbrands/moodle
Jake Dallimore [Thu, 2 Jul 2020 03:49:02 +0000 (11:49 +0800)]
Merge branch 'MDL-69122-master' of git://github.com/bmbrands/moodle

10 months agoMerge branch 'MDL-68714-task-top-process-name' of https://github.com/brendanheywood...
Andrew Nicols [Thu, 2 Jul 2020 03:20:45 +0000 (11:20 +0800)]
Merge branch 'MDL-68714-task-top-process-name' of https://github.com/brendanheywood/moodle

10 months agoMerge branch 'MDL-58926-ajax-timer' of https://github.com/rboyatt/moodle
Jake Dallimore [Thu, 2 Jul 2020 01:37:00 +0000 (09:37 +0800)]
Merge branch 'MDL-58926-ajax-timer' of https://github.com/rboyatt/moodle

10 months agoAutomatically generated installer lang files
AMOS bot [Thu, 2 Jul 2020 00:08:01 +0000 (00:08 +0000)]
Automatically generated installer lang files

10 months agoMerge branch 'MDL-69072-master' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Wed, 1 Jul 2020 21:20:34 +0000 (23:20 +0200)]
Merge branch 'MDL-69072-master' of git://github.com/andrewnicols/moodle

10 months agoMerge branch 'MDL-58931-master' of https://github.com/mackensen/moodle
Eloy Lafuente (stronk7) [Wed, 1 Jul 2020 20:47:16 +0000 (22:47 +0200)]
Merge branch 'MDL-58931-master' of https://github.com/mackensen/moodle

10 months agoMDL-58931 dml: add support for aurora mysql
Charles Fulton [Fri, 21 Feb 2020 20:55:24 +0000 (15:55 -0500)]
MDL-58931 dml: add support for aurora mysql

10 months agoMerge branch 'MDL-63167-master' of git://github.com/peterRd/moodle
Jake Dallimore [Wed, 1 Jul 2020 09:06:01 +0000 (17:06 +0800)]
Merge branch 'MDL-63167-master' of git://github.com/peterRd/moodle

10 months agoMerge branch 'MDL-68584-master' of git://github.com/lucaboesch/moodle
Jake Dallimore [Wed, 1 Jul 2020 08:42:19 +0000 (16:42 +0800)]
Merge branch 'MDL-68584-master' of git://github.com/lucaboesch/moodle

10 months agoMDL-68714 task: Expose current task in cli process name
Brendan Heywood [Fri, 22 May 2020 14:05:30 +0000 (00:05 +1000)]
MDL-68714 task: Expose current task in cli process name

10 months agoMDL-68714 clilib: Allow cli processes to set a process title suffix
Brendan Heywood [Sat, 16 May 2020 10:06:40 +0000 (20:06 +1000)]
MDL-68714 clilib: Allow cli processes to set a process title suffix

10 months agoMerge branch 'MDL-60583' of https://github.com/NeillM/moodle
Andrew Nicols [Wed, 1 Jul 2020 01:16:21 +0000 (09:16 +0800)]
Merge branch 'MDL-60583' of https://github.com/NeillM/moodle

10 months agoMerge branch 'MDL-69150' of https://github.com/paulholden/moodle
Andrew Nicols [Wed, 1 Jul 2020 00:34:30 +0000 (08:34 +0800)]
Merge branch 'MDL-69150' of https://github.com/paulholden/moodle

10 months agoMerge branch 'MDL-69151' of https://github.com/paulholden/moodle
Andrew Nicols [Wed, 1 Jul 2020 00:27:36 +0000 (08:27 +0800)]
Merge branch 'MDL-69151' of https://github.com/paulholden/moodle

10 months agoMerge branch 'MDL-60621-master-1' of git://github.com/mihailges/moodle
Andrew Nicols [Tue, 30 Jun 2020 04:30:48 +0000 (12:30 +0800)]
Merge branch 'MDL-60621-master-1' of git://github.com/mihailges/moodle

10 months agoMDL-60621 core_course: Disable scrollable in the activity chooser modal
Mihail Geshoski [Tue, 16 Jun 2020 03:11:45 +0000 (11:11 +0800)]
MDL-60621 core_course: Disable scrollable in the activity chooser modal

10 months agoMDL-60621 js: Add ability to set a modal to be scrollable or not
Mihail Geshoski [Tue, 16 Jun 2020 01:42:08 +0000 (09:42 +0800)]
MDL-60621 js: Add ability to set a modal to be scrollable or not

With this change the modal can be configured to be scrollable or not.
If enabled to be 'scrollable', the modal's body will become scrollable
when the modal's height exceeds the browser's height. This is useful
in cases where the content in the modal is quite large and extends the
modal beyond the browser's height, which usually results in a bad UI.
If 'scrollable' is not explicitely configured, it will be set as 'true'
by default as in most cases it would be the expected behaviour.

10 months agoMDL-60583 webservice: Add index to improve token lookup performance
Neill Magill [Thu, 25 Jun 2020 08:11:50 +0000 (09:11 +0100)]
MDL-60583 webservice: Add index to improve token lookup performance

Without this index every webservice call will do a full table scan
when it tries to validate a token. On a busy site with many tokens
this adds unnecessary load to the database.

10 months agoMDL-69072 behat: Remove restart_browser_after feature
Andrew Nicols [Tue, 16 Jun 2020 00:24:52 +0000 (08:24 +0800)]
MDL-69072 behat: Remove restart_browser_after feature

This is no longer required as the Mink session is restarted after every
test regardless.

10 months agoMDL-69151 message_airnotifier: start output before accesskey request.
Paul Holden [Fri, 26 Jun 2020 16:31:37 +0000 (17:31 +0100)]
MDL-69151 message_airnotifier: start output before accesskey request.

This allows debugging generated by the request to be shown on the
page.

10 months agoMDL-69150 message_airnotifier: correct apps portal link.
Paul Holden [Fri, 26 Jun 2020 16:11:44 +0000 (17:11 +0100)]
MDL-69150 message_airnotifier: correct apps portal link.

10 months agoMDL-69072 mod_scorm: Stop mink reset after tests
Andrew Nicols [Tue, 16 Jun 2020 00:23:33 +0000 (08:23 +0800)]
MDL-69072 mod_scorm: Stop mink reset after tests

This is now done for all scenarios. It is no longer necessary to do so
specifically for mod_scorm.

10 months agoMDL-69072 behat: Relaunch browser session between scenarios
Andrew Nicols [Mon, 15 Jun 2020 02:37:52 +0000 (10:37 +0800)]
MDL-69072 behat: Relaunch browser session between scenarios

10 months agoMDL-69149 core_grade: Correct xpath attribute selector
Andrew Nicols [Fri, 26 Jun 2020 11:59:56 +0000 (19:59 +0800)]
MDL-69149 core_grade: Correct xpath attribute selector

10 months agoMDL-68584 core_question: flexbox compatible separator for question types
Luca Bösch [Fri, 1 May 2020 22:06:28 +0000 (00:06 +0200)]
MDL-68584 core_question: flexbox compatible separator for question types

* the br tag does not work well in a flexbox context, a 100% with div
works in both classic and boost.

10 months agoMDL-69130 lang: Import fixed English strings (en_fix)
Helen Foster [Thu, 25 Jun 2020 12:25:19 +0000 (14:25 +0200)]
MDL-69130 lang: Import fixed English strings (en_fix)

Significant string change:

- presentationoraltrequired,atto_image - wording changed to mention
  'decorative only' checkbox

10 months agoweekly release 4.0dev
Eloy Lafuente (stronk7) [Thu, 25 Jun 2020 16:05:59 +0000 (18:05 +0200)]
weekly release 4.0dev

10 months agoMerge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Eloy Lafuente (stronk7) [Thu, 25 Jun 2020 16:05:53 +0000 (18:05 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install

10 months agoMDL-69122 report_competency: fix clearfix
Bas Brands [Wed, 24 Jun 2020 07:06:21 +0000 (09:06 +0200)]
MDL-69122 report_competency: fix clearfix

- a misplaced clearfix caused part of the recontrols to be
inaccessible

10 months agoMerge branch 'MDL-68992-master_france_digital_age' of https://github.com/martignoni...
Jake Dallimore [Wed, 24 Jun 2020 01:39:19 +0000 (09:39 +0800)]
Merge branch 'MDL-68992-master_france_digital_age' of https://github.com/martignoni/moodle

10 months agoMerge branch 'MDL-69065-master' of git://github.com/peterRd/moodle
Jake Dallimore [Wed, 24 Jun 2020 01:30:31 +0000 (09:30 +0800)]
Merge branch 'MDL-69065-master' of git://github.com/peterRd/moodle

10 months agoMerge branch 'MDL-66568-master-2' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Tue, 23 Jun 2020 15:57:17 +0000 (17:57 +0200)]
Merge branch 'MDL-66568-master-2' of git://github.com/andrewnicols/moodle

10 months agoMDL-69065 course: Provide the id for the sr param
Peter Dias [Tue, 16 Jun 2020 01:30:40 +0000 (09:30 +0800)]
MDL-69065 course: Provide the id for the sr param

* Pass the section return id to the activity chooser
* Additional behat test to cover the case

10 months agoMerge branch 'MDL-69021-master' of git://github.com/bmbrands/moodle
Jake Dallimore [Tue, 23 Jun 2020 03:31:08 +0000 (11:31 +0800)]
Merge branch 'MDL-69021-master' of git://github.com/bmbrands/moodle

10 months agoMerge branch 'MDL-68841-master' of https://github.com/DinhHien0307/moodle
Adrian Greeve [Tue, 23 Jun 2020 01:39:44 +0000 (09:39 +0800)]
Merge branch 'MDL-68841-master' of https://github.com/DinhHien0307/moodle

10 months agoMDL-69099 tasks: Do not mark the non-enabled plugin's task as disabled
David Mudrák [Fri, 19 Jun 2020 15:02:08 +0000 (17:02 +0200)]
MDL-69099 tasks: Do not mark the non-enabled plugin's task as disabled

The `core\plugininfo\base::is_enabled()` uses three-state logic for its
return value. It can return null as a valid value as per its
documentation. We need to test for the explicit false value in this
case.

To make the attached Behat test able to identify the table, the caption
is added. It seems to be helpful for all users so I leave it displayed
without using the accesshide mechanism.

10 months agoMDL-69021 theme_boost: improve link styles in alerts
Bas Brands [Thu, 11 Jun 2020 08:22:00 +0000 (10:22 +0200)]
MDL-69021 theme_boost: improve link styles in alerts

- provide default styles for links in alerts if the .alert-link
css class is omitted.

10 months agoMerge branch 'MDL-69047-master' of git://github.com/aanabit/moodle
Jake Dallimore [Mon, 22 Jun 2020 04:41:06 +0000 (12:41 +0800)]
Merge branch 'MDL-69047-master' of git://github.com/aanabit/moodle

10 months agoMerge branch 'MDL-69077' of https://github.com/timhunt/moodle
Adrian Greeve [Mon, 22 Jun 2020 02:32:44 +0000 (10:32 +0800)]
Merge branch 'MDL-69077' of https://github.com/timhunt/moodle

10 months agoAutomatically generated installer lang files
AMOS bot [Sun, 21 Jun 2020 00:07:21 +0000 (00:07 +0000)]
Automatically generated installer lang files

10 months agoMDL-68992 Privacy: Update default minimal digital age of consent
Nicolas Martignoni [Fri, 12 Jun 2020 15:20:18 +0000 (17:20 +0200)]
MDL-68992 Privacy: Update default minimal digital age of consent

Updating default minimal digital age of consent according to current legislation,
that was updated for several countries since 2018.

10 months agoMerge branch 'MDL-69008-master' of git://github.com/junpataleta/moodle
Sara Arjona [Fri, 19 Jun 2020 14:44:53 +0000 (16:44 +0200)]
Merge branch 'MDL-69008-master' of git://github.com/junpataleta/moodle

10 months agoMDL-69047 core_contentbank: Hard coding status messages
Amaia Anabitarte [Tue, 16 Jun 2020 14:23:39 +0000 (16:23 +0200)]
MDL-69047 core_contentbank: Hard coding status messages

10 months agoweekly on-sync release 4.0dev
Sara Arjona [Thu, 18 Jun 2020 12:14:26 +0000 (14:14 +0200)]
weekly on-sync release 4.0dev

10 months agoMerge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Sara Arjona [Thu, 18 Jun 2020 12:14:23 +0000 (14:14 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install

10 months agoMerge branch 'MDL-66899-log-quiz-regrade' of https://github.com/rboyatt/moodle
Victor Deniz Falcon [Thu, 18 Jun 2020 03:16:53 +0000 (04:16 +0100)]
Merge branch 'MDL-66899-log-quiz-regrade' of https://github.com/rboyatt/moodle

10 months agoMerge branch 'MDL-69060-master' of git://github.com/lucaboesch/moodle
Víctor Déniz Falcón [Wed, 17 Jun 2020 22:38:15 +0000 (23:38 +0100)]
Merge branch 'MDL-69060-master' of git://github.com/lucaboesch/moodle

10 months agoMDL-69077 questions: question tag capabilties are relevant
Tim Hunt [Wed, 17 Jun 2020 12:06:57 +0000 (13:06 +0100)]
MDL-69077 questions: question tag capabilties are relevant

10 months agoMerge branch 'MDL-68890-master' of https://github.com/DinhHien0307/moodle
Jun Pataleta [Wed, 17 Jun 2020 11:53:29 +0000 (19:53 +0800)]
Merge branch 'MDL-68890-master' of https://github.com/DinhHien0307/moodle

10 months agoMDL-69008 core: Fix accessibility issues in paged content templates
Jun Pataleta [Wed, 10 Jun 2020 15:18:10 +0000 (23:18 +0800)]
MDL-69008 core: Fix accessibility issues in paged content templates

* Added menuitem role for the "Show x per page" menu.
* Added appropriate aria-labels for the links in the paging bar.

10 months agoMerge branch 'MDL-68215-master' of git://github.com/lucaboesch/moodle
Jake Dallimore [Wed, 17 Jun 2020 06:57:42 +0000 (14:57 +0800)]
Merge branch 'MDL-68215-master' of git://github.com/lucaboesch/moodle

10 months agoMDL-63167 grade: Test functions update
Peter Dias [Wed, 17 Jun 2020 06:12:08 +0000 (14:12 +0800)]
MDL-63167 grade: Test functions update

10 months agoMDL-63167 grade: Deprecated gradingform_provider
Peter Dias [Wed, 17 Jun 2020 04:56:23 +0000 (12:56 +0800)]
MDL-63167 grade: Deprecated gradingform_provider

10 months agoMerge branch 'MDL-68971' of https://github.com/timhunt/moodle
Jun Pataleta [Wed, 17 Jun 2020 03:36:12 +0000 (11:36 +0800)]
Merge branch 'MDL-68971' of https://github.com/timhunt/moodle

10 months agoMerge branch 'MDL-67294-master' of git://github.com/mihailges/moodle
Jun Pataleta [Wed, 17 Jun 2020 02:33:55 +0000 (10:33 +0800)]
Merge branch 'MDL-67294-master' of git://github.com/mihailges/moodle

10 months agoMDL-66568 behat: Reset theme CSS between scenarios
Andrew Nicols [Mon, 15 Jun 2020 02:37:17 +0000 (10:37 +0800)]
MDL-66568 behat: Reset theme CSS between scenarios

10 months agoMDL-66568 behat: Support building of themes for behat
Andrew Nicols [Mon, 15 Jun 2020 02:35:38 +0000 (10:35 +0800)]
MDL-66568 behat: Support building of themes for behat

10 months agoMerge branch 'MDL-69049-master' of git://github.com/junpataleta/moodle
Víctor Déniz Falcón [Tue, 16 Jun 2020 17:05:42 +0000 (18:05 +0100)]
Merge branch 'MDL-69049-master' of git://github.com/junpataleta/moodle

10 months agoMDL-67294 assignsubmission_file: Make sure record exists before updating
Mihail Geshoski [Fri, 12 Jun 2020 00:55:30 +0000 (08:55 +0800)]
MDL-67294 assignsubmission_file: Make sure record exists before updating

10 months agoMerge branch 'MDL-68436' of https://github.com/timhunt/moodle
Jun Pataleta [Tue, 16 Jun 2020 06:38:44 +0000 (14:38 +0800)]
Merge branch 'MDL-68436' of https://github.com/timhunt/moodle

10 months agoMDL-69049 tool_dataprivacy: Add possibly missing comment format columns
Jun Pataleta [Mon, 15 Jun 2020 14:47:22 +0000 (22:47 +0800)]
MDL-69049 tool_dataprivacy: Add possibly missing comment format columns

The earlier CONTRIB plugin versions of the tool (<33.2.0, <34.2.0) were
missing the following columns in the data requests table:
* commentsformat
* dpocommentformat
And the upgrade scripts for the merged tool failed in
Moodle 3.3.8+/3.3.0+ failed to add these columns.
So a site which uses the CONTRIB plugin and eventually upgrading to 3.9
will encounter an error during upgrade because of the missing
dpocommentformat column.

10 months agoMerge branch 'MDL-69044' of https://github.com/stronk7/moodle
Víctor Déniz Falcón [Mon, 15 Jun 2020 16:21:49 +0000 (17:21 +0100)]
Merge branch 'MDL-69044' of https://github.com/stronk7/moodle

10 months agoMerge branch 'MDL-69043' of https://github.com/stronk7/moodle
Víctor Déniz Falcón [Mon, 15 Jun 2020 14:55:22 +0000 (15:55 +0100)]
Merge branch 'MDL-69043' of https://github.com/stronk7/moodle

10 months agoMDL-68215 block_activity_result: Format elements more nicely.
Luca Bösch [Sat, 21 Mar 2020 10:54:06 +0000 (11:54 +0100)]
MDL-68215 block_activity_result: Format elements more nicely.

10 months agoMDL-69060 core_contentbank: fix contenbank typos.
Luca Bösch [Mon, 15 Jun 2020 11:35:43 +0000 (13:35 +0200)]
MDL-69060 core_contentbank: fix contenbank typos.

11 months agoMDL-63254 core_event: Remove deprecated message events
Mathew May [Mon, 15 Jun 2020 03:59:34 +0000 (11:59 +0800)]
MDL-63254 core_event: Remove deprecated message events

11 months agoMDL-68890 progressbar: prevent display exist file's progress bar
hiendinh [Tue, 2 Jun 2020 07:07:03 +0000 (14:07 +0700)]
MDL-68890 progressbar: prevent display exist file's progress bar

11 months agoMDL-66568 core_output: Return built theme CSS
Andrew Nicols [Mon, 15 Jun 2020 02:34:40 +0000 (10:34 +0800)]
MDL-66568 core_output: Return built theme CSS

11 months agoMDL-69044 upgrade: add 3.9.0 separation line to all upgrade scripts
Eloy Lafuente (stronk7) [Sun, 14 Jun 2020 11:08:09 +0000 (13:08 +0200)]
MDL-69044 upgrade: add 3.9.0 separation line to all upgrade scripts

11 months agoMDL-69043 backup: Bump release to 4.0
Eloy Lafuente (stronk7) [Sun, 14 Jun 2020 10:53:38 +0000 (12:53 +0200)]
MDL-69043 backup: Bump release to 4.0

11 months agoAutomatically generated installer lang files
AMOS bot [Sun, 14 Jun 2020 00:07:18 +0000 (00:07 +0000)]
Automatically generated installer lang files

11 months agoweekly back-to-dev release 4.0dev
Eloy Lafuente (stronk7) [Sat, 13 Jun 2020 18:11:29 +0000 (20:11 +0200)]
weekly back-to-dev release 4.0dev

11 months agoNOBUG: Change travis.yml back to master
Eloy Lafuente (stronk7) [Sat, 13 Jun 2020 18:04:50 +0000 (20:04 +0200)]
NOBUG: Change travis.yml back to master

11 months agoMoodle release 3.9 v3.9.0
Eloy Lafuente (stronk7) [Sat, 13 Jun 2020 18:04:49 +0000 (20:04 +0200)]
Moodle release 3.9

11 months agoNOBUG: Change travis.yml to MOODLE_39_STABLE
Eloy Lafuente (stronk7) [Sat, 13 Jun 2020 18:04:49 +0000 (20:04 +0200)]
NOBUG: Change travis.yml to MOODLE_39_STABLE

11 months agoMerge branch 'MDL-68632' of git://github.com/aolley/moodle
Eloy Lafuente (stronk7) [Fri, 12 Jun 2020 17:52:26 +0000 (19:52 +0200)]
Merge branch 'MDL-68632' of git://github.com/aolley/moodle

11 months agoMoodle release 3.9rc3 v3.9.0-rc3
Victor Deniz Falcon [Fri, 12 Jun 2020 11:32:06 +0000 (12:32 +0100)]
Moodle release 3.9rc3

11 months agoMerge branch 'MDL-69026-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Fri, 12 Jun 2020 03:58:59 +0000 (11:58 +0800)]
Merge branch 'MDL-69026-master' of git://github.com/andrewnicols/moodle

11 months agoMDL-68632 quizaccess_seb: Limit privacy queriyes to the quiz module
Adam Olley [Thu, 7 May 2020 04:28:23 +0000 (13:58 +0930)]
MDL-68632 quizaccess_seb: Limit privacy queriyes to the quiz module

Without this, joins are performed against the course_modules table purely on
the instance id - other modules can share this ID, resulting in incorrect
contexts being pulled in.

11 months agoMDL-69026 user: Correct statuses => status in test
Andrew Nicols [Fri, 12 Jun 2020 01:39:25 +0000 (09:39 +0800)]
MDL-69026 user: Correct statuses => status in test

11 months agoMDL-69026 user: Wrap sub-query in brackets
Andrew Nicols [Fri, 12 Jun 2020 00:46:46 +0000 (08:46 +0800)]
MDL-69026 user: Wrap sub-query in brackets

It is perfectly valid to have a query like:

Match None of the following:
- Role is ANY of the following:
-- 'Teacher'
-- 'Editing teacher'
-- 'Manager'; AND
- Keyword is NONE of the following:
-- 'Kevin'

However, due to the way in which the query is constructed, this leads to
a query which includes

    WHERE NOT ef.id IS NOT NULL
    AND NOT
        u.id IN (SELECT userid FROM {role_assignments} WHERE roleid IN (...) AND contextid IN (...))
    AND NOT
        NOT (u.firstname || ' ' || u.lastname LIKE '%Kevin%')

The use of NOT NOT is valid in Postgres, MariaDB, MySQL, and MSSQL, but
not in Oracle.

To counter this when the outer jointype is of type NONE, we must wrap
each of the inner WHERE clauses in a set of brackets, which makes the
query:

    WHERE NOT ef.id IS NOT NULL
    AND NOT
        (u.id IN (SELECT userid FROM {role_assignments} WHERE roleid IN (...) AND contextid IN (...)))
    AND NOT
        (NOT (u.firstname || ' ' || u.lastname LIKE '%Kevin%'))

Whilst Oracle does not support the use of `AND NOT NOT ...`, it does support
`AND NOT (NOT ...)`

11 months agoMoodle release 3.9rc2 v3.9.0-rc2
Sara Arjona [Thu, 11 Jun 2020 16:05:14 +0000 (18:05 +0200)]
Moodle release 3.9rc2

11 months agoMerge branch 'MDL-69022' of https://github.com/Chocolate-lightning/moodle
Sara Arjona [Thu, 11 Jun 2020 10:50:49 +0000 (12:50 +0200)]
Merge branch 'MDL-69022' of https://github.com/Chocolate-lightning/moodle

11 months agoMDL-69022 tool_moodlenet: Disable integration by default
Mathew May [Thu, 11 Jun 2020 09:16:12 +0000 (17:16 +0800)]
MDL-69022 tool_moodlenet: Disable integration by default

11 months agoMerge branch 'MDL-69017-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Thu, 11 Jun 2020 08:59:04 +0000 (16:59 +0800)]
Merge branch 'MDL-69017-master' of git://github.com/andrewnicols/moodle

11 months agoMDL-68841 Modal dialogs: Wrong behavior of popup
hiendinh [Thu, 11 Jun 2020 08:25:25 +0000 (15:25 +0700)]
MDL-68841 Modal dialogs: Wrong behavior of popup

11 months agoMerge branch 'MDL-69004-master' of git://github.com/rezaies/moodle
Sara Arjona [Thu, 11 Jun 2020 08:22:38 +0000 (10:22 +0200)]
Merge branch 'MDL-69004-master' of git://github.com/rezaies/moodle

11 months agoMerge branch 'MDL-69020-master' of git://github.com/mihailges/moodle
Jake Dallimore [Thu, 11 Jun 2020 08:18:08 +0000 (16:18 +0800)]
Merge branch 'MDL-69020-master' of git://github.com/mihailges/moodle

11 months agoMDL-69020 tool_moodlenet: Modify defaultmoodlenet_desc string
Mihail Geshoski [Thu, 11 Jun 2020 07:23:54 +0000 (15:23 +0800)]
MDL-69020 tool_moodlenet: Modify defaultmoodlenet_desc string

11 months agoMDL-69017 user: Show all links should work for students
Andrew Nicols [Thu, 11 Jun 2020 04:13:09 +0000 (12:13 +0800)]
MDL-69017 user: Show all links should work for students

11 months agoMerge branch 'MDL-67070-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Thu, 11 Jun 2020 06:22:48 +0000 (14:22 +0800)]
Merge branch 'MDL-67070-master' of git://github.com/andrewnicols/moodle