moodle.git
3 years agoMerge branch 'MDL-59247-master' of git://github.com/jleyva/moodle
Eloy Lafuente (stronk7) [Mon, 2 Oct 2017 21:48:24 +0000 (23:48 +0200)]
Merge branch 'MDL-59247-master' of git://github.com/jleyva/moodle

3 years agoMerge branch 'MDL-59246-master' of git://github.com/jleyva/moodle
Eloy Lafuente (stronk7) [Mon, 2 Oct 2017 21:08:25 +0000 (23:08 +0200)]
Merge branch 'MDL-59246-master' of git://github.com/jleyva/moodle

3 years agoMerge branch 'MDL-59242-master' of git://github.com/jleyva/moodle
Eloy Lafuente (stronk7) [Mon, 2 Oct 2017 20:59:38 +0000 (22:59 +0200)]
Merge branch 'MDL-59242-master' of git://github.com/jleyva/moodle

3 years agoMerge branch 'MDL-60003_master' of git://github.com/dmonllao/moodle
Andrew Nicols [Mon, 2 Oct 2017 12:18:21 +0000 (20:18 +0800)]
Merge branch 'MDL-60003_master' of git://github.com/dmonllao/moodle

3 years agoMerge branch 'MDL-60277_master' of git://github.com/dmonllao/moodle
Andrew Nicols [Mon, 2 Oct 2017 07:58:00 +0000 (15:58 +0800)]
Merge branch 'MDL-60277_master' of git://github.com/dmonllao/moodle

3 years agoMerge branch 'MDL-59241-master' of git://github.com/jleyva/moodle
Andrew Nicols [Mon, 2 Oct 2017 07:52:40 +0000 (15:52 +0800)]
Merge branch 'MDL-59241-master' of git://github.com/jleyva/moodle

3 years agoMerge branch 'MDL-58790' of git://github.com/timhunt/moodle
Andrew Nicols [Mon, 2 Oct 2017 07:39:26 +0000 (15:39 +0800)]
Merge branch 'MDL-58790' of git://github.com/timhunt/moodle

3 years agoMDL-59247 mod_workshop: New WS mod_workshop_get_assessment
Juan Leyva [Mon, 26 Jun 2017 13:26:15 +0000 (14:26 +0100)]
MDL-59247 mod_workshop: New WS mod_workshop_get_assessment

3 years agoMDL-59246 mod_workshop: New WS get_submission_assessments
Juan Leyva [Thu, 22 Jun 2017 19:33:35 +0000 (20:33 +0100)]
MDL-59246 mod_workshop: New WS get_submission_assessments

3 years agoMDL-59242 mod_workshop: New WS mod_workshop_get_submission
Juan Leyva [Thu, 22 Jun 2017 12:34:14 +0000 (13:34 +0100)]
MDL-59242 mod_workshop: New WS mod_workshop_get_submission

3 years agoMerge branch 'wip-MDL-60287-master' of git://github.com/marinaglancy/moodle
Andrew Nicols [Mon, 2 Oct 2017 07:33:55 +0000 (15:33 +0800)]
Merge branch 'wip-MDL-60287-master' of git://github.com/marinaglancy/moodle

3 years agoMDL-59241 mod_workshop: New WS mod_workshop_get_submissions
Juan Leyva [Thu, 22 Jun 2017 10:00:43 +0000 (11:00 +0100)]
MDL-59241 mod_workshop: New WS mod_workshop_get_submissions

3 years agoMDL-60239 libraries: patch Markdown for PHP7.2
Marina Glancy [Mon, 2 Oct 2017 07:15:36 +0000 (15:15 +0800)]
MDL-60239 libraries: patch Markdown for PHP7.2

3 years agoMDL-60277 report_insights: Pass the prediction as a float
David Monllao [Thu, 28 Sep 2017 16:55:24 +0000 (18:55 +0200)]
MDL-60277 report_insights: Pass the prediction as a float

3 years agoMerge branch 'wip-MDL-58548-master' of git://github.com/abgreeve/moodle
Andrew Nicols [Mon, 2 Oct 2017 06:47:08 +0000 (14:47 +0800)]
Merge branch 'wip-MDL-58548-master' of git://github.com/abgreeve/moodle

3 years agoMerge branch 'MDL-58550-master' of git://github.com/ankitagarwal/moodle
Andrew Nicols [Mon, 2 Oct 2017 03:57:34 +0000 (11:57 +0800)]
Merge branch 'MDL-58550-master' of git://github.com/ankitagarwal/moodle

3 years agoMerge branch 'MDL-60289-master' of git://github.com/lameze/moodle
Andrew Nicols [Mon, 2 Oct 2017 03:32:03 +0000 (11:32 +0800)]
Merge branch 'MDL-60289-master' of git://github.com/lameze/moodle

3 years agoMerge branch 'MDL-60236-master' of git://github.com/ankitagarwal/moodle
Andrew Nicols [Mon, 2 Oct 2017 02:31:40 +0000 (10:31 +0800)]
Merge branch 'MDL-60236-master' of git://github.com/ankitagarwal/moodle

3 years agoMDL-60289 libraries: Upgrade Chart.js to 2.7.0
Simey Lameze [Fri, 29 Sep 2017 04:09:49 +0000 (12:09 +0800)]
MDL-60289 libraries: Upgrade Chart.js to 2.7.0

3 years agoMerge branch 'MDL-60239-master' of git://github.com/ankitagarwal/moodle
Andrew Nicols [Mon, 2 Oct 2017 02:21:56 +0000 (10:21 +0800)]
Merge branch 'MDL-60239-master' of git://github.com/ankitagarwal/moodle

3 years agoMerge branch 'MDL-60306-master' of git://github.com/junpataleta/moodle
Andrew Nicols [Mon, 2 Oct 2017 02:15:07 +0000 (10:15 +0800)]
Merge branch 'MDL-60306-master' of git://github.com/junpataleta/moodle

3 years agoMDL-60306 calendar: Fix rrule_manager unit test
Jun Pataleta [Mon, 2 Oct 2017 01:17:33 +0000 (09:17 +0800)]
MDL-60306 calendar: Fix rrule_manager unit test

* The calculation of the expected date should depend on the comparison
with the start date's date and not it's exact timestamp.

3 years agoMDL-58548 lib: Update to moodle specific files.
Adrian Greeve [Thu, 21 Sep 2017 05:25:02 +0000 (13:25 +0800)]
MDL-58548 lib: Update to moodle specific files.

Update to moodle specific files related to the upgrade
of htmlpurifier.

3 years agoMDL-58548 lib: Update htmlpurifier to the latest version.
Adrian Greeve [Thu, 21 Sep 2017 05:23:21 +0000 (13:23 +0800)]
MDL-58548 lib: Update htmlpurifier to the latest version.

3 years agoMDL-60287 scssphp: patch for PHP7.2 compatibility
Marina Glancy [Sun, 1 Oct 2017 03:25:09 +0000 (11:25 +0800)]
MDL-60287 scssphp: patch for PHP7.2 compatibility

3 years agoMDL-60287 scssphp: upgraded to 0.6.7
Marina Glancy [Sun, 1 Oct 2017 03:24:18 +0000 (11:24 +0800)]
MDL-60287 scssphp: upgraded to 0.6.7

3 years agoMDL-60003 analytics: Skip samples with only null values
David Monllao [Tue, 5 Sep 2017 05:06:30 +0000 (07:06 +0200)]
MDL-60003 analytics: Skip samples with only null values

3 years agoweekly release 3.4dev
Jake Dallimore [Thu, 28 Sep 2017 06:27:24 +0000 (14:27 +0800)]
weekly release 3.4dev

3 years agoMDL-60236 libraries: Upgrade simplepie to 1.5.0
Ankit Agarwal [Thu, 28 Sep 2017 04:49:33 +0000 (10:19 +0530)]
MDL-60236 libraries: Upgrade simplepie to 1.5.0

3 years agoMerge branch 'MDL-60243-master' of https://github.com/snake/moodle
Eloy Lafuente (stronk7) [Wed, 27 Sep 2017 18:38:50 +0000 (20:38 +0200)]
Merge branch 'MDL-60243-master' of https://github.com/snake/moodle

3 years agoMerge branch 'wip-MDL-59495-master' of git://github.com/marinaglancy/moodle
Andrew Nicols [Wed, 27 Sep 2017 07:11:20 +0000 (15:11 +0800)]
Merge branch 'wip-MDL-59495-master' of git://github.com/marinaglancy/moodle

3 years agoMDL-60239 libraries: upgrade MD library to 1.7.0
Ankit Agarwal [Wed, 27 Sep 2017 06:58:20 +0000 (12:28 +0530)]
MDL-60239 libraries: upgrade MD library to 1.7.0

3 years agoMDL-59495 registration: do not use the word 'hub' in strings
Marina Glancy [Wed, 13 Sep 2017 01:44:57 +0000 (09:44 +0800)]
MDL-59495 registration: do not use the word 'hub' in strings

Either say 'server', or 'Moodle.net' or change the wording. Registration is only possible on Moodle.net now
and it should no longer be called 'hub'.

3 years agoMDL-59495 lang_hub: deprecate all unused strings
Marina Glancy [Tue, 12 Sep 2017 07:55:58 +0000 (15:55 +0800)]
MDL-59495 lang_hub: deprecate all unused strings

3 years agoMDL-59495 block_community: search courses on moodle.net only
Marina Glancy [Tue, 12 Sep 2017 07:19:11 +0000 (15:19 +0800)]
MDL-59495 block_community: search courses on moodle.net only

Remove support for alternative hubs and hub selector

3 years agoMDL-59495 course: publish courses on moodle.net only
Marina Glancy [Tue, 12 Sep 2017 07:18:21 +0000 (15:18 +0800)]
MDL-59495 course: publish courses on moodle.net only

Remove support for alternative hubs

3 years agoMerge branch 'MDL-59780-master' of git://github.com/ankitagarwal/moodle
Jake Dallimore [Wed, 27 Sep 2017 05:34:56 +0000 (13:34 +0800)]
Merge branch 'MDL-59780-master' of git://github.com/ankitagarwal/moodle

3 years agoMDL-59495 registration: register site on moodle.net only
Marina Glancy [Tue, 12 Sep 2017 07:20:03 +0000 (15:20 +0800)]
MDL-59495 registration: register site on moodle.net only

Remove support for alternative hubs

3 years agoMDL-59495 moodlenet: move all moodlenet code into new namespace
Marina Glancy [Tue, 12 Sep 2017 07:15:06 +0000 (15:15 +0800)]
MDL-59495 moodlenet: move all moodlenet code into new namespace

Support for alternative hubs will be removed in 3.4
We can move all methods working with registration, course publishing and moodle.net
communication into separate namespace

3 years agoMerge branch 'MDL-59940-master' of git://github.com/andrewnicols/moodle
Jake Dallimore [Wed, 27 Sep 2017 04:56:56 +0000 (12:56 +0800)]
Merge branch 'MDL-59940-master' of git://github.com/andrewnicols/moodle

3 years agoMDL-59940 calendar: Fix random behat fails when changing month
Andrew Nicols [Wed, 27 Sep 2017 03:59:52 +0000 (11:59 +0800)]
MDL-59940 calendar: Fix random behat fails when changing month

3 years agoMDL-59940 calendar: Fix behat test for lookahead feature
Andrew Nicols [Wed, 27 Sep 2017 03:59:34 +0000 (11:59 +0800)]
MDL-59940 calendar: Fix behat test for lookahead feature

3 years agoMDL-59780 mathjax: Make sure mathjax url doesn't become empty
Ankit Agarwal [Tue, 19 Sep 2017 05:57:24 +0000 (11:27 +0530)]
MDL-59780 mathjax: Make sure mathjax url doesn't become empty

3 years agoMDL-60243 competencies: fix ordering bug in api_test unit test
Jake Dallimore [Wed, 27 Sep 2017 01:16:25 +0000 (09:16 +0800)]
MDL-60243 competencies: fix ordering bug in api_test unit test

list_user_competencies_to_review() orders by shortname, but the test
creates 2 user competencies with the same short name, resulting in
unpredictable results. This patch fixes that.

3 years agoMerge branch 'MDL-59931_master' of https://github.com/ctam/moodle
Eloy Lafuente (stronk7) [Tue, 26 Sep 2017 23:16:10 +0000 (01:16 +0200)]
Merge branch 'MDL-59931_master' of https://github.com/ctam/moodle

3 years agoMerge branch 'MDL-60005-master' of git://github.com/jleyva/moodle
Eloy Lafuente (stronk7) [Tue, 26 Sep 2017 22:54:09 +0000 (00:54 +0200)]
Merge branch 'MDL-60005-master' of git://github.com/jleyva/moodle

3 years agoMerge branch 'MDL-60156-master' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Tue, 26 Sep 2017 18:36:25 +0000 (20:36 +0200)]
Merge branch 'MDL-60156-master' of git://github.com/andrewnicols/moodle

3 years agoMerge branch 'MDL-59645-master-flickr' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Tue, 26 Sep 2017 17:29:40 +0000 (19:29 +0200)]
Merge branch 'MDL-59645-master-flickr' of git://github.com/mudrd8mz/moodle

3 years agoMDL-58790 quiz editing: translate hard-coded new heading string
Tim Hunt [Tue, 26 Sep 2017 10:03:09 +0000 (11:03 +0100)]
MDL-58790 quiz editing: translate hard-coded new heading string

3 years agoMerge branch 'MDL-60141-master' of git://github.com/jleyva/moodle
Andrew Nicols [Tue, 26 Sep 2017 07:47:56 +0000 (15:47 +0800)]
Merge branch 'MDL-60141-master' of git://github.com/jleyva/moodle

3 years agoMerge branch 'MDL-60121-multi-enrol-backup' of https://github.com/mpetrowi/moodle
Jake Dallimore [Tue, 26 Sep 2017 07:22:33 +0000 (15:22 +0800)]
Merge branch 'MDL-60121-multi-enrol-backup' of https://github.com/mpetrowi/moodle

3 years agoMerge branch 'MDL-60197_master' of git://github.com/markn86/moodle
Andrew Nicols [Tue, 26 Sep 2017 01:56:54 +0000 (09:56 +0800)]
Merge branch 'MDL-60197_master' of git://github.com/markn86/moodle

3 years agoMerge branch 'master' of https://github.com/ConnorSheremeta/moodle
Andrew Nicols [Tue, 26 Sep 2017 00:16:08 +0000 (08:16 +0800)]
Merge branch 'master' of https://github.com/ConnorSheremeta/moodle

3 years agoMerge branch 'MDL-59505-master-gdrive' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Mon, 25 Sep 2017 23:29:35 +0000 (01:29 +0200)]
Merge branch 'MDL-59505-master-gdrive' of git://github.com/mudrd8mz/moodle

3 years agoMerge branch 'MDL-57115-master' of git://github.com/ankitagarwal/moodle
Eloy Lafuente (stronk7) [Mon, 25 Sep 2017 23:11:21 +0000 (01:11 +0200)]
Merge branch 'MDL-57115-master' of git://github.com/ankitagarwal/moodle

3 years agoMerge branch 'MDL-59940-master' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Mon, 25 Sep 2017 21:07:05 +0000 (23:07 +0200)]
Merge branch 'MDL-59940-master' of git://github.com/andrewnicols/moodle

3 years agoMerge branch 'MDL-60158-master' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Mon, 25 Sep 2017 20:06:00 +0000 (22:06 +0200)]
Merge branch 'MDL-60158-master' of git://github.com/andrewnicols/moodle

3 years agoMDL-59931 mod_quiz: Fixing incorrect pagination count.
Carson Tam [Fri, 15 Sep 2017 14:53:35 +0000 (07:53 -0700)]
MDL-59931 mod_quiz: Fixing incorrect pagination count.

3 years agoMerge branch 'wip-MDL-60167-master' of git://github.com/marinaglancy/moodle
Eloy Lafuente (stronk7) [Mon, 25 Sep 2017 17:53:48 +0000 (19:53 +0200)]
Merge branch 'wip-MDL-60167-master' of git://github.com/marinaglancy/moodle

3 years agoMDL-59940 calendar: Fix eslint errors
Andrew Nicols [Mon, 25 Sep 2017 03:51:08 +0000 (11:51 +0800)]
MDL-59940 calendar: Fix eslint errors

3 years agoMDL-59940 calendar: Improve event start time default
Andrew Nicols [Tue, 12 Sep 2017 00:33:46 +0000 (08:33 +0800)]
MDL-59940 calendar: Improve event start time default

Create events on the first day of the month when not in the current
month.

3 years agoMDL-60156 calendar: Replace add event button template
Andrew Nicols [Mon, 18 Sep 2017 04:47:37 +0000 (12:47 +0800)]
MDL-60156 calendar: Replace add event button template

3 years agoMDL-60158 calendar: Fix footer options when viewing as guest
Andrew Nicols [Mon, 18 Sep 2017 05:08:43 +0000 (13:08 +0800)]
MDL-60158 calendar: Fix footer options when viewing as guest

3 years agoMDL-60167 upgrade: Fix duplicate site registrations
Marina Glancy [Thu, 21 Sep 2017 06:28:12 +0000 (14:28 +0800)]
MDL-60167 upgrade: Fix duplicate site registrations

4 years agoweekly release 3.4dev
Dan Poltawski [Fri, 22 Sep 2017 11:43:11 +0000 (12:43 +0100)]
weekly release 3.4dev

"Parting is such sweet sorrow."

xxx

4 years agoMerge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Dan Poltawski [Fri, 22 Sep 2017 11:43:10 +0000 (12:43 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install

4 years agoMerge branch 'MDL-37810-master-fix' of https://github.com/snake/moodle
Jun Pataleta [Fri, 22 Sep 2017 02:54:40 +0000 (10:54 +0800)]
Merge branch 'MDL-37810-master-fix' of https://github.com/snake/moodle

4 years agoMDL-59505 oauth2: Fix storage of access controlled links
David Mudrák [Fri, 15 Sep 2017 13:13:05 +0000 (15:13 +0200)]
MDL-59505 oauth2: Fix storage of access controlled links

When files are copied into the system account's drive, they are put into
folders respecting the structure of contexts. Folder names were based on
context names only and so were likely to collide (such as with users
with the same name).

The patch ads context instance identifiers to the name so that they can
be identified more reliably.

4 years agoMerge branch 'MDL-53169' of https://github.com/stronk7/moodle
Dan Poltawski [Thu, 21 Sep 2017 18:03:55 +0000 (19:03 +0100)]
Merge branch 'MDL-53169' of https://github.com/stronk7/moodle

4 years agoMDL-53169 database: use bound empty strings for cross-db
Eloy Lafuente (stronk7) [Thu, 21 Sep 2017 17:27:59 +0000 (19:27 +0200)]
MDL-53169 database: use bound empty strings for cross-db

4 years agoAutomatically generated installer lang files
AMOS bot [Thu, 21 Sep 2017 16:07:52 +0000 (00:07 +0800)]
Automatically generated installer lang files

4 years agoAutomatically generated installer lang files
AMOS bot [Thu, 21 Sep 2017 16:07:51 +0000 (00:07 +0800)]
Automatically generated installer lang files

4 years agoMDL-37810 roles: fix profile roles logic to include all roles
Jake Dallimore [Thu, 21 Sep 2017 11:49:19 +0000 (19:49 +0800)]
MDL-37810 roles: fix profile roles logic to include all roles

If the user has the role:assign capability then the list of profile roles
will include any role assigned in the context or above.

4 years agoMDL-58550 libraries: Upgrade matthiasmullie libraries
Ankit Agarwal [Thu, 21 Sep 2017 05:28:08 +0000 (10:58 +0530)]
MDL-58550 libraries: Upgrade matthiasmullie libraries

4 years agoMDL-60197 mod_data: not always necessary to show 'select all/none' link
Mark Nelson [Thu, 21 Sep 2017 09:50:28 +0000 (17:50 +0800)]
MDL-60197 mod_data: not always necessary to show 'select all/none' link

4 years agoAutomatically generated installer lang files
AMOS bot [Wed, 20 Sep 2017 16:05:52 +0000 (00:05 +0800)]
Automatically generated installer lang files

4 years agoMerge branch 'MDL-59750-master' of git://github.com/lameze/moodle
Jun Pataleta [Wed, 20 Sep 2017 10:45:37 +0000 (18:45 +0800)]
Merge branch 'MDL-59750-master' of git://github.com/lameze/moodle

4 years agoMerge branch 'MDL-43176' of https://github.com/NeillM/moodle
Eloy Lafuente (stronk7) [Tue, 19 Sep 2017 21:10:31 +0000 (23:10 +0200)]
Merge branch 'MDL-43176' of https://github.com/NeillM/moodle

4 years agoMDL-59750 core_calendar: fix minithree logic on get_view
Simey Lameze [Wed, 20 Sep 2017 05:25:19 +0000 (13:25 +0800)]
MDL-59750 core_calendar: fix minithree logic on get_view

4 years agoMDL-59750 calendar: fix logic on subscription template
Simey Lameze [Wed, 20 Sep 2017 01:16:08 +0000 (09:16 +0800)]
MDL-59750 calendar: fix logic on subscription template

4 years agoMDL-59750 core_calendar: remove show_day method
Simey Lameze [Tue, 19 Sep 2017 05:19:37 +0000 (13:19 +0800)]
MDL-59750 core_calendar: remove show_day method

4 years agoMDL-59750 calendar: organise exporters code
Simey Lameze [Mon, 18 Sep 2017 04:08:06 +0000 (12:08 +0800)]
MDL-59750 calendar: organise exporters code

4 years agoMDL-59750 calendar: add edit and delete url to exporter
Simey Lameze [Mon, 18 Sep 2017 02:54:32 +0000 (10:54 +0800)]
MDL-59750 calendar: add edit and delete url to exporter

4 years agoMDL-59750 calendar: render day view using templates
Simey Lameze [Mon, 18 Sep 2017 02:53:26 +0000 (10:53 +0800)]
MDL-59750 calendar: render day view using templates

4 years agoMDL-59750 core_calendar: rename template month_header to header
Simey Lameze [Mon, 4 Sep 2017 07:57:39 +0000 (15:57 +0800)]
MDL-59750 core_calendar: rename template month_header to header

4 years agoMDL-59750 core_calendar: add next and previous days handling methods
Simey Lameze [Mon, 4 Sep 2017 08:00:43 +0000 (16:00 +0800)]
MDL-59750 core_calendar: add next and previous days handling methods

4 years agoMDL-59750 core_calendar: better handling of event subscription
Simey Lameze [Tue, 12 Sep 2017 02:47:01 +0000 (10:47 +0800)]
MDL-59750 core_calendar: better handling of event subscription

4 years agoMerge branch 'MDL-43176' of https://github.com/NeillM/moodle
Eloy Lafuente (stronk7) [Tue, 19 Sep 2017 21:10:31 +0000 (23:10 +0200)]
Merge branch 'MDL-43176' of https://github.com/NeillM/moodle

4 years agoMerge branch 'MDL-60132-master' of git://github.com/jleyva/moodle
Eloy Lafuente (stronk7) [Tue, 19 Sep 2017 20:34:39 +0000 (22:34 +0200)]
Merge branch 'MDL-60132-master' of git://github.com/jleyva/moodle

4 years agoMerge branch 'MDL-59920-master' of git://github.com/andrewnicols/moodle
Dan Poltawski [Tue, 19 Sep 2017 17:14:18 +0000 (18:14 +0100)]
Merge branch 'MDL-59920-master' of git://github.com/andrewnicols/moodle

4 years agoMerge branch 'MDL-53169-master' of https://github.com/sammarshallou/moodle
Jun Pataleta [Tue, 19 Sep 2017 14:26:30 +0000 (22:26 +0800)]
Merge branch 'MDL-53169-master' of https://github.com/sammarshallou/moodle

4 years agoMDL-59645 flickrlib: Show debug notice when using legacy authentication
David Mudrák [Thu, 24 Aug 2017 19:49:24 +0000 (21:49 +0200)]
MDL-59645 flickrlib: Show debug notice when using legacy authentication

4 years agoMDL-59645 portfolio_flickr: Make the Flickr portfolio export work again
David Mudrák [Thu, 24 Aug 2017 18:20:45 +0000 (20:20 +0200)]
MDL-59645 portfolio_flickr: Make the Flickr portfolio export work again

The patch modifies the Flickr portfolio to make it use of the new oauth1
based client.

4 years agoMDL-59645 repository_flickr: Drop legacy auth tokens and nsids
David Mudrák [Tue, 22 Aug 2017 18:46:29 +0000 (20:46 +0200)]
MDL-59645 repository_flickr: Drop legacy auth tokens and nsids

The values stored in these user preferences were valid for the old
flickr auth mechanism and are not usable any more. The new oauth1 based
version needs to store both the token (in the flickr_access_token
preference) and the token secret (flickr_access_token_secret). The new
version does not need to store the user's nsid.

The cryptic names of these legacy settings are a result of how dealing
with user preferences was originally implemented.

4 years agoMDL-59645 repository_flickr: Make the Flickr repository work again
David Mudrák [Mon, 21 Aug 2017 21:01:31 +0000 (23:01 +0200)]
MDL-59645 repository_flickr: Make the Flickr repository work again

The patch makes the Flickr repository use the new oauth1 based client.
Beside that, other improvements include:

* Does not attempt to guess the photo URL any more. Instead uses
  url_sq and url_o extras of the flickr.photos.search call.
* The photos.search does not return the information about the photo size
  so we set it to null (previously was returned as 'unknown' which made
  it be displayed as zero).
* Does not perform additional API request to obtain the manage URL, uses
  https://www.flickr.com/photos/organize instead.

4 years agoMDL-59645 oauth1: Implement a new simple Flickr API client
David Mudrák [Mon, 21 Aug 2017 20:59:37 +0000 (22:59 +0200)]
MDL-59645 oauth1: Implement a new simple Flickr API client

Flickr has switched over to OAuth 1.0 based authentication. This is a
simple client allowing Moodle to perform authenticated calls to the
Flickr API.

4 years agoMDL-59645 oauth1: Improve reporting of token errors
David Mudrák [Tue, 22 Aug 2017 21:50:49 +0000 (23:50 +0200)]
MDL-59645 oauth1: Improve reporting of token errors

Provide a more meaningful error message and debuginfo allowing to
diagnose what is going on. In case of flickr, this is typically thrown
when flickr API responses with their "bad, bad panda" HTML page instead
of the expected reply.

4 years agoMDL-59645 oauth1: Pass oauth_callback only to obtain the request token
David Mudrák [Mon, 21 Aug 2017 17:14:53 +0000 (19:14 +0200)]
MDL-59645 oauth1: Pass oauth_callback only to obtain the request token

As per the oauth1 spec, the oauth_callback is supposed to be passed only
when obtaining the initial request token. The client used to append it
automatically to all requests which broke the request signature.

4 years agoMDL-57886 plagarism: add note about behaviour change
Dan Poltawski [Tue, 19 Sep 2017 12:37:47 +0000 (13:37 +0100)]
MDL-57886 plagarism: add note about behaviour change

4 years agoMerge branch 'master_MDL-57886' of https://github.com/danmarsden/moodle
Dan Poltawski [Tue, 19 Sep 2017 12:40:12 +0000 (13:40 +0100)]
Merge branch 'master_MDL-57886' of https://github.com/danmarsden/moodle